This was the case before
  commit b41dc8e0
  Author: Vincent Pelletier <vincent@nexedi.com>
  Date:   Wed Sep 12 04:00:08 2018 +0200

      SQLCatalog_deferFullTextIndex{,Activity}: Use serialization_tag .
but I misread the code: when this exception triggered, document was neither
added in parameter_dict nor in failed_path_list. It should be now clearer.

This reverts commit fedebf37.

Finally, it was an issue in selenium runner software, the wrapper
was missing

Also, why make only 2 queries when I can make 2n+1 queries for the same
result ?

getObject is generally a shortcut for "return self", and on brains for
traversing to corresponding document.
Except... Not everywhere. portal_catalog for example defines a completely
unrelated method which takes a UID as argument and does a query retrieving
one document. Which is basically totally redundant with its __call__
method. Still, of course, it is used in several places.
Also, ERP5Form.Report defines yet another getObject method, taking an
acquisition context as argument and traversing to some other path.

So do not use getObject (at least until the code recovers some sanity and
consistency), but getPath + custom activity API. Oh well.

Just like regular indexations, fulltext indexations are subject to last-commit-wins.
Which means that it is possible to reach a state where the fulltext table is
persistently desynchronised from ZODB:
- start fulltext indexation activity on many documents (typically: 100)
- modify one of the documents being indexed
- start fulltext indexation activity caused by this edit, and assume indexation only
happens for this object
- commit the single-object indexation (because it is very fast to retrieve fulltext
data from just one document)
- commit the many-objects indexation later (because it is much slower to
retrieve 100 fulltext representations)

As a consequence, cod emust spawn one fulltext indexation activity per
document, each with the appropriate serialisation tag. Serialisation tag which
must not conflict with regular indexation, so use a fixed prefix.
As a consequence of having to spawn one activity per document, use a
grouping method to still index by batches to amortise transaction overhead.
Keep the same method_id as before for backward-compatibility (maybe
dependencies on this value exist, even though it is bad practice).
Rewrite SQLCatalog_deferFullTextIndexActivity so ot works as a grouping
method, simplifying it in the process:
- build parameter_dict with all entries, as we already know all needed keys
- None is not callable, so test "not None" in just one expression
- remove whitespace at end of line
- use GroupedMessage API

''.split(',') is [''] which evaluates to false ...
e80b37ff was still incorrect

This was not really backward compatible with old slapos versions not passing
zserver_address_list

To answer question in the comment:
> How to inspect inside another iframe?

use selectFrame (after waiting for the frame to be added in the DOM of course).

Reference of selenium commands: https://web.archive.org/web/20160807232621/http://release.seleniumhq.org/selenium-core/1.0.1/reference.html#selectFrame (I'm not sure it's still on the web)

Tests asserts that size have all languages available, so let's be
compatible and just set the default language to the current selected
one at site creation.

This was not really backward compatible when running with old slapos,
because default value was not string in this case.

This step was in reality only removing the "Access Content Information" permission for Anonymous on web_site_module, which was not coherent with erp5_web, and had for consequence to make developers change it by hand when wanting to use web_site_module

Extend test runners to use partition IP  and run functional tests behind an https frontend.

See slapos!374 for the slapos part and more detailed explanations.

/reviewed-on !729

/reviewed-on !742

/reviewed-on nexedi/erp5!737

I made a mistake rebasing & applying the patch to master, so the test
added in
nexedi/erp5!726 (comment 65067) did not
reach master.

This reapplies this part.

Thanks Seb for noticing !

On the traditional editor (from portal_component), selected text was not
highlighted

This is something the webmaster will define.
Also, initialize available languages like this will select a random
default language, which the webmaster might not understand.

So that a declaration like:
context.getUrlFor({command: 'display_action', options: {jio_key: "document", page: "action_reference"}})
can return the URL to redirect to the given action or the document

/reviewed-on nexedi/erp5!735

As it is backward compatible, this option can be passed as environment
variable.

Also re-order all argument output to make it clear which comes from
SlapOS generated wrapper and which are passed by test node.

We now access zserver behind the backend apache on https:// and this
apache's certificate is not trusted

Otherwise running in debug mode on headless machines just display
cryptic error message.

Auto-generate cache_id, removing the risk of duplicating one.
Inline getInstanceID as it is its only caller left.
Avoid wrapping if getTransactionalVariable cannot be imported.
Avoid intermediate variables, at the cost of dupicating logic but
accelerating run-time.
Use functools.wraps .
Access _cache_sequence_number directly - these pieces of code are friends
anyway, we already set a volatile property on Catalog instance. Saves one
getattr and one call.

No backslash at EOL.
Avoid splitting messages, to ease code lookup.
LOG's "error" argument accepts a boolean, which removes the need to touch
sys.exc_info.
Use modern exception raising syntax.