1. 03 Nov, 2020 2 commits
  2. 02 Nov, 2020 4 commits
  3. 30 Oct, 2020 1 commit
  4. 29 Oct, 2020 5 commits
  5. 28 Oct, 2020 3 commits
  6. 27 Oct, 2020 12 commits
  7. 26 Oct, 2020 4 commits
  8. 23 Oct, 2020 1 commit
  9. 22 Oct, 2020 1 commit
    • Léo-Paul Géneau's avatar
      fix/proftpd: socket created in software · 5a5e0168
      Léo-Paul Géneau authored
      When proftpd software release is tested locally, the socket named /srv/slapgrid/slappart76/srv/runner/instance/slappart1/tmp/soft/91d420e3970a2088e648d2eb86e155ea/parts/prof is created but never removed.
      First it is not an appropriated directory to create a socket and then not removing this socket leads to an error if tests are run a second time :
      
      subprocess.CalledProcessError: Command '('ldd', '/srv/slapgrid/slappart76/srv/runner/instance/sla
      ppart1/tmp/soft/91d420e3970a2088e648d2eb86e155ea/parts/prof')' returned non-zero exit status 1.
      
      ----------------------------------------------------------------------
      Ran 0 tests in 9.914s
      
      FAILED (errors=1)
      
      This is due to code in https://github.com/proftpd/proftpd/blob/master/src/ctrls.c :
      
      const char *socket_path = PR_RUN_DIR "/test.sock"; // socket_path="/srv/slapgrid/slappart76/srv/runner/instance/slappart1/tmp/soft/91d420e3970a2088e648d2eb86e155ea/parts/proftp/var/test.sock"
      sstrncpy(sockun.sun_path, socket_path, sizeof(sockun.sun_path)); // sockun.sun_path="/srv/slapgrid/slappart76/srv/runner/instance/slappart1/tmp/soft/91d420e3970a2088e648d2eb86e155ea/parts/prof"
      
      where `sun_path` is limited to UNIX_PATH_MAX (108 characters): char sun_path[UNIX_PATH_MAX]; https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/un.h#L9
      5a5e0168
  10. 21 Oct, 2020 3 commits
  11. 20 Oct, 2020 4 commits
    • Kirill Smelkov's avatar
      *: Factor-out NumPy version into component/numpy/ · eacc0038
      Kirill Smelkov authored
      Move `numpy=1.16.4` from all over the place into component/numpy.
      Don't move if a different numpy version is used, or it looks like a
      software cares to use exactly particular version.
      Downgrade pygolang/test.cfg from numpy=1.16.6 to numpy=1.16.4 and use
      common numpy component version - using numpy=1.16.6 is not required for
      pygolang testing and so this downgrade is acceptable. It will be better
      to upgrade NumPy to latest in component/numpy/ as a future separate step.
      
      See previous patch where it was decided and explained that version for
      component <X> lives in component/X/.
      eacc0038
    • Kirill Smelkov's avatar
      Move dependent egg-versions for added components to stack/slapos.cfg · 97444968
      Kirill Smelkov authored
      Move versions for eggs that component/{ZEO,pygolang,zodbtools,pytest}
      depend on out of component/ and into stack/slapos.cfg
      
      Leave version of component <X> inside component/<X>.
      
      I was asked to do so:
      
      nexedi/slapos!839 (comment 119170)
      97444968
    • Kirill Smelkov's avatar
    • Jérome Perrin's avatar
      fixup! gdb: New component · ffc50ed4
      Jérome Perrin authored
      I tried to use this gdb in a software release installed by slapos-sr-testing (which perform some extra checks that we only do in slapos-sr-testing at the moment) and it complains that:
      
      ```
      ======================================================================
      ERROR: setUpModule (test)
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "/srv/slapgrid/slappart9/srv/slapos/soft/24930952d96110d7e0142b49eba918a8/parts/slapos.core-repository/slapos/testing/testcase.py", line 168, in setUpModule
          installSoftwareUrlList(cls, [software_url], debug=debug)
        File "/srv/slapgrid/slappart9/srv/slapos/soft/24930952d96110d7e0142b49eba918a8/parts/slapos.core-repository/slapos/testing/testcase.py", line 378, in installSoftwareUrlList
          checkSoftware(cls.slap, software_url)
        File "/srv/slapgrid/slappart9/srv/slapos/soft/24930952d96110d7e0142b49eba918a8/parts/slapos.core-repository/slapos/testing/testcase.py", line 336, in checkSoftware
          raise RuntimeError('\n'.join(error_list))
      RuntimeError: /srv/slapgrid/slappart9/srv/slapos/inst/slappart7/tmp/shared/gdb/d14016b094c3637c4ebf6a3df4a8c64d/bin/gdb uses system library /usr/lib/x86_64-linux-gnu/libexpat.so.1.6.8 for libexpat.so.1
      
      ----------------------------------------------------------------------
      Ran 0 tests in 462.686s
      ```
      
      I saw this on a debian KVM on which I don't think I installed any system package except `slapos-node`, but `libexpat1-dev` is installed for some reason, so configure detected it and the built binary is linked against it. I checked some test nodes and `/usr/include/expat.h` seems present on some testnodes, so probably some test nodes will also have this problem. For that, I suggest to build a gdb using slapos `libexpat`, so that we build something more reproductible and not depending on the host system (that's important if we want to use binary cache, but can also be a problem if system packages get remove/upgraded). As you might be thinking now, that's a kind of infinite problem, because we can not add anything that configure might detect, but that's how we usually do for this for now.
      
      While looking at this, I also realised that we were using a .tar.xz URL here, for which rely our recipe will use `xz` command. Because some machines might not have that command, we usually put `xz-utils` in PATH.
      
      How about including something like this ?
      ffc50ed4