- 22 May, 2018 5 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Nicolas Wavrant authored
As module may not have the same permissions as its sub-documents
-
Jérome Perrin authored
We have a general rule not to really delete content, but for categories and web sections I feel it's different. ( there is [#704](https://nexedi.erp5.net/bug_module/704) but it seems it was a different issue at the time ) /reviewed-on !519
-
Jérome Perrin authored
All top level documents are not supposed to acquire local roles https://www.erp5.com/erp5-Guideline.Unset.Acquire.Local.Roles.On.Document.Portal.Type.Configuration.If.Applicable I believe this comes from the time where we were using images as sub-documents of products or persons. We now use embedded files for these cases, so no need to have an exception here. Depending on the security configuration, there might be a notable side effect of applying this change: images that were visible by some users because they acquired Auditor role from the module will not longer be visible by these users, but they will still be indexed as visible, so they will appear in catalog searches. In such case, after re-indexing image module the catalog will be consistent again. /reviewed-on nexedi/erp5!666
-
- 21 May, 2018 10 commits
-
-
Romain Courteaud authored
Forbid click if the event listener is not activated yet
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
Workaround renderjs speed improvement.
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Nicolas Wavrant authored
In production, the sending of emails by using Internet Message Posts created activity failures : ``` Node: activities-XX Failures: 1 User name: 'System Processes' Uid: 1234567890 Document: /erp5/person_module/XXXX Method: Entity_sendEmail Arguments: () Named Parameters: {'cc_url': None, 'from_url': None, 'event_relative_url': 'event_module/YYYY'} Exception: Module Products.CMFActivity.Activity.SQLBase, line 607, in dequeueMessage transaction.commit() Module transaction._manager, line 123, in commit return self.get().commit() Module transaction._transaction, line 280, in commit reraise(t, v, tb) Module transaction._transaction, line 271, in commit self._commitResources() Module Products.TIDStorage.transaction_transaction, line 261, in _commitResources result = original__commitResources(self, *args, **kw) Module transaction._transaction, line 416, in _commitResources reraise(t, v, tb) Module transaction._transaction, line 393, in _commitResources rm.tpc_vote(self) Module ZODB.Connection, line 797, in tpc_vote s = vote(transaction) Module ZEO.ClientStorage, line 1072, in tpc_vote return self._check_serials() Module ZEO.ClientStorage, line 902, in _check_serials raise s ReadConflictError: database read conflict error (oid 0x12345 serial this txn started with 0x12345 2018-05-16 06:27:17.471887, serial currently committed 0x12345 2018-05-16 06:53:10.977183) ``` This Merge Request proposes to allow Entity_sendEmail to be retried in case of ConflictError, as now Entity_sendEmail is doing more than what it used to be. For this, we need to isolate the call to sendMailHostMessage to make sur that email won't be sent several times if the activity "Entity_sendEmail" is retried. We also make sure that the activity created to send a message through MailHost gets the correct parameters to be never retried (retry_max=0 and retry_conflict=False) /reviewed-on nexedi/erp5!672
-
Nicolas Wavrant authored
But only one mail will be sent out by MailHost
-
- 18 May, 2018 17 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
Reduce the number of acquired method calls by grouping them.
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
See 382a3ae2
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Roque authored
- hardcoded parameter removed - minor changes in slapos master communicator
-
Roque authored
-
Nicolas Wavrant authored
This reverts commit 3a811c0e.
-
Nicolas Wavrant authored
This reverts commit 02e06ea3.
-
Xiaowu Zhang authored
-
- 17 May, 2018 6 commits
-
-
Xiaowu Zhang authored
/reviewed-on nexedi/erp5!671
-
Nicolas Wavrant authored
-
Tomáš Peterka authored
-
Tomáš Peterka authored
-
Xiaowu Zhang authored
-
Tomáš Peterka authored
-
- 16 May, 2018 2 commits