Remove a warning caused by the unused 'explain' variable in
headers_idempotent.c.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

There's no real reason to exclude 'generator' from the build or check
targets.  Add it back in.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

The new makefile excludes all modules with external library dependencies
from the usual make check, meaning the libraries are not needed for the
Travis build.

Although it would be nice to include these modules, there are a bunch of
problems with sorting out a correct environment for them.  For now, just
leave them out.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

# Conflicts:
#	.travis.yml
#	Makefile
#	Makefile-ccan

The example code in wwviaudio doesn't compile as is.  Mark it as an
expected failure for ccanlint.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

This fixes a warning.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

This removes the parallel make (-j) option when running make check under
Travis CI.  This will slow down the build somewhat, but makes it easier to
match errors to the modules which caused them.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

--summary (used by make check) causes ccanlint to only ever print a
one-line summary of the results.  When one of the tests fails, this isn't
very useful, because it doesn't say why it failed, or even which test
failed.  This is particularly frustrating for failures in Travis CI builds
where it's not always straightforward to reproduce a similar enough build
environment to check the failure manually for a particular module.

--summary does have one purpose which is vital for make check, though: it
suppresses any attempt to interactively correct / improve the module
printing only results.

This changes --summary to only have the second effect, not the first.  This
won't change the output in the case of passing modules, but will give more
useful information in the case of failing modules.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Since doesnt_matter() expands to nothing, GCC -Wextra suggests { }.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

GCC with -O gives an error here.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Make register_timer "use" my_timer_callback and its own args.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Many are because argc is 'int' not 'unsigned', others just laziness.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

This allows examples to refer to them, but we cast them to void at the
end to avoid -Wunused warnings.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Either with UNNEEDED (if the module already used ccan/compiler) or
with (void) casting.

The only other change is in ccan/list/test/run-CCAN_LIST_DEBUG.c, because
the linenumbers change and thus it needs updating.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

This avoids the warning about it being unused with -Wunused.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

This makes us closer to compiling cleanly with -Wunused (as used by -Wextra).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Found by PCS Suite.

Reported-by: Jon Griffiths
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Ahmed Samy <f.fallen45@gmail.com>

Adds a new test graph which includes a negative weight cycle.  This means
that shortest paths are not well defined, and both Dijkstra's algorithm and
the Bellman-Ford algorithm (which can handle some negative edge weights)
will fail.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

This adds the Bellman-Ford single-source shortest path algorithm to
the aga and agar modules.  The Bellman-Ford algorithm is (usually)
slower than Dijkstra's algorithm, but unlike Dijkstra's is able to
cope with negative edge costs, unless they form a negative cost cycle.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

aga_dijkstra_all_paths() runs Dijkstra's algorithm to completion (as
opposed to aga_dijkstra_path(), which operates lazily).  In effect this
computes the shortest path to all (reachable) nodes from the start node.

So, in this context the name makes sense.  But for an analogous function
for future algorithms (e.g. Bellman-Ford), the name doesn't make sense.

So, in the interests of consistency with those future extensions, change
the name of this to aga_dijkstra_complete().
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Not really a bug, but stylistically questionable and makes PCS Suite
complain.

Reported-by: Jon Griffiths
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

The list of additional packages in our .travis.yml (mostly libraries needed
for specific modules) was incorrectly formatted.  So travis was attempting
to install the "libjudy-dev libvorbis-dev libportaudio-dev libtalloc-dev"
packagde (spaces included) which obviously didn't work.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Remove timer_add() in favor of explicit timer_addrel and timer_addmono.

Someone hit a real-life case where time went backwards, and we asserted.
The correct fix is to use time_mono() where available, but as all known
users actually want a relative timeout, have a helper for that case.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Include assert checks, implement timemono_eq().
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Minor fixes on top of patch from rocco@tecsiel.it:

Hi Rusty,
latest git version of the file ccan/jmap/tools/speed.c does not
compile.

Please find attacched my own version with the following differences:

  1. deleted inclusion of <ccan/jmap/jmap_type.h> which is no longer in ccan/

  2. added inclusion of <ccan/time/time.h>

  3. added definition of struct jmap_obj in terms of JMAP_MEMBERS();

  4. deleted use of macro JMAP_DEFINE_UINTIDX_TYPE() which is no longer needed

  5. changed function normalize() to be aligned with ccan/htable/tools/speed.c

  6. repleaced gettimeofday() in favour of time_now()

  7. added memory cleanup at the end of the program in terms of
       jmap_free(jmap);
       free(objs);
     to be valgrind safe
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

/home/rusty/devel/cvs/ccan/ccan/io/test/run-01-start-finish.c: In function ‘main’:
/home/rusty/devel/cvs/ccan/ccan/io/test/run-01-start-finish.c:89:7: warning: ‘addrinfo’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (connect(fd, addrinfo->ai_addr, addrinfo->ai_addrlen) != 0)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

/home/rusty/devel/cvs/ccan/ccan/tap/tap.h:57:59: warning: ‘max_iters’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    _gen_result(1, __func__, __FILE__, __LINE__, "%s", #e) : \
                                                           ^
/home/rusty/devel/cvs/ccan/ccan/foreach/test/run-nested.c:47:17: note: ‘max_iters’ was declared here
  int i, j, sum, max_iters;
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

/home/rusty/devel/cvs/ccan/ccan/err/test/run.c:124:2: warning: ignoring return value of ‘pipe’, declared with attribute warn_unused_result [-Wunused-result]
  pipe(pfd);
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

/home/rusty/devel/cvs/ccan/ccan/cdump/cdump.c: In function ‘get_type’:
/home/rusty/devel/cvs/ccan/ccan/strmap/strmap.h:88:39: warning: ‘m’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  tcon_cast((map), canary, strmap_get_(&(map)->raw, (member)))
                                       ^
/home/rusty/devel/cvs/ccan/ccan/cdump/cdump.c:216:20: note: ‘m’ was declared here
  cdump_map_t *m;
               ^
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>