If one connect failed, we'd return the other one without
waiting for the connect to complete.  This resulted in
read() returning 0, which was really weird.

The downside: the poll doesn't seem to time out when the
connect times out (Linux 3.13 x86-64).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

A number of functions in bitmap.h take parameters which they don't modify
but aren't currently marked as const.  This patch fixes that.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

No reason for it not to be.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Bitmap words (e.g. resulting from BITMAP_{N,HEAD}WORDS) are of
unsigned type.

Use "unsigned int" to iterate over bitmap words to avoid comparisons
between signed and unsigned expressions. GCC otherwise warns about
these when -Wsign-compare is enabled.
Signed-off-by: Emilio G. Cota <cota@braap.org>

This turns out to be the right sequence for pettycoin, which
wants to reap the child in the finish routine.  From that sample
size of 1, this is clearly the Right Thing!
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Simpler reimplementation of SS's patch; just plumb file and line through
inline functions in header.  We add a new check, which actually tests
these, and fix _info which missed ccan/check_type as a dependency.
Based-on-the-true-story-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

bfgminer/cgminer/sgminer want these.  Con implemented some,
but these are independently written (with tests!)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Acked by contributors:
Luke-Jr <luke@dashjr.org>:
	 I don't have any objections
Douglas Bagnall <douglas@halo.gen.nz>:
	Fine by me.
Joel Stanley <joel@jms.id.au>:
	Fine with me.
Brad Hards <bradh@frogmouth.net>:
	Ack.

No response from Joey (trivial warning patch) or Andreas Schlick (one
trivial patch, but he also wrote opt_free() (which was a 2 line function).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

This was suggested by Luke, though his version insisted on using tab.
This one is a bit more complex, but allows either tab or space.
Suggested-by: Luke Dashjr <luke-jr+git@utopios.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

This correctly continues on the next line indented.
Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Actually, only an issue for 64 bit big endian systems, but still...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

As ccanlint warns.  Also, test TIOCGWINSZ before ioctl, rather than the
header directly since it's a little orthogonal.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

As recently required by ccan/opt.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

These are not supported in all environments, so use PRId64 and PRIu64 instead.
Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

This fixes building for Windows and other platforms which lack <sys/termios.h>
Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

sparse yells at us when it realises we are implicitly casting an
endian type (big endian) to a plain unsigned long.

Get rid of this warning by telling sparse that we know what
we are doing.
Signed-off-by: Emilio G. Cota <cota@braap.org>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

In this case, Linux (at least, Ubuntu 13.10, x86-64 kernel 3.11.0-14-generic)
sets POLLHUP and gives no other error notification.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

A zero-length read should complete immediately, even if the fd isn't readable.
Wire this up, and expose it for callers to use.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Ahmed Samy <f.fallen45@gmail.com>

For now, we'll just have this and later on I'll make it support
writing it also using cpuid_write_info.
Signed-off-by: Ahmed Samy <f.fallen45@gmail.com>

This code provides some macros to check arguments for valid value ranges.
Consider this a mild version of assert(3), because all it does is to log
a message and continue.

These macros don't replace error handling, but they are useful in
situations where an error is unexpected but not common, i.e.
this shouldn't happen but if it does let me know".
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

And add test for that which also tests duplex case.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

This reverts commit 490b6385.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Conflicts:
	ccan/io/io.c

This function writes CPU information to a file.
Signed-off-by: Ahmed Samy <f.fallen45@gmail.com>

Signed-off-by: Ahmed Samy <f.fallen45@gmail.com>

Turns out to be useful for complex cases.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Especially where we have just done a read and spin off a duplex to do a read
as well.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

eax/ebx/ecx/edx are 32-bit registers, and we need 8 bits from most
significand bits so there is no need to mask out 0xFF.
Signed-off-by: Ahmed Samy <f.fallen45@gmail.com>

Otherwise, it's a PITA to close a duplexed connection.  If necessary we
can introduce a half-close to de-deplex later.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Also take out additional feature information from processor information
and feature bits since they can be tested using cpuid_test_feature() and
cpuid_has_feature()
Signed-off-by: Ahmed Samy <f.fallen45@gmail.com>