Commit 2581e470 authored by David Gibson's avatar David Gibson

Makefile: Remove testdepends from make check dependencies

The new Makefile system, via the helper script in tools/gen_deps.sh, when
generating the targets to test a module, inserts dependencies meaning it
must first check modules this one depends on, whether via 'depends' or
'testdepends' in _info.

Although it seems logical, including 'testdepends' is actually incorrect.
If ccan/a testepends on ccan/b then ccan/b must be *built* in order to test
ccan/a, but it doesn't need to be tested.  testepends are explicitly
permitted to contain loops - it's quite common for two complementary
modules to be used to test each other.  This is one of the reasons
testdepends exists separate from depends.

So, remove testdepends from the generated check dependencies, removing the
circular dependency that Make complains about.
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 33ba12ad
......@@ -14,7 +14,7 @@ test_srcs=`ls $path/test/*.[ch] 2>/dev/null | tr '\n' ' '`
module_objs=`ls $path/*.c 2>/dev/null | sed 's/.c$/.o/g' | tr '\n' ' '`
# ... and on the modules this test uses having passed their tests
deps=$(echo `$path/info testdepends` `$path/info depends` | tr ' ' '\n' | \
deps=$(echo `$path/info depends` | tr ' ' '\n' | \
sort | uniq | sed -e 's/$/\/.ok/g' -e '/^\/.ok$/d' | tr '\n' ' ')
# Print the test targets and target aliases
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment