- 12 Jul, 2016 5 commits
-
-
Jim Fulton authored
This test was spewing exceptions without failing for ZODB5. The spew was an indication that something was wrong in this case. (The test was broken.) There had been some bug in the object cache that caused an infinite loop when objects woke themselves up while being reaped. This test is a regression test for that bug. The test was sloppy about transaction managers. The test class creates a bunch of connections using the threaded transaction manager, but this test used a thread to execute the critical code. As a result, the synchronization methods weren't called. This didn't matter much with ZODB4. The objects were still able to load their state. With ZODB5, the synchronization methods are important for proper MVCC and because they weren't called, the objects' state couldn't be reloaded, with 2 effects: - Spew - The test wasn't really testing that object's that reloaded themselves didn't create an infinite loop. Changed the test to not use a threaded transaction manager.
-
Jim Fulton authored
-
Jim Fulton authored
As part of a project to provide object-level commit locks for ZEO, I'm refactiring FileStorage to maintain transaction-specific data in Tranaction.data. This involved undo. In trying to figure this out, I found: - A bug in _undoDataInfo, which I verified with some tests and - _transactionalUndoRecord was maddeningly difficult to reason about (and thus change). I was concerned less by the bug than my inability to know whether a change to the code would be correct. So I refactored the code, mainly transactionalUndoRecord, to make the code easier to understand, fixing some logic errors (I'm pretty sure) along the way. This included lots of comments. (Comments are much easier to compose when you're working out logic you didn't understand.) In addition to makeing the code cleaner, it allows undo to be handled in cases that weren't handled before.
-
Jim Fulton authored
Per @jimfulton, handle_all_serials shouldn't be sniffing in ZODB5 Thanks.
-
Jason Madden authored
-
- 11 Jul, 2016 2 commits
-
-
Jason Madden authored
-
Jason Madden authored
-
- 09 Jul, 2016 2 commits
-
-
Jim Fulton authored
Fix handle_all_serials for the new and old protocols.
-
Jason Madden authored
-
- 06 Jul, 2016 4 commits
-
-
Jim Fulton authored
-
Jim Fulton authored
-
Jim Fulton authored
Switch all storages to the new commit protocol Thanks!
-
Julien Muchembled authored
-
- 05 Jul, 2016 6 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
-
Jim Fulton authored
Only tpc_vote can report resolved conflicts with the new commit protocol
-
Julien Muchembled authored
-
Julien Muchembled authored
-
Jim Fulton authored
-
- 04 Jul, 2016 12 commits
-
-
Jim Fulton authored
-
Jim Fulton authored
-
Jim Fulton authored
-
Jim Fulton authored
Merge 4.x branch
-
Julien Muchembled authored
-
Jim Fulton authored
Better support of the new API to notify of resolved conflicts (store/tpc_finish)
-
Jim Fulton authored
Conflicts: src/ZODB/interfaces.py
-
Julien Muchembled authored
-
Jim Fulton authored
-
Jim Fulton authored
-
Jim Fulton authored
ZEO handles undo asynchronously and ZODB has for some time allowed undo oids to be returned via vote.
-
Jim Fulton authored
-
- 01 Jul, 2016 8 commits
-
-
Jim Fulton authored
-
Jim Fulton authored
-
Jim Fulton authored
Conflicts: src/ZODB/interfaces.py
-
Jim Fulton authored
-
Jim Fulton authored
Define a new interface for storages that support the new commit protocol.
-
Jim Fulton authored
-
Jim Fulton authored
-
Julien Muchembled authored
When switching all storages to the new API in the master branch, I found a few issues, mainly with blobs. 1. Created/modified blobs are invalidated during the first phase (in Connection._store_objects): obj._p_invalidate() And with the old API, _handle_serial then sets _p_serial Ghost objects are not supposed to have a _p_serial and with the new API, a few tests would fail because _p_serial are checked without activating the blob first. 2. Another consequence of _handle_serial not updating _p_changed/_p_serial immediately is that created objects are stored twice if __getstate__ modifies itself. This case is tested in testConnection by doctest_lp485456_setattr_in_setstate_doesnt_cause_multiple_stores Hence the change in Connection._commit: - self._modified is already appended in Connection._store_objects - (obj._p_serial == z64) instead of (oid in self._creating) would not work for savepoints. 3. Setting _p_changed of a Blob with no uncommitted changes would cause an error (lp440234_Setting__p_changed_of_a_Blob_w_no_uncomitted_changes_is_noop) Fixed by the same change as in 2: - oid was appended twice to self._modified but reverted one (self._modified.pop() in _store_objects) - the test passed because _p_changed was reset early by _handle_serial
-
- 30 Jun, 2016 1 commit
-
-
Jim Fulton authored
This allows interface incompatibilities: - Future version of ZODB that requires the new protocol being configured with a storage that doesn't implement the new protocol - ZEO has a client that uses the old protocol can't use a storage that implements the new protocol. To be caught early. This commit also clarifies that the serial returned by ``undo()`` is ignored.
-