Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
caddy
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
caddy
Commits
53635ba5
Commit
53635ba5
authored
8 years ago
by
Leonard Hecker
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed panic due to 0-length buffers being passed to io.CopyBuffer
parent
6352c905
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
2 deletions
+5
-2
caddyhttp/proxy/reverseproxy.go
caddyhttp/proxy/reverseproxy.go
+5
-2
No files found.
caddyhttp/proxy/reverseproxy.go
View file @
53635ba5
...
...
@@ -253,7 +253,7 @@ func (rp *ReverseProxy) ServeHTTP(rw http.ResponseWriter, outreq *http.Request,
}
func
(
rp
*
ReverseProxy
)
copyResponse
(
dst
io
.
Writer
,
src
io
.
Reader
)
{
buf
:=
bufferPool
.
Get
()
buf
:=
bufferPool
.
Get
()
.
([]
byte
)
defer
bufferPool
.
Put
(
buf
)
if
rp
.
FlushInterval
!=
0
{
...
...
@@ -268,7 +268,10 @@ func (rp *ReverseProxy) copyResponse(dst io.Writer, src io.Reader) {
dst
=
mlw
}
}
io
.
CopyBuffer
(
dst
,
src
,
buf
.
([]
byte
))
// `CopyBuffer` only uses `buf` up to it's length and
// panics if it's 0 => Extend it's length up to it's capacity.
io
.
CopyBuffer
(
dst
,
src
,
buf
[
:
cap
(
buf
)])
}
// skip these headers if they already exist.
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment