Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
nexedi
cython
Commits
acd3fdcb
Commit
acd3fdcb
authored
Apr 13, 2020
by
Stefan Behnel
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix a reference leak when PyList_Append() fails.
parent
bf61b1c5
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
6 deletions
+7
-6
Cython/Utility/CythonFunction.c
Cython/Utility/CythonFunction.c
+7
-6
No files found.
Cython/Utility/CythonFunction.c
View file @
acd3fdcb
...
@@ -972,14 +972,15 @@ __pyx_FusedFunction_getitem(__pyx_FusedFunctionObject *self, PyObject *idx)
...
@@ -972,14 +972,15 @@ __pyx_FusedFunction_getitem(__pyx_FusedFunctionObject *self, PyObject *idx)
if
(
PyTuple_Check
(
idx
))
{
if
(
PyTuple_Check
(
idx
))
{
PyObject
*
list
=
PyList_New
(
0
);
PyObject
*
list
=
PyList_New
(
0
);
Py_ssize_t
n
=
PyTuple_GET_SIZE
(
idx
);
Py_ssize_t
n
=
PyTuple_GET_SIZE
(
idx
);
PyObject
*
string
=
NULL
;
PyObject
*
sep
=
NULL
;
PyObject
*
sep
=
NULL
;
int
i
;
int
i
;
if
(
!
list
)
if
(
unlikely
(
!
list
)
)
return
NULL
;
return
NULL
;
for
(
i
=
0
;
i
<
n
;
i
++
)
{
for
(
i
=
0
;
i
<
n
;
i
++
)
{
int
ret
;
PyObject
*
string
;
#if CYTHON_ASSUME_SAFE_MACROS && !CYTHON_AVOID_BORROWED_REFS
#if CYTHON_ASSUME_SAFE_MACROS && !CYTHON_AVOID_BORROWED_REFS
PyObject
*
item
=
PyTuple_GET_ITEM
(
idx
,
i
);
PyObject
*
item
=
PyTuple_GET_ITEM
(
idx
,
i
);
#else
#else
...
@@ -989,14 +990,14 @@ __pyx_FusedFunction_getitem(__pyx_FusedFunctionObject *self, PyObject *idx)
...
@@ -989,14 +990,14 @@ __pyx_FusedFunction_getitem(__pyx_FusedFunctionObject *self, PyObject *idx)
#if !(CYTHON_ASSUME_SAFE_MACROS && !CYTHON_AVOID_BORROWED_REFS)
#if !(CYTHON_ASSUME_SAFE_MACROS && !CYTHON_AVOID_BORROWED_REFS)
Py_DECREF
(
item
);
Py_DECREF
(
item
);
#endif
#endif
if
(
!
string
||
PyList_Append
(
list
,
string
)
<
0
)
if
(
unlikely
(
!
string
))
goto
__pyx_err
;
goto
__pyx_err
;
ret
=
PyList_Append
(
list
,
string
);
Py_DECREF
(
string
);
Py_DECREF
(
string
);
if
(
unlikely
(
ret
<
0
))
goto
__pyx_err
;
}
}
sep
=
PyUnicode_FromString
(
"|"
);
sep
=
PyUnicode_FromString
(
"|"
);
if
(
sep
)
if
(
likely
(
sep
)
)
signature
=
PyUnicode_Join
(
sep
,
list
);
signature
=
PyUnicode_Join
(
sep
,
list
);
__pyx_err:
__pyx_err:
;
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment