Commit 5c050b56 authored by Jérome Perrin's avatar Jérome Perrin Committed by Ioannis Papagiannopoulos

update TODOs

parent 9e339eec
...@@ -33,10 +33,13 @@ ...@@ -33,10 +33,13 @@
* - loading & saving DONE * - loading & saving DONE
* - dropping a new node from palette DONE * - dropping a new node from palette DONE
* - dragging a node * - dragging a node
* - editing node properties with popup * - editing node properties with popup (make sure we can display after
* edit)
* - connecting two nodes * - connecting two nodes
* - removing a connection * - removing a connection
* - changing a node id ( make sure connections are updated ) * - removing a node ( make sure connections are removed )
* - changing a node id ( make sure connections are updated ) ( make sure
* we can display after edit )
*/ */
var gadget_klass = rJS(window), var gadget_klass = rJS(window),
node_template_source = gadget_klass.__template_element node_template_source = gadget_klass.__template_element
...@@ -153,6 +156,7 @@ ...@@ -153,6 +156,7 @@
} }
function waitForConnectionClick(gadget) { function waitForConnectionClick(gadget) {
// TODO: dialog to edit connection properties
loopJsplumbBind(gadget, 'click', function (connection) { loopJsplumbBind(gadget, 'click', function (connection) {
if (confirm("Delete connection ?")) { if (confirm("Delete connection ?")) {
gadget.props.jsplumb_instance.detach(connection); gadget.props.jsplumb_instance.detach(connection);
...@@ -365,7 +369,6 @@ ...@@ -365,7 +369,6 @@
} }
function updateElementData(gadget, node_id, data) { function updateElementData(gadget, node_id, data) {
// XXX should probably not use data.data
var element_id = gadget.props.node_id_to_dom_element_id[node_id], var element_id = gadget.props.node_id_to_dom_element_id[node_id],
new_id = data.id; new_id = data.id;
if (data.data.name) { if (data.data.name) {
...@@ -416,6 +419,7 @@ ...@@ -416,6 +419,7 @@
function expandSchema(class_definition, full_schema) { function expandSchema(class_definition, full_schema) {
// minimal expanding of json schema, supports merging allOf and $ref // minimal expanding of json schema, supports merging allOf and $ref
// references // references
// TODO: check for a library with full support
var property, referenced, i, var property, referenced, i,
expanded_class_definition = {properties: expanded_class_definition = {properties:
class_definition.properties || {}}; class_definition.properties || {}};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment