• Jérome Perrin's avatar
    core_test: increase expected value testWorkflowHistoryList.TestDedup · 0eca529a
    Jérome Perrin authored
    After df85ef46 (ERP5Workflow: DC Workflows are now ERP5 objects (!1378).,
    2020-11-18) we increased the expected value from 24 to 36, because it
    was just different with new workflow implementation and what was important
    is to have large buckets.
    
    After that, the test was flaky and eventually we changed the assertion
    from checking that the value equal the expected value to checking that
    it's larger to checking that it's larger to a satisfying value and we
    used the initial 24 for satisfying value.
    
    A large value here means the bucket contain many items, which happens
    when the pickle size is small
    
    We now understand that pickle are short when the pickler was able to
    deduplicate some strings because they were the same instances (as
    compared by `is` operator). Note that this deduplication happens before
    the one operated by Products.ERP5Type.Workflow.dedupStrings after bucket
    rotation, it's the "normal" deduplication from pickle happening when
    element are added to list.
    
    Because it's a good thing for disk usage to have small pickles, we raise
    our expectation and increase the expected minimal value to be 30.
    0eca529a
test.erp5.testWorkflowHistoryList.py 6.9 KB