erp5_web_renderjs_ui: download OOoDocument when accessed by reference
Same behaviour than File/Image
Showing
-
Owner
@romain is it possible that this causes the test failures from coding style it started to fail around this commit with error like this:
====================================================================== ERROR: test_deadProxyFields (CodingStyleTest.CodingStyleTest erp5_corporate_identity_test) ---------------------------------------------------------------------- Traceback (most recent call last): File "/srv/slapgrid/slappart24/t/eci/soft/e2a3956dee8fbe81b7778768f2abf286/parts/erp5/product/ERP5/tests/testXHTML.py", line 109, in test_deadProxyFields template_field = field.getTemplateField(cache=False) File "/srv/slapgrid/slappart24/t/eci/soft/e2a3956dee8fbe81b7778768f2abf286/parts/erp5/product/ERP5Form/ProxyField.py", line 437, in getTemplateField proxy_field = proxy_form._getOb(field_id, None) AttributeError: _getOb
I see we have a proxy field using
OOoDocument_viewAsWeb
asform_id
https://lab.nexedi.com/nexedi/erp5/-/blob/a61abaafd25785754f76bbc3541b003d9a11cc64/bt5/erp5_dms/SkinTemplateItem/portal_skins/erp5_dms_web/PDF_viewAsWeb/download_pdf.xml#L90The fix seems to be to change the proxy field, it's not really legal to make a proxy field to another field in a "normal" form, we are supposed to use proxy field library forms as target
-
Owner
I agree with the origin of the problem.
But, I went in another direction to try fixing it: !1968 (merged)
-
mentioned in merge request !1968 (merged)
Please register or sign in to comment