Commit 17e1c262 authored by Romain Courteaud's avatar Romain Courteaud

fixup: ERP5TypeFunctionalTestCase: support running tests on seleniumserver

See romain/erp5@f10cc273
parent dd1e900e
Pipeline #16406 failed with stage
...@@ -242,7 +242,7 @@ class FunctionalTestRunner: ...@@ -242,7 +242,7 @@ class FunctionalTestRunner:
selenium_test_runner_configuration = test_runner_configuration.get('selenium', {}) selenium_test_runner_configuration = test_runner_configuration.get('selenium', {})
use_local_firefox = selenium_test_runner_configuration.get('server-url') is None use_local_firefox = selenium_test_runner_configuration.get('server-url') is None
if 'firefox' not in selenium_test_runner_configuration.get( if 'firefox' not in selenium_test_runner_configuration.get(
'desired-capabilities', {}).get('browserName').lower(): 'desired-capabilities', {}).get('browserName', '').lower():
options = None options = None
if use_local_firefox: if use_local_firefox:
......
  • oops thanks. I don't understand why tests were running before this fix. Maybe it broke only when slapos master was merged in slapos 1.0 ?

  • It seems service worker are not available with the latest changes, and this leads to most errors. I didn't check yet if the firefox version changed. Do you have any idea?

  • Firefox version should not have changed. I was trying slapos!1003 (merged) but this does not change the default firefox used by testnodes either ... and it's not supposed to change unless we update testnode, the firefox version comes from

    software-path-list = ["https://lab.nexedi.com/nexedi/slapos/raw/1.0.181/software/seleniumrunner/software.cfg"]

    line from https://lab.nexedi.com/nexedi/slapos/raw/1.0.182/software/erp5testnode/instance-default.cfg

    is it really that everything using service worker stopped working ?

  • in https://erp5js.nexedi.net/#/test_result_module/20210630-68486DBA/187 we have:

    selenium.browserbot.currentWindow.navigator.serviceWorker is undefined (HTML)

    this seems new. This must be because this

        options.set_preference('dom.serviceWorkers.enabled', True)

    from https://lab.nexedi.com/nexedi/erp5/blob/17e1c26244724206cf0cad49dfd04d33a82c0e0f/product/ERP5Type/tests/ERP5TypeFunctionalTestCase.py#L233 no longer work.

  • I guess the problem is that this if

         if 'firefox' not in selenium_test_runner_configuration.get(
              'desired-capabilities', {}).get('browserName', '').lower():
            options = None

    becomes true. The initial intention was to set options = None for the case where we are not using firefox, but this evaluates to true also for the default value. I think we can change this if, I'm trying a patch on for_testrunner_1 (in a few seconds)

  • mentioned in commit ee411a73

    Toggle commit list
  • Let's try ee411a73

  • mentioned in commit romain/erp5@f08b7031

    Toggle commit list
  • It seems all good 👍

  • Thanks yes, it seems good enough, I'm pushing this commit in master, thanks !

Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment