Commit 33256369 authored by Łukasz Nowak's avatar Łukasz Nowak Committed by Alain Takoudjou

Store activities in TRADITIONAL mode.

It will protect against storing truncated data.
parent fc60d002
...@@ -20,6 +20,7 @@ group_method_id_list ...@@ -20,6 +20,7 @@ group_method_id_list
tag_list tag_list
serialization_tag_list serialization_tag_list
</params> </params>
SET SESSION sql_mode='TRADITIONAL'; <dtml-var sql_delimiter>
INSERT INTO <dtml-var table> INSERT INTO <dtml-var table>
(uid, path, active_process_uid, date, method_id, processing_node, processing, priority, group_method_id, tag, serialization_tag, message) (uid, path, active_process_uid, date, method_id, processing_node, processing, priority, group_method_id, tag, serialization_tag, message)
VALUES VALUES
......
  • @vpelletier, this change was done for slapos master by Luke long time ago and I'm cleaning up the changes from this "fork".

    Do you think it is usefull to merge this change on ERP5 master branch or drop it?

    /cc @jm

  • This is an interesting feature that I didn't know (remember ? luke probably mentioned this issue) of.

    I believe it should be enabled for as many CMFActivity queries as possible (I know it cannot be enabled for UPDATE...LIMIT, especially when binlogs are enabled). But please wait for Julien's opinion.

  • Same opinion. We should go further by doing this for the whole connection instead of only this particular request, and that's actually what we already do in NEO. Note however that if we do this, there's at least one known place to fix: SQLBase_reactivate increments columns without explicitly capping them at the max possible value (something which happens for messages that are retried forever).

Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment