Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
erp5
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
139
Merge Requests
139
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Jobs
Commits
Open sidebar
nexedi
erp5
Commits
9db59e7d
Commit
9db59e7d
authored
Apr 25, 2022
by
Jérome Perrin
1
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
PropertyRecordableMixin: clear _recorded_property_dict if empty
This makes smaller pickles
parent
915b4640
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
0 deletions
+4
-0
bt5/erp5_core_test/TestTemplateItem/portal_components/test.erp5.testPropertyRecordable.py
...tem/portal_components/test.erp5.testPropertyRecordable.py
+2
-0
product/ERP5/mixin/property_recordable.py
product/ERP5/mixin/property_recordable.py
+2
-0
No files found.
bt5/erp5_core_test/TestTemplateItem/portal_components/test.erp5.testPropertyRecordable.py
View file @
9db59e7d
...
@@ -82,6 +82,7 @@ class TestPropertyRecordable(ERP5TypeTestCase):
...
@@ -82,6 +82,7 @@ class TestPropertyRecordable(ERP5TypeTestCase):
p
.
clearRecordedProperty
(
'first_name'
)
p
.
clearRecordedProperty
(
'first_name'
)
self
.
assertFalse
(
p
.
isPropertyRecorded
(
'first_name'
))
self
.
assertFalse
(
p
.
isPropertyRecorded
(
'first_name'
))
self
.
assertTrue
(
p
.
isPropertyRecorded
(
'last_name'
))
self
.
assertTrue
(
p
.
isPropertyRecorded
(
'last_name'
))
self
.
assertTrue
(
hasattr
(
p
,
'_recorded_property_dict'
))
# clearing a property that is not currently recorded is not an error
# clearing a property that is not currently recorded is not an error
p
.
clearRecordedProperty
(
'description'
)
p
.
clearRecordedProperty
(
'description'
)
...
@@ -89,5 +90,6 @@ class TestPropertyRecordable(ERP5TypeTestCase):
...
@@ -89,5 +90,6 @@ class TestPropertyRecordable(ERP5TypeTestCase):
p
.
clearRecordedProperty
(
'last_name'
)
p
.
clearRecordedProperty
(
'last_name'
)
self
.
assertFalse
(
p
.
isPropertyRecorded
(
'first_name'
))
self
.
assertFalse
(
p
.
isPropertyRecorded
(
'first_name'
))
self
.
assertFalse
(
p
.
isPropertyRecorded
(
'last_name'
))
self
.
assertFalse
(
p
.
isPropertyRecorded
(
'last_name'
))
self
.
assertFalse
(
hasattr
(
p
,
'_recorded_property_dict'
))
p
.
clearRecordedProperty
(
'description'
)
p
.
clearRecordedProperty
(
'description'
)
product/ERP5/mixin/property_recordable.py
View file @
9db59e7d
...
@@ -87,6 +87,8 @@ class PropertyRecordableMixin:
...
@@ -87,6 +87,8 @@ class PropertyRecordableMixin:
the property record.
the property record.
"""
"""
self
.
_getRecordedPropertyDict
({}).
pop
(
id
,
None
)
self
.
_getRecordedPropertyDict
({}).
pop
(
id
,
None
)
if
not
self
.
_getRecordedPropertyDict
(
True
):
del
self
.
_recorded_property_dict
security
.
declareProtected
(
Permissions
.
AccessContentsInformation
,
security
.
declareProtected
(
Permissions
.
AccessContentsInformation
,
'getRecordedPropertyIdList'
)
'getRecordedPropertyIdList'
)
...
...
Jérome Perrin
@jerome
mentioned in merge request
!1611 (merged)
·
Apr 27, 2022
mentioned in merge request
!1611 (merged)
mentioned in merge request !1611
Toggle commit list
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment