core: make Base_edit raise in case of wrong matrixbox keys

This should not happens, but if this happens we should not just return
in the middle of the loop, because this returned value is not used,
so we would just silently edit partially.

bt5/erp5_hal_json_style/SkinTemplateItem/portal_skins/erp5_hal_json_style/Base_edit.py

@@ -172,11 +172,11 @@ def editMatrixBox(matrixbox_field, matrixbox):
   for cell_index_tuple, cell_value_dict in matrixbox.items():
     # Only update cells which still exist
     if not matrix_context.hasInRange(*cell_index_tuple, **kd):
-      return "Cell %s does not exist" % str(cell_index_tuple)
+      raise ValueError("Cell %s does not exist" % str(cell_index_tuple))
 
     cell = matrix_context.newCell(*cell_index_tuple, **kd)
     if cell is None:
-      return "Could not create cell %s" % str(cell_index_tuple)
+      raise ValueError("Could not create cell %s" % str(cell_index_tuple))
 
     cell.edit(edit_order=edit_order, **gv)  # First update globals which include the def. of property_list
     if 'variated_property' in cell_value_dict:

product/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/Base_edit.py

@@ -184,9 +184,9 @@ def editMatrixBox(matrixbox_field, matrixbox):
                 cleaned_v[key] = None
             cell.edit(edit_order=edit_order, **cleaned_v) # and update the cell specific values
           else:
-            return "Could not create cell %s" % str(cell_index_tuple)
+            raise ValueError("Could not create cell %s" % str(cell_index_tuple))
         else:
-          return "Cell %s does not exist" % str(cell_index_tuple)
+          raise ValueError("Cell %s does not exist %s" % str(cell_index_tuple))
 
 field_prefix_len = len(field_prefix)