- 28 Nov, 2019 4 commits
-
-
Jérome Perrin authored
Without this, subclassing defining this method will have arguments-differ pylint warning because the signature of Base._checkConsistency is different.
-
Jérome Perrin authored
These scripts are used to check the site configuration and also in CodingStyleTest. This is just the minimal so that CodingStyleTest can run, but this could be extended to several scripts currently in erp5_toolbox skinfolder of erp5_forge which overlaps with erp5_administration. Also, regarding CodingStyleTest, it seems that erp5_administration contain a lot of things, so we may want to extract a smaller business template containing only the scripts used for static analysis of business template.
-
Jérome Perrin authored
We want this check to run on all components.
-
Jérome Perrin authored
Module is an acceptable prefix for modules Introduce a list of skins IDs that does not match our conventions but are acceptable because this is what external API are calling.
-
- 26 Nov, 2019 3 commits
-
-
Gabriel Monnerat authored
-
Jérome Perrin authored
MissingCategoryDocumentConstraint was incorrectly using unrestrictedTraverse, unlike category API which uses its own resolveCategory method with better semantics. Because of this, some problems were not reported: - categories using paths that resolve by acquisition, but does not exists as such (like in the test) - categories using path with dynamic objects, like a website language. /reviewed-on !986
-
Jérome Perrin authored
checkRevision now returns a callable, return a do-nothing lambda when the expected revision is already checked out /reviewed-on nexedi/erp5!990
-
- 25 Nov, 2019 5 commits
-
-
Gabriel Monnerat authored
-
Gabriel Monnerat authored
-
Gabriel Monnerat authored
With this merge request we add the feature of allow a gadget to call submitDialog *and* the prototype of scan documents from mobile with new ERP5 UI /reviewed-on nexedi/erp5!932
-
Gabriel Monnerat authored
For now, this is chrome only erp5_document_scanner_ui_test: Add tests to Document Scanner gadget
-
Gabriel Monnerat authored
-
- 22 Nov, 2019 12 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Roque authored
-
Roque authored
-
Roque authored
-
Roque authored
- tests updated
-
Roque authored
- test extended
-
Roque authored
-
Roque authored
-
- 21 Nov, 2019 4 commits
-
-
Julien Muchembled authored
If automatic GC happens just after the testnode repository is updated, the repository in the SR may lose objects and fail to update. See commit 9634a7d8.
-
Sven Franck authored
-
Jérome Perrin authored
Pylint warnings are now causing test failures. /reviewed-on !987
-
Ivan Tyagov authored
revision(s) a Test Result has already been completed. Thus we need to properly handle this use case otherwise simply failing makes "client side" - i.e. testnode keep trying forever in its _retryRPC calls which indefinitely blocks further tests executions.
-
- 19 Nov, 2019 1 commit
-
-
Jérome Perrin authored
A new test suite to perform static check on business templates using `CodingStyleTestCase`. This runs a coding style test for each business template, after installing the business template and its dependencies listed in business template metadata. --- In order to start with a test suite with no failure, business templates that does not pass this test today (because they don't install or because pylint issues still needs to be reviewed) are skipped with an ad-hoc `bt/skip_coding_style_test` in the business template. Note that this file is not created by business template system as it is a temporary measure, business templates must pass pylint and other checks from `CodingStyleTestCase`. --- I took the approach of creating one independent test per business template, instead of the approach of creating a site with all business templates like we did in testNamingConventions or testHTML. This appears as another "Coding Style" test, like Performance or Scalability tests. The idea behind this was that if we extend our business template checks ( for example when we translate the [ERP5 Module Creation Guidelines](https://www.erp5.com/documentation/developer/guideline/module) to some scripts we can run on a business template ), we can check that each business template contain what it should contain and not just that the global result is OK. /reviewed-on !629
-
- 18 Nov, 2019 5 commits
-
-
Arnaud Fontaine authored
PortalTransforms: safe_html: Changes in b255c894 were not actually applied so merge FS module and portal_transforms/safe_html.
-
Vincent Pelletier authored
These titles duplicate listbox configuration, preventing any change from reaching users (...who customised their listbox). Also fixes cases where column title was stored in selection after translation, which breaks some reports.
-
Vincent Pelletier authored
Avoid double-calls when one is enough. Avoid unused locals. Avoid repeating conditions. Inline single-use expressions.
-
Jérome Perrin authored
Bootstrap is actually the automatic migration of tools. It happened to me several times that I mistakenly start an old instance on a too new version of products and this instance is migrated automatically. By leaving a note in transaction it's easier to find out which transaction performed the automatic migration to revert to the state before using technique such as https://blog.gocept.com/2019/06/14/undo-transactions-by-truncating-zodb-data-fs/ for FileStorage. with this change, a command such as; python -m ZODB.scripts.fstail -n 20 ./instance/slappart6/srv/zodb/root.fs show something like: 2019-11-12 02:46:42.106313: hash=44fecb9a63411fbf305cea82f4c699c478000d61 user=' None' description='/timer_service/process_timer\nSite migrated' length=462938 offset=881877846 (+70) for the transaction which did the migration, so it's easy to repair. /reviewed-on !975
-
Arnaud Fontaine authored
* erp5_dms: ERP5OOo/ConversionServer-related Transforms. * erp5_web: Web Page-related Transform. * erp5_base: Everything else. Also, ZODB Components Transforms modules were 'Document Component', whereas it should be 'Module Component' (introduced recently) considering that they have no Portal Type.
-
- 15 Nov, 2019 2 commits
-
-
Romain Courteaud authored
-
Jérome Perrin authored
We'll gradually enable the business templates as we fix them.
-
- 14 Nov, 2019 4 commits
-
-
Julien Muchembled authored
See commit a93ea5f1.
-
Romain Courteaud authored
Test cancelling a dialog displayed twice. Test submitting a dialog displayed twice.
-
Romain Courteaud authored
Keep compatibility with officejs apps
-
Romain Courteaud authored
-