1. 24 Jan, 2022 32 commits
  2. 21 Jan, 2022 1 commit
    • Jérome Perrin's avatar
      property_sheets: generate value accessors for source/destination accounts on default supply · 5ad2b222
      Jérome Perrin authored
      Without these accessors, we have to use constructs like:
      
          resource.edit(
              default_purchase_supply_line_destination_account='account_module/123'
          )
      
      with the accessors, we can use:
      
          resource.edit(
              default_purchase_supply_line_destination_account_value=account,
          )
      
      The former is a bit error prone, because typos in the property name
      silently create a local propery and typos in the relative URL make a
      "broken" relation.
      5ad2b222
  3. 20 Jan, 2022 1 commit
  4. 18 Jan, 2022 1 commit
    • Jérome Perrin's avatar
      dms: rename print actions not to conflict with erp5_odt_style · ea4debfe
      Jérome Perrin authored
      odt_style comes with "Print" global actions which allows getting the
      default form as ODT and convert it to selected format and DMS comes with
      "Print" actions which return a PDF of the document content.
      
      As a result, when user try to use Print, they have the same action twice
      with no way to know which one is which.
      
      This is detected by CodingStyleTestCase.test_DuplicateActions, but only
      for configurations where both erp5_odt_style and erp5_dms are installed,
      which is not the case in coding style test suite which only install the
      miminmal dependent business templates.
      ea4debfe
  5. 17 Jan, 2022 3 commits
  6. 14 Jan, 2022 2 commits
    • Jérome Perrin's avatar
      Workflow: don't change REQUEST when passing transition · 91af570a
      Jérome Perrin authored
      The new workflow implementation from df85ef46 (ERP5Workflow: DC Workflows
      are now ERP5 objects (!1378)., 2020-11-18) had a different behavior in
      the implementation of _executeTransition, it was setting all kwargs
      from the transition in REQUEST. The reasons for this are unclear, it
      seem to come from the first Workflow implementation, 81784db4 (Initial
      Import of ERP5Workflow porduct., 2010-10-15)
      
      The side effects are that calling a workflow method, for example:
      
        document.edit(key=value)
      
      would also alter the global request to set key=value in REQUEST, for the
      rest of the current request.
      
      It was causing subtle issues, especially in tests where the REQUEST
      lifetime is long.
      91af570a
    • Jérome Perrin's avatar
      workflow: fix Update Security Roles action on workflow · 55049a0c
      Jérome Perrin authored
      This was redirecting with the full list of updated documents URLs,
      causing too long URLs.
      
      This also simplifies code a bit, change the wording of messages and
      use translation.
      55049a0c