- 29 Mar, 2022 1 commit
-
-
Georgios Dagkakis authored
Base_report needs to get also the cleanup_tag to make sure it is launched before active process is deleted
-
- 24 Mar, 2022 2 commits
-
-
Julien Muchembled authored
When rendering a proxy field, 3 different fields can come in play: 1. the field to be rendered 3. the template field (i.e. not a proxy field) that knows how to render 2. possibly an intermediate proxy field that contains the value to render What's difficult when rendering a proxy field is to take the above 3 fields into account and this commit does it by creating a temporary field: 1. 'field' variable in TALES 2. the value 3. the code Before this commit, 1 could be wrong.
-
Jérome Perrin authored
This was deprectated because we don't have get*ById for other modules and tools, we just use OFS API. This should also be slightly faster because one less method call (and one less call to warning)
-
- 23 Mar, 2022 4 commits
-
-
Jérome Perrin authored
exiting the context manager restores the original DateTime behavior
-
Jérome Perrin authored
This tests the test framework, because this code is tricky.
-
Jérome Perrin authored
-
Jérome Perrin authored
I'm not sure if this is used, but not being valid python code cause problems with code analysis tools
-
- 22 Mar, 2022 1 commit
-
-
Jérome Perrin authored
Maybe this made sense long time ago, but nowadays we are using equivalence testers which tolerate date differences with more flexibility. createDateTimeFromMillis was also problematic as it uses internal private attributes of DateTime which is a pylint error with more recent DateTime
-
- 21 Mar, 2022 2 commits
-
-
Romain Courteaud authored
Permissions are managed by the document_publication_worflow
-
Xiaowu Zhang authored
-
- 18 Mar, 2022 1 commit
-
-
Jérome Perrin authored
Most service worker precache scripts reference a favicon.ico, but this is using the default favicon.ico from Zope and even though it was included in all ERP5JS and OfficeJS web sites, this was mostly not used, only web_renderjs_ui web pages reference favicon.ico. There's a favicon.ico in erp5_xhtml_style skin folder, but the skin folder is not in ERP5JS skin selection. On Zope2, this caused ERP5JS and OfficeJS application use the default Zope favicon. On Zope4, the service worker can not fill its cache because of 404 errors, because since Zope commit 4f0770941 (Retired icons from the `Zope Management Interface` and various smaller cleanups of ZMI screens., 2011-07-02) there's no default favicon.ico anymore. To solve this, provide a favicon.ico in ERP5JS skin selection, by copying the one from erp5_xhtml_style. We also reference it explicitly in web site layout properties so that it remain in the cache. OfficeJS applications do not use favicon.ico explicitly. They use icons in their web application manifest, but this does not seem to be use as favicon unless the PWA is installed. This part is not addressed by this commit.
-
- 11 Mar, 2022 2 commits
-
-
Vincent Pelletier authored
-
Vincent Pelletier authored
-
- 10 Mar, 2022 5 commits
-
-
Vincent Pelletier authored
Avoid repeating processing_node condition for every single activity whose serialization_tag dependency is being checked. This reduces the length and execution complexity of produced SQL.
-
Jérome Perrin authored
The meaning of empty items for **multi** list fields for categories is not clear for dialogs (if user does not want to apply any filter, then the natural way would be to select nothing). This also caused issues with category fields, when the action script uses restrictedTraverse to get the uids corresponding to the category but a path is empty, like for example in https://lab.nexedi.com/nexedi/erp5/blob/d51bb0413a806b3db0c5eb69dec06065b9601322/bt5/erp5_accounting/SkinTemplateItem/portal_skins/erp5_accounting/AccountModule_getTrialBalanceReportSectionList.py#L40-48 which does this: ```python # optional GAP filter node_uid = [] gap_uid_list = [] for gap in request.get('gap_list', ()): gap_uid_list.append(portal.portal_categories.gap.restrictedTraverse(gap).getUid()) if gap_uid_list: node_uid = [x.uid for x in portal.portal_catalog( portal_type='Account', default_gap_uid=gap_uid_list)] or -1 ``` If an empty item is selected, then `gap_uid_list` will contain an entry for `portal.portal_categories.gap.restrictedTraverse('').getUid()` which will be the uid of the gap base category. Searching with a base category uid nowadays does not match any document, but before 95e3eaec (CMFCategory: Do not index any Base Category as a related document., 2016-12-21), it was matching all documents having a relation from this base category and in the case of this trial balance report it was matching all accounts. This was a problem for old instances with accounts created before 95e3eaec, because when they were first indexed, they had the record in category table, so they were matched, but once they get re-indexed, they no longer had the record, so the result of this report when selecting the empty item became different, because accounts were no longer included. Looking back at this, maybe when updating to get 95e3eaec, we should have ran a migration to delete all these records (re-indexing every document in the background should be enough) so that if there's a problem, the problem happens right now and not after a few months after accounts are modified and re-indexed. When looking at this from end user level, theses empty items not only cause this problem, but also does not have a clear behaviour and are not needed, so the changes here are about removing these empty items. In accounting reports, there was a multi listfield showing all gap categories, "grouped" by chart of account - but the name of the chart of account was not displayed. This change to use a None item, which is rendered as disabled to display the chart of account name, but to do this we had to fix a bug in Formulator, these disabled items were only working properly for single item widgets, not multiple items widgets. See merge request nexedi/erp5!1572
-
Jérome Perrin authored
This addresses a regression from nexedi/erp5!1561 changing the class hierarchy caused Login to loose its docstring and became no longer publishable. This was problematic because it was not detected by the test suite, so HTML test is changed to use zope publication instead of calling the view on the context. Another notable point is that this behaves differently in ERP5JS, the Logins were still visible in ERP5JS. Because we don't actually rely on "no docstring on the class" to prevent publication, this is not changed. See merge request nexedi/erp5!1571
-
Jérome Perrin authored
There was opening and closing tags mismatch: <div><a href="#references1_anchor">References</div></a>
-
Jérome Perrin authored
This seems to be used only in Localizer's ZMI. This is not compatible with newer version of DocumentTemplate, but because we don't use, it's better to remove the functionality
-
- 08 Mar, 2022 8 commits
-
-
Vincent Pelletier authored
In order to stabilise UI tests which are waiting for the loading animation to play during language change. Pick a small delay so users should not notice (value suggested by Romain).
-
Gabriel Monnerat authored
When we have more than one language and many documents with same reference but with different language, the first impression is that we have many duplicated documents. Display the language, we can easily detect that we have same reference to different languages.
-
Jérome Perrin authored
While in a "single" list field, we need an empty item that will be selected by default, there's no such need on a multi list field. These empty items also have the problem that their meaning is not really clear.
-
Jérome Perrin authored
Instead of having empty string items which for which the meaning is not really clear.
-
Vincent Pelletier authored
processing_node -3 is not automatically used anymore, such failure would nowadays be a processing_node of -2. So simplify this comment.
-
Vincent Pelletier authored
For example, an immediateReindexObject and a SQLCatalog_deferFullTextIndexActivity may be spawned.
-
Vincent Pelletier authored
-
Vincent Pelletier authored
Without this, more categories than can be displayed in the dropdown menu may match, pushing expected "Quantity" one out of the list, causing the test to fail.
-
- 07 Mar, 2022 7 commits
-
-
Vincent Pelletier authored
-
Jérome Perrin authored
-
Jérome Perrin authored
This is more realistic, because a real HTTP request will use ZPublisher.BaseRequest.BaseRequest.traverse, which has slightly different behaviour than getting the form on the context of document. The behavior becomes different for documents which do some logic on traversal (like for example the web sites changing the skin).
-
Jérome Perrin authored
This was breaking for cases where values contained characters used for markup such as <> or & and also for the special case of None which is used to render disabled items.
-
Vincent Pelletier authored
-
Jérome Perrin authored
Zope only publish objects if they have a docstring. The change in class hierarchy from b7a60478 (ERP5Security,erp5: simplify EncryptedPasswordMixin.setPassword, 2022-02-21) caused that Login and subclasses no longer have a docstring and as a result there were no longer publishable by Zope, so it was not possible to view them in xhtml style. ERP5JS was not affected, because it does not directly rely on Zope publication APIs.
-
Jérome Perrin authored
We don't want to use wildcard in core business template, because when another business template extend these paths with new documents, the new documents are included in erp5_core. This also cause issues for tests creating dummy content in these paths.
-
- 03 Mar, 2022 4 commits
-
-
Arnaud Fontaine authored
This was still working with Zope 2.13 because the default output_encoding for HTML was iso-8859-15 but this is not the case anymore with Zope 4. Moreover this should be explicit rather than implicit anyway...
-
Arnaud Fontaine authored
Revert "testBusinessTemplateTwoFileExport: Make output_encoding explicit as it should have always been." This reverts commit 968991e7 which does not actually work properly with Zope4.
-
Yusei Tahara authored
-
Yusei Tahara authored
SQLCatalog_trimInventoryCacheOnCatalog needs resource category on movement.
-
- 02 Mar, 2022 1 commit
-
-
Vincent Pelletier authored
-
- 28 Feb, 2022 2 commits
-
-
Arnaud Fontaine authored
This fixes a failure due to Zope4 now defaulting to utf-8.
-
Jérome Perrin authored
Use `portal_alarms/check_consistency` after configuration to make sure that every document created by configurator or part of the dependency business template is valid. For now we have two exceptions (that are some TODO for the future): - Web Sites, because upgrader constraints are not ran by configurator at this point - Business Configuration, because most of the configurator item classes don't fully follow the protocol of constraints, their `fixConsistency` method always return "something needs to be fixed" without actually checking. See merge request !1562
-