By relying on PIL after our monkey-patched OFS.Image.getImageInfo.

We keep this monkey-patch for now, because it adds supports to svg

See merge request !1426

Since 7f32f8cd (erp5_dms: Add PDF Reader using the pdf.js, 2016-06-24)
we have a PDF preview with a javascript PDF view, which is much better way
of viewing PDF.

This commit made the Thumbnail preview obsolete, also it does not really
work on ERP5JS, so remove the thumbnail preview.

See commit ec3c9cbc.

See merge request nexedi/erp5!1429

Wendelin.core is now integral part of ERP5 (see [1,2]), but nothing
inside ERP5 currently uses it. And even though wendelin.core has its own
testsuite, integration problems are always possible.

-> Add test to erp5_core_test that minimally makes sure that basic
wendelin.core operations work.

This test currently passes with wendelin.core 1, which is the default.
It also passes as live test with wendelin.core 2.
However with wendelin.core 2 it currently fails on testnodes like e.g.

    ValueError: ZODB.MappingStorage.MappingStorage is in-RAM storage
	in-RAM storages are not supported:
	a zurl pointing to in-RAM storage in one process would lead to
	another in-RAM storage in WCFS process.

and

    RuntimeError: wcfs: join file:///srv/slapgrid/slappart8/srv/testnode/djk/test_suite/unit_test.2/var/Data.fs: server not started
    (https://nexedijs.erp5.net/#/test_result_module/20210530-92EF3124/102)

because we need to amend ERP5 test driver

1) to run tests on a real storage instead of in-RAM Mapping Storage(*), and
2) to spawn WCFS server for each such storage.

I will try to address those points in a later patch.

In the meantime there should be no reason not to merge this, because we
do not use wendelin.core 2 yet, and solving "1" and "2" first are
preconditions to begin such a usage.

/cc @rafael, @tomo, @seb, @jerome, @romain, @vpelletier, @Tyagov, @klaus, @jp

(*) Combining Zope and WCFS working together requires data to be on a real
    storage, not on in-RAM MappingStorage inside Zope's Python process.

[1] nexedi/slapos@7f877621
[2] nexedi/slapos!874 (comment 122339)

We don't want to show the ID which has a prefix, but the reference

See merge request nexedi/erp5!1427

because DMS extends image portal types with interaction workflows etc,
it's better to also cover the case where DMS is installed.

This fixes problem that some formats such as tiff were not supported.

testSQLCachedWorklist is now part of a dedicated erp5_worklist_sql_test
business template.

We had two mimetypes entries, which caused inconsistencies depending on
wether the lookup was done by mimetype, by glob or by extension.

We had:

- name:
   "Windows BMP image"
- mimetypes:
    image/bmp
    image/x-bmp
    image/x-MS-bmp
- extensions:
- globs:
    *.bmp

and

- name:
   "image/x-ms-bmp"
- mimetypes:
    image/x-ms-bmp
- extensions:
    bmp
- globs:

With this commit they are merged into one:

- name:
   "Windows BMP image"
- mimetypes:
    image/x-ms-bmp
    image/bmp
    image/x-bmp
    image/x-MS-bmp
- extensions:
    bmp
- globs:
    *.bmp

This way we only have one consistent mimetype.

For compatibility with extension lookups (that are done in
Document_guessMimeType interaction workflow from DMS), image/x-ms-bmp is
kept as default. This might not be the best choice, according to
https://www.iana.org/assignments/media-types/media-types.xhtml

This script creates Web Message, not Mail Message

See merge request nexedi/erp5!1411

Fixes [#20210517-960A47](https://erp5js.nexedi.net/#/bug_module/20210517-960A47)

The most important changes are:
 - coding style is enabled again for workflow scripts and starts to be enabled for ERP5 Python scripts
 - monaco editor support for workflow scripts, SQL methods and .less
 - small fixes for python/workflow scripts forms and ZMI

See merge request nexedi/erp5!1422

Changing state directly in Base_contribute was only functional for the case
where metadata was discovered asynchronously. In the case of synchronous
discovery, the state was first changed state, and Document_convertToBaseFormatAndDiscoverMetadata
was executed - but this this was causing Unauthorized like this:

      Module script, line 10, in Document_convertToBaseFormatAndDiscoverMetadata
      - <PythonScript at /erp5/Document_convertToBaseFormatAndDiscoverMetadata used for /erp5/document_module/163>
      - Line 10
        return context.discoverMetadata(filename=filename,
    Unauthorized: You are not allowed to access 'discoverMetadata' in this context

because once we have already changed state, regular user no longer have
permission to access discoverMetadata, because that method needs ModifyPortalContent
permission.

Instead, of handling publication_state only in Base_contribute, treat it
like others user input parameter and change state during discovery.

Tests were also re-organised to move Base_contribute related test in testIngestion
and also to run Base_contribute tests as a non-manager user.

This was never supported, we support only [state in $workflow_id]

See also:

  https://erp5js.nexedi.net/#/bug_module/1740

  b6dcbc19 (l10n_fr,l10n_jp: Fix translation of "Open", 2021-04-30)

Generated from this script:

    #!/srv/slapgrid/slappart3/srv/runner/software/cc0326f0dcb093f56c01291c300c8481/parts/erp5/venv/bin/python

    import polib
    import sys
    import re

    pofile = polib.pofile(sys.argv[1])

    msgs = dict()
    for entry in pofile:
      msgs[entry.msgid] = entry.msgstr

    transition_re = re.compile(r'(.*) \[transition in .*\]')

    fixed_messages = dict()
    for entry in pofile:
      match = transition_re.match(entry.msgid)
      if match:
        # in erp5_l10n_de some msgstr also have the [transition in ...], we drop them
        if transition_re.match(entry.msgstr):
          continue
        short = match.groups()[0]
        if short.endswith('Action'):
          continue
        if short not in msgs:
          print(f"🤔  {short} not translated ( from {entry.msgid} )")
          fixed_messages[short] = entry.msgstr
      else:
        fixed_messages[entry.msgid] = entry.msgstr

    pofile.clear()
    for k, v in fixed_messages.items():
      pofile.append(polib.POEntry(msgid=k, msgstr=v))

    pofile.save(sys.argv[1])

    import subprocess
    subprocess.check_output(
      [
        '/opt/slapos-shared/gettext/4df93a547efd86e0eb70495b88a5d3b1/bin/msgattrib',
        sys.argv[1],
        "--no-fuzzy",
        "--translated",
        "-s",
        "--no-wrap",
        "-o",
        sys.argv[1]

      ]
    )

using:

    msgattrib translation.po --no-fuzzy --translated -s --no-wrap -o translation.po

translated_title is used in listbox search columns, so it's very confusing
for users if they can not use the usual % character for partial matches.

This changes the behaviour of translated_title to autodetect the presence of
% and use LIKE comparison operator in such case.

these ERP5 Python Scripts were not covered by coding style tests

This ERP5 Python script was not checked until now, and add wrong indentation

The ID is calculated from reference, showing reference is enough.
There is no "callable_type" property on workflow script

Don't hardcode a few roles, use the API to get all roles

Only zope Python Scripts were checked

the convention is to use a my_ or your_ prefix

This is only supported in monaco editor

use syntax highlighting for SQL language, not really correct because of
dtml, but probably better than plain text

 - fix order of ZMI tabs to make `Edit` the default
 - enable ZMI code editor
 - add an icon
 - fix links to python scripts in BusinessTemplate_getPythonSourceCodeMessageList

this field did not use a (my_ / your_) prefix

See merge request nexedi/erp5!1419