Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 149
    • Merge requests 149
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !2284

Draft: core,hal_json: preserve listbox editable fields when re-displaying a dialog

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Jérome Perrin requested to merge fix/listbox_multi_editable_validation into master May 07, 2026
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 15

This reverts 682cdb5f (Cleanup formulator internals fields when Base_callDialogMethod does not redirect., 2010-06-08) which was probably made because dialog when not redirecting was calling the action script with all formulator internal parameters, which was a different behavior compared to the case where it redirects and started to cause problems with action scripts not accepting **kw. In ERP5JS the dialog is always called directly, so this specific behavior from erp5_core/Base_callDialogMethod became inconsistent with ERP5JS.

Reverting this and fixing ERP5JS to recreate formulator behavior with field values from requests to also have listbox editable fields in request enables action dialog scripts to re-display the dialog with an error message with all the user input preserved, making it possible to validate dialog "globally" and have a validation error that is not attached to a specific field, like in the example from the test.

This is a bit breaking behavior, observed with "wizard" style dialogs where we have a first dialog with an editable listbox and a second dialog with an editable listbox as well. When using Base_renderForm to in the action script of the first dialog, this will propagate editable fields of the editable listbox as well. Before this change only simple fields (like string fields etc) were used in the second dialog.

Edited May 07, 2026 by Jérome Perrin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/listbox_multi_editable_validation
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7