IdTool: handle group_id on python3
group_id is used as key of OOBtree and as documented, it's not possible to mix keys that can not be compared, so we can not have a mix of string and bytes, for consistency with other BTrees, such as the ones used for OFS. group_id is also used in a SQL column which is BINARY, this is problematic on py3 because the selected values will be returned as bytes, but we expect str here. Because we don't want to run a data migration, we adjust the select methods to convert to str while selecting. Since years there was a warning that id_group must be a string, now we make it a bit stricter, we also enforce that the id_group is valid UTF-8. A few more tests and assertions were also added. Reviewed-on: !1980
Status | Job ID | Name | Coverage | ||||||
---|---|---|---|---|---|---|---|---|---|
External | |||||||||
canceled |
#715642
external
|
ERP5.CodingStyleTest-TestRunner2 |
129:29:00
|
||||||
failed |
#716181
external
|
ERP5.UnitTest-TestRunner2 |
05:07:13
|
||||||
passed |
#715295
external
retried
|
ERP5.CodingStyleTest-TestRunner2 |
10:18:52
|
||||||
failed |
#715631
external
retried
|
ERP5.CodingStyleTest-TestRunner2 |
00:02:05
|
||||||
failed |
#715636
external
retried
|
ERP5.CodingStyleTest-TestRunner2 |
00:02:54
|
||||||
failed |
#715638
external
retried
|
ERP5.CodingStyleTest-TestRunner2 |
00:02:36
|
||||||
failed |
#715639
external
retried
|
ERP5.CodingStyleTest-TestRunner2 |
00:02:34
|
||||||
failed |
#715640
external
retried
|
ERP5.CodingStyleTest-TestRunner2 |
00:01:57
|
||||||
failed |
#715641
external
retried
|
ERP5.CodingStyleTest-TestRunner2 |
00:02:23
|
||||||
passed |
#715173
external
retried
|
ERP5.CodingStyleTest-TestRunner2 |
02:36:30
|
||||||
passed |
#715119
external
retried
|
ERP5.CodingStyleTest-TestRunner2 |
01:02:19
|
||||||
failed |
#715549
external
retried
|
ERP5.UnitTest-TestRunner2 |
00:01:12
|
||||||
failed |
#715550
external
retried
|
ERP5.UnitTest-TestRunner2 |
00:01:10
|
||||||
failed |
#715552
external
retried
|
ERP5.UnitTest-TestRunner2 |
00:01:12
|
||||||
failed |
#715553
external
retried
|
ERP5.UnitTest-TestRunner2 |
00:01:15
|
||||||
failed |
#715554
external
retried
|
ERP5.UnitTest-TestRunner2 |
00:01:09
|
||||||
failed |
#715559
external
retried
|
ERP5.UnitTest-TestRunner2 |
07:52:21
|
||||||
failed |
#715988
external
retried
|
ERP5.UnitTest-TestRunner2 |
05:36:44
|
||||||
failed |
#716100
external
retried
|
ERP5.UnitTest-TestRunner2 |
04:02:51
|
||||||
passed |
#715120
external
retried
|
ERP5.UnitTest-TestRunner2 |
02:19:31
|
||||||
failed |
#715182
external
retried
|
ERP5.UnitTest-TestRunner2 |
05:03:38
|
||||||
failed |
#715379
external
retried
|
ERP5.UnitTest-TestRunner2 |
06:34:18
|
||||||
failed |
#715534
external
retried
|
ERP5.UnitTest-TestRunner2 |
00:01:07
|
||||||
failed |
#715538
external
retried
|
ERP5.UnitTest-TestRunner2 |
00:01:11
|
||||||
failed |
#715543
external
retried
|
ERP5.UnitTest-TestRunner2 |
00:01:24
|
||||||
failed |
#715547
external
retried
|
ERP5.UnitTest-TestRunner2 |
00:01:09
|
||||||
failed |
#715548
external
retried
|
ERP5.UnitTest-TestRunner2 |
00:01:16
|
||||||