Comply to JSLint

cli.js

-/*jslint indent2 */
-/*global console, std */
-
-const EPSILON_YAW = 6;
-const EPSILON_ALTITUDE = 5;
-const TARGET_YAW = 0;
-
-var running = false;
-const wrongParameters = displayMessage.bind(null, "Wrong parameters");
-
-function displayDronePositions() {
-  if(!pubsubRunning)
-    console.log("You must start pubsub first !");
-  else {
-    for (const [id, drone] of Object.entries(droneDict)) {
-      console.log(id, drone.latitude, drone.longitude, drone.altitudeAbs, drone.altitudeRel);
-    }
-  }
-  return 0;
-}
-
-function land() {
-  var yaw;
-
-  while(true) {
-    yaw = getYaw();
-    console.log(`[DEMO] Waiting for yaw... (${yaw} , ${TARGET_YAW})`);
-    if(Math.abs(yaw - TARGET_YAW) < EPSILON_YAW) {
-      break;
-    }
-    sleep(250);
-  }
-
-  console.log("[DEMO] Deploying parachute...");
-  exit_on_fail(doParachute(2), "Failed to deploy parachute");
-}
-
-function waitForAltitude(target_altitude) {
-  var altitude = getAltitude();
-  while(Math.abs(altitude - target_altitude) > EPSILON_ALTITUDE) {
-    console.log(
-      `[DEMO] Waiting for altitude... (${altitude} , ${target_altitude})`);
-    sleep(1000);
-    altitude = getAltitude();
-  }
-}
-
-function goToAltitude(target_altitude, wait, go) {
-  if(go) {
-    exit_on_fail(
-      setAltitude(target_altitude),
-      `Failed to go to altitude ${target_altitude} m`
-    );
-  }
-
-  if(wait) {
-    waitForAltitude(target_altitude);
-  }
-}
-
-function checkNumber(value, toExecute) {
-  return (
-    Number.isNaN(value)
-    ? wrongParameters
-    : toExecute.bind(null, value)
-  );
-}
-
-function displayMessage(message) {
-  console.log(message);
-  return 0;
-}
-
-function exit() {
-  running = false;
-  return 0;
-}
-
-function getInput() {
-  let undefined_cmd;
-  let altitude;
-  let cmd;
-  let latitude;
-  let longitude;
-  let s;
-  let speed;
-  
-  const help = `
-    land
-    goto(point)
-    gotoCoord(latitude, longitude)
-    altitude(altitude)
-    speed(speed)
-    positions
-    reboot
-    exit
-    help
-  `;
-
-  const f = std.fdopen(std.in, "r");
-  running = true;
-  while (running) {
-    std.printf("> ");
-    s = f.getline();
-    undefined_cmd = false;
-  
-    switch (s) {
-    case "altitude":
-      std.printf("Altitude: ");
-      altitude = parseFloat(f.getline());
-      cmd = checkNumber(altitude, setAltitude);
-      break;
-  
-    case "exit":
-      cmd = exit;
-      break;
-  
-/*    case "gotoCoord":
-      std.printf("Latitude: ");
-      latitude = parseFloat(f.getline());
-      std.printf("Longitude: ");
-      longitude = parseFloat(f.getline());
-      cmd = checkNumber(longitude, checkNumber(latitude, setTargetLatLong));
-      break;*/
-  
-    case "help":
-      cmd = displayMessage.bind(null, help);
-      break;
-  
-    case "land":
-      cmd = land;
-      break;
-  
-    case "loiter":
-      cmd = loiter;
-      break;
-  
-    case "positions":
-      cmd = displayDronePositions;
-      break;
-  
-    case "reboot":
-      cmd = reboot;
-      break;
-  
-    case "speed":
-      std.printf("Speed: ");
-      speed = parseFloat(f.getline());
-      cmd = checkNumber(speed, setAirspeed);
-      break;
-  
-    default:
-      undefined_cmd = true;
-      cmd = displayMessage.bind(null, "    Undefined command");
-    }
-  
-    let ret = cmd();
-    if (ret) {
-      console.log("    [ERROR] function:\n", cmd, "\nreturn value:", ret);
-    }
-    else if (s !== "help" && !undefined_cmd) {
-      console.log("    Command successful");
-    }
-  };
-
-  f.close();
-}
-
-me.onUpdate = function() {
-  getInput();
-};
+/*jslint nomen: true, indent: 2, maxerr: 3, maxlen: 80 */
+/*global console, me*/
+
+   (function (console, me) {
+     "use strict";
+   
+     function displayMessage(message) {
+       console.log(message);
+       return 0;
+     }
+   
+     var help = ["altitude(altitude)", "exit",
+       "goto(latitude, longitude, altitude)", "help", "land", "loiter",
+       "positions", "speed(speed)"].join("\n"),
+       wrongParameters = displayMessage.bind(null, "Wrong parameters");
+   
+     function checkNumber(value, toExecute) {
+       return (
+         Number.isNaN(value)
+         ? wrongParameters
+         : toExecute.bind(null, value)
+       );
+     }
+   
+     function displayDronePositions() {
+       Object.entries(me.droneDict).forEach(function ([id, drone]) {
+         console.log(
+           id,
+           drone.latitude,
+           drone.longitude,
+           drone.altitudeAbs,
+           drone.altitudeRel
+         );
+       });
+       return 0;
+     }
+   
+     function exit() {
+       try {
+         me.f.close();
+       } catch (error) {
+         console.error(error);
+       }
+       me.exit(0);
+     }
+   
+     me.onStart = function () {
+       me.f = me.fdopen(me.in, "r");
+       console.log(help);
+     };
+   
+     me.onUpdate = function () {
+       var altitude,
+         latitude,
+         longitude,
+         speed,
+         user_input,
+         undefined_cmd = false,
+         cmd,
+         ret;
+   
+       console.log("> ");
+       user_input = me.f.getline();
+   
+       switch (user_input) {
+       case "altitude":
+         console.log("Altitude: ");
+         altitude = parseFloat(me.f.getline());
+         cmd = checkNumber(altitude, me.setAltitude);
+         break;
+   
+       case "exit":
+         cmd = exit;
+         break;
+   
+       case "goto":
+         console.log("Latitude: ");
+         latitude = parseFloat(me.f.getline());
+         console.log("Longitude: ");
+         longitude = parseFloat(me.f.getline());
+         console.log("Altitude: ");
+         altitude = parseFloat(me.f.getline());
+         cmd = checkNumber(
+           altitude,
+           checkNumber(longitude, checkNumber(latitude, me.setTargetCoordinates))
+         );
+         break;
+   
+       case "help":
+         cmd = displayMessage.bind(null, help);
+         break;
+   
+       case "land":
+         cmd = me.triggerParachute;
+         break;
+   
+       case "loiter":
+         cmd = me.loiter;
+         break;
+   
+       case "positions":
+         cmd = displayDronePositions;
+         break;
+   
+       case "speed":
+         console.log("Speed: ");
+         speed = parseFloat(me.f.getline());
+         cmd = checkNumber(speed, me.setAirspeed);
+         break;
+   
+       default:
+         undefined_cmd = true;
+         cmd = displayMessage.bind(null, "    Undefined command");
+       }
+   
+       ret = cmd();
+       if (ret) {
+         console.log("    [ERROR] function:\n", cmd, "\nreturn value:", ret);
+       } else if (user_input !== "help" && !undefined_cmd) {
+         console.log("    Command successful");
+       }
+     };
+   }(console, me));
+   
\ No newline at end of file