Commit 8f1bc93c authored by Juliusz Chroboczek's avatar Juliusz Chroboczek

Protect against clients with an empty id.

parent 7f93aa5d
...@@ -609,17 +609,18 @@ func AddClient(group string, c Client, creds ClientCredentials) (*Group, error) ...@@ -609,17 +609,18 @@ func AddClient(group string, c Client, creds ClientCredentials) (*Group, error)
} }
} }
} }
id := c.Id()
if g.clients[c.Id()] != nil { if id == "" {
return nil, errors.New("client has empty id")
}
if g.clients[id] != nil {
return nil, ProtocolError("duplicate client id") return nil, ProtocolError("duplicate client id")
} }
g.clients[id] = c
g.clients[c.Id()] = c
g.timestamp = time.Now() g.timestamp = time.Now()
c.Joined(g.Name(), "join") c.Joined(g.Name(), "join")
id := c.Id()
u := c.Username() u := c.Username()
p := c.Permissions() p := c.Permissions()
s := c.Data() s := c.Data()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment