merge_request_spec.rb 150 KB
Newer Older
1 2
# frozen_string_literal: true

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
3 4
require 'spec_helper'

5
RSpec.describe MergeRequest, factory_default: :keep do
6
  include RepoHelpers
7
  include ProjectForksHelper
8
  include ReactiveCachingHelpers
9

10 11
  using RSpec::Parameterized::TableSyntax

12 13
  let_it_be(:namespace) { create_default(:namespace).freeze }
  let_it_be(:project, refind: true) { create_default(:project, :repository).freeze }
14

15 16
  subject { create(:merge_request) }

17
  describe 'associations' do
18 19
    subject { build_stubbed(:merge_request) }

20 21
    it { is_expected.to belong_to(:target_project).class_name('Project') }
    it { is_expected.to belong_to(:source_project).class_name('Project') }
22
    it { is_expected.to belong_to(:merge_user).class_name("User") }
23
    it { is_expected.to have_many(:assignees).through(:merge_request_assignees) }
24
    it { is_expected.to have_many(:reviewers).through(:merge_request_reviewers) }
25
    it { is_expected.to have_many(:merge_request_diffs) }
26
    it { is_expected.to have_many(:user_mentions).class_name("MergeRequestUserMention") }
27
    it { is_expected.to belong_to(:milestone) }
28
    it { is_expected.to belong_to(:iteration) }
29 30
    it { is_expected.to have_many(:resource_milestone_events) }
    it { is_expected.to have_many(:resource_state_events) }
Patrick Bajao's avatar
Patrick Bajao committed
31 32
    it { is_expected.to have_many(:draft_notes) }
    it { is_expected.to have_many(:reviews).inverse_of(:merge_request) }
33
    it { is_expected.to have_one(:cleanup_schedule).inverse_of(:merge_request) }
34 35 36 37 38 39 40 41 42 43 44 45 46 47

    context 'for forks' do
      let!(:project) { create(:project) }
      let!(:fork) { fork_project(project) }
      let!(:merge_request) { create(:merge_request, target_project: project, source_project: fork) }

      it 'does not load another project due to inverse relationship' do
        expect(project.merge_requests.first.target_project.object_id).to eq(project.object_id)
      end

      it 'finds the associated merge request' do
        expect(project.merge_requests.find(merge_request.id)).to eq(merge_request)
      end
    end
48 49
  end

50 51 52 53 54 55 56 57 58 59 60 61 62 63 64
  describe '.from_and_to_forks' do
    it 'returns only MRs from and to forks (with no internal MRs)' do
      project = create(:project)
      fork = fork_project(project)
      fork_2 = fork_project(project)
      mr_from_fork = create(:merge_request, source_project: fork, target_project: project)
      mr_to_fork = create(:merge_request, source_project: project, target_project: fork)

      create(:merge_request, source_project: fork, target_project: fork_2)
      create(:merge_request, source_project: project, target_project: project)

      expect(described_class.from_and_to_forks(project)).to contain_exactly(mr_from_fork, mr_to_fork)
    end
  end

65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82
  describe '.order_merged_at_asc' do
    let_it_be(:older_mr) { create(:merge_request, :with_merged_metrics) }
    let_it_be(:newer_mr) { create(:merge_request, :with_merged_metrics) }

    it 'returns MRs ordered by merged_at ascending' do
      expect(described_class.order_merged_at_asc).to eq([older_mr, newer_mr])
    end
  end

  describe '.order_merged_at_desc' do
    let_it_be(:older_mr) { create(:merge_request, :with_merged_metrics) }
    let_it_be(:newer_mr) { create(:merge_request, :with_merged_metrics) }

    it 'returns MRs ordered by merged_at descending' do
      expect(described_class.order_merged_at_desc).to eq([newer_mr, older_mr])
    end
  end

83 84 85 86 87 88 89 90 91 92 93 94
  describe '.with_jira_issue_keys' do
    let_it_be(:mr_with_jira_title) { create(:merge_request, :unique_branches, title: 'Fix TEST-123') }
    let_it_be(:mr_with_jira_description) { create(:merge_request, :unique_branches, description: 'this closes TEST-321') }
    let_it_be(:mr_without_jira_reference) { create(:merge_request, :unique_branches) }

    subject { described_class.with_jira_issue_keys }

    it { is_expected.to contain_exactly(mr_with_jira_title, mr_with_jira_description) }

    it { is_expected.not_to include(mr_without_jira_reference) }
  end

95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127
  context 'scopes' do
    let_it_be(:user1) { create(:user) }
    let_it_be(:user2) { create(:user) }

    let_it_be(:merge_request1) { create(:merge_request, :unique_branches, reviewers: [user1])}
    let_it_be(:merge_request2) { create(:merge_request, :unique_branches, reviewers: [user2])}
    let_it_be(:merge_request3) { create(:merge_request, :unique_branches, reviewers: [])}

    describe '.review_requested' do
      it 'returns MRs that has any review requests' do
        expect(described_class.review_requested).to eq([merge_request1, merge_request2])
      end
    end

    describe '.no_review_requested' do
      it 'returns MRs that has no review requests' do
        expect(described_class.no_review_requested).to eq([merge_request3])
      end
    end

    describe '.review_requested_to' do
      it 'returns MRs that the user has been requested to review' do
        expect(described_class.review_requested_to(user1)).to eq([merge_request1])
      end
    end

    describe '.no_review_requested_to' do
      it 'returns MRs that the user has been requested to review' do
        expect(described_class.no_review_requested_to(user1)).to eq([merge_request2, merge_request3])
      end
    end
  end

128
  describe '#squash_in_progress?' do
129 130 131
    let(:repo_path) do
      Gitlab::GitalyClient::StorageSettings.allow_disk_access do
        subject.source_project.repository.path
132
      end
133
    end
134

135
    let(:squash_path) { File.join(repo_path, "gitlab-worktree", "squash-#{subject.id}") }
136

137 138 139
    before do
      system(*%W(#{Gitlab.config.git.bin_path} -C #{repo_path} worktree add --detach #{squash_path} master))
    end
140

141 142 143
    it 'returns true when there is a current squash directory' do
      expect(subject.squash_in_progress?).to be_truthy
    end
144

145 146
    it 'returns false when there is no squash directory' do
      FileUtils.rm_rf(squash_path)
147

148 149
      expect(subject.squash_in_progress?).to be_falsey
    end
150

151 152 153
    it 'returns false when the squash directory has expired' do
      time = 20.minutes.ago.to_time
      File.utime(time, time, squash_path)
154

155
      expect(subject.squash_in_progress?).to be_falsey
156 157
    end

158 159
    it 'returns false when the source project has been removed' do
      allow(subject).to receive(:source_project).and_return(nil)
160

161
      expect(subject.squash_in_progress?).to be_falsey
162 163 164 165 166
    end
  end

  describe '#squash?' do
    let(:merge_request) { build(:merge_request, squash: squash) }
167

168 169 170 171 172 173 174 175 176 177 178 179 180 181 182
    subject { merge_request.squash? }

    context 'disabled in database' do
      let(:squash) { false }

      it { is_expected.to be_falsy }
    end

    context 'enabled in database' do
      let(:squash) { true }

      it { is_expected.to be_truthy }
    end
  end

183 184
  describe '#default_squash_commit_message' do
    let(:project) { subject.project }
185 186 187
    let(:is_multiline) { -> (c) { c.description.present? } }
    let(:multiline_commits) { subject.commits.select(&is_multiline) }
    let(:singleline_commits) { subject.commits.reject(&is_multiline) }
188

189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206
    context 'when the total number of commits is safe' do
      it 'returns the oldest multiline commit message' do
        expect(subject.default_squash_commit_message).to eq(multiline_commits.last.message)
      end
    end

    context 'when the total number of commits is big' do
      let(:safe_number) { 20 }

      before do
        stub_const('MergeRequestDiff::COMMITS_SAFE_SIZE', safe_number)
      end

      it 'returns the oldest multiline commit message from safe number of commits' do
        expect(subject.default_squash_commit_message).to eq(
          "remove emtpy file.(beacase git ignore empty file)\nadd whitespace test file.\n"
        )
      end
207
    end
208

Sean McGivern's avatar
Sean McGivern committed
209
    it 'returns the merge request title if there are no multiline commits' do
210 211 212 213 214 215
      expect(subject).to receive(:commits).and_return(
        CommitCollection.new(project, singleline_commits)
      )

      expect(subject.default_squash_commit_message).to eq(subject.title)
    end
Sean McGivern's avatar
Sean McGivern committed
216

217 218
    it 'does not return commit messages from multiline merge commits' do
      collection = CommitCollection.new(project, multiline_commits).enrich!
219

220 221
      expect(collection.commits).to all( receive(:merge_commit?).and_return(true) )
      expect(subject).to receive(:commits).and_return(collection)
222 223 224 225
      expect(subject.default_squash_commit_message).to eq(subject.title)
    end
  end

226 227 228 229 230 231 232
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Issuable) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(Taskable) }
233 234
    it { is_expected.to include_module(MilestoneEventable) }
    it { is_expected.to include_module(StateEventable) }
235 236 237 238

    it_behaves_like 'AtomicInternalId' do
      let(:internal_id_attribute) { :iid }
      let(:instance) { build(:merge_request) }
239
      let(:scope) { :target_project }
240 241 242
      let(:scope_attrs) { { project: instance.target_project } }
      let(:usage) { :merge_requests }
    end
243 244 245
  end

  describe 'validation' do
246 247
    subject { build_stubbed(:merge_request) }

248 249
    it { is_expected.to validate_presence_of(:target_branch) }
    it { is_expected.to validate_presence_of(:source_branch) }
250

251
    context "Validation of merge user with Merge When Pipeline Succeeds" do
252 253 254 255 256
      it "allows user to be nil when the feature is disabled" do
        expect(subject).to be_valid
      end

      it "is invalid without merge user" do
257
        subject.merge_when_pipeline_succeeds = true
258 259 260 261
        expect(subject).not_to be_valid
      end

      it "is valid with merge user" do
262
        subject.merge_when_pipeline_succeeds = true
263 264 265 266 267
        subject.merge_user = build(:user)

        expect(subject).to be_valid
      end
    end
268

Mark Chao's avatar
Mark Chao committed
269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300
    context 'for branch' do
      before do
        stub_feature_flags(stricter_mr_branch_name: false)
      end

      where(:branch_name, :valid) do
        'foo' | true
        'foo:bar' | false
        '+foo:bar' | false
        'foo bar' | false
        '-foo' | false
        'HEAD' | true
        'refs/heads/master' | true
      end

      with_them do
        it "validates source_branch" do
          subject = build(:merge_request, source_branch: branch_name, target_branch: 'master')
          subject.valid?

          expect(subject.errors.added?(:source_branch)).to eq(!valid)
        end

        it "validates target_branch" do
          subject = build(:merge_request, source_branch: 'master', target_branch: branch_name)
          subject.valid?

          expect(subject.errors.added?(:target_branch)).to eq(!valid)
        end
      end
    end

301 302
    context 'for forks' do
      let(:project) { create(:project) }
303 304
      let(:fork1) { fork_project(project) }
      let(:fork2) { fork_project(project) }
305 306 307 308 309 310 311 312

      it 'allows merge requests for sibling-forks' do
        subject.source_project = fork1
        subject.target_project = fork2

        expect(subject).to be_valid
      end
    end
313 314
  end

315 316
  describe 'callbacks' do
    describe '#ensure_merge_request_metrics' do
317
      let(:merge_request) { create(:merge_request) }
318

319
      it 'creates metrics after saving' do
320 321 322 323 324 325 326 327 328
        expect(merge_request.metrics).to be_persisted
        expect(MergeRequest::Metrics.count).to eq(1)
      end

      it 'does not duplicate metrics for a merge request' do
        merge_request.mark_as_merged!

        expect(MergeRequest::Metrics.count).to eq(1)
      end
329 330 331 332 333 334 335 336 337 338 339 340 341

      it 'does not create duplicated metrics records when MR is concurrently updated' do
        merge_request.metrics.destroy

        instance1 = MergeRequest.find(merge_request.id)
        instance2 = MergeRequest.find(merge_request.id)

        instance1.ensure_metrics
        instance2.ensure_metrics

        metrics_records = MergeRequest::Metrics.where(merge_request_id: merge_request.id)
        expect(metrics_records.size).to eq(1)
      end
342 343 344 345 346 347 348 349 350

      it 'syncs the `target_project_id` to the metrics record' do
        project = create(:project)

        merge_request.update!(target_project: project, state: :closed)

        expect(merge_request.target_project_id).to eq(project.id)
        expect(merge_request.target_project_id).to eq(merge_request.metrics.target_project_id)
      end
351 352 353
    end
  end

354
  describe 'respond to' do
355 356
    subject { build(:merge_request) }

357
    it { is_expected.to respond_to(:unchecked?) }
358
    it { is_expected.to respond_to(:checking?) }
359 360
    it { is_expected.to respond_to(:can_be_merged?) }
    it { is_expected.to respond_to(:cannot_be_merged?) }
361
    it { is_expected.to respond_to(:merge_params) }
362
    it { is_expected.to respond_to(:merge_when_pipeline_succeeds) }
363
  end
Andrey Kumanyaev's avatar
Andrey Kumanyaev committed
364

365 366 367
  describe '.by_commit_sha' do
    subject(:by_commit_sha) { described_class.by_commit_sha(sha) }

368
    let!(:merge_request) { create(:merge_request) }
369 370 371 372 373 374 375 376 377 378 379 380 381 382

    context 'with sha contained in latest merge request diff' do
      let(:sha) { 'b83d6e391c22777fca1ed3012fce84f633d7fed0' }

      it 'returns merge requests' do
        expect(by_commit_sha).to eq([merge_request])
      end
    end

    context 'with sha contained not in latest merge request diff' do
      let(:sha) { 'b83d6e391c22777fca1ed3012fce84f633d7fed0' }

      it 'returns empty requests' do
        latest_merge_request_diff = merge_request.merge_request_diffs.create
383 384 385 386 387

        MergeRequestDiffCommit.where(
          merge_request_diff_id: latest_merge_request_diff,
          sha: 'b83d6e391c22777fca1ed3012fce84f633d7fed0'
        ).delete_all
388 389 390 391 392 393 394 395 396 397 398 399 400 401

        expect(by_commit_sha).to be_empty
      end
    end

    context 'with sha not contained in' do
      let(:sha) { 'b83d6e3' }

      it 'returns empty result' do
        expect(by_commit_sha).to be_empty
      end
    end
  end

402 403 404 405 406 407 408 409 410 411
  describe '.by_merge_commit_sha' do
    it 'returns merge requests that match the given merge commit' do
      mr = create(:merge_request, :merged, merge_commit_sha: '123abc')

      create(:merge_request, :merged, merge_commit_sha: '123def')

      expect(described_class.by_merge_commit_sha('123abc')).to eq([mr])
    end
  end

412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433
  describe '.by_squash_commit_sha' do
    subject { described_class.by_squash_commit_sha(sha) }

    let(:sha) { '123abc' }
    let(:merge_request) { create(:merge_request, :merged, squash_commit_sha: sha) }

    it 'returns merge requests that match the given squash commit' do
      is_expected.to eq([merge_request])
    end
  end

  describe '.by_related_commit_sha' do
    subject { described_class.by_related_commit_sha(sha) }

    context 'when commit is a squash commit' do
      let!(:merge_request) { create(:merge_request, :merged, squash_commit_sha: sha) }
      let(:sha) { '123abc' }

      it { is_expected.to eq([merge_request]) }
    end

    context 'when commit is a part of the merge request' do
434
      let!(:merge_request) { create(:merge_request) }
435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451
      let(:sha) { 'b83d6e391c22777fca1ed3012fce84f633d7fed0' }

      it { is_expected.to eq([merge_request]) }
    end

    context 'when commit is a merge commit' do
      let!(:merge_request) { create(:merge_request, :merged, merge_commit_sha: sha) }
      let(:sha) { '123abc' }

      it { is_expected.to eq([merge_request]) }
    end

    context 'when commit is not found' do
      let(:sha) { '0000' }

      it { is_expected.to be_empty }
    end
452 453

    context 'when commit is part of the merge request and a squash commit at the same time' do
454
      let!(:merge_request) { create(:merge_request) }
455 456 457 458 459 460 461 462
      let(:sha) { merge_request.commits.first.id }

      before do
        merge_request.update!(squash_commit_sha: sha)
      end

      it { is_expected.to eq([merge_request]) }
    end
463 464
  end

465 466 467 468
  describe '.by_cherry_pick_sha' do
    it 'returns merge requests that match the given merge commit' do
      note = create(:track_mr_picking_note, commit_id: '456abc')

469
      create(:track_mr_picking_note, project: create(:project), commit_id: '456def')
470 471 472 473 474

      expect(described_class.by_cherry_pick_sha('456abc')).to eq([note.noteable])
    end
  end

475 476 477 478 479 480
  describe '.in_projects' do
    it 'returns the merge requests for a set of projects' do
      expect(described_class.in_projects(Project.all)).to eq([subject])
    end
  end

481 482 483 484 485 486 487 488 489 490 491
  describe '.set_latest_merge_request_diff_ids!' do
    def create_merge_request_with_diffs(source_branch, diffs: 2)
      params = {
        target_project: project,
        target_branch: 'master',
        source_project: project,
        source_branch: source_branch
      }

      create(:merge_request, params).tap do |mr|
        diffs.times { mr.merge_request_diffs.create }
492
        mr.create_merge_head_diff
493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518
      end
    end

    let(:project) { create(:project) }

    it 'sets IDs for merge requests, whether they are already set or not' do
      merge_requests = [
        create_merge_request_with_diffs('feature'),
        create_merge_request_with_diffs('feature-conflict'),
        create_merge_request_with_diffs('wip', diffs: 0),
        create_merge_request_with_diffs('csv')
      ]

      merge_requests.take(2).each do |merge_request|
        merge_request.update_column(:latest_merge_request_diff_id, nil)
      end

      expected = merge_requests.map do |merge_request|
        merge_request.merge_request_diffs.maximum(:id)
      end

      expect { project.merge_requests.set_latest_merge_request_diff_ids! }
        .to change { merge_requests.map { |mr| mr.reload.latest_merge_request_diff_id } }.to(expected)
    end
  end

519 520 521 522 523 524 525 526 527 528 529 530 531 532 533
  describe '.recent_target_branches' do
    let(:project) { create(:project) }
    let!(:merge_request1) { create(:merge_request, :opened, source_project: project, target_branch: 'feature') }
    let!(:merge_request2) { create(:merge_request, :closed, source_project: project, target_branch: 'merge-test') }
    let!(:merge_request3) { create(:merge_request, :opened, source_project: project, target_branch: 'fix') }
    let!(:merge_request4) { create(:merge_request, :closed, source_project: project, target_branch: 'feature') }

    before do
      merge_request1.update_columns(updated_at: 1.day.since)
      merge_request2.update_columns(updated_at: 2.days.since)
      merge_request3.update_columns(updated_at: 3.days.since)
      merge_request4.update_columns(updated_at: 4.days.since)
    end

    it 'returns target branches sort by updated at desc' do
534
      expect(described_class.recent_target_branches).to match_array(%w[feature merge-test fix])
535 536 537
    end
  end

538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554
  describe '.sort_by_attribute' do
    context 'merged_at' do
      let_it_be(:older_mr) { create(:merge_request, :with_merged_metrics) }
      let_it_be(:newer_mr) { create(:merge_request, :with_merged_metrics) }

      it 'sorts asc' do
        merge_requests = described_class.sort_by_attribute(:merged_at_asc)
        expect(merge_requests).to eq([older_mr, newer_mr])
      end

      it 'sorts desc' do
        merge_requests = described_class.sort_by_attribute(:merged_at_desc)
        expect(merge_requests).to eq([newer_mr, older_mr])
      end
    end
  end

555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625
  describe 'time to merge calculations' do
    let_it_be(:user) { create(:user) }
    let_it_be(:project) { create(:project) }

    let!(:mr1) do
      create(
        :merge_request,
        :with_merged_metrics,
        source_project: project,
        target_project: project
      )
    end

    let!(:mr2) do
      create(
        :merge_request,
        :with_merged_metrics,
        source_project: project,
        target_project: project
      )
    end

    let!(:mr3) do
      create(
        :merge_request,
        :with_merged_metrics,
        source_project: project,
        target_project: project
      )
    end

    let!(:unmerged_mr) do
      create(
        :merge_request,
        source_project: project,
        target_project: project
      )
    end

    before do
      project.add_user(user, :developer)
    end

    describe '.total_time_to_merge' do
      it 'returns the sum of the time to merge for all merged MRs' do
        mrs = project.merge_requests

        expect(mrs.total_time_to_merge).to be_within(1).of(expected_total_time(mrs))
      end

      context 'when merged_at is earlier than created_at' do
        before do
          mr1.metrics.update!(merged_at: mr1.metrics.created_at - 1.week)
        end

        it 'returns nil' do
          mrs = project.merge_requests.where(id: mr1.id)

          expect(mrs.total_time_to_merge).to be_nil
        end
      end

      def expected_total_time(mrs)
        mrs = mrs.reject { |mr| mr.merged_at.nil? }
        mrs.reduce(0.0) do |sum, mr|
          (mr.merged_at - mr.created_at) + sum
        end
      end
    end
  end

626
  describe '#target_branch_sha' do
627
    let(:project) { create(:project, :repository) }
628

629
    subject { create(:merge_request, source_project: project, target_project: project) }
630

631
    context 'when the target branch does not exist' do
632
      before do
633
        project.repository.rm_branch(subject.author, subject.target_branch)
634
        subject.clear_memoized_shas
635
      end
636 637

      it 'returns nil' do
638
        expect(subject.target_branch_sha).to be_nil
639 640
      end
    end
641 642 643 644 645 646

    it 'returns memoized value' do
      subject.target_branch_sha = '8ffb3c15a5475e59ae909384297fede4badcb4c7'

      expect(subject.target_branch_sha).to eq '8ffb3c15a5475e59ae909384297fede4badcb4c7'
    end
647 648
  end

649 650 651
  describe '#card_attributes' do
    it 'includes the author name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
652
      allow(subject).to receive(:assignees).and_return([])
653

654
      expect(subject.card_attributes)
655
        .to eq({ 'Author' => 'Robert', 'Assignee' => "" })
656 657
    end

658
    it 'includes the assignees name' do
659
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
660
      allow(subject).to receive(:assignees).and_return([double(name: 'Douwe'), double(name: 'Robert')])
661

662
      expect(subject.card_attributes)
663
        .to eq({ 'Author' => 'Robert', 'Assignee' => 'Douwe and Robert' })
664 665 666
    end
  end

667 668 669 670
  describe '#assignee_or_author?' do
    let(:user) { create(:user) }

    it 'returns true for a user that is assigned to a merge request' do
671
      subject.assignees = [user]
672 673 674 675 676 677 678 679 680 681 682 683 684 685 686

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns true for a user that is the author of a merge request' do
      subject.author = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns false for a user that is not the assignee or author' do
      expect(subject.assignee_or_author?(user)).to eq(false)
    end
  end

687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717
  describe '#visible_closing_issues_for' do
    let(:guest) { create(:user) }
    let(:developer) { create(:user) }
    let(:issue_1) { create(:issue, project: subject.source_project) }
    let(:issue_2) { create(:issue, project: subject.source_project) }
    let(:confidential_issue) { create(:issue, :confidential, project: subject.source_project) }

    before do
      subject.project.add_developer(subject.author)
      subject.target_branch = subject.project.default_branch
      commit = double('commit1', safe_message: "Fixes #{issue_1.to_reference} #{issue_2.to_reference} #{confidential_issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])
    end

    it 'shows only allowed issues to guest' do
      subject.project.add_guest(guest)

      subject.cache_merge_request_closes_issues!

      expect(subject.visible_closing_issues_for(guest)).to match_array([issue_1, issue_2])
    end

    it 'shows only allowed issues to developer' do
      subject.project.add_developer(developer)

      subject.cache_merge_request_closes_issues!

      expect(subject.visible_closing_issues_for(developer)).to match_array([issue_1, confidential_issue, issue_2])
    end

    context 'when external issue tracker is enabled' do
718 719 720 721
      let(:project) { create(:project, :repository) }

      subject { create(:merge_request, source_project: project) }

722 723 724 725 726 727 728 729 730 731 732 733 734 735
      before do
        subject.project.has_external_issue_tracker = true
        subject.project.save!
      end

      it 'calls non #closes_issues to retrieve data' do
        expect(subject).to receive(:closes_issues)
        expect(subject).not_to receive(:cached_closes_issues)

        subject.visible_closing_issues_for
      end
    end
  end

736 737
  describe '#cache_merge_request_closes_issues!' do
    before do
738
      subject.project.add_developer(subject.author)
739 740 741 742 743 744 745 746
      subject.target_branch = subject.project.default_branch
    end

    it 'caches closed issues' do
      issue  = create :issue, project: subject.project
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])

747
      expect { subject.cache_merge_request_closes_issues!(subject.author) }.to change(subject.merge_requests_closing_issues, :count).by(1)
748 749
    end

750 751 752 753 754
    it 'does not cache closed issues when merge request is closed' do
      issue  = create :issue, project: subject.project
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")

      allow(subject).to receive(:commits).and_return([commit])
755
      allow(subject).to receive(:state_id).and_return(described_class.available_states[:closed])
756 757 758 759 760 761 762 763

      expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
    end

    it 'does not cache closed issues when merge request is merged' do
      issue  = create :issue, project: subject.project
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])
764
      allow(subject).to receive(:state_id).and_return(described_class.available_states[:merged])
765 766 767 768

      expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
    end

769 770
    context 'when both internal and external issue trackers are enabled' do
      before do
771
        create(:jira_service, project: subject.project)
772
        subject.project.reload
773 774 775 776 777 778
      end

      it 'does not cache issues from external trackers' do
        issue  = ExternalIssue.new('JIRA-123', subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])
779

780
        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to raise_error
781 782 783 784 785 786 787 788 789 790 791 792 793 794
        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
      end

      it 'caches an internal issue' do
        issue  = create(:issue, project: subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }
          .to change(subject.merge_requests_closing_issues, :count).by(1)
      end
    end

    context 'when only external issue tracker enabled' do
795 796 797 798
      let(:project) { create(:project, :repository) }

      subject { create(:merge_request, source_project: project) }

799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820
      before do
        subject.project.has_external_issue_tracker = true
        subject.project.issues_enabled = false
        subject.project.save!
      end

      it 'does not cache issues from external trackers' do
        issue  = ExternalIssue.new('JIRA-123', subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
      end

      it 'does not cache an internal issue' do
        issue  = create(:issue, project: subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }
          .not_to change(subject.merge_requests_closing_issues, :count)
      end
821 822 823
    end
  end

824
  describe '#source_branch_sha' do
825
    let(:last_branch_commit) { subject.source_project.repository.commit(Gitlab::Git::BRANCH_REF_PREFIX + subject.source_branch) }
826 827

    context 'with diffs' do
828
      subject { create(:merge_request) }
829

830
      it 'returns the sha of the source branch last commit' do
831
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
832 833 834
      end
    end

835 836
    context 'without diffs' do
      subject { create(:merge_request, :without_diffs) }
837

838
      it 'returns the sha of the source branch last commit' do
839
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
840
      end
841 842 843 844 845 846 847 848 849 850 851 852 853 854 855

      context 'when there is a tag name matching the branch name' do
        let(:tag_name) { subject.source_branch }

        it 'returns the sha of the source branch last commit' do
          subject.source_project.repository.add_tag(subject.author,
                                                    tag_name,
                                                    subject.target_branch_sha,
                                                    'Add a tag')

          expect(subject.source_branch_sha).to eq(last_branch_commit.sha)

          subject.source_project.repository.rm_tag(subject.author, tag_name)
        end
      end
856 857
    end

858 859
    context 'when the merge request is being created' do
      subject { build(:merge_request, source_branch: nil, compare_commits: []) }
860

861
      it 'returns nil' do
862
        expect(subject.source_branch_sha).to be_nil
863 864
      end
    end
865 866 867 868 869 870

    it 'returns memoized value' do
      subject.source_branch_sha = '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'

      expect(subject.source_branch_sha).to eq '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
    end
871 872
  end

873
  describe '#to_reference' do
874
    let(:project) { build(:project, name: 'sample-project') }
875 876
    let(:merge_request) { build(:merge_request, target_project: project, iid: 1) }

877
    it 'returns a String reference to the object' do
878
      expect(merge_request.to_reference).to eq "!1"
879 880 881
    end

    it 'supports a cross-project reference' do
882
      another_project = build(:project, name: 'another-project', namespace: project.namespace)
883
      expect(merge_request.to_reference(another_project)).to eq "sample-project!1"
884
    end
885 886

    it 'returns a String reference with the full path' do
887
      expect(merge_request.to_reference(full: true)).to eq(project.full_path + '!1')
888
    end
889
  end
890

891
  describe '#raw_diffs' do
892 893 894
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
895
      let(:merge_request) { create(:merge_request) }
896

897
      it 'delegates to the MR diffs' do
898
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(options)
899

900 901 902 903 904
        merge_request.raw_diffs(options)
      end
    end

    context 'when there are no MR diffs' do
905 906
      let(:merge_request) { build(:merge_request) }

907 908 909 910 911 912 913 914 915 916
      it 'delegates to the compare object' do
        merge_request.compare = double(:compare)

        expect(merge_request.compare).to receive(:raw_diffs).with(options)

        merge_request.raw_diffs(options)
      end
    end
  end

917 918 919 920 921 922
  describe '#diffs' do
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
923
        merge_request.save
924

925
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(hash_including(options)).and_call_original
926

927
        merge_request.diffs(options).diff_files
928 929 930 931
      end
    end

    context 'when there are no MR diffs' do
932
      it 'delegates to the compare object, setting expanded: true' do
933 934
        merge_request.compare = double(:compare)

935
        expect(merge_request.compare).to receive(:diffs).with(options.merge(expanded: true))
936 937 938 939 940 941

        merge_request.diffs(options)
      end
    end
  end

942
  describe '#note_positions_for_paths' do
Patrick Bajao's avatar
Patrick Bajao committed
943
    let(:user) { create(:user) }
944
    let(:merge_request) { create(:merge_request) }
945 946 947 948
    let(:project) { merge_request.project }
    let!(:diff_note) do
      create(:diff_note_on_merge_request, project: project, noteable: merge_request)
    end
949

Patrick Bajao's avatar
Patrick Bajao committed
950 951 952
    let!(:draft_note) do
      create(:draft_note_on_text_diff, author: user, merge_request: merge_request)
    end
953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984

    let(:file_paths) { merge_request.diffs.diff_files.map(&:file_path) }

    subject do
      merge_request.note_positions_for_paths(file_paths)
    end

    it 'returns a Gitlab::Diff::PositionCollection' do
      expect(subject).to be_a(Gitlab::Diff::PositionCollection)
    end

    context 'within all diff files' do
      it 'returns correct positions' do
        expect(subject).to match_array([diff_note.position])
      end
    end

    context 'within specific diff file' do
      let(:file_paths) { [diff_note.position.file_path] }

      it 'returns correct positions' do
        expect(subject).to match_array([diff_note.position])
      end
    end

    context 'within no diff files' do
      let(:file_paths) { [] }

      it 'returns no positions' do
        expect(subject.to_a).to be_empty
      end
    end
Patrick Bajao's avatar
Patrick Bajao committed
985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004

    context 'when user is given' do
      subject do
        merge_request.note_positions_for_paths(file_paths, user)
      end

      it 'returns notes and draft notes positions' do
        expect(subject).to match_array([draft_note.position, diff_note.position])
      end
    end

    context 'when user is not given' do
      subject do
        merge_request.note_positions_for_paths(file_paths)
      end

      it 'returns notes positions' do
        expect(subject).to match_array([diff_note.position])
      end
    end
1005 1006
  end

1007
  describe '#discussions_diffs' do
1008 1009
    let(:merge_request) { create(:merge_request) }

1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035
    shared_examples 'discussions diffs collection' do
      it 'initializes Gitlab::DiscussionsDiff::FileCollection with correct data' do
        note_diff_file = diff_note.note_diff_file

        expect(Gitlab::DiscussionsDiff::FileCollection)
          .to receive(:new)
          .with([note_diff_file])
          .and_call_original

        result = merge_request.discussions_diffs

        expect(result).to be_a(Gitlab::DiscussionsDiff::FileCollection)
      end

      it 'eager loads relations' do
        result = merge_request.discussions_diffs

        recorder = ActiveRecord::QueryRecorder.new do
          result.first.diff_note
          result.first.diff_note.project
        end

        expect(recorder.count).to be_zero
      end
    end

1036
    context 'with commit diff note' do
1037
      let(:other_merge_request) { create(:merge_request, source_project: create(:project, :repository)) }
1038 1039 1040 1041 1042 1043 1044 1045 1046

      let!(:diff_note) do
        create(:diff_note_on_commit, project: merge_request.project)
      end

      let!(:other_mr_diff_note) do
        create(:diff_note_on_commit, project: other_merge_request.project)
      end

1047
      it_behaves_like 'discussions diffs collection'
1048 1049 1050
    end

    context 'with merge request diff note' do
1051
      let!(:diff_note) do
1052 1053 1054
        create(:diff_note_on_merge_request, project: merge_request.project, noteable: merge_request)
      end

1055
      it_behaves_like 'discussions diffs collection'
1056 1057 1058
    end
  end

1059
  describe '#diff_size' do
Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
1060 1061
    let_it_be(:project) { create(:project, :repository) }

1062
    let(:merge_request) do
Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
1063
      build(:merge_request, source_project: project, source_branch: 'expand-collapse-files', target_branch: 'master')
1064 1065 1066
    end

    context 'when there are MR diffs' do
1067
      it 'returns the correct count' do
1068
        merge_request.save
1069 1070

        expect(merge_request.diff_size).to eq('105')
1071 1072
      end

1073 1074 1075 1076 1077
      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        merge_request.save

        expect(merge_request.diff_size).to eq('2+')
1078 1079 1080
      end

      it 'does not perform highlighting' do
1081 1082
        merge_request.save

1083 1084 1085 1086 1087 1088 1089
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end

    context 'when there are no MR diffs' do
1090
      def set_compare(merge_request)
1091 1092 1093 1094 1095 1096 1097 1098 1099 1100
        merge_request.compare = CompareService.new(
          merge_request.source_project,
          merge_request.source_branch
        ).execute(
          merge_request.target_project,
          merge_request.target_branch
        )
      end

      it 'returns the correct count' do
1101 1102 1103 1104 1105 1106 1107 1108 1109 1110
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('105')
      end

      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('2+')
1111 1112 1113
      end

      it 'does not perform highlighting' do
1114 1115
        set_compare(merge_request)

1116 1117 1118 1119 1120 1121 1122
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end
  end

1123 1124
  describe '#modified_paths' do
    let(:paths) { double(:paths) }
1125

1126 1127 1128
    subject(:merge_request) { build(:merge_request) }

    before do
1129
      allow(diff).to receive(:modified_paths).and_return(paths)
1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144
    end

    context 'when past_merge_request_diff is specified' do
      let(:another_diff) { double(:merge_request_diff) }
      let(:diff) { another_diff }

      it 'returns affected file paths from specified past_merge_request_diff' do
        expect(merge_request.modified_paths(past_merge_request_diff: another_diff)).to eq(paths)
      end
    end

    context 'when compare is present' do
      let(:compare) { double(:compare) }
      let(:diff) { compare }

1145
      before do
1146 1147
        merge_request.compare = compare

1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167
        expect(merge_request).to receive(:diff_stats).and_return(diff_stats)
      end

      context 'and diff_stats are not present' do
        let(:diff_stats) { nil }

        it 'returns affected file paths from compare' do
          expect(merge_request.modified_paths).to eq(paths)
        end
      end

      context 'and diff_stats are present' do
        let(:diff_stats) { double(:diff_stats) }

        it 'returns affected file paths from compare' do
          diff_stats_path = double(:diff_stats_paths)
          expect(diff_stats).to receive(:paths).and_return(diff_stats_path)

          expect(merge_request.modified_paths).to eq(diff_stats_path)
        end
1168 1169 1170 1171 1172
      end
    end

    context 'when no arguments provided' do
      let(:diff) { merge_request.merge_request_diff }
1173

1174 1175 1176 1177 1178 1179 1180 1181
      subject(:merge_request) { create(:merge_request, source_branch: 'feature', target_branch: 'master') }

      it 'returns affected file paths for merge_request_diff' do
        expect(merge_request.modified_paths).to eq(paths)
      end
    end
  end

1182 1183 1184 1185 1186 1187 1188 1189 1190 1191
  describe '#new_paths' do
    let(:merge_request) do
      create(:merge_request, source_branch: 'expand-collapse-files', target_branch: 'master')
    end

    it 'returns new path of changed files' do
      expect(merge_request.new_paths.count).to eq(105)
    end
  end

1192
  describe "#related_notes" do
1193
    let!(:merge_request) { create(:merge_request) }
1194 1195

    before do
1196
      allow(merge_request).to receive(:commits) { [merge_request.source_project.repository.commit] }
1197 1198
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.project)
1199
      create(:note, noteable: merge_request, project: merge_request.project)
1200 1201
    end

1202
    it "includes notes for commits" do
1203
      expect(merge_request.commits).not_to be_empty
1204
      expect(merge_request.related_notes.count).to eq(2)
1205
    end
1206

1207
    it "includes notes for commits from target project as well" do
1208 1209 1210
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.target_project)

1211
      expect(merge_request.commits).not_to be_empty
1212
      expect(merge_request.related_notes.count).to eq(3)
1213
    end
1214 1215 1216 1217 1218 1219 1220 1221

    it "excludes system notes for commits" do
      system_note = create(:note_on_commit, :system, commit_id: merge_request.commits.first.id,
                                                     project: merge_request.project)

      expect(merge_request.related_notes.count).to eq(2)
      expect(merge_request.related_notes).not_to include(system_note)
    end
1222
  end
1223

1224 1225
  describe '#for_fork?' do
    it 'returns true if the merge request is for a fork' do
1226 1227
      subject.source_project = build_stubbed(:project, namespace: create(:group))
      subject.target_project = build_stubbed(:project, namespace: create(:group))
1228

1229
      expect(subject.for_fork?).to be_truthy
1230
    end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
1231

1232
    it 'returns false if is not for a fork' do
1233
      expect(subject.for_fork?).to be_falsey
1234 1235 1236
    end
  end

1237
  describe '#closes_issues' do
1238 1239
    let(:project) { create(:project) }

1240 1241
    let(:issue0) { create :issue, project: subject.project }
    let(:issue1) { create :issue, project: subject.project }
1242 1243 1244 1245

    let(:commit0) { double('commit0', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit1) { double('commit1', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit2) { double('commit2', safe_message: "Fixes #{issue1.to_reference}") }
1246

1247 1248
    subject { create(:merge_request, source_project: project) }

1249
    before do
1250
      subject.project.add_developer(subject.author)
1251
      allow(subject).to receive(:commits).and_return([commit0, commit1, commit2])
1252 1253
    end

1254
    it 'accesses the set of issues that will be closed on acceptance' do
1255 1256
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
1257

1258
      closed = subject.closes_issues
1259

1260 1261
      expect(closed).to include(issue0, issue1)
    end
1262

1263 1264 1265
    it 'only lists issues as to be closed if it targets the default branch' do
      allow(subject.project).to receive(:default_branch).and_return('master')
      subject.target_branch = 'something-else'
1266

1267
      expect(subject.closes_issues).to be_empty
1268
    end
1269 1270 1271 1272 1273 1274 1275 1276 1277

    it 'ignores referenced issues when auto-close is disabled' do
      subject.project.update!(autoclose_referenced_issues: false)

      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)

      expect(subject.closes_issues).to be_empty
    end
1278
  end
1279

1280
  describe '#issues_mentioned_but_not_closing' do
1281 1282 1283
    let(:closing_issue) { create :issue, project: subject.project }
    let(:mentioned_issue) { create :issue, project: subject.project }
    let(:commit) { double('commit', safe_message: "Fixes #{closing_issue.to_reference}") }
1284

1285
    it 'detects issues mentioned in description but not closed' do
1286
      subject.project.add_developer(subject.author)
1287
      subject.description = "Is related to #{mentioned_issue.to_reference} and #{closing_issue.to_reference}"
1288

1289
      allow(subject).to receive(:commits).and_return([commit])
1290 1291
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
1292
      subject.cache_merge_request_closes_issues!
1293

1294
      expect(subject.issues_mentioned_but_not_closing(subject.author)).to match_array([mentioned_issue])
1295
    end
1296 1297 1298

    context 'when the project has an external issue tracker' do
      before do
1299
        subject.project.add_developer(subject.author)
1300 1301 1302
        commit = double(:commit, safe_message: 'Fixes TEST-3')

        create(:jira_service, project: subject.project)
1303
        subject.project.reload
1304 1305 1306 1307 1308 1309 1310

        allow(subject).to receive(:commits).and_return([commit])
        allow(subject).to receive(:description).and_return('Is related to TEST-2 and TEST-3')
        allow(subject.project).to receive(:default_branch).and_return(subject.target_branch)
      end

      it 'detects issues mentioned in description but not closed' do
1311 1312
        subject.cache_merge_request_closes_issues!

1313 1314 1315
        expect(subject.issues_mentioned_but_not_closing(subject.author).map(&:to_s)).to match_array(['TEST-2'])
      end
    end
1316 1317
  end

1318
  describe "#work_in_progress?" do
1319 1320 1321
    subject { build_stubbed(:merge_request) }

    [
1322 1323
      'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP: [WIP] WIP:',
      'draft:', 'Draft: ', '[Draft]', '[DRAFT] ', 'Draft - '
1324
    ].each do |wip_prefix|
1325 1326
      it "detects the '#{wip_prefix}' prefix" do
        subject.title = "#{wip_prefix}#{subject.title}"
1327

1328
        expect(subject.work_in_progress?).to eq true
1329
      end
1330 1331
    end

1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343
    it "detects merge request title just saying 'wip'" do
      subject.title = "wip"

      expect(subject.work_in_progress?).to eq true
    end

    it "detects merge request title just saying 'draft'" do
      subject.title = "draft"

      expect(subject.work_in_progress?).to eq true
    end

1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355
    it 'does not detect WIP in the middle of the title' do
      subject.title = 'Something with WIP in the middle'

      expect(subject.work_in_progress?).to eq false
    end

    it 'does not detect Draft in the middle of the title' do
      subject.title = 'Something with Draft in the middle'

      expect(subject.work_in_progress?).to eq false
    end

1356 1357
    it "doesn't detect WIP for words starting with WIP" do
      subject.title = "Wipwap #{subject.title}"
1358
      expect(subject.work_in_progress?).to eq false
1359 1360
    end

1361 1362
    it "doesn't detect WIP for words containing with WIP" do
      subject.title = "WupWipwap #{subject.title}"
1363
      expect(subject.work_in_progress?).to eq false
1364 1365
    end

1366
    it "doesn't detect WIP by default" do
1367
      expect(subject.work_in_progress?).to eq false
1368
    end
1369 1370 1371 1372

    it "is aliased to #draft?" do
      expect(subject.method(:work_in_progress?)).to eq(subject.method(:draft?))
    end
1373 1374
  end

1375
  describe "#wipless_title" do
1376 1377 1378
    subject { build_stubbed(:merge_request) }

    [
1379 1380
      'WIP:', 'WIP: ', '[WIP]', '[WIP] ', '[WIP] WIP: [WIP] WIP:',
      'draft:', 'Draft: ', '[Draft]', '[DRAFT] ', 'Draft - '
1381
    ].each do |wip_prefix|
1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398
      it "removes the '#{wip_prefix}' prefix" do
        wipless_title = subject.title
        subject.title = "#{wip_prefix}#{subject.title}"

        expect(subject.wipless_title).to eq wipless_title
      end

      it "is satisfies the #work_in_progress? method" do
        subject.title = "#{wip_prefix}#{subject.title}"
        subject.title = subject.wipless_title

        expect(subject.work_in_progress?).to eq false
      end
    end
  end

  describe "#wip_title" do
1399 1400
    it "adds the Draft: prefix to the title" do
      wip_title = "Draft: #{subject.title}"
1401 1402

      expect(subject.wip_title).to eq wip_title
1403
    end
1404

1405 1406
    it "does not add the Draft: prefix multiple times" do
      wip_title = "Draft: #{subject.title}"
1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419
      subject.title = subject.wip_title
      subject.title = subject.wip_title

      expect(subject.wip_title).to eq wip_title
    end

    it "is satisfies the #work_in_progress? method" do
      subject.title = subject.wip_title

      expect(subject.work_in_progress?).to eq true
    end
  end

Zeger-Jan van de Weg's avatar
Zeger-Jan van de Weg committed
1420
  describe '#can_remove_source_branch?' do
1421 1422
    let_it_be(:user) { create(:user) }
    let_it_be(:merge_request, reload: true) { create(:merge_request, :simple) }
1423

1424
    subject { merge_request }
1425

1426
    before do
1427
      subject.source_project.add_maintainer(user)
1428
    end
1429

1430
    it "can't be removed when its a protected branch" do
1431
      allow(ProtectedBranch).to receive(:protected?).and_return(true)
1432

1433 1434 1435
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

1436 1437 1438 1439 1440 1441
    it "can't be removed because source project has been deleted" do
      subject.source_project = nil

      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

1442
    it "can't remove a root ref" do
1443
      subject.update(source_branch: 'master', target_branch: 'feature')
1444 1445 1446 1447

      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

1448
    it "is unable to remove the source branch for a project the user cannot push to" do
1449 1450
      user2 = create(:user)

1451 1452 1453
      expect(subject.can_remove_source_branch?(user2)).to be_falsey
    end

1454
    it "can be removed if the last commit is the head of the source branch" do
1455
      allow(subject).to receive(:source_branch_head).and_return(subject.diff_head_commit)
1456

1457
      expect(subject.can_remove_source_branch?(user)).to be_truthy
1458
    end
1459 1460

    it "cannot be removed if the last commit is not also the head of the source branch" do
1461
      subject.clear_memoized_shas
1462 1463
      subject.source_branch = "lfs"

1464 1465
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end
1466 1467
  end

1468
  describe "#source_branch_exists?" do
1469 1470
    let(:project) { create(:project, :repository) }
    let(:merge_request) { create(:merge_request, source_project: project) }
1471 1472
    let(:repository) { merge_request.source_project.repository }

1473
    context 'when the source project is set' do
1474 1475
      it 'returns true when the branch exists' do
        expect(merge_request.source_branch_exists?).to eq(true)
1476 1477 1478
      end
    end

1479
    context 'when the source project is not set' do
1480
      before do
1481
        merge_request.source_project = nil
1482 1483
      end

1484 1485
      it 'returns false' do
        expect(merge_request.source_branch_exists?).to eq(false)
1486 1487 1488 1489
      end
    end
  end

1490
  describe '#default_merge_commit_message' do
1491 1492 1493
    it 'includes merge information as the title' do
      request = build(:merge_request, source_branch: 'source', target_branch: 'target')

1494
      expect(request.default_merge_commit_message)
1495 1496 1497 1498 1499 1500
        .to match("Merge branch 'source' into 'target'\n\n")
    end

    it 'includes its title in the body' do
      request = build(:merge_request, title: 'Remove all technical debt')

1501
      expect(request.default_merge_commit_message)
1502 1503 1504
        .to match("Remove all technical debt\n\n")
    end

1505
    it 'includes its closed issues in the body' do
1506
      issue = create(:issue, project: subject.project)
1507

1508
      subject.project.add_developer(subject.author)
1509
      subject.description = "This issue Closes #{issue.to_reference}"
1510 1511
      allow(subject.project).to receive(:default_branch).and_return(subject.target_branch)
      subject.cache_merge_request_closes_issues!
1512

1513
      expect(subject.default_merge_commit_message)
1514
        .to match("Closes #{issue.to_reference}")
1515 1516 1517 1518 1519
    end

    it 'includes its reference in the body' do
      request = build_stubbed(:merge_request)

1520
      expect(request.default_merge_commit_message)
1521
        .to match("See merge request #{request.to_reference(full: true)}")
1522 1523 1524 1525 1526
    end

    it 'excludes multiple linebreak runs when description is blank' do
      request = build(:merge_request, title: 'Title', description: nil)

1527
      expect(request.default_merge_commit_message).not_to match("Title\n\n\n\n")
1528
    end
1529 1530 1531 1532

    it 'includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

1533
      expect(request.default_merge_commit_message(include_description: true))
1534 1535 1536 1537 1538 1539
        .to match("By removing all code\n\n")
    end

    it 'does not includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

1540
      expect(request.default_merge_commit_message)
1541 1542
        .not_to match("By removing all code\n\n")
    end
1543 1544
  end

1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558
  describe "#auto_merge_strategy" do
    subject { merge_request.auto_merge_strategy }

    let(:merge_request) { create(:merge_request, :merge_when_pipeline_succeeds) }

    it { is_expected.to eq('merge_when_pipeline_succeeds') }

    context 'when auto merge is disabled' do
      let(:merge_request) { create(:merge_request) }

      it { is_expected.to be_nil }
    end
  end

1559 1560 1561
  describe '#committers' do
    it 'returns all the committers of every commit in the merge request' do
      users = subject.commits.without_merge_commits.map(&:committer_email).uniq.map do |email|
1562 1563 1564
        create(:user, email: email)
      end

1565
      expect(subject.committers).to match_array(users)
1566 1567
    end

1568 1569
    it 'returns an empty array if no committer is associated with a user' do
      expect(subject.committers).to be_empty
1570 1571 1572
    end
  end

1573
  describe '#hook_attrs' do
1574 1575 1576 1577 1578 1579 1580 1581
    it 'delegates to Gitlab::HookData::MergeRequestBuilder#build' do
      builder = double

      expect(Gitlab::HookData::MergeRequestBuilder)
        .to receive(:new).with(subject).and_return(builder)
      expect(builder).to receive(:build)

      subject.hook_attrs
1582
    end
1583 1584 1585
  end

  describe '#diverged_commits_count' do
1586
    let(:project) { create(:project, :repository) }
1587
    let(:forked_project) { fork_project(project, nil, repository: true) }
1588

1589
    context 'when the target branch does not exist anymore' do
1590 1591 1592 1593
      subject { create(:merge_request, source_project: project, target_project: project) }

      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
1594
        subject.clear_memoized_shas
1595
      end
1596 1597

      it 'does not crash' do
1598
        expect { subject.diverged_commits_count }.not_to raise_error
1599 1600 1601 1602 1603 1604 1605
      end

      it 'returns 0' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

1606 1607 1608 1609
    context 'diverged on same repository' do
      subject(:merge_request_with_divergence) { create(:merge_request, :diverged, source_project: project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
1610
        expect(subject.diverged_commits_count).to eq(29)
1611 1612 1613 1614
      end
    end

    context 'diverged on fork' do
1615
      subject(:merge_request_fork_with_divergence) { create(:merge_request, :diverged, source_project: forked_project, target_project: project) }
1616

1617
      it 'counts commits that are on target branch but not on source branch', :sidekiq_might_not_need_inline do
1618
        expect(subject.diverged_commits_count).to eq(29)
1619 1620 1621 1622
      end
    end

    context 'rebased on fork' do
1623
      subject(:merge_request_rebased) { create(:merge_request, :rebased, source_project: forked_project, target_project: project) }
1624 1625 1626 1627 1628 1629 1630

      it 'counts commits that are on target branch but not on source branch' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

    describe 'caching' do
1631
      before do
1632 1633 1634 1635
        allow(Rails).to receive(:cache).and_return(ActiveSupport::Cache::MemoryStore.new)
      end

      it 'caches the output' do
1636 1637 1638
        expect(subject).to receive(:compute_diverged_commits_count)
          .once
          .and_return(2)
1639 1640 1641 1642 1643 1644

        subject.diverged_commits_count
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the source sha changes' do
1645 1646 1647
        expect(subject).to receive(:compute_diverged_commits_count)
          .twice
          .and_return(2)
1648 1649

        subject.diverged_commits_count
1650
        allow(subject).to receive(:source_branch_sha).and_return('123abc')
1651 1652 1653 1654
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the target sha changes' do
1655 1656 1657
        expect(subject).to receive(:compute_diverged_commits_count)
          .twice
          .and_return(2)
1658 1659

        subject.diverged_commits_count
1660
        allow(subject).to receive(:target_branch_sha).and_return('123abc')
1661 1662 1663
        subject.diverged_commits_count
      end
    end
1664 1665
  end

1666
  it_behaves_like 'an editable mentionable' do
1667
    subject { create(:merge_request, :simple, source_project: create(:project, :repository)) }
1668

1669
    let(:backref_text) { "merge request #{subject.to_reference}" }
1670
    let(:set_mentionable_text) { ->(txt) { subject.description = txt } }
1671
  end
Vinnie Okada's avatar
Vinnie Okada committed
1672 1673

  it_behaves_like 'a Taskable' do
1674
    subject { create :merge_request, :simple }
Vinnie Okada's avatar
Vinnie Okada committed
1675
  end
1676

1677
  describe '#commit_shas' do
1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691
    context 'persisted merge request' do
      context 'with a limit' do
        it 'returns a limited number of commit shas' do
          expect(subject.commit_shas(limit: 2)).to eq(%w[
            b83d6e391c22777fca1ed3012fce84f633d7fed0 498214de67004b1da3d820901307bed2a68a8ef6
          ])
        end
      end

      context 'without a limit' do
        it 'returns all commit shas of the merge request diff' do
          expect(subject.commit_shas.size).to eq(29)
        end
      end
1692 1693
    end

1694
    context 'new merge request' do
Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
1695 1696 1697
      let_it_be(:project) { create(:project, :repository) }

      subject { build(:merge_request, source_project: project) }
1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722

      context 'compare commits' do
        before do
          subject.compare_commits = [
            double(sha: 'sha1'), double(sha: 'sha2')
          ]
        end

        context 'without a limit' do
          it 'returns all shas of compare commits' do
            expect(subject.commit_shas).to eq(%w[sha2 sha1])
          end
        end

        context 'with a limit' do
          it 'returns a limited number of shas' do
            expect(subject.commit_shas(limit: 1)).to eq(['sha2'])
          end
        end
      end

      it 'returns diff_head_sha as an array' do
        expect(subject.commit_shas).to eq([subject.diff_head_sha])
        expect(subject.commit_shas(limit: 2)).to eq([subject.diff_head_sha])
      end
1723 1724 1725
    end
  end

1726
  context 'head pipeline' do
1727 1728
    let(:diff_head_sha) { Digest::SHA1.hexdigest(SecureRandom.hex) }

1729
    before do
1730
      allow(subject).to receive(:diff_head_sha).and_return(diff_head_sha)
1731
    end
1732

1733 1734 1735
    describe '#head_pipeline' do
      it 'returns nil for MR without head_pipeline_id' do
        subject.update_attribute(:head_pipeline_id, nil)
1736

1737 1738
        expect(subject.head_pipeline).to be_nil
      end
1739 1740 1741 1742 1743 1744 1745 1746

      context 'when the source project does not exist' do
        it 'returns nil' do
          allow(subject).to receive(:source_project).and_return(nil)

          expect(subject.head_pipeline).to be_nil
        end
      end
1747 1748
    end

1749
    describe '#actual_head_pipeline' do
1750 1751 1752
      it 'returns nil for MR with old pipeline' do
        pipeline = create(:ci_empty_pipeline, sha: 'notlatestsha')
        subject.update_attribute(:head_pipeline_id, pipeline.id)
1753

1754
        expect(subject.actual_head_pipeline).to be_nil
1755
      end
1756

1757
      it 'returns the pipeline for MR with recent pipeline' do
1758 1759 1760 1761 1762 1763 1764 1765 1766
        pipeline = create(:ci_empty_pipeline, sha: diff_head_sha)
        subject.update_attribute(:head_pipeline_id, pipeline.id)

        expect(subject.actual_head_pipeline).to eq(subject.head_pipeline)
        expect(subject.actual_head_pipeline).to eq(pipeline)
      end

      it 'returns the pipeline for MR with recent merge request pipeline' do
        pipeline = create(:ci_empty_pipeline, sha: 'merge-sha', source_sha: diff_head_sha)
1767
        subject.update_attribute(:head_pipeline_id, pipeline.id)
1768

1769 1770
        expect(subject.actual_head_pipeline).to eq(subject.head_pipeline)
        expect(subject.actual_head_pipeline).to eq(pipeline)
1771
      end
1772 1773 1774 1775 1776 1777

      it 'returns nil when source project does not exist' do
        allow(subject).to receive(:source_project).and_return(nil)

        expect(subject.actual_head_pipeline).to be_nil
      end
1778 1779
    end
  end
Yorick Peterse's avatar
Yorick Peterse committed
1780

1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793
  describe '#merge_pipeline' do
    it 'returns nil when not merged' do
      expect(subject.merge_pipeline).to be_nil
    end

    context 'when the MR is merged' do
      let(:sha)      { subject.target_project.commit.id }
      let(:pipeline) { create(:ci_empty_pipeline, sha: sha, ref: subject.target_branch, project: subject.target_project) }

      before do
        subject.mark_as_merged!
      end

1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821
      context 'and there is a merge commit' do
        before do
          subject.update_attribute(:merge_commit_sha, pipeline.sha)
        end

        it 'returns the pipeline associated with that merge request' do
          expect(subject.merge_pipeline).to eq(pipeline)
        end
      end

      context 'and there is no merge commit, but there is a diff head' do
        before do
          allow(subject).to receive(:diff_head_sha).and_return(pipeline.sha)
        end

        it 'returns the pipeline associated with that merge request' do
          expect(subject.merge_pipeline).to eq(pipeline)
        end
      end

      context 'and there is no merge commit, but there is a squash commit' do
        before do
          subject.update_attribute(:squash_commit_sha, pipeline.sha)
        end

        it 'returns the pipeline associated with that merge request' do
          expect(subject.merge_pipeline).to eq(pipeline)
        end
1822 1823 1824 1825
      end
    end
  end

1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868
  describe '#has_ci?' do
    let(:merge_request) { build_stubbed(:merge_request) }

    context 'has ci' do
      it 'returns true if MR has head_pipeline_id and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { double }
        allow(merge_request).to receive(:has_no_commits?) { false }

        expect(merge_request.has_ci?).to be(true)
      end

      it 'returns true if MR has any pipeline and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:has_no_commits?) { false }
        allow(merge_request).to receive(:all_pipelines) { [double] }

        expect(merge_request.has_ci?).to be(true)
      end

      it 'returns true if MR has CI service and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { double }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:has_no_commits?) { false }
        allow(merge_request).to receive(:all_pipelines) { [] }

        expect(merge_request.has_ci?).to be(true)
      end
    end

    context 'has no ci' do
      it 'returns false if MR has no CI service nor pipeline, and no commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:all_pipelines) { [] }
        allow(merge_request).to receive(:has_no_commits?) { true }

        expect(merge_request.has_ci?).to be(false)
      end
    end
  end

1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886
  describe '#update_head_pipeline' do
    subject { merge_request.update_head_pipeline }

    let(:merge_request) { create(:merge_request) }

    context 'when there is a pipeline with the diff head sha' do
      let!(:pipeline) do
        create(:ci_empty_pipeline,
               project: merge_request.project,
               sha: merge_request.diff_head_sha,
               ref: merge_request.source_branch)
      end

      it 'updates the head pipeline' do
        expect { subject }
          .to change { merge_request.reload.head_pipeline }
          .from(nil).to(pipeline)
      end
1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903

      context 'when merge request has already had head pipeline' do
        before do
          merge_request.update!(head_pipeline: pipeline)
        end

        context 'when failed to find an actual head pipeline' do
          before do
            allow(merge_request).to receive(:find_actual_head_pipeline) { }
          end

          it 'does not update the current head pipeline' do
            expect { subject }
              .not_to change { merge_request.reload.head_pipeline }
          end
        end
      end
1904 1905
    end

1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936
    context 'when detached merge request pipeline is run on head ref of the merge request' do
      let!(:pipeline) do
        create(:ci_pipeline,
               source: :merge_request_event,
               project: merge_request.source_project,
               ref: merge_request.ref_path,
               sha: sha,
               merge_request: merge_request)
      end

      let(:sha) { merge_request.diff_head_sha }

      it 'sets the head ref of the merge request to the pipeline ref' do
        expect(pipeline.ref).to match(%r{refs/merge-requests/\d+/head})
      end

      it 'updates correctly even though the target branch name of the merge request is different from the pipeline ref' do
        expect { subject }
          .to change { merge_request.reload.head_pipeline }
          .from(nil).to(pipeline)
      end

      context 'when sha is not HEAD of the source branch' do
        let(:sha) { merge_request.diff_base_sha }

        it 'does not update head pipeline' do
          expect { subject }.not_to change { merge_request.reload.head_pipeline }
        end
      end
    end

1937 1938 1939 1940 1941 1942 1943 1944
    context 'when there are no pipelines with the diff head sha' do
      it 'does not update the head pipeline' do
        expect { subject }
          .not_to change { merge_request.reload.head_pipeline }
      end
    end
  end

1945 1946 1947 1948
  describe '#has_test_reports?' do
    subject { merge_request.has_test_reports? }

    context 'when head pipeline has test reports' do
1949
      let(:merge_request) { create(:merge_request, :with_test_reports) }
1950 1951 1952 1953 1954

      it { is_expected.to be_truthy }
    end

    context 'when head pipeline does not have test reports' do
1955
      let(:merge_request) { create(:merge_request) }
1956 1957 1958 1959 1960

      it { is_expected.to be_falsey }
    end
  end

1961 1962 1963 1964
  describe '#has_accessibility_reports?' do
    subject { merge_request.has_accessibility_reports? }

    context 'when head pipeline has an accessibility reports' do
1965
      let(:merge_request) { create(:merge_request, :with_accessibility_reports) }
1966 1967 1968 1969 1970

      it { is_expected.to be_truthy }
    end

    context 'when head pipeline does not have accessibility reports' do
1971
      let(:merge_request) { create(:merge_request) }
1972 1973 1974 1975 1976

      it { is_expected.to be_falsey }
    end
  end

1977 1978 1979 1980
  describe '#has_coverage_reports?' do
    subject { merge_request.has_coverage_reports? }

    context 'when head pipeline has coverage reports' do
1981
      let(:merge_request) { create(:merge_request, :with_coverage_reports) }
1982 1983 1984 1985 1986

      it { is_expected.to be_truthy }
    end

    context 'when head pipeline does not have coverage reports' do
1987
      let(:merge_request) { create(:merge_request) }
1988 1989 1990 1991 1992

      it { is_expected.to be_falsey }
    end
  end

1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016
  describe '#has_codequality_mr_diff_report?' do
    subject { merge_request.has_codequality_mr_diff_report? }

    context 'when head pipeline has codequality mr diff report' do
      let(:merge_request) { create(:merge_request, :with_codequality_mr_diff_reports) }

      it { is_expected.to be_truthy }

      context 'when feature flag is disabled' do
        before do
          stub_feature_flags(codequality_mr_diff: false)
        end

        it { is_expected.to be_falsey }
      end
    end

    context 'when head pipeline does not have codeqquality mr diff report' do
      let(:merge_request) { create(:merge_request) }

      it { is_expected.to be_falsey }
    end
  end

2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028
  describe '#has_codequality_reports?' do
    subject { merge_request.has_codequality_reports? }

    let(:project) { create(:project, :repository) }

    context 'when head pipeline has a codequality report' do
      let(:merge_request) { create(:merge_request, :with_codequality_reports, source_project: project) }

      it { is_expected.to be_truthy }

      context 'when feature flag is disabled' do
        before do
2029
          stub_feature_flags(codequality_backend_comparison: false)
2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042
        end

        it { is_expected.to be_falsey }
      end
    end

    context 'when head pipeline does not have a codequality report' do
      let(:merge_request) { create(:merge_request, source_project: project) }

      it { is_expected.to be_falsey }
    end
  end

2043 2044 2045
  describe '#has_terraform_reports?' do
    context 'when head pipeline has terraform reports' do
      it 'returns true' do
2046
        merge_request = create(:merge_request, :with_terraform_reports)
2047 2048 2049 2050 2051 2052 2053

        expect(merge_request.has_terraform_reports?).to be_truthy
      end
    end

    context 'when head pipeline does not have terraform reports' do
      it 'returns false' do
2054
        merge_request = create(:merge_request)
2055 2056 2057 2058 2059 2060

        expect(merge_request.has_terraform_reports?).to be_falsey
      end
    end
  end

2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104
  describe '#has_sast_reports?' do
    subject { merge_request.has_sast_reports? }

    let(:project) { create(:project, :repository) }

    before do
      stub_licensed_features(sast: true)
    end

    context 'when head pipeline has sast reports' do
      let(:merge_request) { create(:merge_request, :with_sast_reports, source_project: project) }

      it { is_expected.to be_truthy }
    end

    context 'when head pipeline does not have sast reports' do
      let(:merge_request) { create(:merge_request, source_project: project) }

      it { is_expected.to be_falsey }
    end
  end

  describe '#has_secret_detection_reports?' do
    subject { merge_request.has_secret_detection_reports? }

    let(:project) { create(:project, :repository) }

    before do
      stub_licensed_features(secret_detection: true)
    end

    context 'when head pipeline has secret detection reports' do
      let(:merge_request) { create(:merge_request, :with_secret_detection_reports, source_project: project) }

      it { is_expected.to be_truthy }
    end

    context 'when head pipeline does not have secrets detection reports' do
      let(:merge_request) { create(:merge_request, source_project: project) }

      it { is_expected.to be_falsey }
    end
  end

2105
  describe '#calculate_reactive_cache' do
2106
    let(:merge_request) { create(:merge_request) }
2107

2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123
    subject { merge_request.calculate_reactive_cache(service_class_name) }

    context 'when given an unknown service class name' do
      let(:service_class_name) { 'Integer' }

      it 'raises a NameError exception' do
        expect { subject }.to raise_error(NameError, service_class_name)
      end
    end

    context 'when given a known service class name' do
      let(:service_class_name) { 'Ci::CompareTestReportsService' }

      it 'does not raises a NameError exception' do
        allow_any_instance_of(service_class_name.constantize).to receive(:execute).and_return(nil)

2124
        expect { subject }.not_to raise_error
2125 2126 2127 2128
      end
    end
  end

2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177
  describe '#find_exposed_artifacts' do
    let(:project) { create(:project, :repository) }
    let(:merge_request) { create(:merge_request, :with_test_reports, source_project: project) }
    let(:pipeline) { merge_request.head_pipeline }

    subject { merge_request.find_exposed_artifacts }

    context 'when head pipeline has exposed artifacts' do
      let!(:job) do
        create(:ci_build, options: { artifacts: { expose_as: 'artifact', paths: ['ci_artifacts.txt'] } }, pipeline: pipeline)
      end

      let!(:artifacts_metadata) { create(:ci_job_artifact, :metadata, job: job) }

      context 'when reactive cache worker is parsing results asynchronously' do
        it 'returns status' do
          expect(subject[:status]).to eq(:parsing)
        end
      end

      context 'when reactive cache worker is inline' do
        before do
          synchronous_reactive_cache(merge_request)
        end

        it 'returns status and data' do
          expect(subject[:status]).to eq(:parsed)
        end

        context 'when an error occurrs' do
          before do
            expect_next_instance_of(Ci::FindExposedArtifactsService) do |service|
              expect(service).to receive(:for_pipeline)
                .and_raise(StandardError.new)
            end
          end

          it 'returns an error message' do
            expect(subject[:status]).to eq(:error)
          end
        end

        context 'when cached results is not latest' do
          before do
            allow_next_instance_of(Ci::GenerateExposedArtifactsReportService) do |service|
              allow(service).to receive(:latest?).and_return(false)
            end
          end

2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225
          it 'raises and InvalidateReactiveCache error' do
            expect { subject }.to raise_error(ReactiveCaching::InvalidateReactiveCache)
          end
        end
      end
    end
  end

  describe '#find_coverage_reports' do
    let(:project) { create(:project, :repository) }
    let(:merge_request) { create(:merge_request, :with_coverage_reports, source_project: project) }
    let(:pipeline) { merge_request.head_pipeline }

    subject { merge_request.find_coverage_reports }

    context 'when head pipeline has coverage reports' do
      context 'when reactive cache worker is parsing results asynchronously' do
        it 'returns status' do
          expect(subject[:status]).to eq(:parsing)
        end
      end

      context 'when reactive cache worker is inline' do
        before do
          synchronous_reactive_cache(merge_request)
        end

        it 'returns status and data' do
          expect(subject[:status]).to eq(:parsed)
        end

        context 'when an error occurrs' do
          before do
            merge_request.update!(head_pipeline: nil)
          end

          it 'returns an error message' do
            expect(subject[:status]).to eq(:error)
          end
        end

        context 'when cached results is not latest' do
          before do
            allow_next_instance_of(Ci::GenerateCoverageReportsService) do |service|
              allow(service).to receive(:latest?).and_return(false)
            end
          end

2226 2227 2228 2229 2230 2231 2232 2233
          it 'raises and InvalidateReactiveCache error' do
            expect { subject }.to raise_error(ReactiveCaching::InvalidateReactiveCache)
          end
        end
      end
    end
  end

2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281
  describe '#find_codequality_mr_diff_reports' do
    let(:project) { create(:project, :repository) }
    let(:merge_request) { create(:merge_request, :with_codequality_mr_diff_reports, source_project: project) }
    let(:pipeline) { merge_request.head_pipeline }

    subject(:mr_diff_report) { merge_request.find_codequality_mr_diff_reports }

    context 'when head pipeline has coverage reports' do
      context 'when reactive cache worker is parsing results asynchronously' do
        it 'returns status' do
          expect(mr_diff_report[:status]).to eq(:parsing)
        end
      end

      context 'when reactive cache worker is inline' do
        before do
          synchronous_reactive_cache(merge_request)
        end

        it 'returns status and data' do
          expect(mr_diff_report[:status]).to eq(:parsed)
        end

        context 'when an error occurrs' do
          before do
            merge_request.update!(head_pipeline: nil)
          end

          it 'returns an error message' do
            expect(mr_diff_report[:status]).to eq(:error)
          end
        end

        context 'when cached results is not latest' do
          before do
            allow_next_instance_of(Ci::GenerateCodequalityMrDiffReportService) do |service|
              allow(service).to receive(:latest?).and_return(false)
            end
          end

          it 'raises and InvalidateReactiveCache error' do
            expect { mr_diff_report }.to raise_error(ReactiveCaching::InvalidateReactiveCache)
          end
        end
      end
    end
  end

2282 2283 2284 2285 2286 2287 2288
  describe '#compare_test_reports' do
    subject { merge_request.compare_test_reports }

    let(:project) { create(:project, :repository) }
    let(:merge_request) { create(:merge_request, source_project: project) }

    let!(:base_pipeline) do
2289 2290 2291 2292 2293
      create(:ci_pipeline,
             :with_test_reports,
             project: project,
             ref: merge_request.target_branch,
             sha: merge_request.diff_base_sha)
2294 2295
    end

2296 2297
    before do
      merge_request.update!(head_pipeline_id: head_pipeline.id)
2298 2299 2300
    end

    context 'when head pipeline has test reports' do
2301 2302 2303 2304 2305 2306
      let!(:head_pipeline) do
        create(:ci_pipeline,
               :with_test_reports,
               project: project,
               ref: merge_request.source_branch,
               sha: merge_request.diff_head_sha)
2307
      end
2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320

      context 'when reactive cache worker is parsing asynchronously' do
        it 'returns status' do
          expect(subject[:status]).to eq(:parsing)
        end
      end

      context 'when reactive cache worker is inline' do
        before do
          synchronous_reactive_cache(merge_request)
        end

        it 'returns status and data' do
2321
          expect_any_instance_of(Ci::CompareTestReportsService)
2322
            .to receive(:execute).with(base_pipeline, head_pipeline).and_call_original
2323

2324
          subject
2325
        end
2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336

        context 'when cached results is not latest' do
          before do
            allow_any_instance_of(Ci::CompareTestReportsService)
              .to receive(:latest?).and_return(false)
          end

          it 'raises and InvalidateReactiveCache error' do
            expect { subject }.to raise_error(ReactiveCaching::InvalidateReactiveCache)
          end
        end
2337 2338 2339 2340
      end
    end

    context 'when head pipeline does not have test reports' do
2341 2342 2343 2344 2345 2346 2347
      let!(:head_pipeline) do
        create(:ci_pipeline,
               project: project,
               ref: merge_request.source_branch,
               sha: merge_request.diff_head_sha)
      end

2348 2349
      it 'returns status and error message' do
        expect(subject[:status]).to eq(:error)
2350
        expect(subject[:status_reason]).to eq('This merge request does not have test reports')
2351 2352 2353 2354
      end
    end
  end

2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403
  describe '#compare_accessibility_reports' do
    let_it_be(:project) { create(:project, :repository) }
    let_it_be(:merge_request, reload: true) { create(:merge_request, :with_accessibility_reports, source_project: project) }
    let_it_be(:pipeline) { merge_request.head_pipeline }

    subject { merge_request.compare_accessibility_reports }

    context 'when head pipeline has accessibility reports' do
      let(:job) do
        create(:ci_build, options: { artifacts: { reports: { pa11y: ['accessibility.json'] } } }, pipeline: pipeline)
      end

      let(:artifacts_metadata) { create(:ci_job_artifact, :metadata, job: job) }

      context 'when reactive cache worker is parsing results asynchronously' do
        it 'returns parsing status' do
          expect(subject[:status]).to eq(:parsing)
        end
      end

      context 'when reactive cache worker is inline' do
        before do
          synchronous_reactive_cache(merge_request)
        end

        it 'returns parsed status' do
          expect(subject[:status]).to eq(:parsed)
          expect(subject[:data]).to be_present
        end

        context 'when an error occurrs' do
          before do
            merge_request.update!(head_pipeline: nil)
          end

          it 'returns an error status' do
            expect(subject[:status]).to eq(:error)
            expect(subject[:status_reason]).to eq("This merge request does not have accessibility reports")
          end
        end

        context 'when cached result is not latest' do
          before do
            allow_next_instance_of(Ci::CompareAccessibilityReportsService) do |service|
              allow(service).to receive(:latest?).and_return(false)
            end
          end

          it 'raises an InvalidateReactiveCache error' do
2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459
            expect { subject }.to raise_error(ReactiveCaching::InvalidateReactiveCache)
          end
        end
      end
    end
  end

  describe '#compare_codequality_reports' do
    let_it_be(:project) { create(:project, :repository) }
    let_it_be(:merge_request, reload: true) { create(:merge_request, :with_codequality_reports, source_project: project) }
    let_it_be(:pipeline) { merge_request.head_pipeline }

    subject { merge_request.compare_codequality_reports }

    context 'when head pipeline has codequality report' do
      let(:job) do
        create(:ci_build, options: { artifacts: { reports: { codeclimate: ['codequality.json'] } } }, pipeline: pipeline)
      end

      let(:artifacts_metadata) { create(:ci_job_artifact, :metadata, job: job) }

      context 'when reactive cache worker is parsing results asynchronously' do
        it 'returns parsing status' do
          expect(subject[:status]).to eq(:parsing)
        end
      end

      context 'when reactive cache worker is inline' do
        before do
          synchronous_reactive_cache(merge_request)
        end

        it 'returns parsed status' do
          expect(subject[:status]).to eq(:parsed)
          expect(subject[:data]).to be_present
        end

        context 'when an error occurrs' do
          before do
            merge_request.update!(head_pipeline: nil)
          end

          it 'returns an error status' do
            expect(subject[:status]).to eq(:error)
            expect(subject[:status_reason]).to eq("This merge request does not have codequality reports")
          end
        end

        context 'when cached result is not latest' do
          before do
            allow_next_instance_of(Ci::CompareCodequalityReportsService) do |service|
              allow(service).to receive(:latest?).and_return(false)
            end
          end

          it 'raises an InvalidateReactiveCache error' do
2460 2461 2462 2463 2464 2465 2466
            expect { subject }.to raise_error(ReactiveCaching::InvalidateReactiveCache)
          end
        end
      end
    end
  end

2467
  describe '#all_commit_shas' do
2468
    context 'when merge request is persisted' do
2469
      let(:all_commit_shas) do
2470 2471
        subject.merge_request_diffs.flat_map(&:commits).map(&:sha).uniq
      end
2472

2473
      shared_examples 'returning all SHA' do
2474
        it 'returns all SHAs from all merge_request_diffs' do
2475
          expect(subject.merge_request_diffs.size).to eq(2)
2476
          expect(subject.all_commit_shas).to match_array(all_commit_shas)
2477
        end
2478 2479
      end

2480 2481
      context 'with a completely different branch' do
        before do
2482
          subject.update(target_branch: 'csv')
2483 2484 2485
        end

        it_behaves_like 'returning all SHA'
2486 2487
      end

2488 2489
      context 'with a branch having no difference' do
        before do
2490
          subject.update(target_branch: 'branch-merged')
2491 2492 2493 2494 2495
          subject.reload # make sure commits were not cached
        end

        it_behaves_like 'returning all SHA'
      end
2496 2497
    end

2498
    context 'when merge request is not persisted' do
Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
2499 2500
      let_it_be(:project) { create(:project, :repository) }

2501 2502 2503 2504
      context 'when compare commits are set in the service' do
        let(:commit) { spy('commit') }

        subject do
Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
2505
          build(:merge_request, source_project: project, compare_commits: [commit, commit])
2506 2507 2508
        end

        it 'returns commits from compare commits temporary data' do
2509
          expect(subject.all_commit_shas).to eq [commit, commit]
2510
        end
2511 2512
      end

2513
      context 'when compare commits are not set in the service' do
Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
2514
        subject { build(:merge_request, source_project: project) }
2515 2516

        it 'returns array with diff head sha element only' do
2517
          expect(subject.all_commit_shas).to eq [subject.diff_head_sha]
2518 2519
        end
      end
2520 2521 2522
    end
  end

2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538
  describe '#short_merge_commit_sha' do
    let(:merge_request) { build_stubbed(:merge_request) }

    it 'returns short id when there is a merge_commit_sha' do
      merge_request.merge_commit_sha = 'f7ce827c314c9340b075657fd61c789fb01cf74d'

      expect(merge_request.short_merge_commit_sha).to eq('f7ce827c')
    end

    it 'returns nil when there is no merge_commit_sha' do
      merge_request.merge_commit_sha = nil

      expect(merge_request.short_merge_commit_sha).to be_nil
    end
  end

2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592
  describe '#merged_commit_sha' do
    it 'returns nil when not merged' do
      expect(subject.merged_commit_sha).to be_nil
    end

    context 'when the MR is merged' do
      let(:sha) { 'f7ce827c314c9340b075657fd61c789fb01cf74d' }

      before do
        subject.mark_as_merged!
      end

      it 'returns merge_commit_sha when there is a merge_commit_sha' do
        subject.update_attribute(:merge_commit_sha, sha)

        expect(subject.merged_commit_sha).to eq(sha)
      end

      it 'returns squash_commit_sha when there is a squash_commit_sha' do
        subject.update_attribute(:squash_commit_sha, sha)

        expect(subject.merged_commit_sha).to eq(sha)
      end

      it 'returns diff_head_sha when there are no merge_commit_sha and squash_commit_sha' do
        allow(subject).to receive(:diff_head_sha).and_return(sha)

        expect(subject.merged_commit_sha).to eq(sha)
      end
    end
  end

  describe '#short_merged_commit_sha' do
    context 'when merged_commit_sha is nil' do
      before do
        allow(subject).to receive(:merged_commit_sha).and_return(nil)
      end

      it 'returns nil' do
        expect(subject.short_merged_commit_sha).to be_nil
      end
    end

    context 'when merged_commit_sha is present' do
      before do
        allow(subject).to receive(:merged_commit_sha).and_return('f7ce827c314c9340b075657fd61c789fb01cf74d')
      end

      it 'returns shortened merged_commit_sha' do
        expect(subject.short_merged_commit_sha).to eq('f7ce827c')
      end
    end
  end

2593
  describe '#can_be_reverted?' do
2594 2595
    subject { create(:merge_request, source_project: create(:project, :repository)) }

2596 2597
    context 'when there is no merge_commit for the MR' do
      before do
2598
        subject.metrics.update!(merged_at: Time.current.utc)
2599 2600 2601 2602 2603 2604 2605 2606 2607 2608
      end

      it 'returns false' do
        expect(subject.can_be_reverted?(nil)).to be_falsey
      end
    end

    context 'when the MR has been merged' do
      before do
        MergeRequests::MergeService
2609
          .new(subject.target_project, subject.author, { sha: subject.diff_head_sha })
2610 2611 2612 2613 2614 2615 2616 2617 2618
          .execute(subject)
      end

      context 'when there is no revert commit' do
        it 'returns true' do
          expect(subject.can_be_reverted?(nil)).to be_truthy
        end
      end

2619 2620 2621 2622 2623 2624 2625 2626 2627 2628
      context 'when there is no merged_at for the MR' do
        before do
          subject.metrics.update!(merged_at: nil)
        end

        it 'returns true' do
          expect(subject.can_be_reverted?(nil)).to be_truthy
        end
      end

2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644
      context 'when there is a revert commit' do
        let(:current_user) { subject.author }
        let(:branch) { subject.target_branch }
        let(:project) { subject.target_project }

        let(:revert_commit_id) do
          params = {
            commit: subject.merge_commit,
            branch_name: branch,
            start_branch: branch
          }

          Commits::RevertService.new(project, current_user, params).execute[:result]
        end

        before do
2645
          project.add_maintainer(current_user)
2646 2647 2648 2649 2650 2651 2652

          ProcessCommitWorker.new.perform(project.id,
                                          current_user.id,
                                          project.commit(revert_commit_id).to_hash,
                                          project.default_branch == branch)
        end

2653 2654 2655 2656 2657 2658 2659 2660 2661 2662
        context 'but merged at timestamp cannot be found' do
          before do
            allow(subject).to receive(:merged_at) { nil }
          end

          it 'returns false' do
            expect(subject.can_be_reverted?(current_user)).to be_falsey
          end
        end

2663 2664 2665 2666 2667 2668
        context 'when the revert commit is mentioned in a note after the MR was merged' do
          it 'returns false' do
            expect(subject.can_be_reverted?(current_user)).to be_falsey
          end
        end

2669 2670 2671 2672 2673 2674 2675 2676 2677 2678
        context 'when there is no merged_at for the MR' do
          before do
            subject.metrics.update!(merged_at: nil)
          end

          it 'returns false' do
            expect(subject.can_be_reverted?(current_user)).to be_falsey
          end
        end

2679
        context 'when the revert commit is mentioned in a note just before the MR was merged' do
2680
          before do
2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691
            subject.notes.last.update!(created_at: subject.metrics.merged_at - 30.seconds)
          end

          it 'returns false' do
            expect(subject.can_be_reverted?(current_user)).to be_falsey
          end
        end

        context 'when the revert commit is mentioned in a note long before the MR was merged' do
          before do
            subject.notes.last.update!(created_at: subject.metrics.merged_at - 2.minutes)
2692 2693 2694 2695 2696 2697 2698 2699 2700 2701
          end

          it 'returns true' do
            expect(subject.can_be_reverted?(current_user)).to be_truthy
          end
        end
      end
    end
  end

2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736
  describe '#merged_at' do
    context 'when MR is not merged' do
      let(:merge_request) { create(:merge_request, :closed) }

      it 'returns nil' do
        expect(merge_request.merged_at).to be_nil
      end
    end

    context 'when metrics has merged_at data' do
      let(:merge_request) { create(:merge_request, :merged) }

      before do
        merge_request.metrics.update!(merged_at: 1.day.ago)
      end

      it 'returns metrics merged_at' do
        expect(merge_request.merged_at).to eq(merge_request.metrics.merged_at)
      end
    end

    context 'when merged event is persisted, but no metrics merged_at is persisted' do
      let(:user) { create(:user) }
      let(:merge_request) { create(:merge_request, :merged) }

      before do
        EventCreateService.new.merge_mr(merge_request, user)
      end

      it 'returns merged event creation date' do
        expect(merge_request.merge_event).to be_persisted
        expect(merge_request.merged_at).to eq(merge_request.merge_event.created_at)
      end
    end

2737 2738 2739 2740
    context 'when no metrics or merge event exists' do
      let(:user) { create(:user) }
      let(:merge_request) { create(:merge_request, :merged) }

2741
      before do
2742
        merge_request.metrics.destroy!
2743 2744
      end

2745
      context 'when resource event for the merge exists' do
2746 2747 2748 2749 2750 2751 2752
        before do
          SystemNoteService.change_status(merge_request,
                                          merge_request.target_project,
                                          user,
                                          merge_request.state, nil)
        end

2753
        it 'returns the resource event creation date' do
2754 2755
          expect(merge_request.reload.metrics).to be_nil
          expect(merge_request.merge_event).to be_nil
2756 2757
          expect(merge_request.resource_state_events.count).to eq(1)
          expect(merge_request.merged_at).to eq(merge_request.resource_state_events.first.created_at)
2758 2759
        end
      end
2760

2761 2762 2763 2764 2765 2766
      context 'when system note for the merge exists' do
        before do
          # We do not create these system notes anymore but we need this to work for existing MRs
          # that used system notes instead of resource state events
          create(:note, :system, noteable: merge_request, note: 'merged')
        end
2767

2768 2769 2770 2771 2772 2773
        it 'returns the merging note creation date' do
          expect(merge_request.reload.metrics).to be_nil
          expect(merge_request.merge_event).to be_nil
          expect(merge_request.notes.count).to eq(1)
          expect(merge_request.merged_at).to eq(merge_request.notes.first.created_at)
        end
2774 2775 2776 2777
      end
    end
  end

Yorick Peterse's avatar
Yorick Peterse committed
2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798
  describe '#participants' do
    let(:mr) do
      create(:merge_request, source_project: project, target_project: project)
    end

    let!(:note1) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'a')
    end

    let!(:note2) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'b')
    end

    it 'includes the merge request author' do
      expect(mr.participants).to include(mr.author)
    end

    it 'includes the authors of the notes' do
      expect(mr.participants).to include(note1.author, note2.author)
    end
  end
2799 2800 2801 2802 2803

  describe 'cached counts' do
    it 'updates when assignees change' do
      user1 = create(:user)
      user2 = create(:user)
2804
      mr = create(:merge_request, assignees: [user1])
2805 2806
      mr.project.add_developer(user1)
      mr.project.add_developer(user2)
2807

2808 2809
      expect(user1.assigned_open_merge_requests_count).to eq(1)
      expect(user2.assigned_open_merge_requests_count).to eq(0)
2810

2811
      mr.assignees = [user2]
2812

2813 2814
      expect(user1.assigned_open_merge_requests_count).to eq(0)
      expect(user2.assigned_open_merge_requests_count).to eq(1)
2815 2816
    end
  end
2817

2818
  describe '#merge_async' do
2819 2820 2821
    it 'enqueues MergeWorker job and updates merge_jid' do
      merge_request = create(:merge_request)
      user_id = double(:user_id)
2822
      params = {}
2823 2824
      merge_jid = 'hash-123'

2825
      expect(merge_request).to receive(:expire_etag_cache)
2826 2827 2828 2829
      expect(MergeWorker).to receive(:perform_async).with(merge_request.id, user_id, params) do
        merge_jid
      end

2830
      merge_request.merge_async(user_id, params)
2831 2832 2833 2834 2835

      expect(merge_request.reload.merge_jid).to eq(merge_jid)
    end
  end

2836 2837 2838 2839 2840 2841 2842 2843 2844 2845
  describe '#rebase_async' do
    let(:merge_request) { create(:merge_request) }
    let(:user_id) { double(:user_id) }
    let(:rebase_jid) { 'rebase-jid' }

    subject(:execute) { merge_request.rebase_async(user_id) }

    it 'atomically enqueues a RebaseWorker job and updates rebase_jid' do
      expect(RebaseWorker)
        .to receive(:perform_async)
2846
        .with(merge_request.id, user_id, false)
2847 2848
        .and_return(rebase_jid)

2849
      expect(merge_request).to receive(:expire_etag_cache)
2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869
      expect(merge_request).to receive(:lock!).and_call_original

      execute

      expect(merge_request.rebase_jid).to eq(rebase_jid)
    end

    it 'refuses to enqueue a job if a rebase is in progress' do
      merge_request.update_column(:rebase_jid, rebase_jid)

      expect(RebaseWorker).not_to receive(:perform_async)
      expect(Gitlab::SidekiqStatus)
        .to receive(:running?)
        .with(rebase_jid)
        .and_return(true)

      expect { execute }.to raise_error(ActiveRecord::StaleObjectError)
    end

    it 'refuses to enqueue a job if the MR is not open' do
2870
      merge_request.update_column(:state_id, 5)
2871 2872 2873 2874 2875

      expect(RebaseWorker).not_to receive(:perform_async)

      expect { execute }.to raise_error(ActiveRecord::StaleObjectError)
    end
2876 2877 2878 2879 2880 2881 2882

    it "raises ActiveRecord::LockWaitTimeout after 6 tries" do
      expect(merge_request).to receive(:with_lock).exactly(6).times.and_raise(ActiveRecord::LockWaitTimeout)
      expect(RebaseWorker).not_to receive(:perform_async)

      expect { execute }.to raise_error(MergeRequest::RebaseLockTimeout)
    end
2883 2884
  end

2885
  describe '#mergeable?' do
2886
    subject { build_stubbed(:merge_request) }
2887

2888 2889 2890 2891 2892
    it 'returns false if still preparing' do
      expect(subject).to receive(:preparing?) { true }
      expect(subject.mergeable?).to be_falsey
    end

2893 2894
    it 'returns false if #mergeable_state? is false' do
      expect(subject).to receive(:mergeable_state?) { false }
2895

2896
      expect(subject.mergeable?).to be_falsey
2897 2898
    end

2899
    it 'return true if #mergeable_state? is true and the MR #can_be_merged? is true' do
2900
      allow(subject).to receive(:mergeable_state?) { true }
2901
      expect(subject).to receive(:check_mergeability)
2902
      expect(subject).to receive(:can_be_merged?) { true }
2903 2904 2905

      expect(subject.mergeable?).to be_truthy
    end
2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952

    context 'with skip_ci_check option' do
      before do
        allow(subject).to receive_messages(check_mergeability: nil,
                                           can_be_merged?: true,
                                           broken?: false)
      end

      where(:mergeable_ci_state, :skip_ci_check, :expected_mergeable) do
        false | false | false
        false | true  | true
        true  | false | true
        true  | true  | true
      end

      with_them do
        it 'overrides mergeable_ci_state?' do
          allow(subject).to receive(:mergeable_ci_state?) { mergeable_ci_state }

          expect(subject.mergeable?(skip_ci_check: skip_ci_check)).to eq(expected_mergeable)
        end
      end
    end

    context 'with skip_discussions_check option' do
      before do
        allow(subject).to receive_messages(mergeable_ci_state?: true,
                                           check_mergeability: nil,
                                           can_be_merged?: true,
                                           broken?: false)
      end

      where(:mergeable_discussions_state, :skip_discussions_check, :expected_mergeable) do
        false | false | false
        false | true  | true
        true  | false | true
        true  | true  | true
      end

      with_them do
        it 'overrides mergeable_discussions_state?' do
          allow(subject).to receive(:mergeable_discussions_state?) { mergeable_discussions_state }

          expect(subject.mergeable?(skip_discussions_check: skip_discussions_check)).to eq(expected_mergeable)
        end
      end
    end
2953 2954
  end

2955 2956 2957
  describe '#check_mergeability' do
    let(:mergeability_service) { double }

2958 2959
    subject { create(:merge_request, merge_status: 'unchecked') }

2960 2961 2962 2963 2964 2965
    before do
      allow(MergeRequests::MergeabilityCheckService).to receive(:new) do
        mergeability_service
      end
    end

2966
    shared_examples_for 'method that executes MergeabilityCheckService' do
2967 2968 2969 2970 2971
      it 'executes MergeabilityCheckService' do
        expect(mergeability_service).to receive(:execute)

        subject.check_mergeability
      end
2972 2973

      context 'when async is true' do
2974 2975
        it 'executes MergeabilityCheckService asynchronously' do
          expect(mergeability_service).to receive(:async_execute)
2976

2977
          subject.check_mergeability(async: true)
2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991
        end
      end
    end

    context 'if the merge status is unchecked' do
      it_behaves_like 'method that executes MergeabilityCheckService'
    end

    context 'if the merge status is checking' do
      before do
        subject.mark_as_checking!
      end

      it_behaves_like 'method that executes MergeabilityCheckService'
2992 2993 2994
    end

    context 'if the merge status is checked' do
2995 2996 2997 2998
      before do
        subject.mark_as_mergeable!
      end

2999 3000
      it 'does not call MergeabilityCheckService' do
        expect(MergeRequests::MergeabilityCheckService).not_to receive(:new)
3001

3002
        subject.check_mergeability
3003 3004 3005 3006
      end
    end
  end

3007
  describe '#mergeable_state?' do
3008
    subject { create(:merge_request) }
3009

3010
    it 'checks if merge request can be merged' do
3011
      allow(subject).to receive(:mergeable_ci_state?) { true }
3012
      expect(subject).to receive(:check_mergeability)
3013 3014 3015 3016 3017

      subject.mergeable?
    end

    context 'when not open' do
3018 3019 3020
      before do
        subject.close
      end
3021 3022

      it 'returns false' do
3023
        expect(subject.mergeable_state?).to be_falsey
3024 3025 3026 3027
      end
    end

    context 'when working in progress' do
3028
      before do
3029
        subject.title = '[Draft] MR'
3030
      end
3031 3032

      it 'returns false' do
3033
        expect(subject.mergeable_state?).to be_falsey
3034 3035 3036 3037
      end
    end

    context 'when broken' do
3038 3039 3040
      before do
        allow(subject).to receive(:broken?) { true }
      end
3041 3042

      it 'returns false' do
3043
        expect(subject.mergeable_state?).to be_falsey
3044 3045 3046 3047
      end
    end

    context 'when failed' do
3048
      context 'when #mergeable_ci_state? is false' do
3049
        before do
3050
          allow(subject).to receive(:mergeable_ci_state?) { false }
3051 3052 3053 3054
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
3055
        end
3056 3057 3058 3059

        it 'returns true when skipping ci check' do
          expect(subject.mergeable_state?(skip_ci_check: true)).to be(true)
        end
3060
      end
3061

3062
      context 'when #mergeable_discussions_state? is false' do
3063 3064 3065 3066 3067 3068 3069
        before do
          allow(subject).to receive(:mergeable_discussions_state?) { false }
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
        end
3070 3071 3072 3073

        it 'returns true when skipping discussions check' do
          expect(subject.mergeable_state?(skip_discussions_check: true)).to be(true)
        end
3074
      end
3075 3076 3077
    end
  end

3078 3079 3080 3081 3082
  describe "#public_merge_status" do
    using RSpec::Parameterized::TableSyntax
    subject { build(:merge_request, merge_status: status) }

    where(:status, :public_status) do
3083
      'preparing' | 'checking'
3084 3085 3086 3087 3088 3089 3090 3091 3092 3093
      'cannot_be_merged_rechecking' | 'checking'
      'checking'                    | 'checking'
      'cannot_be_merged'            | 'cannot_be_merged'
    end

    with_them do
      it { expect(subject.public_merge_status).to eq(public_status) }
    end
  end

3094
  describe "#head_pipeline_active? " do
3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117
    context 'when project lacks a head_pipeline relation' do
      before do
        subject.head_pipeline = nil
      end

      it 'returns false' do
        expect(subject.head_pipeline_active?).to be false
      end
    end

    context 'when project has a head_pipeline relation' do
      let(:pipeline) { create(:ci_empty_pipeline) }

      before do
        allow(subject).to receive(:head_pipeline) { pipeline }
      end

      it 'accesses the value from the head_pipeline' do
        expect(subject.head_pipeline)
          .to receive(:active?)

        subject.head_pipeline_active?
      end
3118 3119 3120 3121
    end
  end

  describe "#actual_head_pipeline_success? " do
3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144
    context 'when project lacks an actual_head_pipeline relation' do
      before do
        allow(subject).to receive(:actual_head_pipeline) { nil }
      end

      it 'returns false' do
        expect(subject.actual_head_pipeline_success?).to be false
      end
    end

    context 'when project has a actual_head_pipeline relation' do
      let(:pipeline) { create(:ci_empty_pipeline) }

      before do
        allow(subject).to receive(:actual_head_pipeline) { pipeline }
      end

      it 'accesses the value from the actual_head_pipeline' do
        expect(subject.actual_head_pipeline)
          .to receive(:success?)

        subject.actual_head_pipeline_success?
      end
3145 3146 3147
    end
  end

3148
  describe "#actual_head_pipeline_active? " do
3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171
    context 'when project lacks an actual_head_pipeline relation' do
      before do
        allow(subject).to receive(:actual_head_pipeline) { nil }
      end

      it 'returns false' do
        expect(subject.actual_head_pipeline_active?).to be false
      end
    end

    context 'when project has a actual_head_pipeline relation' do
      let(:pipeline) { create(:ci_empty_pipeline) }

      before do
        allow(subject).to receive(:actual_head_pipeline) { pipeline }
      end

      it 'accesses the value from the actual_head_pipeline' do
        expect(subject.actual_head_pipeline)
          .to receive(:active?)

        subject.actual_head_pipeline_active?
      end
3172 3173 3174
    end
  end

3175
  describe '#mergeable_ci_state?' do
3176
    let(:pipeline) { create(:ci_empty_pipeline) }
3177

3178
    context 'when it is only allowed to merge when build is green' do
Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
3179
      let_it_be(:project) { create(:project, :repository, only_allow_merge_if_pipeline_succeeds: true) }
3180

Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
3181
      subject { build(:merge_request, source_project: project) }
3182

3183
      context 'and a failed pipeline is associated' do
3184
        before do
3185
          pipeline.update(status: 'failed', sha: subject.diff_head_sha)
3186
          allow(subject).to receive(:head_pipeline) { pipeline }
3187
        end
3188

3189
        it { expect(subject.mergeable_ci_state?).to be_falsey }
3190 3191
      end

3192 3193
      context 'and a successful pipeline is associated' do
        before do
3194
          pipeline.update(status: 'success', sha: subject.diff_head_sha)
3195
          allow(subject).to receive(:head_pipeline) { pipeline }
3196 3197 3198 3199 3200 3201 3202
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

      context 'and a skipped pipeline is associated' do
        before do
3203
          pipeline.update(status: 'skipped', sha: subject.diff_head_sha)
3204
          allow(subject).to receive(:head_pipeline).and_return(pipeline)
3205 3206
        end

3207
        it { expect(subject.mergeable_ci_state?).to be_falsey }
3208 3209
      end

3210
      context 'when no pipeline is associated' do
3211
        before do
3212 3213 3214 3215 3216 3217 3218 3219
          allow(subject).to receive(:head_pipeline).and_return(nil)
        end

        it { expect(subject.mergeable_ci_state?).to be_falsey }
      end
    end

    context 'when it is only allowed to merge when build is green or skipped' do
Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
3220
      let_it_be(:project) { create(:project, :repository, only_allow_merge_if_pipeline_succeeds: true, allow_merge_on_skipped_pipeline: true) }
3221

Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
3222
      subject { build(:merge_request, source_project: project) }
3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253

      context 'and a failed pipeline is associated' do
        before do
          pipeline.update!(status: 'failed', sha: subject.diff_head_sha)
          allow(subject).to receive(:head_pipeline).and_return(pipeline)
        end

        it { expect(subject.mergeable_ci_state?).to be_falsey }
      end

      context 'and a successful pipeline is associated' do
        before do
          pipeline.update!(status: 'success', sha: subject.diff_head_sha)
          allow(subject).to receive(:head_pipeline).and_return(pipeline)
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

      context 'and a skipped pipeline is associated' do
        before do
          pipeline.update!(status: 'skipped', sha: subject.diff_head_sha)
          allow(subject).to receive(:head_pipeline).and_return(pipeline)
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

      context 'when no pipeline is associated' do
        before do
          allow(subject).to receive(:head_pipeline).and_return(nil)
3254 3255
        end

3256
        it { expect(subject.mergeable_ci_state?).to be_falsey }
3257 3258 3259
      end
    end

3260
    context 'when merges are not restricted to green builds' do
Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
3261
      let_it_be(:project) { create(:project, :repository, only_allow_merge_if_pipeline_succeeds: false) }
3262

Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
3263
      subject { build(:merge_request, source_project: project) }
3264

3265
      context 'and a failed pipeline is associated' do
3266
        before do
3267
          pipeline.statuses << create(:commit_status, status: 'failed', project: project)
3268
          allow(subject).to receive(:head_pipeline) { pipeline }
3269 3270 3271 3272 3273
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

3274
      context 'when no pipeline is associated' do
3275
        before do
3276
          allow(subject).to receive(:head_pipeline) { nil }
3277 3278 3279
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
3280
      end
3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297

      context 'and a skipped pipeline is associated' do
        before do
          pipeline.update!(status: 'skipped', sha: subject.diff_head_sha)
          allow(subject).to receive(:head_pipeline).and_return(pipeline)
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

      context 'when no pipeline is associated' do
        before do
          allow(subject).to receive(:head_pipeline).and_return(nil)
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end
3298 3299
    end
  end
3300

3301
  describe '#mergeable_discussions_state?' do
3302
    let(:merge_request) { create(:merge_request_with_diff_notes, source_project: project) }
3303

3304
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == true' do
3305
      let_it_be(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: true) }
3306

3307
      context 'with all discussions resolved' do
3308
        before do
3309
          merge_request.discussions.each { |d| d.resolve!(merge_request.author) }
3310 3311 3312
        end

        it 'returns true' do
3313
          expect(merge_request.mergeable_discussions_state?).to be_truthy
3314 3315 3316
        end
      end

3317
      context 'with unresolved discussions' do
3318
        before do
3319
          merge_request.discussions.each(&:unresolve!)
3320 3321 3322
        end

        it 'returns false' do
3323
          expect(merge_request.mergeable_discussions_state?).to be_falsey
3324 3325
        end
      end
3326 3327 3328

      context 'with no discussions' do
        before do
Doug Stull's avatar
Doug Stull committed
3329
          merge_request.notes.destroy_all # rubocop: disable Cop/DestroyAll
3330 3331 3332 3333 3334 3335
        end

        it 'returns true' do
          expect(merge_request.mergeable_discussions_state?).to be_truthy
        end
      end
3336 3337
    end

3338
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == false' do
3339
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: false) }
3340

3341
      context 'with unresolved discussions' do
3342
        before do
3343
          merge_request.discussions.each(&:unresolve!)
3344 3345 3346
        end

        it 'returns true' do
3347
          expect(merge_request.mergeable_discussions_state?).to be_truthy
3348 3349 3350 3351 3352
        end
      end
    end
  end

Douwe Maan's avatar
Douwe Maan committed
3353
  describe "#environments_for" do
3354
    let(:project)       { create(:project, :repository) }
Douwe Maan's avatar
Douwe Maan committed
3355
    let(:user)          { project.creator }
Z.J. van de Weg's avatar
Z.J. van de Weg committed
3356
    let(:merge_request) { create(:merge_request, source_project: project) }
3357 3358 3359 3360
    let(:source_branch) { merge_request.source_branch }
    let(:target_branch) { merge_request.target_branch }
    let(:source_oid) { project.commit(source_branch).id }
    let(:target_oid) { project.commit(target_branch).id }
Z.J. van de Weg's avatar
Z.J. van de Weg committed
3361

Douwe Maan's avatar
Douwe Maan committed
3362
    before do
3363 3364
      merge_request.source_project.add_maintainer(user)
      merge_request.target_project.add_maintainer(user)
Douwe Maan's avatar
Douwe Maan committed
3365 3366
    end

3367 3368
    context 'with multiple environments' do
      let(:environments) { create_list(:environment, 3, project: project) }
3369

3370
      before do
3371 3372
        create(:deployment, :success, environment: environments.first, ref: source_branch, sha: source_oid)
        create(:deployment, :success, environment: environments.second, ref: target_branch, sha: target_oid)
3373 3374 3375
      end

      it 'selects deployed environments' do
Douwe Maan's avatar
Douwe Maan committed
3376
        expect(merge_request.environments_for(user)).to contain_exactly(environments.first)
3377
      end
3378 3379 3380 3381 3382 3383 3384 3385

      it 'selects latest deployed environment' do
        latest_environment = create(:environment, project: project)
        create(:deployment, :success, environment: latest_environment, ref: source_branch, sha: source_oid)

        expect(merge_request.environments_for(user)).to eq([environments.first, latest_environment])
        expect(merge_request.environments_for(user, latest: true)).to contain_exactly(latest_environment)
      end
3386 3387 3388
    end

    context 'with environments on source project' do
3389
      let(:source_project) { fork_project(project, nil, repository: true) }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
3390

3391 3392 3393 3394 3395 3396 3397 3398 3399
      let(:merge_request) do
        create(:merge_request,
               source_project: source_project, source_branch: 'feature',
               target_project: project)
      end

      let(:source_environment) { create(:environment, project: source_project) }

      before do
3400
        create(:deployment, :success, environment: source_environment, ref: 'feature', sha: merge_request.diff_head_sha)
3401 3402
      end

3403
      it 'selects deployed environments', :sidekiq_might_not_need_inline do
Douwe Maan's avatar
Douwe Maan committed
3404
        expect(merge_request.environments_for(user)).to contain_exactly(source_environment)
3405 3406 3407 3408 3409 3410
      end

      context 'with environments on target project' do
        let(:target_environment) { create(:environment, project: project) }

        before do
3411
          create(:deployment, :success, environment: target_environment, tag: true, sha: merge_request.diff_head_sha)
3412 3413
        end

3414
        it 'selects deployed environments', :sidekiq_might_not_need_inline do
Douwe Maan's avatar
Douwe Maan committed
3415
          expect(merge_request.environments_for(user)).to contain_exactly(source_environment, target_environment)
3416 3417
        end
      end
3418 3419 3420 3421 3422 3423 3424 3425
    end

    context 'without a diff_head_commit' do
      before do
        expect(merge_request).to receive(:diff_head_commit).and_return(nil)
      end

      it 'returns an empty array' do
Douwe Maan's avatar
Douwe Maan committed
3426
        expect(merge_request.environments_for(user)).to be_empty
3427
      end
Z.J. van de Weg's avatar
Z.J. van de Weg committed
3428 3429 3430
    end
  end

3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444
  describe "#environments" do
    subject { merge_request.environments }

    let(:merge_request) { create(:merge_request, source_branch: 'feature', target_branch: 'master') }
    let(:project) { merge_request.project }

    let(:pipeline) do
      create(:ci_pipeline,
        source: :merge_request_event,
        merge_request: merge_request, project: project,
        sha: merge_request.diff_head_sha,
        merge_requests_as_head_pipeline: [merge_request])
    end

3445
    let!(:job) { create(:ci_build, :with_deployment, :start_review_app, pipeline: pipeline, project: project) }
3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474

    it 'returns environments' do
      is_expected.to eq(pipeline.environments)
      expect(subject.count).to be(1)
    end

    context 'when pipeline is not associated with environments' do
      let!(:job) { create(:ci_build, pipeline: pipeline, project: project) }

      it 'returns empty array' do
        is_expected.to be_empty
      end
    end

    context 'when pipeline is not a pipeline for merge request' do
      let(:pipeline) do
        create(:ci_pipeline,
          project: project,
          ref: 'feature',
          sha: merge_request.diff_head_sha,
          merge_requests_as_head_pipeline: [merge_request])
      end

      it 'returns empty relation' do
        is_expected.to be_empty
      end
    end
  end

3475
  describe "#reload_diff" do
3476 3477 3478
    it 'calls MergeRequests::ReloadDiffsService#execute with correct params' do
      user = create(:user)
      service = instance_double(MergeRequests::ReloadDiffsService, execute: nil)
3479

3480 3481 3482
      expect(MergeRequests::ReloadDiffsService)
        .to receive(:new).with(subject, user)
        .and_return(service)
3483

3484
      subject.reload_diff(user)
3485

3486
      expect(service).to have_received(:execute)
3487
    end
3488 3489 3490 3491 3492 3493 3494 3495 3496 3497

    context 'when using the after_update hook to update' do
      context 'when the branches are updated' do
        it 'uses the new heads to generate the diff' do
          expect { subject.update!(source_branch: subject.target_branch, target_branch: subject.source_branch) }
            .to change { subject.merge_request_diff.start_commit_sha }
            .and change { subject.merge_request_diff.head_commit_sha }
        end
      end
    end
3498
  end
3499

3500 3501 3502 3503 3504 3505
  describe '#update_diff_discussion_positions' do
    let(:discussion) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject).to_discussion }
    let(:commit) { subject.project.commit(sample_commit.id) }
    let(:old_diff_refs) { subject.diff_refs }

    before do
3506
      # Update merge_request_diff so that #diff_refs will return commit.diff_refs
3507 3508 3509 3510 3511 3512
      allow(subject).to receive(:create_merge_request_diff) do
        subject.merge_request_diffs.create(
          base_commit_sha: commit.parent_id,
          start_commit_sha: commit.parent_id,
          head_commit_sha: commit.sha
        )
3513

3514
        subject.reload_merge_request_diff
3515
      end
3516
    end
3517

3518
    it "updates diff discussion positions" do
3519
      expect(Discussions::UpdateDiffPositionService).to receive(:new).with(
3520
        subject.project,
3521
        subject.author,
3522 3523
        old_diff_refs: old_diff_refs,
        new_diff_refs: commit.diff_refs,
3524
        paths: discussion.position.paths
3525 3526
      ).and_call_original

3527
      expect_any_instance_of(Discussions::UpdateDiffPositionService).to receive(:execute).with(discussion).and_call_original
3528 3529
      expect_any_instance_of(DiffNote).to receive(:save).once

3530 3531 3532 3533 3534 3535
      subject.update_diff_discussion_positions(old_diff_refs: old_diff_refs,
                                               new_diff_refs: commit.diff_refs,
                                               current_user: subject.author)
    end

    context 'when resolve_outdated_diff_discussions is set' do
3536 3537
      let(:project) { create(:project, :repository) }

3538
      subject { create(:merge_request, source_project: project) }
3539

3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553
      before do
        discussion

        subject.project.update!(resolve_outdated_diff_discussions: true)
      end

      it 'calls MergeRequests::ResolvedDiscussionNotificationService' do
        expect_any_instance_of(MergeRequests::ResolvedDiscussionNotificationService)
          .to receive(:execute).with(subject)

        subject.update_diff_discussion_positions(old_diff_refs: old_diff_refs,
                                                 new_diff_refs: commit.diff_refs,
                                                 current_user: subject.author)
      end
3554 3555
    end
  end
3556 3557

  describe '#branch_merge_base_commit' do
3558 3559
    let(:project) { create(:project, :repository) }

3560
    subject { create(:merge_request, source_project: project) }
3561

3562 3563 3564 3565 3566 3567 3568
    context 'source and target branch exist' do
      it { expect(subject.branch_merge_base_commit.sha).to eq('ae73cb07c9eeaf35924a10f713b364d32b2dd34f') }
      it { expect(subject.branch_merge_base_commit).to be_a(Commit) }
    end

    context 'when the target branch does not exist' do
      before do
3569
        subject.project.repository.rm_branch(subject.author, subject.target_branch)
3570
        subject.clear_memoized_shas
3571 3572 3573 3574
      end

      it 'returns nil' do
        expect(subject.branch_merge_base_commit).to be_nil
3575 3576 3577 3578
      end
    end
  end

3579
  describe "#diff_refs" do
3580
    context "with diffs" do
3581 3582
      let(:project) { create(:project, :repository) }

3583
      subject { create(:merge_request, source_project: project) }
3584

3585
      let(:expected_diff_refs) do
3586 3587 3588 3589 3590
        Gitlab::Diff::DiffRefs.new(
          base_sha:  subject.merge_request_diff.base_commit_sha,
          start_sha: subject.merge_request_diff.start_commit_sha,
          head_sha:  subject.merge_request_diff.head_commit_sha
        )
3591
      end
3592 3593 3594 3595 3596 3597

      it "does not touch the repository" do
        subject # Instantiate the object

        expect_any_instance_of(Repository).not_to receive(:commit)

3598
        subject.diff_refs
3599 3600 3601
      end

      it "returns expected diff_refs" do
3602
        expect(subject.diff_refs).to eq(expected_diff_refs)
3603
      end
3604 3605 3606 3607 3608 3609 3610 3611 3612 3613

      context 'when importing' do
        before do
          subject.importing = true
        end

        it "returns MR diff_refs" do
          expect(subject.diff_refs).to eq(expected_diff_refs)
        end
      end
3614 3615
    end
  end
3616

3617
  describe "#source_project_missing?" do
3618
    let(:project) { create(:project) }
3619
    let(:forked_project) { fork_project(project) }
3620
    let(:user) { create(:user) }
3621
    let(:unlink_project) { Projects::UnlinkForkService.new(forked_project, user) }
3622

Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3623
    context "when the fork exists" do
3624 3625
      let(:merge_request) do
        create(:merge_request,
3626
          source_project: forked_project,
3627 3628 3629
          target_project: project)
      end

3630
      it { expect(merge_request.source_project_missing?).to be_falsey }
3631 3632
    end

Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3633
    context "when the source project is the same as the target project" do
3634 3635
      let(:merge_request) { create(:merge_request, source_project: project) }

3636
      it { expect(merge_request.source_project_missing?).to be_falsey }
3637 3638
    end

Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3639
    context "when the fork does not exist" do
3640
      let!(:merge_request) do
3641
        create(:merge_request,
3642
          source_project: forked_project,
3643 3644 3645
          target_project: project)
      end

Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3646
      it "returns true" do
3647 3648 3649
        unlink_project.execute
        merge_request.reload

3650
        expect(merge_request.source_project_missing?).to be_truthy
3651 3652 3653 3654
      end
    end
  end

3655
  describe '#merge_ongoing?' do
3656
    it 'returns true when the merge request is locked' do
3657
      merge_request = build_stubbed(:merge_request, state_id: described_class.available_states[:locked])
3658 3659 3660 3661

      expect(merge_request.merge_ongoing?).to be(true)
    end

3662
    it 'returns true when merge_id, MR is not merged and it has no running job' do
3663
      merge_request = build_stubbed(:merge_request, state_id: described_class.available_states[:opened], merge_jid: 'foo')
3664
      allow(Gitlab::SidekiqStatus).to receive(:running?).with('foo') { true }
3665 3666 3667

      expect(merge_request.merge_ongoing?).to be(true)
    end
3668 3669

    it 'returns false when merge_jid is nil' do
3670
      merge_request = build_stubbed(:merge_request, state_id: described_class.available_states[:opened], merge_jid: nil)
3671 3672 3673 3674 3675

      expect(merge_request.merge_ongoing?).to be(false)
    end

    it 'returns false if MR is merged' do
3676
      merge_request = build_stubbed(:merge_request, state_id: described_class.available_states[:merged], merge_jid: 'foo')
3677 3678 3679 3680 3681

      expect(merge_request.merge_ongoing?).to be(false)
    end

    it 'returns false if there is no merge job running' do
3682
      merge_request = build_stubbed(:merge_request, state_id: described_class.available_states[:opened], merge_jid: 'foo')
3683
      allow(Gitlab::SidekiqStatus).to receive(:running?).with('foo') { false }
3684 3685 3686

      expect(merge_request.merge_ongoing?).to be(false)
    end
3687 3688
  end

3689
  describe "#closed_or_merged_without_fork?" do
3690
    let(:project) { create(:project) }
3691
    let(:forked_project) { fork_project(project) }
3692
    let(:user) { create(:user) }
3693
    let(:unlink_project) { Projects::UnlinkForkService.new(forked_project, user) }
3694

Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3695
    context "when the merge request is closed" do
3696 3697
      let(:closed_merge_request) do
        create(:closed_merge_request,
3698
          source_project: forked_project,
3699 3700 3701
          target_project: project)
      end

Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3702
      it "returns false if the fork exist" do
3703
        expect(closed_merge_request.closed_or_merged_without_fork?).to be_falsey
3704 3705
      end

Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3706
      it "returns true if the fork does not exist" do
3707 3708 3709
        unlink_project.execute
        closed_merge_request.reload

3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729
        expect(closed_merge_request.closed_or_merged_without_fork?).to be_truthy
      end
    end

    context "when the merge request was merged" do
      let(:merged_merge_request) do
        create(:merged_merge_request,
          source_project: forked_project,
          target_project: project)
      end

      it "returns false if the fork exist" do
        expect(merged_merge_request.closed_or_merged_without_fork?).to be_falsey
      end

      it "returns true if the fork does not exist" do
        unlink_project.execute
        merged_merge_request.reload

        expect(merged_merge_request.closed_or_merged_without_fork?).to be_truthy
3730 3731
      end
    end
Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3732

Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3733
    context "when the merge request is open" do
Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3734 3735
      let(:open_merge_request) do
        create(:merge_request,
3736
          source_project: forked_project,
Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3737 3738 3739 3740
          target_project: project)
      end

      it "returns false" do
3741
        expect(open_merge_request.closed_or_merged_without_fork?).to be_falsey
Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3742 3743
      end
    end
3744
  end
3745

3746
  describe '#reopenable?' do
3747 3748 3749
    context 'when the merge request is closed' do
      it 'returns true' do
        subject.close
Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3750

3751
        expect(subject.reopenable?).to be_truthy
3752 3753 3754
      end

      context 'forked project' do
3755
        let(:project)      { create(:project, :public) }
3756
        let(:user)         { create(:user) }
3757
        let(:forked_project) { fork_project(project, user) }
3758 3759

        let!(:merge_request) do
3760
          create(:closed_merge_request,
3761
            source_project: forked_project,
3762 3763 3764 3765
            target_project: project)
        end

        it 'returns false if unforked' do
3766
          Projects::UnlinkForkService.new(forked_project, user).execute
3767

3768
          expect(merge_request.reload.reopenable?).to be_falsey
3769 3770 3771
        end

        it 'returns false if the source project is deleted' do
3772
          Projects::DestroyService.new(forked_project, user).execute
3773

3774
          expect(merge_request.reload.reopenable?).to be_falsey
3775 3776
        end

Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3777
        it 'returns false if the merge request is merged' do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
3778
          merge_request.update(state: 'merged')
3779

3780
          expect(merge_request.reload.reopenable?).to be_falsey
3781 3782
        end
      end
Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3783 3784
    end

Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3785
    context 'when the merge request is opened' do
3786
      it 'returns false' do
3787
        expect(subject.reopenable?).to be_falsey
3788
      end
Katarzyna Kobierska's avatar
Katarzyna Kobierska committed
3789 3790
    end
  end
3791

3792
  describe '#pipeline_coverage_delta' do
3793
    let!(:merge_request) { create(:merge_request) }
3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847

    let!(:source_pipeline) do
      create(:ci_pipeline,
        project: project,
        ref: merge_request.source_branch,
        sha: merge_request.diff_head_sha
      )
    end

    let!(:target_pipeline) do
      create(:ci_pipeline,
        project: project,
        ref: merge_request.target_branch,
        sha: merge_request.diff_base_sha
      )
    end

    def create_build(pipeline, coverage, name)
      create(:ci_build, :success, pipeline: pipeline, coverage: coverage, name: name)
      merge_request.update_head_pipeline
    end

    context 'when both source and target branches have coverage information' do
      it 'returns the appropriate coverage delta' do
        create_build(source_pipeline, 60.2, 'test:1')
        create_build(target_pipeline, 50, 'test:2')

        expect(merge_request.pipeline_coverage_delta).to eq('10.20')
      end
    end

    context 'when target branch does not have coverage information' do
      it 'returns nil' do
        create_build(source_pipeline, 50, 'test:1')

        expect(merge_request.pipeline_coverage_delta).to be_nil
      end
    end

    context 'when source branch does not have coverage information' do
      it 'returns nil for coverage_delta' do
        create_build(target_pipeline, 50, 'test:1')

        expect(merge_request.pipeline_coverage_delta).to be_nil
      end
    end

    context 'neither source nor target branch has coverage information' do
      it 'returns nil for coverage_delta' do
        expect(merge_request.pipeline_coverage_delta).to be_nil
      end
    end
  end

3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928
  describe '#use_merge_base_pipeline_for_comparison?' do
    let(:project) { create(:project, :public, :repository) }
    let(:merge_request) { create(:merge_request, :with_codequality_reports, source_project: project) }

    subject { merge_request.use_merge_base_pipeline_for_comparison?(service_class) }

    context 'when service class is Ci::CompareCodequalityReportsService' do
      let(:service_class) { 'Ci::CompareCodequalityReportsService' }

      context 'when feature flag is enabled' do
        it { is_expected.to be_truthy }
      end

      context 'when feature flag is disabled' do
        before do
          stub_feature_flags(codequality_backend_comparison: false)
        end

        it { is_expected.to be_falsey }
      end
    end

    context 'when service class is different' do
      let(:service_class) { 'Ci::GenerateCoverageReportsService' }

      it { is_expected.to be_falsey }
    end
  end

  describe '#comparison_base_pipeline' do
    subject(:pipeline) { merge_request.comparison_base_pipeline(service_class) }

    let(:project) { create(:project, :public, :repository) }
    let(:merge_request) { create(:merge_request, :with_codequality_reports, source_project: project) }
    let!(:base_pipeline) do
      create(:ci_pipeline,
        :with_test_reports,
        project: project,
        ref: merge_request.target_branch,
        sha: merge_request.diff_base_sha
      )
    end

    context 'when service class is Ci::CompareCodequalityReportsService' do
      let(:service_class) { 'Ci::CompareCodequalityReportsService' }

      context 'when merge request has a merge request pipeline' do
        let(:merge_request) do
          create(:merge_request, :with_merge_request_pipeline)
        end

        let(:merge_base_pipeline) do
          create(:ci_pipeline, ref: merge_request.target_branch, sha: merge_request.target_branch_sha)
        end

        before do
          merge_base_pipeline
          merge_request.update_head_pipeline
        end

        it 'returns the merge_base_pipeline' do
          expect(pipeline).to eq(merge_base_pipeline)
        end
      end

      context 'when merge does not have a merge request pipeline' do
        it 'returns the base_pipeline' do
          expect(pipeline).to eq(base_pipeline)
        end
      end
    end

    context 'when service_class is different' do
      let(:service_class) { 'Ci::GenerateCoverageReportsService' }

      it 'returns the base_pipeline' do
        expect(pipeline).to eq(base_pipeline)
      end
    end
  end

3929 3930 3931 3932 3933 3934 3935 3936 3937
  describe '#base_pipeline' do
    let(:pipeline_arguments) do
      {
        project: project,
        ref: merge_request.target_branch,
        sha: merge_request.diff_base_sha
      }
    end

3938
    let(:project) { create(:project, :public, :repository) }
3939 3940
    let(:merge_request) { create(:merge_request, source_project: project) }

3941 3942 3943
    let!(:first_pipeline) { create(:ci_pipeline, pipeline_arguments) }
    let!(:last_pipeline) { create(:ci_pipeline, pipeline_arguments) }
    let!(:last_pipeline_with_other_ref) { create(:ci_pipeline, pipeline_arguments.merge(ref: 'other')) }
3944

3945
    it 'returns latest pipeline for the target branch' do
3946 3947 3948 3949
      expect(merge_request.base_pipeline).to eq(last_pipeline)
    end
  end

3950 3951 3952 3953 3954
  describe '#merge_base_pipeline' do
    let(:merge_request) do
      create(:merge_request, :with_merge_request_pipeline)
    end

3955
    let(:merge_base_pipeline) do
3956 3957 3958
      create(:ci_pipeline, ref: merge_request.target_branch, sha: merge_request.target_branch_sha)
    end

3959 3960
    before do
      merge_base_pipeline
3961
      merge_request.update_head_pipeline
3962
    end
3963

3964 3965
    it 'returns a pipeline pointing to a commit on the target ref' do
      expect(merge_request.merge_base_pipeline).to eq(merge_base_pipeline)
3966 3967 3968
    end
  end

3969
  describe '#has_commits?' do
3970
    it 'returns true when merge request diff has commits' do
3971 3972
      allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(2)
3973 3974 3975

      expect(subject.has_commits?).to be_truthy
    end
3976 3977 3978 3979 3980 3981 3982 3983 3984

    context 'when commits_count is nil' do
      it 'returns false' do
        allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(nil)

        expect(subject.has_commits?).to be_falsey
      end
    end
3985 3986 3987 3988
  end

  describe '#has_no_commits?' do
    before do
3989 3990
      allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(0)
3991 3992 3993 3994 3995 3996
    end

    it 'returns true when merge request diff has 0 commits' do
      expect(subject.has_no_commits?).to be_truthy
    end
  end
3997 3998

  describe '#merge_request_diff_for' do
3999 4000 4001
    let(:project) { create(:project, :repository) }

    subject { create(:merge_request, importing: true, source_project: project) }
4002

4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'with diff refs' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff1.diff_refs)).to eq(merge_request_diff1)
      end
    end

    context 'with a commit SHA' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff3.head_commit_sha)).to eq(merge_request_diff3)
      end
    end
4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028

    it 'runs a single query on the initial call, and none afterwards' do
      expect { subject.merge_request_diff_for(merge_request_diff1.diff_refs) }
        .not_to exceed_query_limit(1)

      expect { subject.merge_request_diff_for(merge_request_diff2.diff_refs) }
        .not_to exceed_query_limit(0)

      expect { subject.merge_request_diff_for(merge_request_diff3.head_commit_sha) }
        .not_to exceed_query_limit(0)
    end
4029
  end
4030 4031

  describe '#version_params_for' do
4032 4033 4034
    let(:project) { create(:project, :repository) }

    subject { create(:merge_request, importing: true, source_project: project) }
4035

4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'when the diff refs are for an older merge request version' do
      let(:diff_refs) { merge_request_diff1.diff_refs }

      it 'returns the diff ID for the version to show' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff1.id)
      end
    end

    context 'when the diff refs are for a comparison between merge request versions' do
      let(:diff_refs) { merge_request_diff3.compare_with(merge_request_diff1.head_commit_sha).diff_refs }

      it 'returns the diff ID and start sha of the versions to compare' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff3.id, start_sha: merge_request_diff1.head_commit_sha)
      end
    end

    context 'when the diff refs are not for a merge request version' do
      let(:diff_refs) { project.commit(sample_commit.id).diff_refs }

      it 'returns nil' do
        expect(subject.version_params_for(diff_refs)).to be_nil
      end
    end
  end
4064

4065
  describe '#fetch_ref!' do
4066 4067
    let(:project) { create(:project, :repository) }

4068
    subject { create(:merge_request, source_project: project) }
4069

micael.bergeron's avatar
micael.bergeron committed
4070
    it 'fetches the ref correctly' do
4071
      expect { subject.target_project.repository.delete_refs(subject.ref_path) }.not_to raise_error
4072

4073 4074
      subject.fetch_ref!
      expect(subject.target_project.repository.ref_exists?(subject.ref_path)).to be_truthy
4075 4076
    end
  end
4077 4078 4079 4080 4081 4082 4083 4084 4085

  describe 'removing a merge request' do
    it 'refreshes the number of open merge requests of the target project' do
      project = subject.target_project

      expect { subject.destroy }
        .to change { project.open_merge_requests_count }.from(1).to(0)
    end
  end
4086 4087 4088 4089

  it_behaves_like 'throttled touch' do
    subject { create(:merge_request, updated_at: 1.hour.ago) }
  end
4090 4091

  context 'state machine transitions' do
4092 4093
    let(:project) { create(:project, :repository) }

4094
    describe '#unlock_mr' do
4095
      subject { create(:merge_request, state: 'locked', source_project: project, merge_jid: 123) }
4096

4097
      it 'updates merge request head pipeline and sets merge_jid to nil', :sidekiq_might_not_need_inline do
4098 4099 4100 4101 4102 4103 4104 4105 4106
        pipeline = create(:ci_empty_pipeline, project: subject.project, ref: subject.source_branch, sha: subject.source_branch_sha)

        subject.unlock_mr

        subject.reload
        expect(subject.head_pipeline).to eq(pipeline)
        expect(subject.merge_jid).to be_nil
      end
    end
4107 4108 4109 4110

    describe 'transition to cannot_be_merged' do
      let(:notification_service) { double(:notification_service) }
      let(:todo_service) { double(:todo_service) }
4111

4112
      subject { create(:merge_request, state, source_project: project, merge_status: :unchecked) }
4113 4114 4115 4116

      before do
        allow(NotificationService).to receive(:new).and_return(notification_service)
        allow(TodoService).to receive(:new).and_return(todo_service)
4117 4118

        allow(subject.project.repository).to receive(:can_be_merged?).and_return(false)
4119 4120
      end

4121 4122 4123
      [:opened, :locked].each do |state|
        context state do
          let(:state) { state }
4124

4125 4126 4127 4128
          it 'notifies conflict, but does not notify again if rechecking still results in cannot_be_merged' do
            expect(notification_service).to receive(:merge_request_unmergeable).with(subject).once
            expect(todo_service).to receive(:merge_request_became_unmergeable).with(subject).once

4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144
            subject.mark_as_unmergeable!

            subject.mark_as_unchecked!
            subject.mark_as_unmergeable!
          end

          it 'notifies conflict, but does not notify again if rechecking still results in cannot_be_merged with async mergeability check' do
            expect(notification_service).to receive(:merge_request_unmergeable).with(subject).once
            expect(todo_service).to receive(:merge_request_became_unmergeable).with(subject).once

            subject.mark_as_checking!
            subject.mark_as_unmergeable!

            subject.mark_as_unchecked!
            subject.mark_as_checking!
            subject.mark_as_unmergeable!
4145 4146 4147 4148 4149 4150
          end

          it 'notifies conflict, whenever newly unmergeable' do
            expect(notification_service).to receive(:merge_request_unmergeable).with(subject).twice
            expect(todo_service).to receive(:merge_request_became_unmergeable).with(subject).twice

4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173
            subject.mark_as_unmergeable!

            subject.mark_as_unchecked!
            subject.mark_as_mergeable!

            subject.mark_as_unchecked!
            subject.mark_as_unmergeable!
          end

          it 'notifies conflict, whenever newly unmergeable with async mergeability check' do
            expect(notification_service).to receive(:merge_request_unmergeable).with(subject).twice
            expect(todo_service).to receive(:merge_request_became_unmergeable).with(subject).twice

            subject.mark_as_checking!
            subject.mark_as_unmergeable!

            subject.mark_as_unchecked!
            subject.mark_as_checking!
            subject.mark_as_mergeable!

            subject.mark_as_unchecked!
            subject.mark_as_checking!
            subject.mark_as_unmergeable!
4174 4175 4176 4177
          end

          it 'does not notify whenever merge request is newly unmergeable due to other reasons' do
            allow(subject.project.repository).to receive(:can_be_merged?).and_return(true)
4178

4179 4180
            expect(notification_service).not_to receive(:merge_request_unmergeable)
            expect(todo_service).not_to receive(:merge_request_became_unmergeable)
4181

4182
            subject.mark_as_unmergeable!
4183 4184
          end
        end
4185
      end
4186

4187 4188
      [:closed, :merged].each do |state|
        let(:state) { state }
4189

4190 4191 4192 4193
        context state do
          it 'does not notify' do
            expect(notification_service).not_to receive(:merge_request_unmergeable)
            expect(todo_service).not_to receive(:merge_request_became_unmergeable)
4194

4195
            subject.mark_as_unmergeable!
4196 4197
          end
        end
4198
      end
4199 4200

      context 'source branch is missing' do
4201
        subject { create(:merge_request, :invalid, :opened, source_project: project, merge_status: :unchecked, target_branch: 'master') }
4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214

        before do
          allow(subject.project.repository).to receive(:can_be_merged?).and_call_original
        end

        it 'does not raise error' do
          expect(notification_service).not_to receive(:merge_request_unmergeable)
          expect(todo_service).not_to receive(:merge_request_became_unmergeable)

          expect { subject.mark_as_unmergeable }.not_to raise_error
          expect(subject.cannot_be_merged?).to eq(true)
        end
      end
4215 4216 4217 4218 4219
    end

    describe 'check_state?' do
      it 'indicates whether MR is still checking for mergeability' do
        state_machine = described_class.state_machines[:merge_status]
4220
        check_states = [:unchecked, :cannot_be_merged_recheck, :cannot_be_merged_rechecking, :checking]
4221 4222 4223 4224 4225 4226 4227 4228 4229 4230

        check_states.each do |merge_status|
          expect(state_machine.check_state?(merge_status)).to be true
        end

        (state_machine.states.map(&:name) - check_states).each do |merge_status|
          expect(state_machine.check_state?(merge_status)).to be false
        end
      end
    end
4231
  end
4232 4233 4234

  describe '#should_be_rebased?' do
    it 'returns false for the same source and target branches' do
4235
      merge_request = build_stubbed(:merge_request, source_project: project, target_project: project)
4236 4237 4238 4239 4240 4241

      expect(merge_request.should_be_rebased?).to be_falsey
    end
  end

  describe '#rebase_in_progress?' do
4242 4243 4244 4245 4246 4247
    where(:rebase_jid, :jid_valid, :result) do
      'foo' | true  | true
      'foo' | false | false
      ''    | true  | false
      nil   | true  | false
    end
4248

4249
    with_them do
4250
      let(:merge_request) { build_stubbed(:merge_request) }
4251 4252 4253 4254 4255 4256 4257 4258 4259

      subject { merge_request.rebase_in_progress? }

      it do
        allow(Gitlab::SidekiqStatus).to receive(:running?).with(rebase_jid) { jid_valid }

        merge_request.rebase_jid = rebase_jid

        is_expected.to eq(result)
4260
      end
4261 4262
    end
  end
4263

4264
  describe '#allow_collaboration' do
4265
    let(:merge_request) do
4266
      build(:merge_request, source_branch: 'fixes', allow_collaboration: true)
4267 4268 4269
    end

    it 'is false when pushing by a maintainer is not possible' do
4270
      expect(merge_request).to receive(:collaborative_push_possible?) { false }
4271

4272
      expect(merge_request.allow_collaboration).to be_falsy
4273 4274 4275
    end

    it 'is true when pushing by a maintainer is possible' do
4276
      expect(merge_request).to receive(:collaborative_push_possible?) { true }
4277

4278
      expect(merge_request.allow_collaboration).to be_truthy
4279 4280 4281
    end
  end

4282
  describe '#collaborative_push_possible?' do
4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293
    let(:merge_request) do
      build(:merge_request, source_branch: 'fixes')
    end

    before do
      allow(ProtectedBranch).to receive(:protected?) { false }
    end

    it 'does not allow maintainer to push if the source project is the same as the target' do
      merge_request.target_project = merge_request.source_project = create(:project, :public)

4294
      expect(merge_request.collaborative_push_possible?).to be_falsy
4295 4296 4297 4298 4299 4300
    end

    it 'allows maintainer to push when both source and target are public' do
      merge_request.target_project = build(:project, :public)
      merge_request.source_project = build(:project, :public)

4301
      expect(merge_request.collaborative_push_possible?).to be_truthy
4302 4303 4304 4305 4306 4307 4308 4309 4310 4311
    end

    it 'is not available for protected branches' do
      merge_request.target_project = build(:project, :public)
      merge_request.source_project = build(:project, :public)

      expect(ProtectedBranch).to receive(:protected?)
                                   .with(merge_request.source_project, 'fixes')
                                   .and_return(true)

4312
      expect(merge_request.collaborative_push_possible?).to be_falsy
4313 4314 4315
    end
  end

4316
  describe '#can_allow_collaboration?' do
4317 4318 4319 4320 4321 4322 4323 4324
    let(:target_project) { create(:project, :public) }
    let(:source_project) { fork_project(target_project) }
    let(:merge_request) do
      create(:merge_request,
             source_project: source_project,
             source_branch: 'fixes',
             target_project: target_project)
    end
4325

4326 4327 4328
    let(:user) { create(:user) }

    before do
4329
      allow(merge_request).to receive(:collaborative_push_possible?) { true }
4330 4331 4332
    end

    it 'is false if the user does not have push access to the source project' do
4333
      expect(merge_request.can_allow_collaboration?(user)).to be_falsy
4334 4335 4336 4337 4338
    end

    it 'is true when the user has push access to the source project' do
      source_project.add_developer(user)

4339
      expect(merge_request.can_allow_collaboration?(user)).to be_truthy
4340 4341
    end
  end
4342 4343 4344

  describe '#merge_participants' do
    it 'contains author' do
4345
      expect(subject.merge_participants).to contain_exactly(subject.author)
4346 4347 4348 4349 4350
    end

    describe 'when merge_when_pipeline_succeeds? is true' do
      describe 'when merge user is author' do
        let(:user) { create(:user) }
4351

4352 4353 4354 4355 4356 4357 4358
        subject do
          create(:merge_request,
                 merge_when_pipeline_succeeds: true,
                 merge_user: user,
                 author: user)
        end

4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372
        context 'author is not a project member' do
          it 'is empty' do
            expect(subject.merge_participants).to be_empty
          end
        end

        context 'author is a project member' do
          before do
            subject.project.team.add_reporter(user)
          end

          it 'contains author only' do
            expect(subject.merge_participants).to contain_exactly(subject.author)
          end
4373 4374 4375 4376 4377
        end
      end

      describe 'when merge user and author are different users' do
        let(:merge_user) { create(:user) }
4378

4379 4380 4381 4382 4383 4384
        subject do
          create(:merge_request,
                 merge_when_pipeline_succeeds: true,
                 merge_user: merge_user)
        end

4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402
        before do
          subject.project.team.add_reporter(subject.author)
        end

        context 'merge user is not a member' do
          it 'contains author only' do
            expect(subject.merge_participants).to contain_exactly(subject.author)
          end
        end

        context 'both author and merge users are project members' do
          before do
            subject.project.team.add_reporter(merge_user)
          end

          it 'contains author and merge user' do
            expect(subject.merge_participants).to contain_exactly(subject.author, merge_user)
          end
4403 4404 4405 4406
        end
      end
    end
  end
4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434

  describe '.merge_request_ref?' do
    subject { described_class.merge_request_ref?(ref) }

    context 'when ref is ref name of a branch' do
      let(:ref) { 'feature' }

      it { is_expected.to be_falsey }
    end

    context 'when ref is HEAD ref path of a branch' do
      let(:ref) { 'refs/heads/feature' }

      it { is_expected.to be_falsey }
    end

    context 'when ref is HEAD ref path of a merge request' do
      let(:ref) { 'refs/merge-requests/1/head' }

      it { is_expected.to be_truthy }
    end

    context 'when ref is merge ref path of a merge request' do
      let(:ref) { 'refs/merge-requests/1/merge' }

      it { is_expected.to be_truthy }
    end
  end
4435

4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469
  describe '.merge_train_ref?' do
    subject { described_class.merge_train_ref?(ref) }

    context 'when ref is ref name of a branch' do
      let(:ref) { 'feature' }

      it { is_expected.to be_falsey }
    end

    context 'when ref is HEAD ref path of a branch' do
      let(:ref) { 'refs/heads/feature' }

      it { is_expected.to be_falsey }
    end

    context 'when ref is HEAD ref path of a merge request' do
      let(:ref) { 'refs/merge-requests/1/head' }

      it { is_expected.to be_falsey }
    end

    context 'when ref is merge ref path of a merge request' do
      let(:ref) { 'refs/merge-requests/1/merge' }

      it { is_expected.to be_falsey }
    end

    context 'when ref is train ref path of a merge request' do
      let(:ref) { 'refs/merge-requests/1/train' }

      it { is_expected.to be_truthy }
    end
  end

4470 4471 4472
  describe '#cleanup_refs' do
    subject { merge_request.cleanup_refs(only: only) }

4473
    let(:merge_request) { build(:merge_request, source_project: create(:project, :repository)) }
4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498

    context 'when removing all refs' do
      let(:only) { :all }

      it 'deletes all refs from the target project' do
        expect(merge_request.target_project.repository)
          .to receive(:delete_refs)
          .with(merge_request.ref_path, merge_request.merge_ref_path, merge_request.train_ref_path)

        subject
      end
    end

    context 'when removing only train ref' do
      let(:only) { :train }

      it 'deletes train ref from the target project' do
        expect(merge_request.target_project.repository)
          .to receive(:delete_refs)
          .with(merge_request.train_ref_path)

        subject
      end
    end
  end
4499

4500
  describe '.with_auto_merge_enabled' do
4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519
    let!(:project) { create(:project) }
    let!(:fork) { fork_project(project) }
    let!(:merge_request1) do
      create(:merge_request,
             :merge_when_pipeline_succeeds,
             target_project: project,
             target_branch: 'master',
             source_project: project,
             source_branch: 'feature-1')
    end

    let!(:merge_request4) do
      create(:merge_request,
             target_project: project,
             target_branch: 'master',
             source_project: fork,
             source_branch: 'fork-feature-2')
    end

4520
    let(:query) { described_class.with_auto_merge_enabled }
4521

4522
    it { expect(query).to contain_exactly(merge_request1) }
4523
  end
4524 4525

  it_behaves_like 'versioned description'
4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588

  describe '#commits' do
    context 'persisted merge request' do
      context 'with a limit' do
        it 'returns a limited number of commits' do
          expect(subject.commits(limit: 2).map(&:sha)).to eq(%w[
            b83d6e391c22777fca1ed3012fce84f633d7fed0
            498214de67004b1da3d820901307bed2a68a8ef6
          ])
          expect(subject.commits(limit: 3).map(&:sha)).to eq(%w[
            b83d6e391c22777fca1ed3012fce84f633d7fed0
            498214de67004b1da3d820901307bed2a68a8ef6
            1b12f15a11fc6e62177bef08f47bc7b5ce50b141
          ])
        end
      end

      context 'without a limit' do
        it 'returns all commits of the merge request diff' do
          expect(subject.commits.size).to eq(29)
        end
      end
    end

    context 'new merge request' do
      subject { build(:merge_request) }

      context 'compare commits' do
        let(:first_commit) { double }
        let(:second_commit) { double }

        before do
          subject.compare_commits = [
            first_commit, second_commit
          ]
        end

        context 'without a limit' do
          it 'returns all the compare commits' do
            expect(subject.commits.to_a).to eq([second_commit, first_commit])
          end
        end

        context 'with a limit' do
          it 'returns a limited number of commits' do
            expect(subject.commits(limit: 1).to_a).to eq([second_commit])
          end
        end
      end
    end
  end

  describe '#recent_commits' do
    before do
      stub_const("#{MergeRequestDiff}::COMMITS_SAFE_SIZE", 2)
    end

    it 'returns the safe number of commits' do
      expect(subject.recent_commits.map(&:sha)).to eq(%w[
        b83d6e391c22777fca1ed3012fce84f633d7fed0 498214de67004b1da3d820901307bed2a68a8ef6
      ])
    end
  end
4589 4590 4591 4592 4593

  describe '#recent_visible_deployments' do
    let(:merge_request) { create(:merge_request) }

    it 'returns visible deployments' do
4594 4595
      envs = create_list(:environment, 3, project: merge_request.target_project)

4596 4597 4598 4599
      created = create(
        :deployment,
        :created,
        project: merge_request.target_project,
4600
        environment: envs[0]
4601 4602 4603 4604 4605 4606
      )

      success = create(
        :deployment,
        :success,
        project: merge_request.target_project,
4607
        environment: envs[1]
4608 4609 4610 4611 4612 4613
      )

      failed = create(
        :deployment,
        :failed,
        project: merge_request.target_project,
4614
        environment: envs[2]
4615 4616
      )

4617 4618 4619 4620
      merge_request_relation = MergeRequest.where(id: merge_request.id)
      created.link_merge_requests(merge_request_relation)
      success.link_merge_requests(merge_request_relation)
      failed.link_merge_requests(merge_request_relation)
4621 4622 4623 4624 4625 4626

      expect(merge_request.recent_visible_deployments).to eq([failed, success])
    end

    it 'only returns a limited number of deployments' do
      20.times do
4627
        environment = create(:environment, project: merge_request.target_project)
4628 4629 4630 4631 4632 4633 4634
        deploy = create(
          :deployment,
          :success,
          project: merge_request.target_project,
          environment: environment
        )

4635
        deploy.link_merge_requests(MergeRequest.where(id: merge_request.id))
4636 4637 4638 4639 4640
      end

      expect(merge_request.recent_visible_deployments.count).to eq(10)
    end
  end
4641 4642

  describe '#diffable_merge_ref?' do
4643 4644
    let(:merge_request) { create(:merge_request) }

4645
    context 'merge request can be merged' do
4646
      context 'merge_head diff is not created' do
4647
        it 'returns true' do
4648
          expect(merge_request.diffable_merge_ref?).to eq(false)
4649 4650 4651
        end
      end

4652
      context 'merge_head diff is created' do
4653
        before do
4654
          create(:merge_request_diff, :merge_head, merge_request: merge_request)
4655
        end
4656

4657
        it 'returns true' do
4658
          expect(merge_request.diffable_merge_ref?).to eq(true)
4659 4660
        end

4661
        context 'merge request is merged' do
4662 4663 4664
          before do
            merge_request.mark_as_merged!
          end
4665 4666

          it 'returns false' do
4667
            expect(merge_request.diffable_merge_ref?).to eq(false)
4668 4669 4670
          end
        end

4671 4672
        context 'merge request cannot be merged' do
          before do
4673
            merge_request.mark_as_unchecked!
4674 4675 4676
          end

          it 'returns false' do
4677
            expect(merge_request.diffable_merge_ref?).to eq(true)
4678 4679 4680 4681 4682 4683
          end

          context 'display_merge_conflicts_in_diff is disabled' do
            before do
              stub_feature_flags(display_merge_conflicts_in_diff: false)
            end
4684

4685
            it 'returns false' do
4686
              expect(merge_request.diffable_merge_ref?).to eq(false)
4687 4688 4689
            end
          end
        end
4690 4691 4692
      end
    end
  end
4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706

  describe '#predefined_variables' do
    let(:merge_request) { create(:merge_request) }

    it 'caches all SQL-sourced data on the first call' do
      control = ActiveRecord::QueryRecorder.new { merge_request.predefined_variables }.count

      expect(control).to be > 0

      count = ActiveRecord::QueryRecorder.new { merge_request.predefined_variables }.count

      expect(count).to eq(0)
    end
  end
4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717

  describe 'banzai_render_context' do
    let(:project) { build(:project_empty_repo) }
    let(:merge_request) { build :merge_request, target_project: project, source_project: project }

    subject(:context) { merge_request.banzai_render_context(:title) }

    it 'sets the label_url_method in the context' do
      expect(context[:label_url_method]).to eq(:project_merge_requests_url)
    end
  end
4718

4719
  describe '#head_pipeline_builds_with_coverage' do
4720 4721
    it 'delegates to head_pipeline' do
      expect(subject)
4722 4723 4724 4725
        .to delegate_method(:builds_with_coverage)
        .to(:head_pipeline)
        .with_prefix
        .with_arguments(allow_nil: true)
4726 4727
    end
  end
4728

Patrick Bajao's avatar
Patrick Bajao committed
4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753
  describe '#merge_ref_head' do
    let(:merge_request) { create(:merge_request) }

    context 'when merge_ref_sha is not present' do
      let!(:result) do
        MergeRequests::MergeToRefService
          .new(merge_request.project, merge_request.author)
          .execute(merge_request)
      end

      it 'returns the commit based on merge ref path' do
        expect(merge_request.merge_ref_head.id).to eq(result[:commit_id])
      end
    end

    context 'when merge_ref_sha is present' do
      before do
        merge_request.update!(merge_ref_sha: merge_request.project.repository.commit.id)
      end

      it 'returns the commit based on cached merge_ref_sha' do
        expect(merge_request.merge_ref_head.id).to eq(merge_request.merge_ref_sha)
      end
    end
  end
4754 4755

  describe '#allows_reviewers?' do
4756
    it 'returns true' do
4757 4758 4759 4760 4761
      merge_request = build_stubbed(:merge_request)

      expect(merge_request.allows_reviewers?).to be(true)
    end
  end
4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775

  describe '#update_and_mark_in_progress_merge_commit_sha' do
    let(:ref) { subject.target_project.repository.commit.id }

    before do
      expect(subject.target_project).to receive(:mark_primary_write_location)
    end

    it 'updates commit ID' do
      expect { subject.update_and_mark_in_progress_merge_commit_sha(ref) }
        .to change { subject.in_progress_merge_commit_sha }
        .from(nil).to(ref)
    end
  end
4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805

  describe '#enabled_reports' do
    let(:project) { create(:project, :repository) }

    where(:report_type, :with_reports, :feature) do
      :sast                | :with_sast_reports                | :sast
      :secret_detection    | :with_secret_detection_reports    | :secret_detection
    end

    with_them do
      subject { merge_request.enabled_reports[report_type] }

      before do
        stub_feature_flags(drop_license_management_artifact: false)
        stub_licensed_features({ feature => true })
      end

      context "when head pipeline has reports" do
        let(:merge_request) { create(:merge_request, with_reports, source_project: project) }

        it { is_expected.to be_truthy }
      end

      context "when head pipeline does not have reports" do
        let(:merge_request) { create(:merge_request, source_project: project) }

        it { is_expected.to be_falsy }
      end
    end
  end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
4806
end