repository_spec.rb 82.5 KB
Newer Older
1
# coding: utf-8
Robert Speicher's avatar
Robert Speicher committed
2 3 4
require "spec_helper"

describe Gitlab::Git::Repository, seed_helper: true do
5
  include Gitlab::EncodingHelper
6
  using RSpec::Parameterized::TableSyntax
Robert Speicher's avatar
Robert Speicher committed
7

8 9 10 11 12 13 14 15 16 17 18 19 20 21
  shared_examples 'wrapping gRPC errors' do |gitaly_client_class, gitaly_client_method|
    it 'wraps gRPC not found error' do
      expect_any_instance_of(gitaly_client_class).to receive(gitaly_client_method)
        .and_raise(GRPC::NotFound)
      expect { subject }.to raise_error(Gitlab::Git::Repository::NoRepository)
    end

    it 'wraps gRPC unknown error' do
      expect_any_instance_of(gitaly_client_class).to receive(gitaly_client_method)
        .and_raise(GRPC::Unknown)
      expect { subject }.to raise_error(Gitlab::Git::CommandError)
    end
  end

22
  let(:repository) { Gitlab::Git::Repository.new('default', TEST_REPO_PATH, '') }
23
  let(:storage_path) { TestEnv.repos_path }
24
  let(:user) { build(:user) }
Robert Speicher's avatar
Robert Speicher committed
25

26
  describe '.create_hooks' do
27
    let(:repo_path) { File.join(storage_path, 'hook-test.git') }
28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70
    let(:hooks_dir) { File.join(repo_path, 'hooks') }
    let(:target_hooks_dir) { Gitlab.config.gitlab_shell.hooks_path }
    let(:existing_target) { File.join(repo_path, 'foobar') }

    before do
      FileUtils.rm_rf(repo_path)
      FileUtils.mkdir_p(repo_path)
    end

    context 'hooks is a directory' do
      let(:existing_file) { File.join(hooks_dir, 'my-file') }

      before do
        FileUtils.mkdir_p(hooks_dir)
        FileUtils.touch(existing_file)
        described_class.create_hooks(repo_path, target_hooks_dir)
      end

      it { expect(File.readlink(hooks_dir)).to eq(target_hooks_dir) }
      it { expect(Dir[File.join(repo_path, "hooks.old.*/my-file")].count).to eq(1) }
    end

    context 'hooks is a valid symlink' do
      before do
        FileUtils.mkdir_p existing_target
        File.symlink(existing_target, hooks_dir)
        described_class.create_hooks(repo_path, target_hooks_dir)
      end

      it { expect(File.readlink(hooks_dir)).to eq(target_hooks_dir) }
    end

    context 'hooks is a broken symlink' do
      before do
        FileUtils.rm_f(existing_target)
        File.symlink(existing_target, hooks_dir)
        described_class.create_hooks(repo_path, target_hooks_dir)
      end

      it { expect(File.readlink(hooks_dir)).to eq(target_hooks_dir) }
    end
  end

Robert Speicher's avatar
Robert Speicher committed
71 72 73 74 75 76 77 78
  describe "Respond to" do
    subject { repository }

    it { is_expected.to respond_to(:rugged) }
    it { is_expected.to respond_to(:root_ref) }
    it { is_expected.to respond_to(:tags) }
  end

79 80
  describe '#root_ref' do
    context 'with gitaly disabled' do
81 82 83
      before do
        allow(Gitlab::GitalyClient).to receive(:feature_enabled?).and_return(false)
      end
84 85 86 87 88 89 90

      it 'calls #discover_default_branch' do
        expect(repository).to receive(:discover_default_branch)
        repository.root_ref
      end
    end

91
    it 'returns UTF-8' do
92
      expect(repository.root_ref).to be_utf8
93 94
    end

95
    it 'gets the branch name from GitalyClient' do
Andrew Newdigate's avatar
Andrew Newdigate committed
96
      expect_any_instance_of(Gitlab::GitalyClient::RefService).to receive(:default_branch_name)
97 98
      repository.root_ref
    end
99

Andrew Newdigate's avatar
Andrew Newdigate committed
100
    it_behaves_like 'wrapping gRPC errors', Gitlab::GitalyClient::RefService, :default_branch_name do
101
      subject { repository.root_ref }
102
    end
103 104
  end

105
  describe "#rugged" do
106
    describe 'when storage is broken', :broken_storage  do
107
      it 'raises a storage exception when storage is not available' do
108
        broken_repo = described_class.new('broken', 'a/path.git', '')
109 110 111 112 113 114

        expect { broken_repo.rugged }.to raise_error(Gitlab::Git::Storage::Inaccessible)
      end
    end

    it 'raises a no repository exception when there is no repo' do
115
      broken_repo = described_class.new('default', 'a/path.git', '')
116 117 118 119

      expect { broken_repo.rugged }.to raise_error(Gitlab::Git::Repository::NoRepository)
    end

120 121 122
    describe 'alternates keyword argument' do
      context 'with no Git env stored' do
        before do
123
          allow(Gitlab::Git::HookEnv).to receive(:all).and_return({})
124
        end
125

126 127
        it "is passed an empty array" do
          expect(Rugged::Repository).to receive(:new).with(repository.path, alternates: [])
128

129 130
          repository.rugged
        end
131 132
      end

133 134
      context 'with absolute and relative Git object dir envvars stored' do
        before do
135
          allow(Gitlab::Git::HookEnv).to receive(:all).and_return({
136 137 138
            'GIT_OBJECT_DIRECTORY_RELATIVE' => './objects/foo',
            'GIT_ALTERNATE_OBJECT_DIRECTORIES_RELATIVE' => ['./objects/bar', './objects/baz'],
            'GIT_OBJECT_DIRECTORY' => 'ignored',
139
            'GIT_ALTERNATE_OBJECT_DIRECTORIES' => %w[ignored ignored],
140 141 142 143 144 145 146 147 148 149
            'GIT_OTHER' => 'another_env'
          })
        end

        it "is passed the relative object dir envvars after being converted to absolute ones" do
          alternates = %w[foo bar baz].map { |d| File.join(repository.path, './objects', d) }
          expect(Rugged::Repository).to receive(:new).with(repository.path, alternates: alternates)

          repository.rugged
        end
150 151 152 153
      end
    end
  end

Robert Speicher's avatar
Robert Speicher committed
154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186
  describe "#discover_default_branch" do
    let(:master) { 'master' }
    let(:feature) { 'feature' }
    let(:feature2) { 'feature2' }

    it "returns 'master' when master exists" do
      expect(repository).to receive(:branch_names).at_least(:once).and_return([feature, master])
      expect(repository.discover_default_branch).to eq('master')
    end

    it "returns non-master when master exists but default branch is set to something else" do
      File.write(File.join(repository.path, 'HEAD'), 'ref: refs/heads/feature')
      expect(repository).to receive(:branch_names).at_least(:once).and_return([feature, master])
      expect(repository.discover_default_branch).to eq('feature')
      File.write(File.join(repository.path, 'HEAD'), 'ref: refs/heads/master')
    end

    it "returns a non-master branch when only one exists" do
      expect(repository).to receive(:branch_names).at_least(:once).and_return([feature])
      expect(repository.discover_default_branch).to eq('feature')
    end

    it "returns a non-master branch when more than one exists and master does not" do
      expect(repository).to receive(:branch_names).at_least(:once).and_return([feature, feature2])
      expect(repository.discover_default_branch).to eq('feature')
    end

    it "returns nil when no branch exists" do
      expect(repository).to receive(:branch_names).at_least(:once).and_return([])
      expect(repository.discover_default_branch).to be_nil
    end
  end

187
  describe '#branch_names' do
Robert Speicher's avatar
Robert Speicher committed
188 189 190 191 192
    subject { repository.branch_names }

    it 'has SeedRepo::Repo::BRANCHES.size elements' do
      expect(subject.size).to eq(SeedRepo::Repo::BRANCHES.size)
    end
193 194

    it 'returns UTF-8' do
195
      expect(subject.first).to be_utf8
196 197
    end

Robert Speicher's avatar
Robert Speicher committed
198 199
    it { is_expected.to include("master") }
    it { is_expected.not_to include("branch-from-space") }
200

201
    it 'gets the branch names from GitalyClient' do
Andrew Newdigate's avatar
Andrew Newdigate committed
202
      expect_any_instance_of(Gitlab::GitalyClient::RefService).to receive(:branch_names)
203 204
      subject
    end
205

Andrew Newdigate's avatar
Andrew Newdigate committed
206
    it_behaves_like 'wrapping gRPC errors', Gitlab::GitalyClient::RefService, :branch_names
Robert Speicher's avatar
Robert Speicher committed
207 208
  end

209
  describe '#tag_names' do
Robert Speicher's avatar
Robert Speicher committed
210 211 212
    subject { repository.tag_names }

    it { is_expected.to be_kind_of Array }
213

Robert Speicher's avatar
Robert Speicher committed
214 215 216 217
    it 'has SeedRepo::Repo::TAGS.size elements' do
      expect(subject.size).to eq(SeedRepo::Repo::TAGS.size)
    end

218
    it 'returns UTF-8' do
219
      expect(subject.first).to be_utf8
220 221
    end

Robert Speicher's avatar
Robert Speicher committed
222 223 224 225 226 227
    describe '#last' do
      subject { super().last }
      it { is_expected.to eq("v1.2.1") }
    end
    it { is_expected.to include("v1.0.0") }
    it { is_expected.not_to include("v5.0.0") }
228

229
    it 'gets the tag names from GitalyClient' do
Andrew Newdigate's avatar
Andrew Newdigate committed
230
      expect_any_instance_of(Gitlab::GitalyClient::RefService).to receive(:tag_names)
231 232
      subject
    end
233

Andrew Newdigate's avatar
Andrew Newdigate committed
234
    it_behaves_like 'wrapping gRPC errors', Gitlab::GitalyClient::RefService, :tag_names
Robert Speicher's avatar
Robert Speicher committed
235 236
  end

237 238 239
  describe '#archive_metadata' do
    let(:storage_path) { '/tmp' }
    let(:cache_key) { File.join(repository.gl_repository, SeedRepo::LastCommit::ID) }
Robert Speicher's avatar
Robert Speicher committed
240

241 242 243
    let(:append_sha) { true }
    let(:ref) { 'master' }
    let(:format) { nil }
244

245 246 247 248
    let(:expected_extension) { 'tar.gz' }
    let(:expected_filename) { "#{expected_prefix}.#{expected_extension}" }
    let(:expected_path) { File.join(storage_path, cache_key, expected_filename) }
    let(:expected_prefix) { "gitlab-git-test-#{ref}-#{SeedRepo::LastCommit::ID}" }
249

250
    subject(:metadata) { repository.archive_metadata(ref, storage_path, format, append_sha: append_sha) }
251

252 253
    it 'sets CommitId to the commit SHA' do
      expect(metadata['CommitId']).to eq(SeedRepo::LastCommit::ID)
254
    end
255

256 257
    it 'sets ArchivePrefix to the expected prefix' do
      expect(metadata['ArchivePrefix']).to eq(expected_prefix)
258
    end
259

260 261 262 263
    it 'sets ArchivePath to the expected globally-unique path' do
      # This is really important from a security perspective. Think carefully
      # before changing it: https://gitlab.com/gitlab-org/gitlab-ce/issues/45689
      expect(expected_path).to include(File.join(repository.gl_repository, SeedRepo::LastCommit::ID))
Robert Speicher's avatar
Robert Speicher committed
264

265 266
      expect(metadata['ArchivePath']).to eq(expected_path)
    end
Robert Speicher's avatar
Robert Speicher committed
267

268 269 270
    context 'append_sha varies archive path and filename' do
      where(:append_sha, :ref, :expected_prefix) do
        sha = SeedRepo::LastCommit::ID
Robert Speicher's avatar
Robert Speicher committed
271

272 273 274 275 276 277 278
        true  | 'master' | "gitlab-git-test-master-#{sha}"
        true  | sha      | "gitlab-git-test-#{sha}-#{sha}"
        false | 'master' | "gitlab-git-test-master"
        false | sha      | "gitlab-git-test-#{sha}"
        nil   | 'master' | "gitlab-git-test-master-#{sha}"
        nil   | sha      | "gitlab-git-test-#{sha}"
      end
Robert Speicher's avatar
Robert Speicher committed
279

280 281 282 283 284
      with_them do
        it { expect(metadata['ArchivePrefix']).to eq(expected_prefix) }
        it { expect(metadata['ArchivePath']).to eq(expected_path) }
      end
    end
Robert Speicher's avatar
Robert Speicher committed
285

286 287 288 289 290 291 292
    context 'format varies archive path and filename' do
      where(:format, :expected_extension) do
        nil      | 'tar.gz'
        'madeup' | 'tar.gz'
        'tbz2'   | 'tar.bz2'
        'zip'    | 'zip'
      end
Robert Speicher's avatar
Robert Speicher committed
293

294 295 296 297 298
      with_them do
        it { expect(metadata['ArchivePrefix']).to eq(expected_prefix) }
        it { expect(metadata['ArchivePath']).to eq(expected_path) }
      end
    end
Robert Speicher's avatar
Robert Speicher committed
299 300
  end

301
  describe '#size' do
Robert Speicher's avatar
Robert Speicher committed
302 303 304 305 306
    subject { repository.size }

    it { is_expected.to be < 2 }
  end

307
  describe '#empty?' do
308
    it { expect(repository).not_to be_empty }
Robert Speicher's avatar
Robert Speicher committed
309 310
  end

311
  describe '#ref_names' do
Robert Speicher's avatar
Robert Speicher committed
312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327
    let(:ref_names) { repository.ref_names }
    subject { ref_names }

    it { is_expected.to be_kind_of Array }

    describe '#first' do
      subject { super().first }
      it { is_expected.to eq('feature') }
    end

    describe '#last' do
      subject { super().last }
      it { is_expected.to eq('v1.2.1') }
    end
  end

328
  describe '#submodule_url_for' do
329
    let(:repository) { Gitlab::Git::Repository.new('default', TEST_REPO_PATH, '') }
330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352
    let(:ref) { 'master' }

    def submodule_url(path)
      repository.submodule_url_for(ref, path)
    end

    it { expect(submodule_url('six')).to eq('git://github.com/randx/six.git') }
    it { expect(submodule_url('nested/six')).to eq('git://github.com/randx/six.git') }
    it { expect(submodule_url('deeper/nested/six')).to eq('git://github.com/randx/six.git') }
    it { expect(submodule_url('invalid/path')).to eq(nil) }

    context 'uncommitted submodule dir' do
      let(:ref) { 'fix-existing-submodule-dir' }

      it { expect(submodule_url('submodule-existing-dir')).to eq(nil) }
    end

    context 'tags' do
      let(:ref) { 'v1.2.1' }

      it { expect(submodule_url('six')).to eq('git://github.com/randx/six.git') }
    end

353 354 355 356 357 358 359
    context 'no .gitmodules at commit' do
      let(:ref) { '9596bc54a6f0c0c98248fe97077eb5ccf48a98d0' }

      it { expect(submodule_url('six')).to eq(nil) }
    end

    context 'no gitlink entry' do
360 361 362 363 364 365
      let(:ref) { '6d39438' }

      it { expect(submodule_url('six')).to eq(nil) }
    end
  end

366
  context '#submodules' do
367
    let(:repository) { Gitlab::Git::Repository.new('default', TEST_REPO_PATH, '') }
Robert Speicher's avatar
Robert Speicher committed
368 369

    context 'where repo has submodules' do
370
      let(:submodules) { repository.send(:submodules, 'master') }
Robert Speicher's avatar
Robert Speicher committed
371 372 373 374 375 376 377 378 379
      let(:submodule) { submodules.first }

      it { expect(submodules).to be_kind_of Hash }
      it { expect(submodules.empty?).to be_falsey }

      it 'should have valid data' do
        expect(submodule).to eq([
          "six", {
            "id" => "409f37c4f05865e4fb208c771485f211a22c4c2d",
380
            "name" => "six",
Robert Speicher's avatar
Robert Speicher committed
381 382 383 384 385 386 387
            "url" => "git://github.com/randx/six.git"
          }
        ])
      end

      it 'should handle nested submodules correctly' do
        nested = submodules['nested/six']
388
        expect(nested['name']).to eq('nested/six')
Robert Speicher's avatar
Robert Speicher committed
389 390 391 392 393 394
        expect(nested['url']).to eq('git://github.com/randx/six.git')
        expect(nested['id']).to eq('24fb71c79fcabc63dfd8832b12ee3bf2bf06b196')
      end

      it 'should handle deeply nested submodules correctly' do
        nested = submodules['deeper/nested/six']
395
        expect(nested['name']).to eq('deeper/nested/six')
Robert Speicher's avatar
Robert Speicher committed
396 397 398 399 400 401 402 403 404
        expect(nested['url']).to eq('git://github.com/randx/six.git')
        expect(nested['id']).to eq('24fb71c79fcabc63dfd8832b12ee3bf2bf06b196')
      end

      it 'should not have an entry for an invalid submodule' do
        expect(submodules).not_to have_key('invalid/path')
      end

      it 'should not have an entry for an uncommited submodule dir' do
405
        submodules = repository.send(:submodules, 'fix-existing-submodule-dir')
Robert Speicher's avatar
Robert Speicher committed
406 407 408 409
        expect(submodules).not_to have_key('submodule-existing-dir')
      end

      it 'should handle tags correctly' do
410
        submodules = repository.send(:submodules, 'v1.2.1')
Robert Speicher's avatar
Robert Speicher committed
411 412 413 414

        expect(submodules.first).to eq([
          "six", {
            "id" => "409f37c4f05865e4fb208c771485f211a22c4c2d",
415
            "name" => "six",
Robert Speicher's avatar
Robert Speicher committed
416 417 418 419
            "url" => "git://github.com/randx/six.git"
          }
        ])
      end
420 421 422 423 424 425 426 427 428 429 430 431 432

      it 'should not break on invalid syntax' do
        allow(repository).to receive(:blob_content).and_return(<<-GITMODULES.strip_heredoc)
          [submodule "six"]
          path = six
          url = git://github.com/randx/six.git

          [submodule]
          foo = bar
        GITMODULES

        expect(submodules).to have_key('six')
      end
Robert Speicher's avatar
Robert Speicher committed
433 434 435
    end

    context 'where repo doesn\'t have submodules' do
436
      let(:submodules) { repository.send(:submodules, '6d39438') }
Robert Speicher's avatar
Robert Speicher committed
437 438 439 440 441 442
      it 'should return an empty hash' do
        expect(submodules).to be_empty
      end
    end
  end

443
  describe '#commit_count' do
444
    shared_examples 'simple commit counting' do
445 446
      it { expect(repository.commit_count("master")).to eq(25) }
      it { expect(repository.commit_count("feature")).to eq(9) }
447
      it { expect(repository.commit_count("does-not-exist")).to eq(0) }
448 449 450
    end

    context 'when Gitaly commit_count feature is enabled' do
451
      it_behaves_like 'simple commit counting'
Andrew Newdigate's avatar
Andrew Newdigate committed
452
      it_behaves_like 'wrapping gRPC errors', Gitlab::GitalyClient::CommitService, :commit_count do
453 454 455 456
        subject { repository.commit_count('master') }
      end
    end

457
    context 'when Gitaly commit_count feature is disabled', :skip_gitaly_mock  do
458
      it_behaves_like 'simple commit counting'
459
    end
Robert Speicher's avatar
Robert Speicher committed
460 461
  end

462 463 464 465 466 467 468 469 470 471 472 473 474
  describe '#has_local_branches?' do
    shared_examples 'check for local branches' do
      it { expect(repository.has_local_branches?).to eq(true) }

      context 'mutable' do
        let(:repository) { Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '') }

        after do
          ensure_seeds
        end

        it 'returns false when there are no branches' do
          # Sanity check
475
          expect(repository.has_local_branches?).to eq(true)
476 477 478 479 480 481

          FileUtils.rm_rf(File.join(repository.path, 'packed-refs'))
          heads_dir = File.join(repository.path, 'refs/heads')
          FileUtils.rm_rf(heads_dir)
          FileUtils.mkdir_p(heads_dir)

482
          repository.expire_has_local_branches_cache
483 484 485
          expect(repository.has_local_branches?).to eq(false)
        end
      end
486 487 488 489 490 491 492 493 494 495

      context 'memoizes the value' do
        it 'returns true' do
          expect(repository).to receive(:uncached_has_local_branches?).once.and_call_original

          2.times do
            expect(repository.has_local_branches?).to eq(true)
          end
        end
      end
496 497 498 499 500 501
    end

    context 'with gitaly' do
      it_behaves_like 'check for local branches'
    end

502
    context 'without gitaly', :skip_gitaly_mock do
503 504 505 506
      it_behaves_like 'check for local branches'
    end
  end

Robert Speicher's avatar
Robert Speicher committed
507
  describe "#delete_branch" do
508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529
    shared_examples "deleting a branch" do
      let(:repository) { Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '') }

      after do
        ensure_seeds
      end

      it "removes the branch from the repo" do
        branch_name = "to-be-deleted-soon"

        repository.create_branch(branch_name)
        expect(repository.rugged.branches[branch_name]).not_to be_nil

        repository.delete_branch(branch_name)
        expect(repository.rugged.branches[branch_name]).to be_nil
      end

      context "when branch does not exist" do
        it "raises a DeleteBranchError exception" do
          expect { repository.delete_branch("this-branch-does-not-exist") }.to raise_error(Gitlab::Git::Repository::DeleteBranchError)
        end
      end
Robert Speicher's avatar
Robert Speicher committed
530 531
    end

532 533
    context "when Gitaly delete_branch is enabled" do
      it_behaves_like "deleting a branch"
Robert Speicher's avatar
Robert Speicher committed
534 535
    end

536
    context "when Gitaly delete_branch is disabled", :skip_gitaly_mock do
537
      it_behaves_like "deleting a branch"
Robert Speicher's avatar
Robert Speicher committed
538 539 540 541
    end
  end

  describe "#create_branch" do
542 543
    shared_examples 'creating a branch' do
      let(:repository) { Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '') }
Robert Speicher's avatar
Robert Speicher committed
544

545 546 547
      after do
        ensure_seeds
      end
Robert Speicher's avatar
Robert Speicher committed
548

549 550 551
      it "should create a new branch" do
        expect(repository.create_branch('new_branch', 'master')).not_to be_nil
      end
Robert Speicher's avatar
Robert Speicher committed
552

553 554 555 556 557 558 559 560 561 562 563 564
      it "should create a new branch with the right name" do
        expect(repository.create_branch('another_branch', 'master').name).to eq('another_branch')
      end

      it "should fail if we create an existing branch" do
        repository.create_branch('duplicated_branch', 'master')
        expect {repository.create_branch('duplicated_branch', 'master')}.to raise_error("Branch duplicated_branch already exists")
      end

      it "should fail if we create a branch from a non existing ref" do
        expect {repository.create_branch('branch_based_in_wrong_ref', 'master_2_the_revenge')}.to raise_error("Invalid reference master_2_the_revenge")
      end
Robert Speicher's avatar
Robert Speicher committed
565 566
    end

567 568
    context 'when Gitaly create_branch feature is enabled' do
      it_behaves_like 'creating a branch'
Robert Speicher's avatar
Robert Speicher committed
569 570
    end

571
    context 'when Gitaly create_branch feature is disabled', :skip_gitaly_mock do
572
      it_behaves_like 'creating a branch'
Robert Speicher's avatar
Robert Speicher committed
573 574 575
    end
  end

576
  describe '#delete_refs' do
577 578
    shared_examples 'deleting refs' do
      let(:repo) { Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '') }
579

580 581 582
      after do
        ensure_seeds
      end
583

584 585
      it 'deletes the ref' do
        repo.delete_refs('refs/heads/feature')
586

587 588 589 590 591 592 593 594 595 596 597
        expect(repo.rugged.references['refs/heads/feature']).to be_nil
      end

      it 'deletes all refs' do
        refs = %w[refs/heads/wip refs/tags/v1.1.0]
        repo.delete_refs(*refs)

        refs.each do |ref|
          expect(repo.rugged.references[ref]).to be_nil
        end
      end
598

599 600 601 602
      it 'does not fail when deleting an empty list of refs' do
        expect { repo.delete_refs(*[]) }.not_to raise_error
      end

603 604
      it 'raises an error if it failed' do
        expect { repo.delete_refs('refs\heads\fix') }.to raise_error(Gitlab::Git::Repository::GitError)
605 606 607
      end
    end

608 609
    context 'when Gitaly delete_refs feature is enabled' do
      it_behaves_like 'deleting refs'
610 611
    end

612 613
    context 'when Gitaly delete_refs feature is disabled', :disable_gitaly do
      it_behaves_like 'deleting refs'
614 615 616
    end
  end

617
  describe '#branch_names_contains_sha' do
618 619 620
    let(:head_id) { repository.rugged.head.target.oid }
    let(:new_branch) { head_id }
    let(:utf8_branch) { 'branch-é' }
621

622 623 624
    before do
      repository.create_branch(new_branch, 'master')
      repository.create_branch(utf8_branch, 'master')
625 626
    end

627 628 629
    after do
      repository.delete_branch(new_branch)
      repository.delete_branch(utf8_branch)
630 631
    end

632 633
    it 'displays that branch' do
      expect(repository.branch_names_contains_sha(head_id)).to include('master', new_branch, utf8_branch)
634 635 636
    end
  end

Robert Speicher's avatar
Robert Speicher committed
637
  describe "#refs_hash" do
638
    subject { repository.refs_hash }
Robert Speicher's avatar
Robert Speicher committed
639 640 641 642

    it "should have as many entries as branches and tags" do
      expected_refs = SeedRepo::Repo::BRANCHES + SeedRepo::Repo::TAGS
      # We flatten in case a commit is pointed at by more than one branch and/or tag
643 644 645 646 647
      expect(subject.values.flatten.size).to eq(expected_refs.size)
    end

    it 'has valid commit ids as keys' do
      expect(subject.keys).to all( match(Commit::COMMIT_SHA_PATTERN) )
Robert Speicher's avatar
Robert Speicher committed
648 649 650
    end
  end

651
  describe "#remove_remote" do
Robert Speicher's avatar
Robert Speicher committed
652
    before(:all) do
653
      @repo = Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '')
654
      @repo.remove_remote("expendable")
Robert Speicher's avatar
Robert Speicher committed
655 656 657 658 659 660 661 662 663 664 665
    end

    it "should remove the remote" do
      expect(@repo.rugged.remotes).not_to include("expendable")
    end

    after(:all) do
      ensure_seeds
    end
  end

666
  describe "#remote_update" do
Robert Speicher's avatar
Robert Speicher committed
667
    before(:all) do
668
      @repo = Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '')
669
      @repo.remote_update("expendable", url: TEST_NORMAL_REPO_PATH)
Robert Speicher's avatar
Robert Speicher committed
670 671 672
    end

    it "should add the remote" do
673 674 675
      expect(@repo.rugged.remotes["expendable"].url).to(
        eq(TEST_NORMAL_REPO_PATH)
      )
Robert Speicher's avatar
Robert Speicher committed
676 677 678 679 680 681 682
    end

    after(:all) do
      ensure_seeds
    end
  end

683
  describe '#fetch_repository_as_mirror' do
684 685
    let(:new_repository) do
      Gitlab::Git::Repository.new('default', 'my_project.git', '')
Robert Speicher's avatar
Robert Speicher committed
686 687
    end

688
    subject { new_repository.fetch_repository_as_mirror(repository) }
689 690

    before do
691
      Gitlab::Shell.new.create_repository('default', 'my_project')
Robert Speicher's avatar
Robert Speicher committed
692 693
    end

694
    after do
695
      Gitlab::Shell.new.remove_repository('default', 'my_project')
696 697
    end

698 699 700
    shared_examples 'repository mirror fecthing' do
      it 'fetches a repository as a mirror remote' do
        subject
701

702 703
        expect(refs(new_repository.path)).to eq(refs(repository.path))
      end
704

705 706 707 708
      context 'with keep-around refs' do
        let(:sha) { SeedRepo::Commit::ID }
        let(:keep_around_ref) { "refs/keep-around/#{sha}" }
        let(:tmp_ref) { "refs/tmp/#{SecureRandom.hex}" }
709

710 711 712 713
        before do
          repository.rugged.references.create(keep_around_ref, sha, force: true)
          repository.rugged.references.create(tmp_ref, sha, force: true)
        end
714

715 716
        it 'includes the temporary and keep-around refs' do
          subject
717

718 719 720
          expect(refs(new_repository.path)).to include(keep_around_ref)
          expect(refs(new_repository.path)).to include(tmp_ref)
        end
721 722
      end
    end
723 724 725 726 727 728 729 730

    context 'with gitaly enabled' do
      it_behaves_like 'repository mirror fecthing'
    end

    context 'with gitaly enabled', :skip_gitaly_mock do
      it_behaves_like 'repository mirror fecthing'
    end
731 732 733
  end

  describe '#remote_tags' do
734
    let(:remote_name) { 'upstream' }
735
    let(:target_commit_id) { SeedRepo::Commit::ID }
736 737 738 739 740
    let(:tag_name) { 'v0.0.1' }
    let(:tag_message) { 'My tag' }
    let(:remote_repository) do
      Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '')
    end
741

742
    subject { repository.remote_tags(remote_name) }
743

744 745 746 747
    before do
      repository.add_remote(remote_name, remote_repository.path)
      remote_repository.add_tag(tag_name, user: user, target: target_commit_id)
    end
748

749 750 751 752 753
    after do
      ensure_seeds
    end

    it 'gets the remote tags' do
754
      expect(subject.first).to be_an_instance_of(Gitlab::Git::Tag)
755
      expect(subject.first.name).to eq(tag_name)
756
      expect(subject.first.dereferenced_target.id).to eq(target_commit_id)
Robert Speicher's avatar
Robert Speicher committed
757 758 759 760
    end
  end

  describe "#log" do
761 762 763 764 765 766 767 768 769 770
    shared_examples 'repository log' do
      let(:commit_with_old_name) do
        Gitlab::Git::Commit.decorate(repository, @commit_with_old_name_id)
      end
      let(:commit_with_new_name) do
        Gitlab::Git::Commit.decorate(repository, @commit_with_new_name_id)
      end
      let(:rename_commit) do
        Gitlab::Git::Commit.decorate(repository, @rename_commit_id)
      end
Robert Speicher's avatar
Robert Speicher committed
771

772 773 774 775 776 777 778
      before(:context) do
        # Add new commits so that there's a renamed file in the commit history
        repo = Gitlab::Git::Repository.new('default', TEST_REPO_PATH, '').rugged
        @commit_with_old_name_id = new_commit_edit_old_file(repo)
        @rename_commit_id = new_commit_move_file(repo)
        @commit_with_new_name_id = new_commit_edit_new_file(repo)
      end
Robert Speicher's avatar
Robert Speicher committed
779

780 781 782 783
      after(:context) do
        # Erase our commits so other tests get the original repo
        repo = Gitlab::Git::Repository.new('default', TEST_REPO_PATH, '').rugged
        repo.references.update("refs/heads/master", SeedRepo::LastCommit::ID)
Robert Speicher's avatar
Robert Speicher committed
784 785
      end

786 787 788 789 790 791
      context "where 'follow' == true" do
        let(:options) { { ref: "master", follow: true } }

        context "and 'path' is a directory" do
          it "does not follow renames" do
            log_commits = repository.log(options.merge(path: "encoding"))
792 793 794 795

            aggregate_failures do
              expect(log_commits).to include(commit_with_new_name)
              expect(log_commits).to include(rename_commit)
796
              expect(log_commits).not_to include(commit_with_old_name)
797
            end
798
          end
Robert Speicher's avatar
Robert Speicher committed
799 800
        end

801 802 803 804
        context "and 'path' is a file that matches the new filename" do
          context 'without offset' do
            it "follows renames" do
              log_commits = repository.log(options.merge(path: "encoding/CHANGELOG"))
805

806 807 808 809 810
              aggregate_failures do
                expect(log_commits).to include(commit_with_new_name)
                expect(log_commits).to include(rename_commit)
                expect(log_commits).to include(commit_with_old_name)
              end
811
            end
812 813
          end

814 815 816
          context 'with offset=1' do
            it "follows renames and skip the latest commit" do
              log_commits = repository.log(options.merge(path: "encoding/CHANGELOG", offset: 1))
817

818 819 820 821 822 823
              aggregate_failures do
                expect(log_commits).not_to include(commit_with_new_name)
                expect(log_commits).to include(rename_commit)
                expect(log_commits).to include(commit_with_old_name)
              end
            end
824 825
          end

826 827 828
          context 'with offset=1', 'and limit=1' do
            it "follows renames, skip the latest commit and return only one commit" do
              log_commits = repository.log(options.merge(path: "encoding/CHANGELOG", offset: 1, limit: 1))
829

830
              expect(log_commits).to contain_exactly(rename_commit)
831
            end
832 833
          end

834 835 836
          context 'with offset=1', 'and limit=2' do
            it "follows renames, skip the latest commit and return only two commits" do
              log_commits = repository.log(options.merge(path: "encoding/CHANGELOG", offset: 1, limit: 2))
837

838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860
              aggregate_failures do
                expect(log_commits).to contain_exactly(rename_commit, commit_with_old_name)
              end
            end
          end

          context 'with offset=2' do
            it "follows renames and skip the latest commit" do
              log_commits = repository.log(options.merge(path: "encoding/CHANGELOG", offset: 2))

              aggregate_failures do
                expect(log_commits).not_to include(commit_with_new_name)
                expect(log_commits).not_to include(rename_commit)
                expect(log_commits).to include(commit_with_old_name)
              end
            end
          end

          context 'with offset=2', 'and limit=1' do
            it "follows renames, skip the two latest commit and return only one commit" do
              log_commits = repository.log(options.merge(path: "encoding/CHANGELOG", offset: 2, limit: 1))

              expect(log_commits).to contain_exactly(commit_with_old_name)
861
            end
862 863
          end

864 865 866
          context 'with offset=2', 'and limit=2' do
            it "follows renames, skip the two latest commit and return only one commit" do
              log_commits = repository.log(options.merge(path: "encoding/CHANGELOG", offset: 2, limit: 2))
867

868 869 870 871 872 873
              aggregate_failures do
                expect(log_commits).not_to include(commit_with_new_name)
                expect(log_commits).not_to include(rename_commit)
                expect(log_commits).to include(commit_with_old_name)
              end
            end
874 875 876
          end
        end

877 878 879
        context "and 'path' is a file that matches the old filename" do
          it "does not follow renames" do
            log_commits = repository.log(options.merge(path: "CHANGELOG"))
880 881 882

            aggregate_failures do
              expect(log_commits).not_to include(commit_with_new_name)
883
              expect(log_commits).to include(rename_commit)
884 885
              expect(log_commits).to include(commit_with_old_name)
            end
886
          end
Robert Speicher's avatar
Robert Speicher committed
887 888
        end

889 890 891
        context "unknown ref" do
          it "returns an empty array" do
            log_commits = repository.log(options.merge(ref: 'unknown'))
Robert Speicher's avatar
Robert Speicher committed
892

893
            expect(log_commits).to eq([])
894
          end
Robert Speicher's avatar
Robert Speicher committed
895 896 897
        end
      end

898 899
      context "where 'follow' == false" do
        options = { follow: false }
Robert Speicher's avatar
Robert Speicher committed
900

901 902 903 904
        context "and 'path' is a directory" do
          let(:log_commits) do
            repository.log(options.merge(path: "encoding"))
          end
Robert Speicher's avatar
Robert Speicher committed
905

906 907 908 909 910
          it "does not follow renames" do
            expect(log_commits).to include(commit_with_new_name)
            expect(log_commits).to include(rename_commit)
            expect(log_commits).not_to include(commit_with_old_name)
          end
Robert Speicher's avatar
Robert Speicher committed
911 912
        end

913 914 915 916
        context "and 'path' is a file that matches the new filename" do
          let(:log_commits) do
            repository.log(options.merge(path: "encoding/CHANGELOG"))
          end
Robert Speicher's avatar
Robert Speicher committed
917

918 919 920 921 922
          it "does not follow renames" do
            expect(log_commits).to include(commit_with_new_name)
            expect(log_commits).to include(rename_commit)
            expect(log_commits).not_to include(commit_with_old_name)
          end
Robert Speicher's avatar
Robert Speicher committed
923 924
        end

925 926 927 928
        context "and 'path' is a file that matches the old filename" do
          let(:log_commits) do
            repository.log(options.merge(path: "CHANGELOG"))
          end
Robert Speicher's avatar
Robert Speicher committed
929

930 931 932 933 934
          it "does not follow renames" do
            expect(log_commits).to include(commit_with_old_name)
            expect(log_commits).to include(rename_commit)
            expect(log_commits).not_to include(commit_with_new_name)
          end
Robert Speicher's avatar
Robert Speicher committed
935 936
        end

937 938 939 940 941 942 943 944
        context "and 'path' includes a directory that used to be a file" do
          let(:log_commits) do
            repository.log(options.merge(ref: "refs/heads/fix-blob-path", path: "files/testdir/file.txt"))
          end

          it "returns a list of commits" do
            expect(log_commits.size).to eq(1)
          end
Robert Speicher's avatar
Robert Speicher committed
945 946 947
        end
      end

948 949
      context "where provides 'after' timestamp" do
        options = { after: Time.iso8601('2014-03-03T20:15:01+00:00') }
Robert Speicher's avatar
Robert Speicher committed
950

951 952 953 954 955 956 957
        it "should returns commits on or after that timestamp" do
          commits = repository.log(options)

          expect(commits.size).to be > 0
          expect(commits).to satisfy do |commits|
            commits.all? { |commit| commit.committed_date >= options[:after] }
          end
Robert Speicher's avatar
Robert Speicher committed
958 959 960
        end
      end

961 962
      context "where provides 'before' timestamp" do
        options = { before: Time.iso8601('2014-03-03T20:15:01+00:00') }
Robert Speicher's avatar
Robert Speicher committed
963

964 965
        it "should returns commits on or before that timestamp" do
          commits = repository.log(options)
Robert Speicher's avatar
Robert Speicher committed
966

967 968 969 970
          expect(commits.size).to be > 0
          expect(commits).to satisfy do |commits|
            commits.all? { |commit| commit.committed_date <= options[:before] }
          end
Robert Speicher's avatar
Robert Speicher committed
971 972 973
        end
      end

974 975
      context 'when multiple paths are provided' do
        let(:options) { { ref: 'master', path: ['PROCESS.md', 'README.md'] } }
Robert Speicher's avatar
Robert Speicher committed
976

977 978 979 980
        def commit_files(commit)
          commit.rugged_diff_from_parent.deltas.flat_map do |delta|
            [delta.old_file[:path], delta.new_file[:path]].uniq.compact
          end
981 982
        end

983 984
        it 'only returns commits matching at least one path' do
          commits = repository.log(options)
985

986 987 988 989
          expect(commits.size).to be > 0
          expect(commits).to satisfy do |commits|
            commits.none? { |commit| (commit_files(commit) & options[:path]).empty? }
          end
990 991 992
        end
      end

993 994 995 996
      context 'limit validation' do
        where(:limit) do
          [0, nil, '', 'foo']
        end
997

998 999
        with_them do
          it { expect { repository.log(limit: limit) }.to raise_error(ArgumentError) }
Robert Speicher's avatar
Robert Speicher committed
1000 1001
        end
      end
1002

1003 1004 1005
      context 'with all' do
        it 'returns a list of commits' do
          commits = repository.log({ all: true, limit: 50 })
1006

1007 1008
          expect(commits.size).to eq(37)
        end
1009 1010
      end
    end
Tiago Botelho's avatar
Tiago Botelho committed
1011

1012 1013 1014
    context 'when Gitaly find_commits feature is enabled' do
      it_behaves_like 'repository log'
    end
Tiago Botelho's avatar
Tiago Botelho committed
1015

1016 1017
    context 'when Gitaly find_commits feature is disabled', :disable_gitaly do
      it_behaves_like 'repository log'
Tiago Botelho's avatar
Tiago Botelho committed
1018
    end
Robert Speicher's avatar
Robert Speicher committed
1019 1020
  end

1021
  describe "#rugged_commits_between" do
Robert Speicher's avatar
Robert Speicher committed
1022 1023 1024 1025 1026
    context 'two SHAs' do
      let(:first_sha) { 'b0e52af38d7ea43cf41d8a6f2471351ac036d6c9' }
      let(:second_sha) { '0e50ec4d3c7ce42ab74dda1d422cb2cbffe1e326' }

      it 'returns the number of commits between' do
1027
        expect(repository.rugged_commits_between(first_sha, second_sha).count).to eq(3)
Robert Speicher's avatar
Robert Speicher committed
1028 1029 1030 1031 1032 1033 1034 1035
      end
    end

    context 'SHA and master branch' do
      let(:sha) { 'b0e52af38d7ea43cf41d8a6f2471351ac036d6c9' }
      let(:branch) { 'master' }

      it 'returns the number of commits between a sha and a branch' do
1036
        expect(repository.rugged_commits_between(sha, branch).count).to eq(5)
Robert Speicher's avatar
Robert Speicher committed
1037 1038 1039
      end

      it 'returns the number of commits between a branch and a sha' do
1040
        expect(repository.rugged_commits_between(branch, sha).count).to eq(0) # sha is before branch
Robert Speicher's avatar
Robert Speicher committed
1041 1042 1043 1044 1045 1046 1047 1048
      end
    end

    context 'two branches' do
      let(:first_branch) { 'feature' }
      let(:second_branch) { 'master' }

      it 'returns the number of commits between' do
1049
        expect(repository.rugged_commits_between(first_branch, second_branch).count).to eq(17)
Robert Speicher's avatar
Robert Speicher committed
1050 1051 1052 1053 1054 1055 1056 1057 1058 1059
      end
    end
  end

  describe '#count_commits_between' do
    subject { repository.count_commits_between('feature', 'master') }

    it { is_expected.to eq(17) }
  end

Rubén Dávila's avatar
Rubén Dávila committed
1060
  describe '#raw_changes_between' do
1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074
    shared_examples 'raw changes' do
      let(:old_rev) { }
      let(:new_rev) { }
      let(:changes) { repository.raw_changes_between(old_rev, new_rev) }

      context 'initial commit' do
        let(:old_rev) { Gitlab::Git::BLANK_SHA }
        let(:new_rev) { '1a0b36b3cdad1d2ee32457c102a8c0b7056fa863' }

        it 'returns the changes' do
          expect(changes).to be_present
          expect(changes.size).to eq(3)
        end
      end
Rubén Dávila's avatar
Rubén Dávila committed
1075

1076 1077 1078
      context 'with an invalid rev' do
        let(:old_rev) { 'foo' }
        let(:new_rev) { 'bar' }
Rubén Dávila's avatar
Rubén Dávila committed
1079

1080 1081 1082
        it 'returns an error' do
          expect { changes }.to raise_error(Gitlab::Git::Repository::GitError)
        end
Rubén Dávila's avatar
Rubén Dávila committed
1083 1084
      end

1085 1086 1087
      context 'with valid revs' do
        let(:old_rev) { 'fa1b1e6c004a68b7d8763b86455da9e6b23e36d6' }
        let(:new_rev) { '4b4918a572fa86f9771e5ba40fbd48e1eb03e2c6' }
Rubén Dávila's avatar
Rubén Dávila committed
1088

1089 1090 1091 1092 1093 1094 1095
        it 'returns the changes' do
          expect(changes.size).to eq(9)
          expect(changes.first.operation).to eq(:modified)
          expect(changes.first.new_path).to eq('.gitmodules')
          expect(changes.last.operation).to eq(:added)
          expect(changes.last.new_path).to eq('files/lfs/picture-invalid.png')
        end
Rubén Dávila's avatar
Rubén Dávila committed
1096 1097 1098
      end
    end

1099 1100 1101
    context 'when gitaly is enabled' do
      it_behaves_like 'raw changes'
    end
Rubén Dávila's avatar
Rubén Dávila committed
1102

1103 1104
    context 'when gitaly is disabled', :disable_gitaly do
      it_behaves_like 'raw changes'
Rubén Dávila's avatar
Rubén Dávila committed
1105 1106 1107
    end
  end

1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130
  describe '#merge_base' do
    shared_examples '#merge_base' do
      where(:from, :to, :result) do
        '570e7b2abdd848b95f2f578043fc23bd6f6fd24d' | '40f4a7a617393735a95a0bb67b08385bc1e7c66d' | '570e7b2abdd848b95f2f578043fc23bd6f6fd24d'
        '40f4a7a617393735a95a0bb67b08385bc1e7c66d' | '570e7b2abdd848b95f2f578043fc23bd6f6fd24d' | '570e7b2abdd848b95f2f578043fc23bd6f6fd24d'
        '40f4a7a617393735a95a0bb67b08385bc1e7c66d' | 'foobar' | nil
        'foobar' | '40f4a7a617393735a95a0bb67b08385bc1e7c66d' | nil
      end

      with_them do
        it { expect(repository.merge_base(from, to)).to eq(result) }
      end
    end

    context 'with gitaly' do
      it_behaves_like '#merge_base'
    end

    context 'without gitaly', :skip_gitaly_mock do
      it_behaves_like '#merge_base'
    end
  end

1131
  describe '#count_commits' do
1132 1133 1134
    shared_examples 'extended commit counting' do
      context 'with after timestamp' do
        it 'returns the number of commits after timestamp' do
1135
          options = { ref: 'master', after: Time.iso8601('2013-03-03T20:15:01+00:00') }
1136

1137 1138
          expect(repository.count_commits(options)).to eq(25)
        end
1139 1140
      end

1141 1142
      context 'with before timestamp' do
        it 'returns the number of commits before timestamp' do
1143
          options = { ref: 'feature', before: Time.iso8601('2015-03-03T20:15:01+00:00') }
1144

1145 1146
          expect(repository.count_commits(options)).to eq(9)
        end
1147 1148
      end

1149 1150 1151 1152 1153 1154 1155 1156
      context 'with max_count' do
        it 'returns the number of commits with path ' do
          options = { ref: 'master', max_count: 5 }

          expect(repository.count_commits(options)).to eq(5)
        end
      end

1157 1158
      context 'with path' do
        it 'returns the number of commits with path ' do
1159 1160 1161 1162 1163 1164 1165 1166 1167
          options = { ref: 'master', path: 'encoding' }

          expect(repository.count_commits(options)).to eq(2)
        end
      end

      context 'with option :from and option :to' do
        it 'returns the number of commits ahead for fix-mode..fix-blob-path' do
          options = { from: 'fix-mode', to: 'fix-blob-path' }
1168

1169 1170
          expect(repository.count_commits(options)).to eq(2)
        end
1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192

        it 'returns the number of commits ahead for fix-blob-path..fix-mode' do
          options = { from: 'fix-blob-path', to: 'fix-mode' }

          expect(repository.count_commits(options)).to eq(1)
        end

        context 'with option :left_right' do
          it 'returns the number of commits for fix-mode...fix-blob-path' do
            options = { from: 'fix-mode', to: 'fix-blob-path', left_right: true }

            expect(repository.count_commits(options)).to eq([1, 2])
          end

          context 'with max_count' do
            it 'returns the number of commits with path ' do
              options = { from: 'fix-mode', to: 'fix-blob-path', left_right: true, max_count: 1 }

              expect(repository.count_commits(options)).to eq([1, 1])
            end
          end
        end
1193
      end
1194 1195 1196 1197 1198 1199 1200 1201

      context 'with max_count' do
        it 'returns the number of commits up to the passed limit' do
          options = { ref: 'master', max_count: 10, after: Time.iso8601('2013-03-03T20:15:01+00:00') }

          expect(repository.count_commits(options)).to eq(10)
        end
      end
Tiago Botelho's avatar
Tiago Botelho committed
1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212

      context "with all" do
        it "returns the number of commits in the whole repository" do
          options = { all: true }

          expect(repository.count_commits(options)).to eq(34)
        end
      end

      context 'without all or ref being specified' do
        it "raises an ArgumentError" do
1213
          expect { repository.count_commits({}) }.to raise_error(ArgumentError)
Tiago Botelho's avatar
Tiago Botelho committed
1214 1215
        end
      end
1216
    end
1217 1218 1219 1220 1221 1222 1223 1224

    context 'when Gitaly count_commits feature is enabled' do
      it_behaves_like 'extended commit counting'
    end

    context 'when Gitaly count_commits feature is disabled', :disable_gitaly do
      it_behaves_like 'extended commit counting'
    end
1225 1226
  end

Robert Speicher's avatar
Robert Speicher committed
1227 1228
  describe '#autocrlf' do
    before(:all) do
1229
      @repo = Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '')
Robert Speicher's avatar
Robert Speicher committed
1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243
      @repo.rugged.config['core.autocrlf'] = true
    end

    it 'return the value of the autocrlf option' do
      expect(@repo.autocrlf).to be(true)
    end

    after(:all) do
      @repo.rugged.config.delete('core.autocrlf')
    end
  end

  describe '#autocrlf=' do
    before(:all) do
1244
      @repo = Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '')
Robert Speicher's avatar
Robert Speicher committed
1245 1246 1247 1248 1249 1250
      @repo.rugged.config['core.autocrlf'] = false
    end

    it 'should set the autocrlf option to the provided option' do
      @repo.autocrlf = :input

1251
      File.open(File.join(SEED_STORAGE_PATH, TEST_MUTABLE_REPO_PATH, 'config')) do |config_file|
Robert Speicher's avatar
Robert Speicher committed
1252 1253 1254 1255 1256 1257 1258 1259 1260 1261
        expect(config_file.read).to match('autocrlf = input')
      end
    end

    after(:all) do
      @repo.rugged.config.delete('core.autocrlf')
    end
  end

  describe '#find_branch' do
1262 1263 1264
    shared_examples 'finding a branch' do
      it 'should return a Branch for master' do
        branch = repository.find_branch('master')
Robert Speicher's avatar
Robert Speicher committed
1265

1266 1267 1268
        expect(branch).to be_a_kind_of(Gitlab::Git::Branch)
        expect(branch.name).to eq('master')
      end
Robert Speicher's avatar
Robert Speicher committed
1269

1270 1271
      it 'should handle non-existent branch' do
        branch = repository.find_branch('this-is-garbage')
Robert Speicher's avatar
Robert Speicher committed
1272

1273 1274
        expect(branch).to eq(nil)
      end
Robert Speicher's avatar
Robert Speicher committed
1275 1276
    end

1277 1278 1279
    context 'when Gitaly find_branch feature is enabled' do
      it_behaves_like 'finding a branch'
    end
Robert Speicher's avatar
Robert Speicher committed
1280

1281
    context 'when Gitaly find_branch feature is disabled', :skip_gitaly_mock do
1282
      it_behaves_like 'finding a branch'
Robert Speicher's avatar
Robert Speicher committed
1283

1284 1285 1286
      context 'force_reload is true' do
        it 'should reload Rugged::Repository' do
          expect(Rugged::Repository).to receive(:new).twice.and_call_original
1287

1288 1289
          repository.find_branch('master')
          branch = repository.find_branch('master', force_reload: true)
1290

1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304
          expect(branch).to be_a_kind_of(Gitlab::Git::Branch)
          expect(branch.name).to eq('master')
        end
      end

      context 'force_reload is false' do
        it 'should not reload Rugged::Repository' do
          expect(Rugged::Repository).to receive(:new).once.and_call_original

          branch = repository.find_branch('master', force_reload: false)

          expect(branch).to be_a_kind_of(Gitlab::Git::Branch)
          expect(branch.name).to eq('master')
        end
1305
      end
Robert Speicher's avatar
Robert Speicher committed
1306
    end
1307 1308
  end

1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330
  describe '#ref_name_for_sha' do
    let(:ref_path) { 'refs/heads' }
    let(:sha) { repository.find_branch('master').dereferenced_target.id }
    let(:ref_name) { 'refs/heads/master' }

    it 'returns the ref name for the given sha' do
      expect(repository.ref_name_for_sha(ref_path, sha)).to eq(ref_name)
    end

    it "returns an empty name if the ref doesn't exist" do
      expect(repository.ref_name_for_sha(ref_path, "000000")).to eq("")
    end

    it "raise an exception if the ref is empty" do
      expect { repository.ref_name_for_sha(ref_path, "") }.to raise_error(ArgumentError)
    end

    it "raise an exception if the ref is nil" do
      expect { repository.ref_name_for_sha(ref_path, nil) }.to raise_error(ArgumentError)
    end
  end

1331 1332 1333 1334 1335
  describe '#branches' do
    subject { repository.branches }

    context 'with local and remote branches' do
      let(:repository) do
1336
        Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '')
1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351
      end

      before do
        create_remote_branch(repository, 'joe', 'remote_branch', 'master')
        repository.create_branch('local_branch', 'master')
      end

      after do
        ensure_seeds
      end

      it 'returns the local and remote branches' do
        expect(subject.any? { |b| b.name == 'joe/remote_branch' }).to eq(true)
        expect(subject.any? { |b| b.name == 'local_branch' }).to eq(true)
      end
Robert Speicher's avatar
Robert Speicher committed
1352 1353
    end

1354 1355 1356 1357
    # With Gitaly enabled, Gitaly just doesn't return deleted branches.
    context 'with deleted branch with Gitaly disabled' do
      before do
        allow(Gitlab::GitalyClient).to receive(:feature_enabled?).and_return(false)
1358 1359 1360
      end

      it 'returns no results' do
1361 1362 1363 1364 1365 1366 1367
        ref = double()
        allow(ref).to receive(:name) { 'bad-branch' }
        allow(ref).to receive(:target) { raise Rugged::ReferenceError }
        branches = double()
        allow(branches).to receive(:each) { [ref].each }
        allow(repository.rugged).to receive(:branches) { branches }

1368 1369
        expect(subject).to be_empty
      end
Robert Speicher's avatar
Robert Speicher committed
1370
    end
1371 1372

    it_behaves_like 'wrapping gRPC errors', Gitlab::GitalyClient::RefService, :branches
Robert Speicher's avatar
Robert Speicher committed
1373 1374 1375 1376
  end

  describe '#branch_count' do
    it 'returns the number of branches' do
1377
      expect(repository.branch_count).to eq(11)
Robert Speicher's avatar
Robert Speicher committed
1378
    end
1379 1380 1381

    context 'with local and remote branches' do
      let(:repository) do
1382
        Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '')
1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407
      end

      before do
        create_remote_branch(repository, 'joe', 'remote_branch', 'master')
        repository.create_branch('local_branch', 'master')
      end

      after do
        ensure_seeds
      end

      it 'returns the count of local branches' do
        expect(repository.branch_count).to eq(repository.local_branches.count)
      end

      context 'with Gitaly disabled' do
        before do
          allow(Gitlab::GitalyClient).to receive(:feature_enabled?).and_return(false)
        end

        it 'returns the count of local branches' do
          expect(repository.branch_count).to eq(repository.local_branches.count)
        end
      end
    end
Robert Speicher's avatar
Robert Speicher committed
1408 1409
  end

1410
  describe '#merged_branch_names' do
1411 1412 1413 1414
    shared_examples 'finding merged branch names' do
      context 'when branch names are passed' do
        it 'only returns the names we are asking' do
          names = repository.merged_branch_names(%w[merge-test])
1415

1416 1417
          expect(names).to contain_exactly('merge-test')
        end
1418

1419 1420
        it 'does not return unmerged branch names' do
          names = repository.merged_branch_names(%w[feature])
1421

1422 1423
          expect(names).to be_empty
        end
1424 1425
      end

1426 1427 1428
      context 'when no root ref is available' do
        it 'returns empty list' do
          project = create(:project, :empty_repo)
1429

1430
          names = project.repository.merged_branch_names(%w[feature])
1431

1432 1433
          expect(names).to be_empty
        end
1434 1435
      end

1436 1437 1438 1439
      context 'when no branch names are specified' do
        before do
          repository.create_branch('identical', 'master')
        end
1440

1441 1442 1443
        after do
          ensure_seeds
        end
1444

1445 1446
        it 'returns all merged branch names except for identical one' do
          names = repository.merged_branch_names
1447

1448 1449 1450 1451 1452
          expect(names).to include('merge-test')
          expect(names).to include('fix-mode')
          expect(names).not_to include('feature')
          expect(names).not_to include('identical')
        end
1453 1454
      end
    end
1455 1456 1457 1458 1459 1460 1461 1462

    context 'when Gitaly merged_branch_names feature is enabled' do
      it_behaves_like 'finding merged branch names'
    end

    context 'when Gitaly merged_branch_names feature is disabled', :disable_gitaly do
      it_behaves_like 'finding merged branch names'
    end
1463 1464
  end

Robert Speicher's avatar
Robert Speicher committed
1465 1466
  describe "#ls_files" do
    let(:master_file_paths) { repository.ls_files("master") }
1467
    let(:utf8_file_paths) { repository.ls_files("ls-files-utf8") }
Robert Speicher's avatar
Robert Speicher committed
1468 1469 1470 1471 1472 1473 1474 1475 1476 1477
    let(:not_existed_branch) { repository.ls_files("not_existed_branch") }

    it "read every file paths of master branch" do
      expect(master_file_paths.length).to equal(40)
    end

    it "reads full file paths of master branch" do
      expect(master_file_paths).to include("files/html/500.html")
    end

1478
    it "does not read submodule directory and empty directory of master branch" do
Robert Speicher's avatar
Robert Speicher committed
1479 1480 1481 1482 1483 1484 1485 1486 1487 1488
      expect(master_file_paths).not_to include("six")
    end

    it "does not include 'nil'" do
      expect(master_file_paths).not_to include(nil)
    end

    it "returns empty array when not existed branch" do
      expect(not_existed_branch.length).to equal(0)
    end
1489 1490 1491 1492

    it "returns valid utf-8 data" do
      expect(utf8_file_paths.map { |file| file.force_encoding('utf-8') }).to all(be_valid_encoding)
    end
Robert Speicher's avatar
Robert Speicher committed
1493 1494 1495
  end

  describe "#copy_gitattributes" do
1496 1497
    shared_examples 'applying git attributes' do
      let(:attributes_path) { File.join(SEED_STORAGE_PATH, TEST_REPO_PATH, 'info/attributes') }
Robert Speicher's avatar
Robert Speicher committed
1498

1499 1500
      after do
        FileUtils.rm_rf(attributes_path) if Dir.exist?(attributes_path)
Robert Speicher's avatar
Robert Speicher committed
1501 1502
      end

1503 1504
      it "raises an error with invalid ref" do
        expect { repository.copy_gitattributes("invalid") }.to raise_error(Gitlab::Git::Repository::InvalidRef)
Robert Speicher's avatar
Robert Speicher committed
1505 1506
      end

1507 1508
      context 'when forcing encoding issues' do
        let(:branch_name) { "ʕ•ᴥ•ʔ" }
Robert Speicher's avatar
Robert Speicher committed
1509

1510 1511 1512
        before do
          repository.create_branch(branch_name, "master")
        end
Robert Speicher's avatar
Robert Speicher committed
1513

1514 1515 1516
        after do
          repository.rm_branch(branch_name, user: build(:admin))
        end
Robert Speicher's avatar
Robert Speicher committed
1517

1518 1519
        it "doesn't raise with a valid unicode ref" do
          expect { repository.copy_gitattributes(branch_name) }.not_to raise_error
Robert Speicher's avatar
Robert Speicher committed
1520

1521 1522
          repository
        end
Robert Speicher's avatar
Robert Speicher committed
1523 1524
      end

1525 1526 1527 1528
      context "with no .gitattrbutes" do
        before do
          repository.copy_gitattributes("master")
        end
Robert Speicher's avatar
Robert Speicher committed
1529

1530 1531 1532
        it "does not have an info/attributes" do
          expect(File.exist?(attributes_path)).to be_falsey
        end
Robert Speicher's avatar
Robert Speicher committed
1533 1534
      end

1535 1536 1537 1538
      context "with .gitattrbutes" do
        before do
          repository.copy_gitattributes("gitattributes")
        end
Robert Speicher's avatar
Robert Speicher committed
1539

1540 1541 1542
        it "has an info/attributes" do
          expect(File.exist?(attributes_path)).to be_truthy
        end
Robert Speicher's avatar
Robert Speicher committed
1543

1544 1545 1546 1547
        it "has the same content in info/attributes as .gitattributes" do
          contents = File.open(attributes_path, "rb") { |f| f.read }
          expect(contents).to eq("*.md binary\n")
        end
Robert Speicher's avatar
Robert Speicher committed
1548 1549
      end

1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563
      context "with updated .gitattrbutes" do
        before do
          repository.copy_gitattributes("gitattributes")
          repository.copy_gitattributes("gitattributes-updated")
        end

        it "has an info/attributes" do
          expect(File.exist?(attributes_path)).to be_truthy
        end

        it "has the updated content in info/attributes" do
          contents = File.read(attributes_path)
          expect(contents).to eq("*.txt binary\n")
        end
Robert Speicher's avatar
Robert Speicher committed
1564 1565
      end

1566 1567 1568 1569 1570 1571 1572 1573 1574
      context "with no .gitattrbutes in HEAD but with previous info/attributes" do
        before do
          repository.copy_gitattributes("gitattributes")
          repository.copy_gitattributes("master")
        end

        it "does not have an info/attributes" do
          expect(File.exist?(attributes_path)).to be_falsey
        end
Robert Speicher's avatar
Robert Speicher committed
1575 1576
      end
    end
1577 1578 1579 1580 1581 1582 1583 1584

    context 'when gitaly is enabled' do
      it_behaves_like 'applying git attributes'
    end

    context 'when gitaly is disabled', :disable_gitaly do
      it_behaves_like 'applying git attributes'
    end
Robert Speicher's avatar
Robert Speicher committed
1585 1586
  end

1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609
  describe '#ref_exists?' do
    shared_examples 'checks the existence of refs' do
      it 'returns true for an existing tag' do
        expect(repository.ref_exists?('refs/heads/master')).to eq(true)
      end

      it 'returns false for a non-existing tag' do
        expect(repository.ref_exists?('refs/tags/THIS_TAG_DOES_NOT_EXIST')).to eq(false)
      end

      it 'raises an ArgumentError for an empty string' do
        expect { repository.ref_exists?('') }.to raise_error(ArgumentError)
      end

      it 'raises an ArgumentError for an invalid ref' do
        expect { repository.ref_exists?('INVALID') }.to raise_error(ArgumentError)
      end
    end

    context 'when Gitaly ref_exists feature is enabled' do
      it_behaves_like 'checks the existence of refs'
    end

1610
    context 'when Gitaly ref_exists feature is disabled', :skip_gitaly_mock do
1611 1612 1613 1614
      it_behaves_like 'checks the existence of refs'
    end
  end

Robert Speicher's avatar
Robert Speicher committed
1615
  describe '#tag_exists?' do
1616 1617 1618
    shared_examples 'checks the existence of tags' do
      it 'returns true for an existing tag' do
        tag = repository.tag_names.first
Robert Speicher's avatar
Robert Speicher committed
1619

1620 1621 1622 1623 1624 1625 1626 1627 1628 1629
        expect(repository.tag_exists?(tag)).to eq(true)
      end

      it 'returns false for a non-existing tag' do
        expect(repository.tag_exists?('v9000')).to eq(false)
      end
    end

    context 'when Gitaly ref_exists_tags feature is enabled' do
      it_behaves_like 'checks the existence of tags'
Robert Speicher's avatar
Robert Speicher committed
1630 1631
    end

1632
    context 'when Gitaly ref_exists_tags feature is disabled', :skip_gitaly_mock do
1633
      it_behaves_like 'checks the existence of tags'
Robert Speicher's avatar
Robert Speicher committed
1634 1635 1636 1637
    end
  end

  describe '#branch_exists?' do
1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649
    shared_examples 'checks the existence of branches' do
      it 'returns true for an existing branch' do
        expect(repository.branch_exists?('master')).to eq(true)
      end

      it 'returns false for a non-existing branch' do
        expect(repository.branch_exists?('kittens')).to eq(false)
      end

      it 'returns false when using an invalid branch name' do
        expect(repository.branch_exists?('.bla')).to eq(false)
      end
Robert Speicher's avatar
Robert Speicher committed
1650 1651
    end

1652 1653
    context 'when Gitaly ref_exists_branches feature is enabled' do
      it_behaves_like 'checks the existence of branches'
Robert Speicher's avatar
Robert Speicher committed
1654 1655
    end

1656
    context 'when Gitaly ref_exists_branches feature is disabled', :skip_gitaly_mock do
1657
      it_behaves_like 'checks the existence of branches'
Robert Speicher's avatar
Robert Speicher committed
1658 1659 1660
    end
  end

1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678
  describe '#batch_existence' do
    let(:refs) { ['deadbeef', SeedRepo::RubyBlob::ID, '909e6157199'] }

    it 'returns existing refs back' do
      result = repository.batch_existence(refs)

      expect(result).to eq([SeedRepo::RubyBlob::ID])
    end

    context 'existing: true' do
      it 'inverts meaning and returns non-existing refs' do
        result = repository.batch_existence(refs, existing: false)

        expect(result).to eq(%w(deadbeef 909e6157199))
      end
    end
  end

Robert Speicher's avatar
Robert Speicher committed
1679 1680
  describe '#local_branches' do
    before(:all) do
1681
      @repo = Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '')
Robert Speicher's avatar
Robert Speicher committed
1682 1683 1684 1685 1686 1687 1688
    end

    after(:all) do
      ensure_seeds
    end

    it 'returns the local branches' do
1689
      create_remote_branch(@repo, 'joe', 'remote_branch', 'master')
Robert Speicher's avatar
Robert Speicher committed
1690 1691 1692 1693 1694
      @repo.create_branch('local_branch', 'master')

      expect(@repo.local_branches.any? { |branch| branch.name == 'remote_branch' }).to eq(false)
      expect(@repo.local_branches.any? { |branch| branch.name == 'local_branch' }).to eq(true)
    end
1695

1696 1697 1698 1699
    it 'returns a Branch with UTF-8 fields' do
      branches = @repo.local_branches.to_a
      expect(branches.size).to be > 0
      branches.each do |branch|
1700 1701
        expect(branch.name).to be_utf8
        expect(branch.target).to be_utf8 unless branch.target.nil?
1702
      end
1703
    end
1704

1705
    it 'gets the branches from GitalyClient' do
Andrew Newdigate's avatar
Andrew Newdigate committed
1706
      expect_any_instance_of(Gitlab::GitalyClient::RefService).to receive(:local_branches)
1707 1708 1709
        .and_return([])
      @repo.local_branches
    end
1710

Andrew Newdigate's avatar
Andrew Newdigate committed
1711
    it_behaves_like 'wrapping gRPC errors', Gitlab::GitalyClient::RefService, :local_branches do
1712
      subject { @repo.local_branches }
1713
    end
Robert Speicher's avatar
Robert Speicher committed
1714 1715
  end

1716 1717 1718 1719 1720 1721 1722
  describe '#languages' do
    shared_examples 'languages' do
      it 'returns exactly the expected results' do
        languages = repository.languages('4b4918a572fa86f9771e5ba40fbd48e1eb03e2c6')
        expected_languages = [
          { value: 66.63, label: "Ruby", color: "#701516", highlight: "#701516" },
          { value: 22.96, label: "JavaScript", color: "#f1e05a", highlight: "#f1e05a" },
1723
          { value: 7.9, label: "HTML", color: "#e34c26", highlight: "#e34c26" },
1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749
          { value: 2.51, label: "CoffeeScript", color: "#244776", highlight: "#244776" }
        ]

        expect(languages.size).to eq(expected_languages.size)

        expected_languages.size.times do |i|
          a = expected_languages[i]
          b = languages[i]

          expect(a.keys.sort).to eq(b.keys.sort)
          expect(a[:value]).to be_within(0.1).of(b[:value])

          non_float_keys = a.keys - [:value]
          expect(a.values_at(*non_float_keys)).to eq(b.values_at(*non_float_keys))
        end
      end

      it "uses the repository's HEAD when no ref is passed" do
        lang = repository.languages.first

        expect(lang[:label]).to eq('Ruby')
      end
    end

    it_behaves_like 'languages'

1750
    context 'with rugged', :skip_gitaly_mock do
1751 1752 1753 1754
      it_behaves_like 'languages'
    end
  end

1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783
  describe '#license_short_name' do
    shared_examples 'acquiring the Licensee license key' do
      subject { repository.license_short_name }

      context 'when no license file can be found' do
        let(:project) { create(:project, :repository) }
        let(:repository) { project.repository.raw_repository }

        before do
          project.repository.delete_file(project.owner, 'LICENSE', message: 'remove license', branch_name: 'master')
        end

        it { is_expected.to be_nil }
      end

      context 'when an mit license is found' do
        it { is_expected.to eq('mit') }
      end
    end

    context 'when gitaly is enabled' do
      it_behaves_like 'acquiring the Licensee license key'
    end

    context 'when gitaly is disabled', :disable_gitaly do
      it_behaves_like 'acquiring the Licensee license key'
    end
  end

1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829
  describe '#with_repo_branch_commit' do
    context 'when comparing with the same repository' do
      let(:start_repository) { repository }

      context 'when the branch exists' do
        let(:start_branch_name) { 'master' }

        it 'yields the commit' do
          expect { |b| repository.with_repo_branch_commit(start_repository, start_branch_name, &b) }
            .to yield_with_args(an_instance_of(Gitlab::Git::Commit))
        end
      end

      context 'when the branch does not exist' do
        let(:start_branch_name) { 'definitely-not-master' }

        it 'yields nil' do
          expect { |b| repository.with_repo_branch_commit(start_repository, start_branch_name, &b) }
            .to yield_with_args(nil)
        end
      end
    end

    context 'when comparing with another repository' do
      let(:start_repository) { Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '') }

      context 'when the branch exists' do
        let(:start_branch_name) { 'master' }

        it 'yields the commit' do
          expect { |b| repository.with_repo_branch_commit(start_repository, start_branch_name, &b) }
            .to yield_with_args(an_instance_of(Gitlab::Git::Commit))
        end
      end

      context 'when the branch does not exist' do
        let(:start_branch_name) { 'definitely-not-master' }

        it 'yields nil' do
          expect { |b| repository.with_repo_branch_commit(start_repository, start_branch_name, &b) }
            .to yield_with_args(nil)
        end
      end
    end
  end

1830
  describe '#fetch_source_branch!' do
1831 1832 1833 1834
    shared_examples '#fetch_source_branch!' do
      let(:local_ref) { 'refs/merge-requests/1/head' }
      let(:repository) { Gitlab::Git::Repository.new('default', TEST_REPO_PATH, '') }
      let(:source_repository) { Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '') }
1835

1836 1837 1838
      after do
        ensure_seeds
      end
1839

1840 1841 1842 1843 1844
      context 'when the branch exists' do
        context 'when the commit does not exist locally' do
          let(:source_branch) { 'new-branch-for-fetch-source-branch' }
          let(:source_rugged) { source_repository.rugged }
          let(:new_oid) { new_commit_edit_old_file(source_rugged).oid }
1845

1846 1847 1848
          before do
            source_rugged.branches.create(source_branch, new_oid)
          end
1849

1850 1851 1852 1853 1854
          it 'writes the ref' do
            expect(repository.fetch_source_branch!(source_repository, source_branch, local_ref)).to eq(true)
            expect(repository.commit(local_ref).sha).to eq(new_oid)
          end
        end
1855

1856 1857 1858
        context 'when the commit exists locally' do
          let(:source_branch) { 'master' }
          let(:expected_oid) { SeedRepo::LastCommit::ID }
1859

1860 1861 1862
          it 'writes the ref' do
            # Sanity check: the commit should already exist
            expect(repository.commit(expected_oid)).not_to be_nil
1863

1864 1865 1866 1867
            expect(repository.fetch_source_branch!(source_repository, source_branch, local_ref)).to eq(true)
            expect(repository.commit(local_ref).sha).to eq(expected_oid)
          end
        end
1868 1869
      end

1870 1871 1872 1873 1874 1875 1876
      context 'when the branch does not exist' do
        let(:source_branch) { 'definitely-not-master' }

        it 'does not write the ref' do
          expect(repository.fetch_source_branch!(source_repository, source_branch, local_ref)).to eq(false)
          expect(repository.commit(local_ref)).to be_nil
        end
1877 1878
      end
    end
1879 1880 1881 1882 1883 1884

    it_behaves_like '#fetch_source_branch!'

    context 'without gitaly', :skip_gitaly_mock do
      it_behaves_like '#fetch_source_branch!'
    end
1885 1886
  end

1887 1888 1889 1890 1891 1892 1893
  describe '#rm_branch' do
    shared_examples "user deleting a branch" do
      let(:project) { create(:project, :repository) }
      let(:repository) { project.repository.raw }
      let(:branch_name) { "to-be-deleted-soon" }

      before do
1894
        project.add_developer(user)
1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908
        repository.create_branch(branch_name)
      end

      it "removes the branch from the repo" do
        repository.rm_branch(branch_name, user: user)

        expect(repository.rugged.branches[branch_name]).to be_nil
      end
    end

    context "when Gitaly user_delete_branch is enabled" do
      it_behaves_like "user deleting a branch"
    end

1909
    context "when Gitaly user_delete_branch is disabled", :skip_gitaly_mock do
1910 1911 1912 1913
      it_behaves_like "user deleting a branch"
    end
  end

1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930
  describe '#write_ref' do
    context 'validations' do
      using RSpec::Parameterized::TableSyntax

      where(:ref_path, :ref) do
        'foo bar' | '123'
        'foobar'  | "12\x003"
      end

      with_them do
        it 'raises ArgumentError' do
          expect { repository.write_ref(ref_path, ref) }.to raise_error(ArgumentError)
        end
      end
    end
  end

1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968
  describe '#write_config' do
    before do
      repository.rugged.config["gitlab.fullpath"] = repository.path
    end

    shared_examples 'writing repo config' do
      context 'is given a path' do
        it 'writes it to disk' do
          repository.write_config(full_path: "not-the/real-path.git")

          config = File.read(File.join(repository.path, "config"))

          expect(config).to include("[gitlab]")
          expect(config).to include("fullpath = not-the/real-path.git")
        end
      end

      context 'it is given an empty path' do
        it 'does not write it to disk' do
          repository.write_config(full_path: "")

          config = File.read(File.join(repository.path, "config"))

          expect(config).to include("[gitlab]")
          expect(config).to include("fullpath = #{repository.path}")
        end
      end
    end

    context "when gitaly_write_config is enabled" do
      it_behaves_like "writing repo config"
    end

    context "when gitaly_write_config is disabled", :disable_gitaly do
      it_behaves_like "writing repo config"
    end
  end

1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994
  describe '#merge' do
    let(:repository) do
      Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '')
    end
    let(:source_sha) { '913c66a37b4a45b9769037c55c2d238bd0942d2e' }
    let(:target_branch) { 'test-merge-target-branch' }

    before do
      repository.create_branch(target_branch, '6d394385cf567f80a8fd85055db1ab4c5295806f')
    end

    after do
      ensure_seeds
    end

    shared_examples '#merge' do
      it 'can perform a merge' do
        merge_commit_id = nil
        result = repository.merge(user, source_sha, target_branch, 'Test merge') do |commit_id|
          merge_commit_id = commit_id
        end

        expect(result.newrev).to eq(merge_commit_id)
        expect(result.repo_created).to eq(false)
        expect(result.branch_created).to eq(false)
      end
1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005

      it 'returns nil if there was a concurrent branch update' do
        concurrent_update_id = '33f3729a45c02fc67d00adb1b8bca394b0e761d9'
        result = repository.merge(user, source_sha, target_branch, 'Test merge') do
          # This ref update should make the merge fail
          repository.write_ref(Gitlab::Git::BRANCH_REF_PREFIX + target_branch, concurrent_update_id)
        end

        # This 'nil' signals that the merge was not applied
        expect(result).to be_nil

Jacob Vosmaer's avatar
Jacob Vosmaer committed
2006
        # Our concurrent ref update should not have been undone
2007 2008
        expect(repository.find_branch(target_branch).target).to eq(concurrent_update_id)
      end
2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019
    end

    context 'with gitaly' do
      it_behaves_like '#merge'
    end

    context 'without gitaly', :skip_gitaly_mock do
      it_behaves_like '#merge'
    end
  end

2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037
  describe '#ff_merge' do
    let(:repository) do
      Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '')
    end
    let(:branch_head) { '6d394385cf567f80a8fd85055db1ab4c5295806f' }
    let(:source_sha) { 'cfe32cf61b73a0d5e9f13e774abde7ff789b1660' }
    let(:target_branch) { 'test-ff-target-branch' }

    before do
      repository.create_branch(target_branch, branch_head)
    end

    after do
      ensure_seeds
    end

    subject { repository.ff_merge(user, source_sha, target_branch) }

2038 2039 2040 2041 2042
    shared_examples '#ff_merge' do
      it 'performs a ff_merge' do
        expect(subject.newrev).to eq(source_sha)
        expect(subject.repo_created).to be(false)
        expect(subject.branch_created).to be(false)
2043

2044 2045
        expect(repository.commit(target_branch).id).to eq(source_sha)
      end
2046

2047 2048
      context 'with a non-existing target branch' do
        subject { repository.ff_merge(user, source_sha, 'this-isnt-real') }
2049

2050 2051 2052
        it 'throws an ArgumentError' do
          expect { subject }.to raise_error(ArgumentError)
        end
2053 2054
      end

2055 2056
      context 'with a non-existing source commit' do
        let(:source_sha) { 'f001' }
2057

2058 2059 2060
        it 'throws an ArgumentError' do
          expect { subject }.to raise_error(ArgumentError)
        end
2061 2062
      end

2063 2064 2065 2066 2067 2068 2069 2070 2071 2072
      context 'when the source sha is not a descendant of the branch head' do
        let(:source_sha) { '1a0b36b3cdad1d2ee32457c102a8c0b7056fa863' }

        it "doesn't perform the ff_merge" do
          expect { subject }.to raise_error(Gitlab::Git::CommitError)

          expect(repository.commit(target_branch).id).to eq(branch_head)
        end
      end
    end
2073

2074 2075 2076 2077 2078
    context 'with gitaly' do
      it "calls Gitaly's OperationService" do
        expect_any_instance_of(Gitlab::GitalyClient::OperationService)
          .to receive(:user_ff_branch).with(user, source_sha, target_branch)
          .and_return(nil)
2079

2080
        subject
2081
      end
2082 2083 2084 2085 2086 2087

      it_behaves_like '#ff_merge'
    end

    context 'without gitaly', :skip_gitaly_mock do
      it_behaves_like '#ff_merge'
2088 2089 2090
    end
  end

2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116
  describe '#delete_all_refs_except' do
    let(:repository) do
      Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '')
    end

    before do
      repository.write_ref("refs/delete/a", "0b4bc9a49b562e85de7cc9e834518ea6828729b9")
      repository.write_ref("refs/also-delete/b", "12d65c8dd2b2676fa3ac47d955accc085a37a9c1")
      repository.write_ref("refs/keep/c", "6473c90867124755509e100d0d35ebdc85a0b6ae")
      repository.write_ref("refs/also-keep/d", "0b4bc9a49b562e85de7cc9e834518ea6828729b9")
    end

    after do
      ensure_seeds
    end

    it 'deletes all refs except those with the specified prefixes' do
      repository.delete_all_refs_except(%w(refs/keep refs/also-keep refs/heads))
      expect(repository.ref_exists?("refs/delete/a")).to be(false)
      expect(repository.ref_exists?("refs/also-delete/b")).to be(false)
      expect(repository.ref_exists?("refs/keep/c")).to be(true)
      expect(repository.ref_exists?("refs/also-keep/d")).to be(true)
      expect(repository.ref_exists?("refs/heads/master")).to be(true)
    end
  end

2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172
  describe 'remotes' do
    let(:repository) do
      Gitlab::Git::Repository.new('default', TEST_MUTABLE_REPO_PATH, '')
    end
    let(:remote_name) { 'my-remote' }

    after do
      ensure_seeds
    end

    describe '#add_remote' do
      let(:url) { 'http://my-repo.git' }
      let(:mirror_refmap) { '+refs/*:refs/*' }

      it 'creates a new remote via Gitaly' do
        expect_any_instance_of(Gitlab::GitalyClient::RemoteService)
          .to receive(:add_remote).with(remote_name, url, mirror_refmap)

        repository.add_remote(remote_name, url, mirror_refmap: mirror_refmap)
      end

      context 'with Gitaly disabled', :skip_gitaly_mock do
        it 'creates a new remote via Rugged' do
          expect_any_instance_of(Rugged::RemoteCollection).to receive(:create)
            .with(remote_name, url)
          expect_any_instance_of(Rugged::Config).to receive(:[]=)
          .with("remote.#{remote_name}.mirror", true)
          expect_any_instance_of(Rugged::Config).to receive(:[]=)
          .with("remote.#{remote_name}.prune", true)
          expect_any_instance_of(Rugged::Config).to receive(:[]=)
            .with("remote.#{remote_name}.fetch", mirror_refmap)

          repository.add_remote(remote_name, url, mirror_refmap: mirror_refmap)
        end
      end
    end

    describe '#remove_remote' do
      it 'removes the remote via Gitaly' do
        expect_any_instance_of(Gitlab::GitalyClient::RemoteService)
          .to receive(:remove_remote).with(remote_name)

        repository.remove_remote(remote_name)
      end

      context 'with Gitaly disabled', :skip_gitaly_mock do
        it 'removes the remote via Rugged' do
          expect_any_instance_of(Rugged::RemoteCollection).to receive(:delete)
            .with(remote_name)

          repository.remove_remote(remote_name)
        end
      end
    end
  end

2173 2174 2175 2176 2177 2178 2179
  describe '#gitlab_projects' do
    subject { repository.gitlab_projects }

    it { expect(subject.shard_path).to eq(storage_path) }
    it { expect(subject.repository_relative_path).to eq(repository.relative_path) }
  end

2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207
  describe '#bundle_to_disk' do
    shared_examples 'bundling to disk' do
      let(:save_path) { File.join(Dir.tmpdir, "repo-#{SecureRandom.hex}.bundle") }

      after do
        FileUtils.rm_rf(save_path)
      end

      it 'saves a bundle to disk' do
        repository.bundle_to_disk(save_path)

        success = system(
          *%W(#{Gitlab.config.git.bin_path} -C #{repository.path} bundle verify #{save_path}),
          [:out, :err] => '/dev/null'
        )
        expect(success).to be true
      end
    end

    context 'when Gitaly bundle_to_disk feature is enabled' do
      it_behaves_like 'bundling to disk'
    end

    context 'when Gitaly bundle_to_disk feature is disabled', :disable_gitaly do
      it_behaves_like 'bundling to disk'
    end
  end

2208 2209 2210 2211 2212 2213
  describe '#create_from_bundle' do
    shared_examples 'creating repo from bundle' do
      let(:bundle_path) { File.join(Dir.tmpdir, "repo-#{SecureRandom.hex}.bundle") }
      let(:project) { create(:project) }
      let(:imported_repo) { project.repository.raw }

2214 2215 2216 2217 2218 2219 2220
      before do
        expect(repository.bundle_to_disk(bundle_path)).to be true
      end

      after do
        FileUtils.rm_rf(bundle_path)
      end
2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248

      it 'creates a repo from a bundle file' do
        expect(imported_repo).not_to exist

        result = imported_repo.create_from_bundle(bundle_path)

        expect(result).to be true
        expect(imported_repo).to exist
        expect { imported_repo.fsck }.not_to raise_exception
      end

      it 'creates a symlink to the global hooks dir' do
        imported_repo.create_from_bundle(bundle_path)
        hooks_path = File.join(imported_repo.path, 'hooks')

        expect(File.readlink(hooks_path)).to eq(Gitlab.config.gitlab_shell.hooks_path)
      end
    end

    context 'when Gitaly create_repo_from_bundle feature is enabled' do
      it_behaves_like 'creating repo from bundle'
    end

    context 'when Gitaly create_repo_from_bundle feature is disabled', :disable_gitaly do
      it_behaves_like 'creating repo from bundle'
    end
  end

2249
  describe '#checksum' do
2250
    it 'calculates the checksum for non-empty repo' do
2251
      expect(repository.checksum).to eq '4be7d24ce7e8d845502d599b72d567d23e6a40c0'
2252
    end
2253

2254 2255
    it 'returns 0000000000000000000000000000000000000000 for an empty repo' do
      FileUtils.rm_rf(File.join(storage_path, 'empty-repo.git'))
2256

2257 2258 2259 2260
      system(git_env, *%W(#{Gitlab.config.git.bin_path} init --bare empty-repo.git),
             chdir: storage_path,
             out:   '/dev/null',
             err:   '/dev/null')
2261

2262
      empty_repo = described_class.new('default', 'empty-repo.git', '')
2263

2264 2265
      expect(empty_repo.checksum).to eq '0000000000000000000000000000000000000000'
    end
2266

2267 2268
    it 'raises Gitlab::Git::Repository::InvalidRepository error for non-valid git repo' do
      FileUtils.rm_rf(File.join(storage_path, 'non-valid.git'))
2269

2270 2271 2272 2273
      system(git_env, *%W(#{Gitlab.config.git.bin_path} clone --bare #{TEST_REPO_PATH} non-valid.git),
             chdir: SEED_STORAGE_PATH,
             out: '/dev/null',
             err: '/dev/null')
2274

2275
      File.truncate(File.join(storage_path, 'non-valid.git/HEAD'), 0)
2276

2277
      non_valid = described_class.new('default', 'non-valid.git', '')
2278

2279
      expect { non_valid.checksum }.to raise_error(Gitlab::Git::Repository::InvalidRepository)
2280 2281
    end

2282 2283
    it 'raises Gitlab::Git::Repository::NoRepository error when there is no repo' do
      broken_repo = described_class.new('default', 'a/path.git', '')
2284

2285
      expect { broken_repo.checksum }.to raise_error(Gitlab::Git::Repository::NoRepository)
2286 2287 2288
    end
  end

2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314
  context 'gitlab_projects commands' do
    let(:gitlab_projects) { repository.gitlab_projects }
    let(:timeout) { Gitlab.config.gitlab_shell.git_timeout }

    describe '#push_remote_branches' do
      subject do
        repository.push_remote_branches('downstream-remote', ['master'])
      end

      it 'executes the command' do
        expect(gitlab_projects).to receive(:push_branches)
          .with('downstream-remote', timeout, true, ['master'])
          .and_return(true)

        is_expected.to be_truthy
      end

      it 'raises an error if the command fails' do
        allow(gitlab_projects).to receive(:output) { 'error' }
        expect(gitlab_projects).to receive(:push_branches)
          .with('downstream-remote', timeout, true, ['master'])
          .and_return(false)

        expect { subject }.to raise_error(Gitlab::Git::CommandError, 'error')
      end
    end
2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361

    describe '#delete_remote_branches' do
      subject do
        repository.delete_remote_branches('downstream-remote', ['master'])
      end

      it 'executes the command' do
        expect(gitlab_projects).to receive(:delete_remote_branches)
          .with('downstream-remote', ['master'])
          .and_return(true)

        is_expected.to be_truthy
      end

      it 'raises an error if the command fails' do
        allow(gitlab_projects).to receive(:output) { 'error' }
        expect(gitlab_projects).to receive(:delete_remote_branches)
          .with('downstream-remote', ['master'])
          .and_return(false)

        expect { subject }.to raise_error(Gitlab::Git::CommandError, 'error')
      end
    end

    describe '#delete_remote_branches' do
      subject do
        repository.delete_remote_branches('downstream-remote', ['master'])
      end

      it 'executes the command' do
        expect(gitlab_projects).to receive(:delete_remote_branches)
          .with('downstream-remote', ['master'])
          .and_return(true)

        is_expected.to be_truthy
      end

      it 'raises an error if the command fails' do
        allow(gitlab_projects).to receive(:output) { 'error' }
        expect(gitlab_projects).to receive(:delete_remote_branches)
          .with('downstream-remote', ['master'])
          .and_return(false)

        expect { subject }.to raise_error(Gitlab::Git::CommandError, 'error')
      end
    end

2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394
    describe '#clean_stale_repository_files' do
      let(:worktree_path) { File.join(repository.path, 'worktrees', 'delete-me') }

      it 'cleans up the files' do
        repository.with_worktree(worktree_path, 'master', env: ENV) do
          FileUtils.touch(worktree_path, mtime: Time.now - 8.hours)
          # git rev-list --all will fail in git 2.16 if HEAD is pointing to a non-existent object,
          # but the HEAD must be 40 characters long or git will ignore it.
          File.write(File.join(worktree_path, 'HEAD'), Gitlab::Git::BLANK_SHA)

          # git 2.16 fails with "fatal: bad object HEAD"
          expect { repository.rev_list(including: :all) }.to raise_error(Gitlab::Git::Repository::GitError)

          repository.clean_stale_repository_files

          expect { repository.rev_list(including: :all) }.not_to raise_error
          expect(File.exist?(worktree_path)).to be_falsey
        end
      end

      it 'increments a counter upon an error' do
        expect(repository.gitaly_repository_client).to receive(:cleanup).and_raise(Gitlab::Git::CommandError)

        counter = double(:counter)

        expect(counter).to receive(:increment)
        expect(Gitlab::Metrics).to receive(:counter).with(:failed_repository_cleanup_total,
                                                          'Number of failed repository cleanup events').and_return(counter)

        repository.clean_stale_repository_files
      end
    end

2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416
    describe '#delete_remote_branches' do
      subject do
        repository.delete_remote_branches('downstream-remote', ['master'])
      end

      it 'executes the command' do
        expect(gitlab_projects).to receive(:delete_remote_branches)
          .with('downstream-remote', ['master'])
          .and_return(true)

        is_expected.to be_truthy
      end

      it 'raises an error if the command fails' do
        allow(gitlab_projects).to receive(:output) { 'error' }
        expect(gitlab_projects).to receive(:delete_remote_branches)
          .with('downstream-remote', ['master'])
          .and_return(false)

        expect { subject }.to raise_error(Gitlab::Git::CommandError, 'error')
      end
    end
2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435

    describe '#squash' do
      let(:squash_id) { '1' }
      let(:branch_name) { 'fix' }
      let(:start_sha) { '4b4918a572fa86f9771e5ba40fbd48e1eb03e2c6' }
      let(:end_sha) { '12d65c8dd2b2676fa3ac47d955accc085a37a9c1' }

      subject do
        opts = {
          branch: branch_name,
          start_sha: start_sha,
          end_sha: end_sha,
          author: user,
          message: 'Squash commit message'
        }

        repository.squash(user, squash_id, opts)
      end

2436
      context 'sparse checkout', :skip_gitaly_mock do
2437 2438
        let(:expected_files) { %w(files files/js files/js/application.js) }

2439
        it 'checks out only the files in the diff' do
2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453
          allow(repository).to receive(:with_worktree).and_wrap_original do |m, *args|
            m.call(*args) do
              worktree_path = args[0]
              files_pattern = File.join(worktree_path, '**', '*')
              expected = expected_files.map do |path|
                File.expand_path(path, worktree_path)
              end

              expect(Dir[files_pattern]).to eq(expected)
            end
          end

          subject
        end
2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478

        context 'when the diff contains a rename' do
          let(:repo) { Gitlab::Git::Repository.new('default', TEST_REPO_PATH, '').rugged }
          let(:end_sha) { new_commit_move_file(repo).oid }

          after do
            # Erase our commits so other tests get the original repo
            repo = Gitlab::Git::Repository.new('default', TEST_REPO_PATH, '').rugged
            repo.references.update('refs/heads/master', SeedRepo::LastCommit::ID)
          end

          it 'does not include the renamed file in the sparse checkout' do
            allow(repository).to receive(:with_worktree).and_wrap_original do |m, *args|
              m.call(*args) do
                worktree_path = args[0]
                files_pattern = File.join(worktree_path, '**', '*')

                expect(Dir[files_pattern]).not_to include('CHANGELOG')
                expect(Dir[files_pattern]).not_to include('encoding/CHANGELOG')
              end
            end

            subject
          end
        end
2479
      end
2480 2481 2482 2483 2484 2485 2486 2487

      context 'with an ASCII-8BIT diff', :skip_gitaly_mock do
        let(:diff) { "diff --git a/README.md b/README.md\nindex faaf198..43c5edf 100644\n--- a/README.md\n+++ b/README.md\n@@ -1,4 +1,4 @@\n-testme\n+✓ testme\n ======\n \n Sample repo for testing gitlab features\n" }

        it 'applies a ASCII-8BIT diff' do
          allow(repository).to receive(:run_git!).and_call_original
          allow(repository).to receive(:run_git!).with(%W(diff --binary #{start_sha}...#{end_sha})).and_return(diff.force_encoding('ASCII-8BIT'))

2488
          expect(subject).to match(/\h{40}/)
2489 2490
        end
      end
2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504

      context 'with trailing whitespace in an invalid patch', :skip_gitaly_mock do
        let(:diff) { "diff --git a/README.md b/README.md\nindex faaf198..43c5edf 100644\n--- a/README.md\n+++ b/README.md\n@@ -1,4 +1,4 @@\n-testme\n+   \n ======   \n \n Sample repo for testing gitlab features\n" }

        it 'does not include whitespace warnings in the error' do
          allow(repository).to receive(:run_git!).and_call_original
          allow(repository).to receive(:run_git!).with(%W(diff --binary #{start_sha}...#{end_sha})).and_return(diff.force_encoding('ASCII-8BIT'))

          expect { subject }.to raise_error do |error|
            expect(error).to be_a(described_class::GitError)
            expect(error.message).not_to include('trailing whitespace')
          end
        end
      end
2505
    end
2506 2507
  end

2508 2509 2510
  def create_remote_branch(repository, remote_name, branch_name, source_branch_name)
    source_branch = repository.branches.find { |branch| branch.name == source_branch_name }
    rugged = repository.rugged
Robert Speicher's avatar
Robert Speicher committed
2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582
    rugged.references.create("refs/remotes/#{remote_name}/#{branch_name}", source_branch.dereferenced_target.sha)
  end

  # Build the options hash that's passed to Rugged::Commit#create
  def commit_options(repo, index, message)
    options = {}
    options[:tree] = index.write_tree(repo)
    options[:author] = {
      email: "test@example.com",
      name: "Test Author",
      time: Time.gm(2014, "mar", 3, 20, 15, 1)
    }
    options[:committer] = {
      email: "test@example.com",
      name: "Test Author",
      time: Time.gm(2014, "mar", 3, 20, 15, 1)
    }
    options[:message] ||= message
    options[:parents] = repo.empty? ? [] : [repo.head.target].compact
    options[:update_ref] = "HEAD"

    options
  end

  # Writes a new commit to the repo and returns a Rugged::Commit.  Replaces the
  # contents of CHANGELOG with a single new line of text.
  def new_commit_edit_old_file(repo)
    oid = repo.write("I replaced the changelog with this text", :blob)
    index = repo.index
    index.read_tree(repo.head.target.tree)
    index.add(path: "CHANGELOG", oid: oid, mode: 0100644)

    options = commit_options(
      repo,
      index,
      "Edit CHANGELOG in its original location"
    )

    sha = Rugged::Commit.create(repo, options)
    repo.lookup(sha)
  end

  # Writes a new commit to the repo and returns a Rugged::Commit.  Replaces the
  # contents of encoding/CHANGELOG with new text.
  def new_commit_edit_new_file(repo)
    oid = repo.write("I'm a new changelog with different text", :blob)
    index = repo.index
    index.read_tree(repo.head.target.tree)
    index.add(path: "encoding/CHANGELOG", oid: oid, mode: 0100644)

    options = commit_options(repo, index, "Edit encoding/CHANGELOG")

    sha = Rugged::Commit.create(repo, options)
    repo.lookup(sha)
  end

  # Writes a new commit to the repo and returns a Rugged::Commit.  Moves the
  # CHANGELOG file to the encoding/ directory.
  def new_commit_move_file(repo)
    blob_oid = repo.head.target.tree.detect { |i| i[:name] == "CHANGELOG" }[:oid]
    file_content = repo.lookup(blob_oid).content
    oid = repo.write(file_content, :blob)
    index = repo.index
    index.read_tree(repo.head.target.tree)
    index.add(path: "encoding/CHANGELOG", oid: oid, mode: 0100644)
    index.remove("CHANGELOG")

    options = commit_options(repo, index, "Move CHANGELOG to encoding/")

    sha = Rugged::Commit.create(repo, options)
    repo.lookup(sha)
  end
2583 2584 2585 2586 2587 2588

  def refs(dir)
    IO.popen(%W[git -C #{dir} for-each-ref], &:read).split("\n").map do |line|
      line.split("\t").last
    end
  end
Robert Speicher's avatar
Robert Speicher committed
2589
end