Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • G gitlab-ce
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • gitlab-ce
  • Repository
You need to sign in or sign up before continuing.
  • gitlab-ce
  • lib
  • gitlab
  • database
  • connection.rb
Find file BlameHistoryPermalink
  • Yorick Peterse's avatar
    Remove caching of Connection#config · 76ac934c
    Yorick Peterse authored Jul 28, 2021
    Caching was added in
    https://gitlab.com/gitlab-org/gitlab/-/merge_requests/65262, which lead
    to an incident and support for using uncached configs in
    https://gitlab.com/gitlab-org/gitlab/-/merge_requests/66988.
    
    In this commit we remove caching of the config settings, and add a test
    and comment to explain why we don't want the data to be cached. The
    performance impact is likely not worth potentially breaking code that
    expects uncached settings.
    
    This fixes https://gitlab.com/gitlab-org/gitlab/-/issues/337054.
    76ac934c
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7