• Sean McGivern's avatar
    Ensure that we only request blobs in one batch · 1885691b
    Sean McGivern authored
    Blob.lazy adds a blob to a batch to load at a later point, using the
    BatchLoader library. Whenever any lazy blob's attributes are accessed,
    all lazy blobs requested to that point will be loaded.
    
    BatchLoader, the library we use for this, should only request items in a
    batch once. That is, if we have these batches:
    
    1. a, b, c
    2. d, e, f
    
    Then a, b, and c should only be requested in the first batch. But if you
    modify the list of items in the batch, then the second batch will
    request a, b, c, d, e, f, which is almost certainly not what we want!
    
    https://github.com/exAspArk/batch-loader/issues/44 is the upstream issue
    for this, but we can also solve this in our application by not modifying
    the arguments we're using inside a BatchLoader batch.
    1885691b
fix-lazy-blobs-requesting-all-previous-blobs.yml 141 Bytes