Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • G gitlab-ce
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • gitlab-ce
  • Repository
You need to sign in or sign up before continuing.
  • gitlab-ce
  • app
  • controllers
  • application_controller.rb
Find file BlameHistoryPermalink
  • Stan Hu's avatar
    Set shorter TTL for all unauthenticated requests · 8ccdaf33
    Stan Hu authored Oct 24, 2019
    GitLab 11.2 limited the time-to-live (TTL) of unauthenticated sessions
    via https://gitlab.com/gitlab-org/gitlab/merge_requests/6586 using
    `before_action` in `ApplicationController`. However, this broke OAuth2
    logins, which set the `current_user` **after** a login is successful, so
    we moved it to an `after_action` in
    https://gitlab.com/gitlab-org/gitlab-foss/merge_requests/21144. However,
    `after_action` isn't called if a exception is raised in the request
    cycle. Thus, in some situations, TTLs weren't always being set to a
    short value.
    
    This commit adds the TTL limiting to the Devise Failure App, which is
    run anytime the user is redirected to the sign-in page.
    
    Relates to
    https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/8247
    8ccdaf33
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7