Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • G gitlab-ce
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • gitlab-ce
  • Repository
  • gitlab-ce
  • changelogs
  • unreleased
  • ImproveShellScriptsChangeDirException...
Find file BlameHistoryPermalink
  • Peter Dave Hello's avatar
    Execute `exit 1` when shell script `cd` fails · 95c8007e
    Peter Dave Hello authored Oct 26, 2020
    It's dangerous when `cd` fails but following commands keeps running
    which would lead to expected results.
    
    For those shell scripts without `set -e`, use `exit 1` before furthur
    refactor could be a safe and efficient workaround, for thoes shell
    scripts with `-e`, the shell(script) will exit immediately if any
    command has a non-zero exit status, so they don't need `exit 1`
    
    Reference:
    - https://github.com/koalaman/shellcheck/wiki/SC2164
    95c8007e
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7