• Stan Hu's avatar
    Allow Pages to define a storage-specific connection · d92bedb2
    Stan Hu authored
    Consolidated object storage settings were introduced to:
    
    1. Simplify configuration settings in Workhorse and Rails by using a
    single credential.
    2. Ensure credentials used by Workhorse and Rails remained consistent.
    3. Avoid configuration spew by preventing admins from configuring 10
    different credentials for 10 different object types.
    
    If any storage-specific settings were configured, consolidated object
    storage settings would not take effect.
    
    However, in the case of GitLab Pages, which does not use Workhorse
    acceleration, we can relax this requirement. Normally in the Helm Chart,
    we use an internal service name, such as `gitlab-minio-svc:9000`. But
    with Pages, we need to provide a public FQDN, such as
    `minio.example.com`.
    
    Closes https://gitlab.com/gitlab-org/gitlab/-/issues/284604
    d92bedb2
object_store_settings_spec.rb 6.13 KB