Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
002cbbcb
Commit
002cbbcb
authored
Oct 29, 2020
by
Kamil Trzciński
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Extend `bin/feature-flag` with `milestone`
This reads a milestone from `VERSION` and appends `milestone:` to YAML
parent
e35ecfeb
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
0 deletions
+13
-0
bin/feature-flag
bin/feature-flag
+12
-0
lib/feature/shared.rb
lib/feature/shared.rb
+1
-0
No files found.
bin/feature-flag
View file @
002cbbcb
...
...
@@ -35,6 +35,7 @@ class FeatureFlagOptionParser
:name
,
:type
,
:group
,
:milestone
,
:ee
,
:amend
,
:dry_run
,
...
...
@@ -64,6 +65,10 @@ class FeatureFlagOptionParser
options
.
introduced_by_url
=
value
end
opts
.
on
(
'-M'
,
'--milestone [string]'
,
String
,
'Milestone in which the Feature Flag was introduced'
)
do
|
value
|
options
.
milestone
=
value
end
opts
.
on
(
'-i'
,
'--rollout-issue-url [string]'
,
String
,
'URL of Issue rolling out the Feature Flag'
)
do
|
value
|
options
.
rollout_issue_url
=
value
end
...
...
@@ -188,6 +193,11 @@ class FeatureFlagOptionParser
end
end
def
read_milestone
milestone
=
File
.
read
(
'VERSION'
)
milestone
.
gsub
(
/^(\d+\.\d+).*$/
,
'\1'
).
chomp
end
def
read_default_enabled
(
options
)
TYPES
.
dig
(
options
.
type
,
:default_enabled
)
end
...
...
@@ -214,6 +224,7 @@ class FeatureFlagCreator
options
.
group
||=
FeatureFlagOptionParser
.
read_group
options
.
introduced_by_url
||=
FeatureFlagOptionParser
.
read_introduced_by_url
options
.
rollout_issue_url
||=
FeatureFlagOptionParser
.
read_rollout_issue_url
(
options
)
options
.
milestone
||=
FeatureFlagOptionParser
.
read_milestone
$stdout
.
puts
"
\e
[32mcreate
\e
[0m
#{
file_path
}
"
$stdout
.
puts
contents
...
...
@@ -243,6 +254,7 @@ class FeatureFlagCreator
'name'
=>
options
.
name
,
'introduced_by_url'
=>
options
.
introduced_by_url
,
'rollout_issue_url'
=>
options
.
rollout_issue_url
,
'milestone'
=>
options
.
milestone
,
'group'
=>
options
.
group
,
'type'
=>
options
.
type
.
to_s
,
'default_enabled'
=>
FeatureFlagOptionParser
.
read_default_enabled
(
options
)
...
...
lib/feature/shared.rb
View file @
002cbbcb
...
...
@@ -57,6 +57,7 @@ class Feature
name
introduced_by_url
rollout_issue_url
milestone
type
group
default_enabled
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment