Commit 0058066c authored by David Fernandez's avatar David Fernandez Committed by Arturo Herrero

Enable `check_maven_path_first` by default

parent 2499808c
---
title: Improve the Maven API file endpoints response time when a non existing package is requested
merge_request: 60142
author:
type: performance
......@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/327487
milestone: '13.11'
type: development
group: group::package
default_enabled: false
default_enabled: true
......@@ -25,7 +25,7 @@ module API
helpers do
def path_exists?(path)
# return true when FF disabled so that processing the request is not stopped
return true unless Feature.enabled?(:check_maven_path_first)
return true unless Feature.enabled?(:check_maven_path_first, default_enabled: :yaml)
return false if path.blank?
Packages::Maven::Metadatum.with_path(path)
......
......@@ -49,7 +49,7 @@ RSpec.describe API::MavenPackages do
shared_examples 'rejecting the request for non existing maven path' do |expected_status: :not_found|
before do
if Feature.enabled?(:check_maven_path_first)
if Feature.enabled?(:check_maven_path_first, default_enabled: :yaml)
expect(::Packages::Maven::PackageFinder).not_to receive(:new)
end
end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment