Merge branch 'rspec-empty-line-after-letitbe-ee-spec-controllers-groups' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/controllers/groups

See merge request gitlab-org/gitlab!58412

.rubocop_manual_todo.yml

@@ -392,13 +392,6 @@ Rails/TimeZone:
 # WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/325836
 RSpec/EmptyLineAfterFinalLetItBe:
   Exclude:
-    - ee/spec/controllers/groups/analytics/cycle_analytics/stages_controller_spec.rb
-    - ee/spec/controllers/groups/analytics/cycle_analytics/summary_controller_spec.rb
-    - ee/spec/controllers/groups/analytics/cycle_analytics/value_streams_controller_spec.rb
-    - ee/spec/controllers/groups/analytics/tasks_by_type_controller_spec.rb
-    - ee/spec/controllers/groups/autocomplete_sources_controller_spec.rb
-    - ee/spec/controllers/groups/insights_controller_spec.rb
-    - ee/spec/controllers/groups/todos_controller_spec.rb
     - ee/spec/controllers/subscriptions_controller_spec.rb
     - ee/spec/features/boards/group_boards/multiple_boards_spec.rb
     - ee/spec/features/ci_shared_runner_warnings_spec.rb

ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-controllers-groups.yml

+---
+title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/controllers/groups
+merge_request: 58412
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/controllers/groups/analytics/cycle_analytics/stages_controller_spec.rb

@@ -15,6 +15,7 @@ RSpec.describe Groups::Analytics::CycleAnalytics::StagesController do
 
   context 'when params have group_id and value_stream_id' do
     let_it_be(:value_stream) { create(:cycle_analytics_group_value_stream, group: group) }
+
     let(:params) { { group_id: group, value_stream_id: value_stream.id } }
     let(:parent) { group }
 

ee/spec/controllers/groups/analytics/cycle_analytics/summary_controller_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Groups::Analytics::CycleAnalytics::SummaryController do
   let_it_be(:user) { create(:user) }
   let_it_be(:group, refind: true) { create(:group) }
+
   let(:params) { { group_id: group.full_path, created_after: '2010-01-01', created_before: '2010-01-02' } }
 
   before do

ee/spec/controllers/groups/analytics/cycle_analytics/value_streams_controller_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Groups::Analytics::CycleAnalytics::ValueStreamsController do
   let_it_be(:user) { create(:user) }
   let_it_be(:group, refind: true) { create(:group) }
+
   let(:params) { { group_id: group } }
 
   before do

ee/spec/controllers/groups/analytics/tasks_by_type_controller_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Groups::Analytics::TasksByTypeController do
   let_it_be(:user) { create(:user) }
+
   let(:group) { create(:group) }
   let(:label) { create(:group_label, group: group) }
   let!(:issue) { create(:labeled_issue, created_at: 5.days.ago, project: create(:project, group: group), labels: [label]) }

ee/spec/controllers/groups/autocomplete_sources_controller_spec.rb

@@ -65,6 +65,7 @@ RSpec.describe Groups::AutocompleteSourcesController do
     let_it_be(:issue) { create(:issue, project: project) }
     let_it_be(:incident) { create(:incident, project: project) }
     let_it_be(:test_case) { create(:quality_test_case, project: project) }
+
     let(:none) { [] }
     let(:all) { [issue, incident, test_case] }
 

ee/spec/controllers/groups/insights_controller_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe Groups::InsightsController do
   let_it_be(:project) { create(:project, :private) }
   let_it_be(:insight) { create(:insight, group: parent_group, project: project) }
   let_it_be(:user) { create(:user) }
+
   let(:query_params) { { type: 'bar', query: { issuable_type: 'issue', collection_labels: ['bug'] }, projects: projects_params } }
   let(:projects_params) { { only: [project.id, project.full_path] } }
   let(:params) { { trailing_slash: true } }

ee/spec/controllers/groups/todos_controller_spec.rb

@@ -31,6 +31,7 @@ RSpec.describe Groups::TodosController do
     context 'when epic is not confidential' do
       let_it_be(:group) { create(:group, :private) }
       let_it_be(:epic) { create(:epic, group: group) }
+
       let(:parent) { group }
 
       context 'when epics are available' do