Merge branch 'tokenize-filtered-search' into 'master'

Use colon to tokenize input in filtered search

Closes #196084

See merge request gitlab-org/gitlab!26072

app/assets/javascripts/filtered_search/filtered_search_manager.js

@@ -472,33 +472,6 @@ export default class FilteredSearchManager {
         });
         input.value = input.value.replace(`${tokenKey}:`, '');
       }
-
-      const splitSearchToken = searchToken && searchToken.split(' ');
-      let lastSearchToken = _.last(splitSearchToken);
-      lastSearchToken = lastSearchToken?.toLowerCase();
-
-      /**
-       * If user writes "milestone", a known token, in the input, we should not
-       * wait for leading colon to flush it as a filter token.
-       */
-      if (this.filteredSearchTokenKeys.getKeys().includes(lastSearchToken)) {
-        if (splitSearchToken.length > 1) {
-          splitSearchToken.pop();
-          const searchVisualTokens = splitSearchToken.join(' ');
-
-          input.value = input.value.replace(searchVisualTokens, '');
-          FilteredSearchVisualTokens.addSearchVisualToken(searchVisualTokens);
-        }
-        FilteredSearchVisualTokens.addFilterVisualToken(lastSearchToken, null, null, {
-          uppercaseTokenName: this.filteredSearchTokenKeys.shouldUppercaseTokenName(
-            lastSearchToken,
-          ),
-          capitalizeTokenValue: this.filteredSearchTokenKeys.shouldCapitalizeTokenValue(
-            lastSearchToken,
-          ),
-        });
-        input.value = input.value.replace(lastSearchToken, '');
-      }
     } else if (!isLastVisualTokenValid && !FilteredSearchVisualTokens.getLastTokenOperator()) {
       const tokenKey = FilteredSearchVisualTokens.getLastTokenPartial();
       const tokenOperator = searchToken && searchToken.trim();

changelogs/unreleased/tokenize-filtered-search.yml

+---
+title: Use colon to tokenize input in filtered search
+merge_request: 26072
+author:
+type: changed

ee/spec/features/epics/filtered_search/visual_tokens_spec.rb

@@ -24,7 +24,7 @@ describe 'epics list', :js do
 
   context 'editing author token' do
     before do
-      input_filtered_search('author=@root', submit: false)
+      input_filtered_search('author:=@root', submit: false)
       first('.tokens-container .filtered-search-token').click
     end
 
@@ -52,7 +52,7 @@ describe 'epics list', :js do
 
   context 'editing label token' do
     before do
-      input_filtered_search("label=~#{label.title}", submit: false)
+      input_filtered_search("label:=~#{label.title}", submit: false)
       first('.tokens-container .filtered-search-token').click
     end
 

ee/spec/features/issues/filtered_search/dropdown_epic_spec.rb

@@ -27,13 +27,13 @@ describe 'Dropdown epic', :js do
 
   describe 'behavior' do
     it 'loads all the epics when opened' do
-      input_filtered_search('epic=', submit: false, extra_space: false)
+      input_filtered_search('epic:=', submit: false, extra_space: false)
 
       expect_filtered_search_dropdown_results(filter_dropdown, 2)
     end
 
     it 'selects epic and correct title is loaded' do
-      input_filtered_search('epic=', submit: false, extra_space: false)
+      input_filtered_search('epic:=', submit: false, extra_space: false)
       wait_for_requests
 
       find('li', text: epic.title).click
@@ -42,7 +42,7 @@ describe 'Dropdown epic', :js do
     end
 
     it 'filters issues by epic' do
-      input_filtered_search('epic=', submit: false, extra_space: false)
+      input_filtered_search('epic:=', submit: false, extra_space: false)
       wait_for_requests
 
       find('li', text: epic2.title).click

ee/spec/features/issues/filtered_search/dropdown_weight_spec.rb

@@ -21,7 +21,7 @@ describe 'Dropdown weight', :js do
 
   describe 'behavior' do
     it 'loads all the weights when opened' do
-      input_filtered_search('weight=', submit: false, extra_space: false)
+      input_filtered_search('weight:=', submit: false, extra_space: false)
 
       expect_filtered_search_dropdown_results(filter_dropdown, 21)
     end

ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb

@@ -40,7 +40,7 @@ describe 'Filter issues weight', :js do
 
   describe 'only weight' do
     it 'filter issues by searched weight' do
-      input_filtered_search('weight=1')
+      input_filtered_search('weight:=1')
 
       expect_issues_list_count(1)
     end
@@ -48,7 +48,7 @@ describe 'Filter issues weight', :js do
 
   describe 'weight with other filters' do
     it 'filters issues by searched weight and text' do
-      search = "weight=2 bug"
+      search = "weight:=2 bug"
       input_filtered_search(search)
 
       expect_issues_list_count(1)
@@ -56,7 +56,7 @@ describe 'Filter issues weight', :js do
     end
 
     it 'filters issues by searched weight, author and text' do
-      search = "weight=2 author=@root bug"
+      search = "weight:=2 author:=@root bug"
       input_filtered_search(search)
 
       expect_issues_list_count(1)
@@ -64,7 +64,7 @@ describe 'Filter issues weight', :js do
     end
 
     it 'filters issues by searched weight, author, assignee and text' do
-      search = "weight=2 author=@root assignee=@root bug"
+      search = "weight:=2 author:=@root assignee:=@root bug"
       input_filtered_search(search)
 
       expect_issues_list_count(1)
@@ -72,7 +72,7 @@ describe 'Filter issues weight', :js do
     end
 
     it 'filters issues by searched weight, author, assignee, label and text' do
-      search = "weight=2 author=@root assignee=@root label=~urgent bug"
+      search = "weight:=2 author:=@root assignee:=@root label:=~urgent bug"
       input_filtered_search(search)
 
       expect_issues_list_count(1)
@@ -80,7 +80,7 @@ describe 'Filter issues weight', :js do
     end
 
     it 'filters issues by searched weight, milestone and text' do
-      search = "weight=2 milestone=%version1 bug"
+      search = "weight:=2 milestone:=%version1 bug"
       input_filtered_search(search)
 
       expect_issues_list_count(1)

ee/spec/features/merge_requests/user_filters_by_approvers_spec.rb

@@ -32,7 +32,7 @@ describe 'Merge Requests > User filters by approvers', :js do
 
   context 'filtering by approver:none' do
     it 'applies the filter' do
-      input_filtered_search('approver=none')
+      input_filtered_search('approver:=none')
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
 
@@ -45,7 +45,7 @@ describe 'Merge Requests > User filters by approvers', :js do
 
   context 'filtering by approver:any' do
     it 'applies the filter' do
-      input_filtered_search('approver=any')
+      input_filtered_search('approver:=any')
 
       expect(page).to have_issuable_counts(open: 3, closed: 0, all: 3)
 
@@ -58,7 +58,7 @@ describe 'Merge Requests > User filters by approvers', :js do
 
   context 'filtering by approver:@username' do
     it 'applies the filter' do
-      input_filtered_search("approver=@#{first_user.username}")
+      input_filtered_search("approver:=@#{first_user.username}")
 
       expect(page).to have_issuable_counts(open: 2, closed: 0, all: 2)
 
@@ -71,7 +71,7 @@ describe 'Merge Requests > User filters by approvers', :js do
 
   context 'filtering by multiple approvers' do
     it 'applies the filter' do
-      input_filtered_search("approver=@#{first_user.username} approver=@#{user.username}")
+      input_filtered_search("approver:=@#{first_user.username} approver:=@#{user.username}")
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
 
@@ -84,7 +84,7 @@ describe 'Merge Requests > User filters by approvers', :js do
 
   context 'filtering by an approver from a group' do
     it 'applies the filter' do
-      input_filtered_search("approver=@#{group_user.username}")
+      input_filtered_search("approver:=@#{group_user.username}")
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
 

spec/features/admin/admin_runners_spec.rb

@@ -57,7 +57,7 @@ describe "Admin Runners" do
           expect(page).to have_content 'runner-active'
           expect(page).to have_content 'runner-paused'
 
-          input_filtered_search_keys('status=active')
+          input_filtered_search_keys('status:=active')
           expect(page).to have_content 'runner-active'
           expect(page).not_to have_content 'runner-paused'
         end
@@ -68,7 +68,7 @@ describe "Admin Runners" do
 
           visit admin_runners_path
 
-          input_filtered_search_keys('status=offline')
+          input_filtered_search_keys('status:=offline')
 
           expect(page).not_to have_content 'runner-active'
           expect(page).not_to have_content 'runner-paused'
@@ -83,12 +83,12 @@ describe "Admin Runners" do
 
           visit admin_runners_path
 
-          input_filtered_search_keys('status=active')
+          input_filtered_search_keys('status:=active')
           expect(page).to have_content 'runner-a-1'
           expect(page).to have_content 'runner-b-1'
           expect(page).not_to have_content 'runner-a-2'
 
-          input_filtered_search_keys('status=active runner-a')
+          input_filtered_search_keys('status:=active runner-a')
           expect(page).to have_content 'runner-a-1'
           expect(page).not_to have_content 'runner-b-1'
           expect(page).not_to have_content 'runner-a-2'
@@ -105,7 +105,7 @@ describe "Admin Runners" do
           expect(page).to have_content 'runner-project'
           expect(page).to have_content 'runner-group'
 
-          input_filtered_search_keys('type=project_type')
+          input_filtered_search_keys('type:=project_type')
           expect(page).to have_content 'runner-project'
           expect(page).not_to have_content 'runner-group'
         end
@@ -116,7 +116,7 @@ describe "Admin Runners" do
 
           visit admin_runners_path
 
-          input_filtered_search_keys('type=instance_type')
+          input_filtered_search_keys('type:=instance_type')
 
           expect(page).not_to have_content 'runner-project'
           expect(page).not_to have_content 'runner-group'
@@ -131,12 +131,12 @@ describe "Admin Runners" do
 
           visit admin_runners_path
 
-          input_filtered_search_keys('type=project_type')
+          input_filtered_search_keys('type:=project_type')
           expect(page).to have_content 'runner-a-1'
           expect(page).to have_content 'runner-b-1'
           expect(page).not_to have_content 'runner-a-2'
 
-          input_filtered_search_keys('type=project_type runner-a')
+          input_filtered_search_keys('type:=project_type runner-a')
           expect(page).to have_content 'runner-a-1'
           expect(page).not_to have_content 'runner-b-1'
           expect(page).not_to have_content 'runner-a-2'
@@ -153,7 +153,7 @@ describe "Admin Runners" do
           expect(page).to have_content 'runner-blue'
           expect(page).to have_content 'runner-red'
 
-          input_filtered_search_keys('tag=blue')
+          input_filtered_search_keys('tag:=blue')
 
           expect(page).to have_content 'runner-blue'
           expect(page).not_to have_content 'runner-red'
@@ -165,7 +165,7 @@ describe "Admin Runners" do
 
           visit admin_runners_path
 
-          input_filtered_search_keys('tag=red')
+          input_filtered_search_keys('tag:=red')
 
           expect(page).not_to have_content 'runner-blue'
           expect(page).not_to have_content 'runner-blue'
@@ -179,13 +179,13 @@ describe "Admin Runners" do
 
           visit admin_runners_path
 
-          input_filtered_search_keys('tag=blue')
+          input_filtered_search_keys('tag:=blue')
 
           expect(page).to have_content 'runner-a-1'
           expect(page).to have_content 'runner-b-1'
           expect(page).not_to have_content 'runner-a-2'
 
-          input_filtered_search_keys('tag=blue runner-a')
+          input_filtered_search_keys('tag:=blue runner-a')
 
           expect(page).to have_content 'runner-a-1'
           expect(page).not_to have_content 'runner-b-1'

spec/features/boards/boards_spec.rb

@@ -624,7 +624,7 @@ describe 'Issue Boards', :js do
   end
 
   def set_filter(type, text)
-    find('.filtered-search').native.send_keys("#{type}=#{text}")
+    find('.filtered-search').native.send_keys("#{type}:=#{text}")
   end
 
   def submit_filter

spec/features/boards/modal_filter_spec.rb

@@ -211,7 +211,7 @@ describe 'Issue Boards add issue modal filtering', :js do
   end
 
   def set_filter(type, text = '')
-    find('.add-issues-modal .filtered-search').native.send_keys("#{type}=#{text}")
+    find('.add-issues-modal .filtered-search').native.send_keys("#{type}:=#{text}")
   end
 
   def submit_filter

spec/features/dashboard/issues_filter_spec.rb

@@ -28,14 +28,14 @@ describe 'Dashboard Issues filtering', :js do
 
   context 'filtering by milestone' do
     it 'shows all issues with no milestone' do
-      input_filtered_search("milestone=none")
+      input_filtered_search("milestone:=none")
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
       expect(page).to have_selector('.issue', count: 1)
     end
 
     it 'shows all issues with the selected milestone' do
-      input_filtered_search("milestone=%\"#{milestone.title}\"")
+      input_filtered_search("milestone:=%\"#{milestone.title}\"")
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
       expect(page).to have_selector('.issue', count: 1)
@@ -63,7 +63,7 @@ describe 'Dashboard Issues filtering', :js do
     let!(:label_link) { create(:label_link, label: label, target: issue) }
 
     it 'shows all issues with the selected label' do
-      input_filtered_search("label=~#{label.title}")
+      input_filtered_search("label:=~#{label.title}")
 
       page.within 'ul.content-list' do
         expect(page).to have_content issue.title

spec/features/dashboard/issues_spec.rb

@@ -30,7 +30,7 @@ RSpec.describe 'Dashboard Issues' do
 
     it 'shows issues when current user is author', :js do
       reset_filters
-      input_filtered_search("author=#{current_user.to_reference}")
+      input_filtered_search("author:=#{current_user.to_reference}")
 
       expect(page).to have_content(authored_issue.title)
       expect(page).to have_content(authored_issue_on_public_project.title)

spec/features/dashboard/merge_requests_spec.rb

@@ -107,7 +107,7 @@ describe 'Dashboard Merge Requests' do
 
     it 'shows authored merge requests', :js do
       reset_filters
-      input_filtered_search("author=#{current_user.to_reference}")
+      input_filtered_search("author:=#{current_user.to_reference}")
 
       expect(page).to have_content(authored_merge_request.title)
       expect(page).to have_content(authored_merge_request_from_fork.title)
@@ -120,7 +120,7 @@ describe 'Dashboard Merge Requests' do
 
     it 'shows labeled merge requests', :js do
       reset_filters
-      input_filtered_search("label=#{label.name}")
+      input_filtered_search("label:=#{label.name}")
 
       expect(page).to have_content(labeled_merge_request.title)
 

spec/features/groups/issues_spec.rb

@@ -48,7 +48,7 @@ describe 'Group issues page' do
       let(:user2) { user_outside_group }
 
       it 'filters by only group users' do
-        filtered_search.set('assignee=')
+        filtered_search.set('assignee:=')
 
         expect(find('#js-dropdown-assignee .filter-dropdown')).to have_content(user.name)
         expect(find('#js-dropdown-assignee .filter-dropdown')).not_to have_content(user2.name)

spec/features/groups/merge_requests_spec.rb

@@ -52,7 +52,7 @@ describe 'Group merge requests page' do
     let(:user2) { user_outside_group }
 
     it 'filters by assignee only group users' do
-      filtered_search.set('assignee=')
+      filtered_search.set('assignee:=')
 
       expect(find('#js-dropdown-assignee .filter-dropdown')).to have_content(user.name)
       expect(find('#js-dropdown-assignee .filter-dropdown')).not_to have_content(user2.name)

spec/features/issues/filtered_search/dropdown_assignee_spec.rb

@@ -20,13 +20,13 @@ describe 'Dropdown assignee', :js do
 
   describe 'behavior' do
     it 'loads all the assignees when opened' do
-      input_filtered_search('assignee=', submit: false, extra_space: false)
+      input_filtered_search('assignee:=', submit: false, extra_space: false)
 
       expect_filtered_search_dropdown_results(filter_dropdown, 2)
     end
 
     it 'shows current user at top of dropdown' do
-      input_filtered_search('assignee=', submit: false, extra_space: false)
+      input_filtered_search('assignee:=', submit: false, extra_space: false)
 
       expect(filter_dropdown.first('.filter-dropdown-item')).to have_content(user.name)
     end
@@ -35,7 +35,7 @@ describe 'Dropdown assignee', :js do
   describe 'selecting from dropdown without Ajax call' do
     before do
       Gitlab::Testing::RequestBlockerMiddleware.block_requests!
-      input_filtered_search('assignee=', submit: false, extra_space: false)
+      input_filtered_search('assignee:=', submit: false, extra_space: false)
     end
 
     after do

spec/features/issues/filtered_search/dropdown_author_spec.rb

@@ -20,13 +20,13 @@ describe 'Dropdown author', :js do
 
   describe 'behavior' do
     it 'loads all the authors when opened' do
-      input_filtered_search('author=', submit: false, extra_space: false)
+      input_filtered_search('author:=', submit: false, extra_space: false)
 
       expect_filtered_search_dropdown_results(filter_dropdown, 2)
     end
 
     it 'shows current user at top of dropdown' do
-      input_filtered_search('author=', submit: false, extra_space: false)
+      input_filtered_search('author:=', submit: false, extra_space: false)
 
       expect(filter_dropdown.first('.filter-dropdown-item')).to have_content(user.name)
     end
@@ -35,7 +35,7 @@ describe 'Dropdown author', :js do
   describe 'selecting from dropdown without Ajax call' do
     before do
       Gitlab::Testing::RequestBlockerMiddleware.block_requests!
-      input_filtered_search('author=', submit: false, extra_space: false)
+      input_filtered_search('author:=', submit: false, extra_space: false)
     end
 
     after do

spec/features/issues/filtered_search/dropdown_base_spec.rb

@@ -27,14 +27,14 @@ describe 'Dropdown base', :js do
     it 'shows loading indicator when opened' do
       slow_requests do
         # We aren't using `input_filtered_search` because we want to see the loading indicator
-        filtered_search.set('assignee=')
+        filtered_search.set('assignee:=')
 
         expect(page).to have_css("#{js_dropdown_assignee} .filter-dropdown-loading", visible: true)
       end
     end
 
     it 'hides loading indicator when loaded' do
-      input_filtered_search('assignee=', submit: false, extra_space: false)
+      input_filtered_search('assignee:=', submit: false, extra_space: false)
 
       expect(find(js_dropdown_assignee)).not_to have_css('.filter-dropdown-loading')
     end
@@ -42,7 +42,7 @@ describe 'Dropdown base', :js do
 
   describe 'caching requests' do
     it 'caches requests after the first load' do
-      input_filtered_search('assignee=', submit: false, extra_space: false)
+      input_filtered_search('assignee:=', submit: false, extra_space: false)
       initial_size = dropdown_assignee_size
 
       expect(initial_size).to be > 0
@@ -50,7 +50,7 @@ describe 'Dropdown base', :js do
       new_user = create(:user)
       project.add_maintainer(new_user)
       find('.filtered-search-box .clear-search').click
-      input_filtered_search('assignee=', submit: false, extra_space: false)
+      input_filtered_search('assignee:=', submit: false, extra_space: false)
 
       expect(dropdown_assignee_size).to eq(initial_size)
     end

spec/features/issues/filtered_search/dropdown_emoji_spec.rb

@@ -43,19 +43,19 @@ describe 'Dropdown emoji', :js do
 
     describe 'behavior' do
       it 'opens when the search bar has my-reaction=' do
-        filtered_search.set('my-reaction=')
+        filtered_search.set('my-reaction:=')
 
         expect(page).to have_css(js_dropdown_emoji, visible: true)
       end
 
       it 'loads all the emojis when opened' do
-        input_filtered_search('my-reaction=', submit: false, extra_space: false)
+        input_filtered_search('my-reaction:=', submit: false, extra_space: false)
 
         expect_filtered_search_dropdown_results(filter_dropdown, 3)
       end
 
       it 'shows the most populated emoji at top of dropdown' do
-        input_filtered_search('my-reaction=', submit: false, extra_space: false)
+        input_filtered_search('my-reaction:=', submit: false, extra_space: false)
 
         expect(first("#{js_dropdown_emoji} .filter-dropdown li")).to have_content(award_emoji_star.name)
       end

spec/features/issues/filtered_search/dropdown_label_spec.rb

@@ -21,7 +21,7 @@ describe 'Dropdown label', :js do
   describe 'behavior' do
     it 'loads all the labels when opened' do
       create(:label, project: project, title: 'bug-label')
-      filtered_search.set('label=')
+      filtered_search.set('label:=')
 
       expect_filtered_search_dropdown_results(filter_dropdown, 1)
     end

spec/features/issues/filtered_search/dropdown_milestone_spec.rb

@@ -23,7 +23,7 @@ describe 'Dropdown milestone', :js do
 
   describe 'behavior' do
     before do
-      filtered_search.set('milestone=')
+      filtered_search.set('milestone:=')
     end
 
     it 'loads all the milestones when opened' do

spec/features/issues/filtered_search/dropdown_release_spec.rb

@@ -23,7 +23,7 @@ describe 'Dropdown release', :js do
 
   describe 'behavior' do
     before do
-      filtered_search.set('release=')
+      filtered_search.set('release:=')
     end
 
     it 'loads all the releases when opened' do

spec/features/issues/filtered_search/filter_issues_spec.rb

@@ -67,7 +67,7 @@ describe 'Filter issues', :js do
   it 'filters by all available tokens' do
     search_term = 'issue'
 
-    input_filtered_search("assignee=@#{user.username} author=@#{user.username} label=~#{caps_sensitive_label.title} milestone=%#{milestone.title} #{search_term}")
+    input_filtered_search("assignee:=@#{user.username} author:=@#{user.username} label:=~#{caps_sensitive_label.title} milestone:=%#{milestone.title} #{search_term}")
 
     wait_for_requests
 
@@ -84,7 +84,7 @@ describe 'Filter issues', :js do
   describe 'filter issues by author' do
     context 'only author' do
       it 'filters issues by searched author' do
-        input_filtered_search("author=@#{user.username}")
+        input_filtered_search("author:=@#{user.username}")
 
         wait_for_requests
 
@@ -98,7 +98,7 @@ describe 'Filter issues', :js do
   describe 'filter issues by assignee' do
     context 'only assignee' do
       it 'filters issues by searched assignee' do
-        input_filtered_search("assignee=@#{user.username}")
+        input_filtered_search("assignee:=@#{user.username}")
 
         wait_for_requests
 
@@ -108,7 +108,7 @@ describe 'Filter issues', :js do
       end
 
       it 'filters issues by no assignee' do
-        input_filtered_search('assignee=none')
+        input_filtered_search('assignee:=none')
 
         expect_tokens([assignee_token('None')])
         expect_issues_list_count(3)
@@ -122,7 +122,7 @@ describe 'Filter issues', :js do
       it 'filters issues by multiple assignees' do
         create(:issue, project: project, author: user, assignees: [user2, user])
 
-        input_filtered_search("assignee=@#{user.username} assignee=@#{user2.username}")
+        input_filtered_search("assignee:=@#{user.username} assignee:=@#{user2.username}")
 
         expect_tokens([
           assignee_token(user.name),
@@ -138,7 +138,7 @@ describe 'Filter issues', :js do
   describe 'filter issues by label' do
     context 'only label' do
       it 'filters issues by searched label' do
-        input_filtered_search("label=~#{bug_label.title}")
+        input_filtered_search("label:=~#{bug_label.title}")
 
         expect_tokens([label_token(bug_label.title)])
         expect_issues_list_count(2)
@@ -146,7 +146,7 @@ describe 'Filter issues', :js do
       end
 
       it 'filters issues not containing searched label' do
-        input_filtered_search("label!=~#{bug_label.title}")
+        input_filtered_search("label:!=~#{bug_label.title}")
 
         expect_tokens([label_token(bug_label.title)])
         expect_issues_list_count(6)
@@ -154,7 +154,7 @@ describe 'Filter issues', :js do
       end
 
       it 'filters issues by no label' do
-        input_filtered_search('label=none')
+        input_filtered_search('label:=none')
 
         expect_tokens([label_token('None', false)])
         expect_issues_list_count(4)
@@ -162,7 +162,7 @@ describe 'Filter issues', :js do
       end
 
       it 'filters issues by no label' do
-        input_filtered_search('label!=none')
+        input_filtered_search('label:!=none')
 
         expect_tokens([label_token('None', false)])
         expect_issues_list_count(4)
@@ -170,7 +170,7 @@ describe 'Filter issues', :js do
       end
 
       it 'filters issues by multiple labels' do
-        input_filtered_search("label=~#{bug_label.title} label=~#{caps_sensitive_label.title}")
+        input_filtered_search("label:=~#{bug_label.title} label:=~#{caps_sensitive_label.title}")
 
         expect_tokens([
           label_token(bug_label.title),
@@ -181,7 +181,7 @@ describe 'Filter issues', :js do
       end
 
       it 'filters issues by multiple labels with not operator' do
-        input_filtered_search("label!=~#{bug_label.title} label=~#{caps_sensitive_label.title}")
+        input_filtered_search("label:!=~#{bug_label.title} label:=~#{caps_sensitive_label.title}")
 
         expect_tokens([
           label_token(bug_label.title),
@@ -196,7 +196,7 @@ describe 'Filter issues', :js do
         special_issue = create(:issue, title: "Issue with special character label", project: project)
         special_issue.labels << special_label
 
-        input_filtered_search("label=~#{special_label.title}")
+        input_filtered_search("label:=~#{special_label.title}")
 
         expect_tokens([label_token(special_label.title)])
         expect_issues_list_count(1)
@@ -208,7 +208,7 @@ describe 'Filter issues', :js do
         special_issue = create(:issue, title: "Issue with special character label", project: project)
         special_issue.labels << special_label
 
-        input_filtered_search("label!=~#{special_label.title}")
+        input_filtered_search("label:!=~#{special_label.title}")
 
         expect_tokens([label_token(special_label.title)])
         expect_issues_list_count(8)
@@ -218,7 +218,7 @@ describe 'Filter issues', :js do
       it 'does not show issues for unused labels' do
         new_label = create(:label, project: project, title: 'new_label')
 
-        input_filtered_search("label=~#{new_label.title}")
+        input_filtered_search("label:=~#{new_label.title}")
 
         expect_tokens([label_token(new_label.title)])
         expect_no_issues_list
@@ -226,7 +226,7 @@ describe 'Filter issues', :js do
       end
 
       it 'does show issues for bug label' do
-        input_filtered_search("label!=~#{bug_label.title}")
+        input_filtered_search("label:!=~#{bug_label.title}")
 
         expect_tokens([label_token(bug_label.title)])
         expect_issues_list_count(6)
@@ -240,7 +240,7 @@ describe 'Filter issues', :js do
         special_multiple_issue = create(:issue, title: "Issue with special character multiple words label", project: project)
         special_multiple_issue.labels << special_multiple_label
 
-        input_filtered_search("label=~'#{special_multiple_label.title}'")
+        input_filtered_search("label:=~'#{special_multiple_label.title}'")
 
         # Check for search results (which makes sure that the page has changed)
         expect_issues_list_count(1)
@@ -252,7 +252,7 @@ describe 'Filter issues', :js do
       end
 
       it 'single quotes' do
-        input_filtered_search("label=~'#{multiple_words_label.title}'")
+        input_filtered_search("label:=~'#{multiple_words_label.title}'")
 
         expect_issues_list_count(1)
         expect_tokens([label_token("\"#{multiple_words_label.title}\"")])
@@ -260,7 +260,7 @@ describe 'Filter issues', :js do
       end
 
       it 'double quotes' do
-        input_filtered_search("label=~\"#{multiple_words_label.title}\"")
+        input_filtered_search("label:=~\"#{multiple_words_label.title}\"")
 
         expect_tokens([label_token("\"#{multiple_words_label.title}\"")])
         expect_issues_list_count(1)
@@ -272,7 +272,7 @@ describe 'Filter issues', :js do
         double_quotes_label_issue = create(:issue, title: "Issue with double quotes label", project: project)
         double_quotes_label_issue.labels << double_quotes_label
 
-        input_filtered_search("label=~'#{double_quotes_label.title}'")
+        input_filtered_search("label:=~'#{double_quotes_label.title}'")
 
         expect_tokens([label_token("'#{double_quotes_label.title}'")])
         expect_issues_list_count(1)
@@ -284,7 +284,7 @@ describe 'Filter issues', :js do
         single_quotes_label_issue = create(:issue, title: "Issue with single quotes label", project: project)
         single_quotes_label_issue.labels << single_quotes_label
 
-        input_filtered_search("label=~\"#{single_quotes_label.title}\"")
+        input_filtered_search("label:=~\"#{single_quotes_label.title}\"")
 
         expect_tokens([label_token("\"#{single_quotes_label.title}\"")])
         expect_issues_list_count(1)
@@ -296,7 +296,7 @@ describe 'Filter issues', :js do
       it 'filters issues by searched label, label2, author, assignee, milestone and text' do
         search_term = 'bug'
 
-        input_filtered_search("label=~#{bug_label.title} label=~#{caps_sensitive_label.title} author=@#{user.username} assignee=@#{user.username} milestone=%#{milestone.title} #{search_term}")
+        input_filtered_search("label:=~#{bug_label.title} label:=~#{caps_sensitive_label.title} author:=@#{user.username} assignee:=@#{user.username} milestone:=%#{milestone.title} #{search_term}")
 
         wait_for_requests
 
@@ -314,7 +314,7 @@ describe 'Filter issues', :js do
       it 'filters issues by searched label, label2, author, assignee, not included in a milestone' do
         search_term = 'bug'
 
-        input_filtered_search("label=~#{bug_label.title} label=~#{caps_sensitive_label.title} author=@#{user.username} assignee=@#{user.username} milestone!=%#{milestone.title} #{search_term}")
+        input_filtered_search("label:=~#{bug_label.title} label:=~#{caps_sensitive_label.title} author:=@#{user.username} assignee:=@#{user.username} milestone:!=%#{milestone.title} #{search_term}")
 
         wait_for_requests
 
@@ -344,7 +344,7 @@ describe 'Filter issues', :js do
   describe 'filter issues by milestone' do
     context 'only milestone' do
       it 'filters issues by searched milestone' do
-        input_filtered_search("milestone=%#{milestone.title}")
+        input_filtered_search("milestone:=%#{milestone.title}")
 
         expect_tokens([milestone_token(milestone.title)])
         expect_issues_list_count(5)
@@ -352,7 +352,7 @@ describe 'Filter issues', :js do
       end
 
       it 'filters issues by no milestone' do
-        input_filtered_search("milestone=none")
+        input_filtered_search("milestone:=none")
 
         expect_tokens([milestone_token('None', false)])
         expect_issues_list_count(3)
@@ -360,7 +360,7 @@ describe 'Filter issues', :js do
       end
 
       it 'filters issues by negation of no milestone' do
-        input_filtered_search("milestone!=none ")
+        input_filtered_search("milestone:!=none ")
 
         expect_tokens([milestone_token('None', false, '!=')])
         expect_issues_list_count(5)
@@ -372,7 +372,7 @@ describe 'Filter issues', :js do
           create(:issue, project: project, milestone: future_milestone, author: user)
         end
 
-        input_filtered_search("milestone=upcoming")
+        input_filtered_search("milestone:=upcoming")
 
         expect_tokens([milestone_token('Upcoming', false)])
         expect_issues_list_count(1)
@@ -384,7 +384,7 @@ describe 'Filter issues', :js do
           create(:issue, project: project, milestone: future_milestone, author: user)
         end
 
-        input_filtered_search("milestone!=upcoming")
+        input_filtered_search("milestone:!=upcoming")
 
         expect_tokens([milestone_token('Upcoming', false, '!=')])
         expect_issues_list_count(8)
@@ -392,7 +392,7 @@ describe 'Filter issues', :js do
       end
 
       it 'filters issues by started milestones' do
-        input_filtered_search("milestone=started")
+        input_filtered_search("milestone:=started")
 
         expect_tokens([milestone_token('Started', false)])
         expect_issues_list_count(5)
@@ -400,7 +400,7 @@ describe 'Filter issues', :js do
       end
 
       it 'filters issues by negation of started milestones' do
-        input_filtered_search("milestone!=started")
+        input_filtered_search("milestone:!=started")
 
         expect_tokens([milestone_token('Started', false, '!=')])
         expect_issues_list_count(3)
@@ -411,7 +411,7 @@ describe 'Filter issues', :js do
         special_milestone = create(:milestone, title: '!@\#{$%^&*()}', project: project)
         create(:issue, project: project, milestone: special_milestone)
 
-        input_filtered_search("milestone=%#{special_milestone.title}")
+        input_filtered_search("milestone:=%#{special_milestone.title}")
 
         expect_tokens([milestone_token(special_milestone.title)])
         expect_issues_list_count(1)
@@ -422,7 +422,7 @@ describe 'Filter issues', :js do
         special_milestone = create(:milestone, title: '!@\#{$%^&*()}', project: project)
         create(:issue, project: project, milestone: special_milestone)
 
-        input_filtered_search("milestone!=%#{special_milestone.title}")
+        input_filtered_search("milestone:!=%#{special_milestone.title}")
 
         expect_tokens([milestone_token(special_milestone.title, false, '!=')])
         expect_issues_list_count(8)
@@ -432,7 +432,7 @@ describe 'Filter issues', :js do
       it 'does not show issues for unused milestones' do
         new_milestone = create(:milestone, title: 'new', project: project)
 
-        input_filtered_search("milestone=%#{new_milestone.title}")
+        input_filtered_search("milestone:=%#{new_milestone.title}")
 
         expect_tokens([milestone_token(new_milestone.title)])
         expect_no_issues_list
@@ -442,7 +442,7 @@ describe 'Filter issues', :js do
       it 'show issues for unused milestones' do
         new_milestone = create(:milestone, title: 'new', project: project)
 
-        input_filtered_search("milestone!=%#{new_milestone.title}")
+        input_filtered_search("milestone:!=%#{new_milestone.title}")
 
         expect_tokens([milestone_token(new_milestone.title, false, '!=')])
         expect_issues_list_count(8)
@@ -521,7 +521,7 @@ describe 'Filter issues', :js do
 
     context 'searched text with other filters' do
       it 'filters issues by searched text, author, text, assignee, text, label1, text, label2, text, milestone and text' do
-        input_filtered_search("bug author=@#{user.username} report label=~#{bug_label.title} label=~#{caps_sensitive_label.title} milestone=%#{milestone.title} foo")
+        input_filtered_search("bug author:=@#{user.username} report label:=~#{bug_label.title} label:=~#{caps_sensitive_label.title} milestone:=%#{milestone.title} foo")
 
         expect_issues_list_count(1)
         expect_filtered_search_input('bug report foo')
@@ -595,7 +595,7 @@ describe 'Filter issues', :js do
     end
 
     it 'milestone dropdown loads milestones' do
-      input_filtered_search("milestone=", submit: false)
+      input_filtered_search("milestone:=", submit: false)
 
       within('#js-dropdown-milestone') do
         expect(page).to have_selector('.filter-dropdown .filter-dropdown-item', count: 1)
@@ -603,7 +603,7 @@ describe 'Filter issues', :js do
     end
 
     it 'label dropdown load labels' do
-      input_filtered_search("label=", submit: false)
+      input_filtered_search("label:=", submit: false)
 
       within('#js-dropdown-label') do
         expect(page).to have_selector('.filter-dropdown .filter-dropdown-item', count: 3)

spec/features/issues/filtered_search/visual_tokens_spec.rb

@@ -36,7 +36,7 @@ describe 'Visual tokens', :js do
 
   describe 'editing a single token' do
     before do
-      input_filtered_search('author=@root assignee=none', submit: false)
+      input_filtered_search('author:=@root assignee:=none', submit: false)
       first('.tokens-container .filtered-search-token').click
       wait_for_requests
     end
@@ -77,7 +77,7 @@ describe 'Visual tokens', :js do
 
   describe 'editing multiple tokens' do
     before do
-      input_filtered_search('author=@root assignee=none', submit: false)
+      input_filtered_search('author:=@root assignee:=none', submit: false)
       first('.tokens-container .filtered-search-token').click
     end
 
@@ -93,7 +93,7 @@ describe 'Visual tokens', :js do
 
   describe 'editing a search term while editing another filter token' do
     before do
-      input_filtered_search('foo assignee=', submit: false)
+      input_filtered_search('foo assignee:=', submit: false)
       first('.tokens-container .filtered-search-term').click
     end
 
@@ -112,7 +112,7 @@ describe 'Visual tokens', :js do
 
   describe 'add new token after editing existing token' do
     before do
-      input_filtered_search('author=@root assignee=none', submit: false)
+      input_filtered_search('author:=@root assignee:=none', submit: false)
       first('.tokens-container .filtered-search-token').double_click
       filtered_search.send_keys(' ')
     end
@@ -123,7 +123,7 @@ describe 'Visual tokens', :js do
       end
 
       it 'opens token dropdown' do
-        filtered_search.send_keys('author=')
+        filtered_search.send_keys('author:=')
 
         expect(page).to have_css('#js-dropdown-author', visible: true)
       end
@@ -131,7 +131,7 @@ describe 'Visual tokens', :js do
 
     describe 'visual tokens' do
       it 'creates visual token' do
-        filtered_search.send_keys('author=@thomas ')
+        filtered_search.send_keys('author:=@thomas ')
         token = page.all('.tokens-container .filtered-search-token')[1]
 
         expect(token.find('.name').text).to eq('Author')
@@ -140,7 +140,7 @@ describe 'Visual tokens', :js do
     end
 
     it 'does not tokenize incomplete token' do
-      filtered_search.send_keys('author=')
+      filtered_search.send_keys('author:=')
 
       find('body').click
       token = page.all('.tokens-container .js-visual-token')[1]
@@ -152,7 +152,7 @@ describe 'Visual tokens', :js do
 
   describe 'search using incomplete visual tokens' do
     before do
-      input_filtered_search('author=@root assignee=none', extra_space: false)
+      input_filtered_search('author:=@root assignee:=none', extra_space: false)
     end
 
     it 'tokenizes the search term to complete visual token' do

spec/features/merge_requests/filters_generic_behavior_spec.rb

@@ -23,7 +23,7 @@ describe 'Merge Requests > Filters generic behavior', :js do
 
   context 'when filtered by a label' do
     before do
-      input_filtered_search('label=~bug')
+      input_filtered_search('label:=~bug')
     end
 
     describe 'state tabs' do

spec/features/merge_requests/user_filters_by_assignees_spec.rb

@@ -18,7 +18,7 @@ describe 'Merge Requests > User filters by assignees', :js do
 
   context 'filtering by assignee:none' do
     it 'applies the filter' do
-      input_filtered_search('assignee=none')
+      input_filtered_search('assignee:=none')
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
       expect(page).not_to have_content 'Bugfix1'
@@ -28,7 +28,7 @@ describe 'Merge Requests > User filters by assignees', :js do
 
   context 'filtering by assignee=@username' do
     it 'applies the filter' do
-      input_filtered_search("assignee=@#{user.username}")
+      input_filtered_search("assignee:=@#{user.username}")
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
       expect(page).to have_content 'Bugfix1'

spec/features/merge_requests/user_filters_by_labels_spec.rb

@@ -22,7 +22,7 @@ describe 'Merge Requests > User filters by labels', :js do
 
   context 'filtering by label:none' do
     it 'applies the filter' do
-      input_filtered_search('label=none')
+      input_filtered_search('label:=none')
 
       expect(page).to have_issuable_counts(open: 0, closed: 0, all: 0)
       expect(page).not_to have_content 'Bugfix1'
@@ -32,7 +32,7 @@ describe 'Merge Requests > User filters by labels', :js do
 
   context 'filtering by label:~enhancement' do
     it 'applies the filter' do
-      input_filtered_search('label=~enhancement')
+      input_filtered_search('label:=~enhancement')
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
       expect(page).to have_content 'Bugfix2'
@@ -42,7 +42,7 @@ describe 'Merge Requests > User filters by labels', :js do
 
   context 'filtering by label:~enhancement and label:~bug' do
     it 'applies the filters' do
-      input_filtered_search('label=~bug label=~enhancement')
+      input_filtered_search('label:=~bug label:=~enhancement')
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
       expect(page).to have_content 'Bugfix2'

spec/features/merge_requests/user_filters_by_milestones_spec.rb

@@ -18,14 +18,14 @@ describe 'Merge Requests > User filters by milestones', :js do
   end
 
   it 'filters by no milestone' do
-    input_filtered_search('milestone=none')
+    input_filtered_search('milestone:=none')
 
     expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
     expect(page).to have_css('.merge-request', count: 1)
   end
 
   it 'filters by a specific milestone' do
-    input_filtered_search("milestone=%'#{milestone.title}'")
+    input_filtered_search("milestone:=%'#{milestone.title}'")
 
     expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
     expect(page).to have_css('.merge-request', count: 1)
@@ -33,7 +33,7 @@ describe 'Merge Requests > User filters by milestones', :js do
 
   describe 'filters by upcoming milestone' do
     it 'does not show merge requests with no expiry' do
-      input_filtered_search('milestone=upcoming')
+      input_filtered_search('milestone:=upcoming')
 
       expect(page).to have_issuable_counts(open: 0, closed: 0, all: 0)
       expect(page).to have_css('.merge-request', count: 0)
@@ -43,7 +43,7 @@ describe 'Merge Requests > User filters by milestones', :js do
       let(:milestone) { create(:milestone, project: project, due_date: Date.tomorrow) }
 
       it 'shows merge requests' do
-        input_filtered_search('milestone=upcoming')
+        input_filtered_search('milestone:=upcoming')
 
         expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
         expect(page).to have_css('.merge-request', count: 1)
@@ -54,7 +54,7 @@ describe 'Merge Requests > User filters by milestones', :js do
       let(:milestone) { create(:milestone, project: project, due_date: Date.yesterday) }
 
       it 'does not show any merge requests' do
-        input_filtered_search('milestone=upcoming')
+        input_filtered_search('milestone:=upcoming')
 
         expect(page).to have_issuable_counts(open: 0, closed: 0, all: 0)
         expect(page).to have_css('.merge-request', count: 0)

spec/features/merge_requests/user_filters_by_multiple_criteria_spec.rb

@@ -20,7 +20,7 @@ describe 'Merge requests > User filters by multiple criteria', :js do
 
   describe 'filtering by label:~"Won\'t fix" and assignee:~bug' do
     it 'applies the filters' do
-      input_filtered_search("label=~\"Won't fix\" assignee=@#{user.username}")
+      input_filtered_search("label:=~\"Won't fix\" assignee:=@#{user.username}")
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
       expect(page).to have_content 'Bugfix2'
@@ -30,7 +30,7 @@ describe 'Merge requests > User filters by multiple criteria', :js do
 
   describe 'filtering by text, author, assignee, milestone, and label' do
     it 'filters by text, author, assignee, milestone, and label' do
-      input_filtered_search_keys("author=@#{user.username} assignee=@#{user.username} milestone=%\"v1.1\" label=~\"Won't fix\" Bug")
+      input_filtered_search_keys("author:=@#{user.username} assignee:=@#{user.username} milestone:=%\"v1.1\" label:=~\"Won't fix\" Bug")
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
       expect(page).to have_content 'Bugfix2'

spec/features/merge_requests/user_filters_by_target_branch_spec.rb

@@ -17,7 +17,7 @@ describe 'Merge Requests > User filters by target branch', :js do
 
   context 'filtering by target-branch:master' do
     it 'applies the filter' do
-      input_filtered_search('target-branch=master')
+      input_filtered_search('target-branch:=master')
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
       expect(page).to have_content mr1.title
@@ -27,7 +27,7 @@ describe 'Merge Requests > User filters by target branch', :js do
 
   context 'filtering by target-branch:merged-target' do
     it 'applies the filter' do
-      input_filtered_search('target-branch=merged-target')
+      input_filtered_search('target-branch:=merged-target')
 
       expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
       expect(page).not_to have_content mr1.title
@@ -37,7 +37,7 @@ describe 'Merge Requests > User filters by target branch', :js do
 
   context 'filtering by target-branch:feature' do
     it 'applies the filter' do
-      input_filtered_search('target-branch=feature')
+      input_filtered_search('target-branch:=feature')
 
       expect(page).to have_issuable_counts(open: 0, closed: 0, all: 0)
       expect(page).not_to have_content mr1.title

spec/support/helpers/filtered_search_helpers.rb

@@ -26,7 +26,7 @@ module FilteredSearchHelpers
   # Select a label clicking in the search dropdown instead
   # of entering label names on the input.
   def select_label_on_dropdown(label_title)
-    input_filtered_search("label=", submit: false)
+    input_filtered_search("label:=", submit: false)
 
     within('#js-dropdown-label') do
       wait_for_requests
@@ -71,7 +71,7 @@ module FilteredSearchHelpers
   end
 
   def init_label_search
-    filtered_search.set('label=')
+    filtered_search.set('label:=')
     # This ensures the dropdown is shown
     expect(find('#js-dropdown-label')).not_to have_css('.filter-dropdown-loading')
   end

spec/support/shared_examples/features/issuables_user_dropdown_behaviors_shared_examples.rb

@@ -13,7 +13,7 @@ RSpec.shared_examples 'issuable user dropdown behaviors' do
       it 'only includes members of the project/group' do
         visit issuables_path
 
-        filtered_search.set("#{dropdown}=")
+        filtered_search.set("#{dropdown}:=")
 
         expect(find("#js-dropdown-#{dropdown} .filter-dropdown")).to have_content(user_in_dropdown.name)
         expect(find("#js-dropdown-#{dropdown} .filter-dropdown")).not_to have_content(user_not_in_dropdown.name)