Merge branch 'kassio/bulkimports-enable-ff-by-default' into 'master'

Enable bulk_import feature flag by default

See merge request gitlab-org/gitlab!69110

app/controllers/import/bulk_imports_controller.rb

@@ -112,7 +112,7 @@ class Import::BulkImportsController < ApplicationController
   end
 
   def ensure_group_import_enabled
-    render_404 unless Feature.enabled?(:bulk_import)
+    render_404 unless Feature.enabled?(:bulk_import, default_enabled: :yaml)
   end
 
   def access_token_key

app/views/groups/new.html.haml

@@ -15,7 +15,7 @@
 
     #import-group-pane.tab-pane
       - if import_sources_enabled?
-        - if Feature.enabled?(:bulk_import)
+        - if Feature.enabled?(:bulk_import, default_enabled: :yaml)
           = render 'import_group_from_another_instance_panel'
           .gl-mt-7.gl-border-b-solid.gl-border-gray-100.gl-border-1
         = render 'import_group_from_file_panel'

config/feature_flags/development/bulk_import.yml

@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/255310
 milestone: '13.5'
 type: development
 group: group::import
-default_enabled: false
+default_enabled: true

doc/user/group/import/index.md

@@ -77,7 +77,7 @@ Any other items are **not** migrated.
 
 ## Enable or disable GitLab Group Migration
 
-GitLab Migration is deployed behind a feature flag that is **disabled by default**.
+GitLab Migration is deployed behind a feature flag that is **enabled by default**.
 [GitLab administrators with access to the GitLab Rails console](../../../administration/feature_flags.md) can enable it.
 
 To enable it:

qa/qa/specs/features/api/1_manage/bulk_import_group_spec.rb

@@ -54,7 +54,6 @@ module QA
       end
 
       before do
-        Runtime::Feature.enable(:bulk_import) unless staging?
         Runtime::Feature.enable(:top_level_group_creation_enabled) if staging?
 
         sandbox.add_member(user, Resource::Members::AccessLevel::MAINTAINER)
@@ -91,7 +90,6 @@ module QA
       after do
         user.remove_via_api!
       ensure
-        Runtime::Feature.disable(:bulk_import) unless staging?
         Runtime::Feature.disable(:top_level_group_creation_enabled) if staging?
       end
     end

qa/qa/specs/features/browser_ui/1_manage/group/bulk_import_group_spec.rb

@@ -38,7 +38,6 @@ module QA
       end
 
       before do
-        Runtime::Feature.enable(:bulk_import) unless staging?
         Runtime::Feature.enable(:top_level_group_creation_enabled) if staging?
 
         sandbox.add_member(user, Resource::Members::AccessLevel::MAINTAINER)
@@ -77,7 +76,6 @@ module QA
       after do
         user.remove_via_api!
       ensure
-        Runtime::Feature.disable(:bulk_import) unless staging?
         Runtime::Feature.disable(:top_level_group_creation_enabled) if staging?
       end
     end

qa/qa/specs/features/ee/api/1_manage/bulk_import_group_spec.rb

@@ -56,8 +56,6 @@ module QA
       end
 
       before do
-        Runtime::Feature.enable(:bulk_import)
-
         sandbox.add_member(user, Resource::Members::AccessLevel::MAINTAINER)
         source_group.add_member(author, Resource::Members::AccessLevel::MAINTAINER)
         author.set_public_email
@@ -83,8 +81,6 @@ module QA
       after do
         user.remove_via_api!
         author.remove_via_api!
-      ensure
-        Runtime::Feature.disable(:bulk_import)
       end
 
       it 'imports group epics', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/quality/test_cases/1921' do