Commit 06725b55 authored by Kyle Wiebers's avatar Kyle Wiebers Committed by Rémy Coutable

Initial tooling docs and danger changes

parent 2121aba9
...@@ -42,8 +42,9 @@ please list them here. ...@@ -42,8 +42,9 @@ please list them here.
Please select the appropriate label from the following: Please select the appropriate label from the following:
~"feature::addition" ~"feature::addition"
~"type::maintenance" ~"type::maintenance"
~"tooling::pipelines" ~"maintenance::refactor"
~"tooling::workflow" ~"maintenance::pipelines"
~"maintenance::workflow"
--> -->
/label ~"type::maintenance" /label ~"type::maintenance"
...@@ -35,4 +35,4 @@ This will help keep track of expected cost increases to the [GitLab project aver ...@@ -35,4 +35,4 @@ This will help keep track of expected cost increases to the [GitLab project aver
- [ ] Consider communicating these changes to the broader team following the [communication guideline for pipeline changes](https://about.gitlab.com/handbook/engineering/quality/engineering-productivity/#pipeline-changes) - [ ] Consider communicating these changes to the broader team following the [communication guideline for pipeline changes](https://about.gitlab.com/handbook/engineering/quality/engineering-productivity/#pipeline-changes)
/label ~"type::tooling" ~"tooling::pipelines" ~"Engineering Productivity" /label ~"maintenance::pipelines" ~"Engineering Productivity"
...@@ -9,7 +9,6 @@ SPECIALIZATIONS = { ...@@ -9,7 +9,6 @@ SPECIALIZATIONS = {
ux: 'UX', ux: 'UX',
docs: 'documentation', docs: 'documentation',
qa: 'QA', qa: 'QA',
tooling: 'type::tooling',
ci_template: 'ci::templates', ci_template: 'ci::templates',
feature_flag: 'feature flag' feature_flag: 'feature flag'
}.freeze }.freeze
......
# frozen_string_literal: true # frozen_string_literal: true
NO_SPECS_LABELS = [ NO_SPECS_LABELS = [
'type::tooling', 'maintenance::pipelines',
'tooling::pipelines', 'maintenance::workflow',
'tooling::workflow',
'documentation', 'documentation',
'QA' 'QA'
].freeze ].freeze
......
...@@ -45,7 +45,7 @@ scheduling into milestones. Labeling is a task for everyone. (For some projects, ...@@ -45,7 +45,7 @@ scheduling into milestones. Labeling is a task for everyone. (For some projects,
Most issues will have labels for at least one of the following: Most issues will have labels for at least one of the following:
- Type. For example: `~"type::feature"`, `~"type::bug"`, or `~"type::tooling"`. - Type. For example: `~"type::feature"`, `~"type::bug"`, or `~"type::maintenance"`.
- Stage. For example: `~"devops::plan"` or `~"devops::create"`. - Stage. For example: `~"devops::plan"` or `~"devops::create"`.
- Group. For example: `~"group::source code"`, `~"group::knowledge"`, or `~"group::editor"`. - Group. For example: `~"group::source code"`, `~"group::knowledge"`, or `~"group::editor"`.
- Category. For example: `~"Category:Code Analytics"`, `~"Category:DevOps Reports"`, or `~"Category:Templates"`. - Category. For example: `~"Category:Code Analytics"`, `~"Category:DevOps Reports"`, or `~"Category:Templates"`.
...@@ -72,19 +72,7 @@ labels, you can _always_ add the type, stage, group, and often the category/feat ...@@ -72,19 +72,7 @@ labels, you can _always_ add the type, stage, group, and often the category/feat
Type labels are very important. They define what kind of issue this is. Every Type labels are very important. They define what kind of issue this is. Every
issue should have one and only one. issue should have one and only one.
The current type labels are: The current type labels are [available in the handbook](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification)
- `~"type::feature"`
- `~"feature::addition"`
- `~"feature::enhancement"`
- `~"type::maintenance"`
- `~"type::bug"`
- `~"type::tooling"`
- `~"tooling::pipelines"`
- `~"tooling::workflow"`
- `~"support request"`
- `~meta`
- `~documentation`
A number of type labels have a priority assigned to them, which automatically A number of type labels have a priority assigned to them, which automatically
makes them float to the top, depending on their importance. makes them float to the top, depending on their importance.
......
...@@ -62,28 +62,28 @@ RSpec.describe Tooling::Danger::Datateam do ...@@ -62,28 +62,28 @@ RSpec.describe Tooling::Danger::Datateam do
'with metric file changes and no performance indicator changes and other label' => { 'with metric file changes and no performance indicator changes and other label' => {
modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml), modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml),
changed_lines: ['-product_stage: growth'], changed_lines: ['-product_stage: growth'],
mr_labels: ['type::tooling'], mr_labels: ['type::maintenance'],
impacted: false, impacted: false,
impacted_files: [] impacted_files: []
}, },
'with performance indicator changes and other label' => { 'with performance indicator changes and other label' => {
modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb),
changed_lines: ['+-gmau'], changed_lines: ['+-gmau'],
mr_labels: ['type::tooling'], mr_labels: ['type::maintenance'],
impacted: true, impacted: true,
impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml)
}, },
'with performance indicator changes, Data Warehouse::Impact Check and other label' => { 'with performance indicator changes, Data Warehouse::Impact Check and other label' => {
modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb),
changed_lines: ['+-gmau'], changed_lines: ['+-gmau'],
mr_labels: ['type::tooling', 'Data Warehouse::Impact Check'], mr_labels: ['type::maintenance', 'Data Warehouse::Impact Check'],
impacted: false, impacted: false,
impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml)
}, },
'with performance indicator changes and other labels' => { 'with performance indicator changes and other labels' => {
modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb),
changed_lines: ['+-gmau'], changed_lines: ['+-gmau'],
mr_labels: ['type::tooling', 'Data Warehouse::Impacted'], mr_labels: ['type::maintenance', 'Data Warehouse::Impacted'],
impacted: false, impacted: false,
impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml)
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment