Merge branch...

Merge branch '10248-npm-packages-with-a-dot-on-the-package-name-returns-403-when-trying-to-install' into 'master'

Fix NPM package install with a dot in the name

Closes #10248

See merge request gitlab-org/gitlab-ee!9900

ee/changelogs/unreleased/10248-npm-packages-with-a-dot-on-the-package-name-returns-403-when-trying-to-install.yml

+---
+title: Fix npm package install with a dot in the name
+merge_request: 9900
+author:
+type: fixed

ee/lib/api/npm_packages.rb

@@ -32,7 +32,7 @@ module API
     params do
       requires :package_name, type: String, desc: 'Package name'
     end
-    get 'packages/npm/*package_name', requirements: NPM_ENDPOINT_REQUIREMENTS do
+    get 'packages/npm/*package_name', format: false, requirements: NPM_ENDPOINT_REQUIREMENTS do
       package_name = params[:package_name]
 
       # To avoid name collision we require project path and project package be the same.

ee/spec/requests/api/npm_packages_spec.rb

@@ -35,6 +35,16 @@ describe API::NpmPackages do
 
         expect_a_valid_package_response
       end
+
+      context 'project path with a dot' do
+        let(:project) { create(:project, :public, namespace: group, path: 'foo.bar') }
+
+        it 'returns the package info' do
+          get_package(package)
+
+          expect_a_valid_package_response
+        end
+      end
     end
 
     context 'internal project' do