Merge branch '333791-fix-terraform-wrong-use-of-grouppackagesfinder' into 'master'

Fix bug due to fuzzy matching of terraform module names

See merge request gitlab-org/gitlab!73588

lib/api/terraform/modules/v1/packages.rb

@@ -46,7 +46,8 @@ module API
             def finder_params
               {
                 package_type: :terraform_module,
-                package_name: "#{params[:module_name]}/#{params[:module_system]}"
+                package_name: "#{params[:module_name]}/#{params[:module_system]}",
+                exact_name: true
               }.tap do |finder_params|
                 finder_params[:package_version] = params[:module_version] if params.has_key?(:module_version)
               end

spec/requests/api/terraform/modules/v1/packages_spec.rb

@@ -28,10 +28,25 @@ RSpec.describe API::Terraform::Modules::V1::Packages do
 
   describe 'GET /api/v4/packages/terraform/modules/v1/:module_namespace/:module_name/:module_system/versions' do
     let(:url) { api("/packages/terraform/modules/v1/#{group.path}/#{package.name}/versions") }
-    let(:headers) { {} }
+    let(:headers) { { 'Authorization' => "Bearer #{tokens[:job_token]}" } }
 
     subject { get(url, headers: headers) }
 
+    context 'with a conflicting package name' do
+      let!(:conflicting_package) { create(:terraform_module_package, project: project, name: "conflict-#{package.name}", version: '2.0.0') }
+
+      before do
+        group.add_developer(user)
+      end
+
+      it 'returns only one version' do
+        subject
+
+        expect(json_response['modules'][0]['versions'].size).to eq(1)
+        expect(json_response['modules'][0]['versions'][0]['version']).to eq('1.0.0')
+      end
+    end
+
     context 'with valid namespace' do
       where(:visibility, :user_role, :member, :token_type, :valid_token, :shared_examples_name, :expected_status) do
         :public  | :developer  | true  | :personal_access_token | true  | 'returns terraform module packages'        | :success