RSpec zero monkey patching mode

The plan for RSpec 4.0 is to disable monkey patching:
https://rspec.info/blog/2013/07/the-plan-for-rspec-3/#zero-monkey-patching-mode

This commit stops using RSpec monkey patching:
https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode

ee/spec/controllers/admin/application_settings_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::ApplicationSettingsController do
+RSpec.describe Admin::ApplicationSettingsController do
   include StubENV
 
   let(:admin) { create(:admin) }

ee/spec/controllers/admin/applications_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::ApplicationsController do
+RSpec.describe Admin::ApplicationsController do
   let(:admin) { create(:admin) }
   let(:application) { create(:oauth_application, owner_id: nil, owner_type: nil) }
 

ee/spec/controllers/admin/audit_logs_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::AuditLogsController do
+RSpec.describe Admin::AuditLogsController do
   let(:admin) { create(:admin) }
 
   describe 'GET #index' do

ee/spec/controllers/admin/clusters_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::ClustersController do
+RSpec.describe Admin::ClustersController do
   include AccessMatchersForController
 
   let(:user) { create(:admin) }

ee/spec/controllers/admin/credentials_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::CredentialsController do
+RSpec.describe Admin::CredentialsController do
   describe 'GET #index' do
     context 'admin user' do
       before do

ee/spec/controllers/admin/dashboard_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::DashboardController do
+RSpec.describe Admin::DashboardController do
   describe '#index' do
     render_views
 

ee/spec/controllers/admin/elasticsearch_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::ElasticsearchController do
+RSpec.describe Admin::ElasticsearchController do
   let(:admin) { create(:admin) }
 
   describe 'POST #enqueue_index' do

ee/spec/controllers/admin/emails_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::EmailsController, :clean_gitlab_redis_shared_state do
+RSpec.describe Admin::EmailsController, :clean_gitlab_redis_shared_state do
   include ExclusiveLeaseHelpers
 
   let_it_be(:admin) { create(:admin) }

ee/spec/controllers/admin/geo/nodes_controller_spec.rb

 # frozen_string_literal: true
 require 'spec_helper'
 
-describe Admin::Geo::NodesController do
+RSpec.describe Admin::Geo::NodesController do
   shared_examples 'unlicensed geo action' do
     it 'redirects to the 403 page' do
       expect(response).to have_gitlab_http_status(:forbidden)

ee/spec/controllers/admin/geo/projects_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::Geo::ProjectsController, :geo do
+RSpec.describe Admin::Geo::ProjectsController, :geo do
   include EE::GeoHelpers
 
   let_it_be(:admin) { create(:admin) }

ee/spec/controllers/admin/geo/settings_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::Geo::SettingsController, :geo do
+RSpec.describe Admin::Geo::SettingsController, :geo do
   include EE::GeoHelpers
   include StubENV
 

ee/spec/controllers/admin/geo/uploads_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::Geo::UploadsController, :geo do
+RSpec.describe Admin::Geo::UploadsController, :geo do
   include EE::GeoHelpers
 
   let_it_be(:admin) { create(:admin) }

ee/spec/controllers/admin/groups_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::GroupsController do
+RSpec.describe Admin::GroupsController do
   let(:admin) { create(:admin) }
   let(:group) { create(:group) }
 

ee/spec/controllers/admin/impersonations_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::ImpersonationsController do
+RSpec.describe Admin::ImpersonationsController do
   let(:impersonator) { create(:admin) }
   let(:user) { create(:user) }
 

ee/spec/controllers/admin/instance_review_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::InstanceReviewController do
+RSpec.describe Admin::InstanceReviewController do
   include UsageDataHelpers
 
   let(:admin) { create(:admin) }

ee/spec/controllers/admin/licenses_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::LicensesController do
+RSpec.describe Admin::LicensesController do
   let(:admin) { create(:admin) }
 
   before do

ee/spec/controllers/admin/projects_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::ProjectsController, :geo do
+RSpec.describe Admin::ProjectsController, :geo do
   include EE::GeoHelpers
 
   let!(:project_registry) { create(:geo_project_registry) }

ee/spec/controllers/admin/push_rules_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::PushRulesController do
+RSpec.describe Admin::PushRulesController do
   include StubENV
 
   let(:admin) { create(:admin) }

ee/spec/controllers/admin/users_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::UsersController do
+RSpec.describe Admin::UsersController do
   let(:admin) { create(:admin) }
   let(:user) { create(:user) }
 

ee/spec/controllers/analytics/analytics_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Analytics::AnalyticsController do
+RSpec.describe Analytics::AnalyticsController do
   let(:user) { create(:user) }
 
   before do

ee/spec/controllers/analytics/cycle_analytics/stages_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Analytics::CycleAnalytics::StagesController do
+RSpec.describe Analytics::CycleAnalytics::StagesController do
   let_it_be(:user) { create(:user) }
   let_it_be(:group, refind: true) { create(:group) }
   let(:params) { { group_id: group.full_path } }

ee/spec/controllers/analytics/cycle_analytics/summary_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Analytics::CycleAnalytics::SummaryController do
+RSpec.describe Analytics::CycleAnalytics::SummaryController do
   let_it_be(:user) { create(:user) }
   let_it_be(:group, refind: true) { create(:group) }
   let(:params) { { group_id: group.full_path, created_after: '2010-01-01', created_before: '2010-01-02' } }

ee/spec/controllers/analytics/cycle_analytics_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Analytics::CycleAnalyticsController do
+RSpec.describe Analytics::CycleAnalyticsController do
   let(:user) { create(:user) }
 
   before do

ee/spec/controllers/analytics/tasks_by_type_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Analytics::TasksByTypeController do
+RSpec.describe Analytics::TasksByTypeController do
   let(:user) { create(:user) }
   let(:group) { create(:group) }
   let(:label) { create(:group_label, group: group) }

ee/spec/controllers/autocomplete_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe AutocompleteController do
+RSpec.describe AutocompleteController do
   let(:project) { create(:project) }
   let(:user) { project.owner }
 

ee/spec/controllers/boards/issues_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Boards::IssuesController do
+RSpec.describe Boards::IssuesController do
   include ExternalAuthorizationServiceHelpers
 
   let(:group) { create(:group, :private) }

ee/spec/controllers/boards/lists_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Boards::ListsController do
+RSpec.describe Boards::ListsController do
   let_it_be(:group)  { create(:group, :private) }
   let_it_be(:board)  { create(:board, group: group) }
   let_it_be(:user)   { create(:user) }

ee/spec/controllers/boards/milestones_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Boards::MilestonesController do
+RSpec.describe Boards::MilestonesController do
   let(:project) { create(:project, :private) }
   let(:board) { create(:board, project: project) }
   let(:user)  { create(:user) }

ee/spec/controllers/boards/users_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Boards::UsersController do
+RSpec.describe Boards::UsersController do
   let(:group) { create(:group, :private) }
   let(:board) { create(:board, group: group) }
   let(:guest) { create(:user) }

ee/spec/controllers/concerns/boards_responses_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe BoardsResponses do
+RSpec.describe BoardsResponses do
   let(:controller_class) do
     Class.new do
       include BoardsResponses

ee/spec/controllers/concerns/ee/routable_actions/sso_enforcement_redirect_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe EE::RoutableActions::SsoEnforcementRedirect do
+RSpec.describe EE::RoutableActions::SsoEnforcementRedirect do
   let(:saml_provider) { create(:saml_provider, enforced_sso: true) }
   let(:root_group) { saml_provider.group }
   let(:nested_group) { create(:group, :private, parent: root_group) }

ee/spec/controllers/concerns/internal_redirect_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe InternalRedirect do
+RSpec.describe InternalRedirect do
   let(:controller_class) do
     Class.new do
       include InternalRedirect

ee/spec/controllers/concerns/routable_actions_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe RoutableActions do
+RSpec.describe RoutableActions do
   controller(::ApplicationController) do
     include RoutableActions
 

ee/spec/controllers/countries_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe CountriesController do
+RSpec.describe CountriesController do
   describe 'GET #index' do
     it 'returns list of countries as json' do
       get :index

ee/spec/controllers/country_states_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe CountryStatesController do
+RSpec.describe CountryStatesController do
   describe 'GET #index' do
     it 'returns a list of states as json' do
       country = 'NL'

ee/spec/controllers/ee/dashboard/projects_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Dashboard::ProjectsController do
+RSpec.describe Dashboard::ProjectsController do
   include ExternalAuthorizationServiceHelpers
 
   let(:user) { create(:user) }

ee/spec/controllers/ee/groups_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GroupsController do
+RSpec.describe GroupsController do
   include ExternalAuthorizationServiceHelpers
 
   let_it_be(:user) { create(:user) }

ee/spec/controllers/ee/profiles/preferences_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Profiles::PreferencesController do
+RSpec.describe Profiles::PreferencesController do
   let(:user) { create(:user) }
 
   before do

ee/spec/controllers/ee/projects/autocomplete_sources_controller_spec.rb

 # frozen_string_literal: true
 require 'spec_helper'
 
-describe Projects::AutocompleteSourcesController do
+RSpec.describe Projects::AutocompleteSourcesController do
   let_it_be(:user) { create(:user) }
   let_it_be(:group) { create(:group) }
   let_it_be(:group2) { create(:group) }

ee/spec/controllers/ee/projects/blob_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Projects::BlobController do
+RSpec.describe Projects::BlobController do
   include ProjectForksHelper
 
   let(:project) { create(:project, :public, :repository) }

ee/spec/controllers/ee/projects/jobs_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Projects::JobsController do
+RSpec.describe Projects::JobsController do
   describe 'GET #show', :clean_gitlab_redis_shared_state do
     context 'when requesting JSON' do
       let_it_be(:user) { create(:user) }

ee/spec/controllers/ee/projects/merge_requests/content_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Projects::MergeRequests::ContentController do
+RSpec.describe Projects::MergeRequests::ContentController do
   let(:project) { create(:project, :repository) }
   let(:user) { create(:user) }
   let(:merge_request) { create(:merge_request, target_project: project, source_project: project) }

ee/spec/controllers/ee/projects/protected_branches_controller_spec.rb

 # frozen_string_literal: true
 require "spec_helper"
 
-describe Projects::ProtectedBranchesController do
+RSpec.describe Projects::ProtectedBranchesController do
   let(:project) { create(:project, :repository) }
   let(:protected_branch) { create(:protected_branch, project: project) }
   let(:project_params) { { namespace_id: project.namespace.to_param, project_id: project } }

ee/spec/controllers/ee/root_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe RootController do
+RSpec.describe RootController do
   include ::EE::GeoHelpers
 
   describe 'GET #index' do

ee/spec/controllers/ee/sent_notifications_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe SentNotificationsController do
+RSpec.describe SentNotificationsController do
   let(:user) { create(:user) }
 
   context 'Unsubscribing from an epic' do

ee/spec/controllers/ee/sessions_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe SessionsController, :geo do
+RSpec.describe SessionsController, :geo do
   include DeviseHelpers
   include EE::GeoHelpers
 

ee/spec/controllers/explore/onboarding_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Explore::OnboardingController do
+RSpec.describe Explore::OnboardingController do
   let(:user) { create(:user, username: 'gitlab-org') }
 
   before do

ee/spec/controllers/groups/analytics/cycle_analytics/stages_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::Analytics::CycleAnalytics::StagesController do
+RSpec.describe Groups::Analytics::CycleAnalytics::StagesController do
   let_it_be(:user) { create(:user) }
   let_it_be(:group, refind: true) { create(:group) }
   let(:params) { { group_id: group } }

ee/spec/controllers/groups/analytics/cycle_analytics_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::Analytics::CycleAnalyticsController do
+RSpec.describe Groups::Analytics::CycleAnalyticsController do
   let(:group) { create(:group) }
   let(:user) { create(:user) }
 

ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::Analytics::ProductivityAnalyticsController do
+RSpec.describe Groups::Analytics::ProductivityAnalyticsController do
   let_it_be(:current_user) { create(:user) }
   let_it_be(:group) { create :group }
 

ee/spec/controllers/groups/analytics/tasks_by_type_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Analytics::TasksByTypeController do
+RSpec.describe Analytics::TasksByTypeController do
   let_it_be(:user) { create(:user) }
   let(:group) { create(:group) }
   let(:label) { create(:group_label, group: group) }

ee/spec/controllers/groups/audit_events_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::AuditEventsController do
+RSpec.describe Groups::AuditEventsController do
   let(:user) { create(:user) }
   let(:owner) { create(:user) }
   let(:group) { create(:group, :private) }

ee/spec/controllers/groups/autocomplete_sources_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::AutocompleteSourcesController do
+RSpec.describe Groups::AutocompleteSourcesController do
   let(:user) { create(:user) }
   let(:group) { create(:group, :private) }
   let!(:epic) { create(:epic, group: group) }

ee/spec/controllers/groups/billings_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::BillingsController do
+RSpec.describe Groups::BillingsController do
   let(:user)  { create(:user) }
   let(:group) { create(:group, :private) }
 

ee/spec/controllers/groups/boards_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::BoardsController do
+RSpec.describe Groups::BoardsController do
   let(:group) { create(:group) }
   let(:user) { create(:user) }
 

ee/spec/controllers/groups/clusters_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::ClustersController do
+RSpec.describe Groups::ClustersController do
   include AccessMatchersForController
 
   let_it_be(:group) { create(:group) }

ee/spec/controllers/groups/contribution_analytics_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::ContributionAnalyticsController do
+RSpec.describe Groups::ContributionAnalyticsController do
   let(:user) { create(:user) }
   let(:user2) { create(:user) }
   let(:user3) { create(:user) }

ee/spec/controllers/groups/dependency_proxies_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::DependencyProxiesController do
+RSpec.describe Groups::DependencyProxiesController do
   let(:group) { create(:group) }
   let(:user)  { create(:user) }
 

ee/spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::DependencyProxyForContainersController do
+RSpec.describe Groups::DependencyProxyForContainersController do
   let(:group) { create(:group) }
   let(:token_response) { { status: :success, token: 'abcd1234' } }
 

ee/spec/controllers/groups/epic_issues_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::EpicIssuesController do
+RSpec.describe Groups::EpicIssuesController do
   let(:group) { create(:group, :public) }
   let(:project) { create(:project, group: group) }
   let(:milestone) { create(:milestone, project: project) }

ee/spec/controllers/groups/epic_links_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::EpicLinksController do
+RSpec.describe Groups::EpicLinksController do
   let(:group) { create(:group, :public) }
   let(:parent_epic) { create(:epic, group: group) }
   let(:epic1) { create(:epic, group: group) }

ee/spec/controllers/groups/epics/notes_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::Epics::NotesController do
+RSpec.describe Groups::Epics::NotesController do
   let(:user) { create(:user) }
   let(:group) { create(:group) }
   let(:epic) { create(:epic, group: group) }

ee/spec/controllers/groups/epics_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::EpicsController do
+RSpec.describe Groups::EpicsController do
   let(:group) { create(:group, :private) }
   let(:epic) { create(:epic, group: group) }
   let(:user)  { create(:user) }

ee/spec/controllers/groups/group_members_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::GroupMembersController do
+RSpec.describe Groups::GroupMembersController do
   include ExternalAuthorizationServiceHelpers
 
   let(:user)  { create(:user) }

ee/spec/controllers/groups/groups_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GroupsController do
+RSpec.describe GroupsController do
   include ExternalAuthorizationServiceHelpers
 
   let(:user) { create(:user) }

ee/spec/controllers/groups/hooks_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::HooksController do
+RSpec.describe Groups::HooksController do
   let(:user)  { create(:user) }
   let(:group) { create(:group) }
 

ee/spec/controllers/groups/insights_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::InsightsController do
+RSpec.describe Groups::InsightsController do
   let_it_be(:parent_group) { create(:group, :private) }
   let_it_be(:nested_group) { create(:group, :private, parent: parent_group) }
   let_it_be(:project) { create(:project, :private) }

ee/spec/controllers/groups/issues_analytics_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::IssuesAnalyticsController do
+RSpec.describe Groups::IssuesAnalyticsController do
   it_behaves_like 'issues analytics controller' do
     let_it_be(:user)  { create(:user) }
     let_it_be(:group) { create(:group) }

ee/spec/controllers/groups/issues_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::IssuesController do
+RSpec.describe Groups::IssuesController do
   let(:user)      { create(:user) }
   let(:group)     { create(:group, :public) }
   let(:project)   { create(:project_empty_repo, :public, namespace: group) }

ee/spec/controllers/groups/ldap_settings_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::LdapSettingsController do
+RSpec.describe Groups::LdapSettingsController do
   include LdapHelpers
 
   let(:group) { create(:group) }

ee/spec/controllers/groups/ldaps_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::LdapsController do
+RSpec.describe Groups::LdapsController do
   include LdapHelpers
 
   let(:group) { create(:group) }

ee/spec/controllers/groups/merge_requests_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::MergeRequestsController do
+RSpec.describe Groups::MergeRequestsController do
   let(:user)           { create(:user) }
   let(:group)          { create(:group, :public) }
   let(:project)        { create(:project, :repository, group: group) }

ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::OmniauthCallbacksController do
+RSpec.describe Groups::OmniauthCallbacksController do
   include LoginHelpers
   include ForgeryProtection
 

ee/spec/controllers/groups/push_rules_controller_spec.rb

 # frozen_string_literal: true
 require 'spec_helper'
 
-describe Groups::PushRulesController do
+RSpec.describe Groups::PushRulesController do
   let_it_be(:group) { create(:group, :private) }
   let_it_be(:user) { create(:user) }
 

ee/spec/controllers/groups/roadmap_controller_spec.rb

 # frozen_string_literal: true
 require 'spec_helper'
 
-describe Groups::RoadmapController do
+RSpec.describe Groups::RoadmapController do
   let(:group) { create(:group, :private) }
   let(:epic)  { create(:epic, group: group) }
   let(:user)  { create(:user) }

ee/spec/controllers/groups/saml_providers_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::SamlProvidersController do
+RSpec.describe Groups::SamlProvidersController do
   let(:saml_provider) { create(:saml_provider, group: group) }
   let(:group) { create(:group, :private, parent_id: nil) }
   let(:user) { create(:user) }

ee/spec/controllers/groups/scim_oauth_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::ScimOauthController do
+RSpec.describe Groups::ScimOauthController do
   let(:saml_provider) { create(:saml_provider, group: group) }
   let(:group) { create(:group, :private, parent_id: nil) }
   let(:user) { create(:user) }

ee/spec/controllers/groups/security/compliance_dashboards_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::Security::ComplianceDashboardsController do
+RSpec.describe Groups::Security::ComplianceDashboardsController do
   let(:user) { create(:user) }
   let(:group) { create(:group) }
 

ee/spec/controllers/groups/security/credentials_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::Security::CredentialsController do
+RSpec.describe Groups::Security::CredentialsController do
   let_it_be(:group_with_managed_accounts) { create(:group_with_managed_accounts, :private) }
   let_it_be(:managed_users) { create_list(:user, 2, :group_managed, managing_group: group_with_managed_accounts) }
 

ee/spec/controllers/groups/security/dashboard_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::Security::DashboardController do
+RSpec.describe Groups::Security::DashboardController do
   let(:user) { create(:user) }
   let(:group) { create(:group) }
 

ee/spec/controllers/groups/security/vulnerability_findings_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::Security::VulnerabilityFindingsController do
+RSpec.describe Groups::Security::VulnerabilityFindingsController do
   let(:group) { create(:group) }
   let(:sub_group) { create(:group, parent: group) }
   let(:params) { { group_id: group } }

ee/spec/controllers/groups/security/vulnerable_projects_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::Security::VulnerableProjectsController do
+RSpec.describe Groups::Security::VulnerableProjectsController do
   let(:group) { create(:group) }
   let(:user) { create(:user) }
 

ee/spec/controllers/groups/sso_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::SsoController do
+RSpec.describe Groups::SsoController do
   let(:user) { create(:user) }
   let(:group) { create(:group, :private, name: 'our-group', saml_discovery_token: 'test-token') }
 

ee/spec/controllers/groups/todos_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::TodosController do
+RSpec.describe Groups::TodosController do
   let(:user)   { create(:user) }
   let(:group)  { create(:group, :private) }
   let(:epic)   { create(:epic, group: group) }

ee/spec/controllers/jira_connect/app_descriptor_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe JiraConnect::AppDescriptorController do
+RSpec.describe JiraConnect::AppDescriptorController do
   describe '#show' do
     it 'returns JSON app descriptor' do
       get :show

ee/spec/controllers/jira_connect/events_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe JiraConnect::EventsController do
+RSpec.describe JiraConnect::EventsController do
   describe '#installed' do
     subject do
       post :installed, params: {

ee/spec/controllers/jira_connect/subscriptions_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe JiraConnect::SubscriptionsController do
+RSpec.describe JiraConnect::SubscriptionsController do
   let_it_be(:installation) { create(:jira_connect_installation) }
 
   describe '#index' do

ee/spec/controllers/ldap/omniauth_callbacks_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Ldap::OmniauthCallbacksController do
+RSpec.describe Ldap::OmniauthCallbacksController do
   include_context 'Ldap::OmniauthCallbacksController'
 
   it "displays LDAP sync flash on first sign in" do

ee/spec/controllers/oauth/applications_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Oauth::ApplicationsController do
+RSpec.describe Oauth::ApplicationsController do
   let(:user) { create(:user) }
 
   context 'project members' do

ee/spec/controllers/oauth/geo_auth_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Oauth::GeoAuthController, :geo do
+RSpec.describe Oauth::GeoAuthController, :geo do
   include EE::GeoHelpers
 
   # The Geo OAuth workflow depends on the OAuth application and the URL

ee/spec/controllers/oauth/jira/authorizations_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Oauth::Jira::AuthorizationsController do
+RSpec.describe Oauth::Jira::AuthorizationsController do
   describe 'GET new' do
     it 'redirects to OAuth authorization with correct params' do
       get :new, params: { client_id: 'client-123', redirect_uri: 'http://example.com/' }

ee/spec/controllers/operations_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe OperationsController do
+RSpec.describe OperationsController do
   include Rails.application.routes.url_helpers
 
   let(:user) { create(:user) }

ee/spec/controllers/profiles/billings_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Profiles::BillingsController do
+RSpec.describe Profiles::BillingsController do
   let(:user) { create(:user) }
 
   describe 'GET #index' do

ee/spec/controllers/profiles/keys_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Profiles::KeysController do
+RSpec.describe Profiles::KeysController do
   let(:user) { create(:user) }
 
   describe '#create' do

ee/spec/controllers/profiles/slacks_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Profiles::SlacksController do
+RSpec.describe Profiles::SlacksController do
   let(:user) { create(:user) }
 
   before do

ee/spec/controllers/profiles/usage_quotas_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Profiles::UsageQuotasController do
+RSpec.describe Profiles::UsageQuotasController do
   let_it_be(:user) { create(:user) }
 
   before do

ee/spec/controllers/profiles_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require('spec_helper')
 
-describe ProfilesController, :request_store do
+RSpec.describe ProfilesController, :request_store do
   let_it_be(:user) { create(:user) }
   let_it_be(:admin) { create(:admin) }
 

ee/spec/controllers/projects/analytics/issues_analytics_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Projects::Analytics::IssuesAnalyticsController do
+RSpec.describe Projects::Analytics::IssuesAnalyticsController do
   it_behaves_like 'issues analytics controller' do
     let_it_be(:user)  { create(:user) }
     let_it_be(:group) { create(:group) }

ee/spec/controllers/projects/approver_groups_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Projects::ApproverGroupsController do
+RSpec.describe Projects::ApproverGroupsController do
   describe '#destroy' do
     let(:user) { create(:user) }
     let(:project) { create(:project) }

ee/spec/controllers/projects/approvers_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Projects::ApproversController do
+RSpec.describe Projects::ApproversController do
   describe '#destroy' do
     let(:user) { create(:user) }
     let(:project) { create(:project) }