Skip to content

G
gitlab-ce
Commit 09a8c054 authored by charlie ablett's avatar charlie ablett
Browse files
Options

Merge branch 'patch-95' into 'master' 

I changed merge into merging

See merge request gitlab-org/gitlab!30437
parents c98dee5b 3c1c5906
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 1 deletion
doc/development/code_review.md
View file @ 09a8c054
...@@ -319,7 +319,7 @@ Before taking the decision to merge: ...@@ -319,7 +319,7 @@ Before taking the decision to merge:
- Set the milestone. - Set the milestone.
- Consider warnings and errors from danger bot, code quality, and other reports. - Consider warnings and errors from danger bot, code quality, and other reports.
Unless a strong case can be made for the violation, these should be resolved Unless a strong case can be made for the violation, these should be resolved
before merge. A comment must to be posted if the MR is merged with any failed job. before merging. A comment must to be posted if the MR is merged with any failed job.
When ready to merge: When ready to merge:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7