Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0a43715f
Commit
0a43715f
authored
Sep 13, 2021
by
Furkan Ayhan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove FF ci_modified_paths_of_external_prs
It's already enabled by default since 14.2 Changelog: other
parent
98a4386b
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
19 deletions
+1
-19
app/models/ci/pipeline.rb
app/models/ci/pipeline.rb
+1
-1
config/feature_flags/development/ci_modified_paths_of_external_prs.yml
...e_flags/development/ci_modified_paths_of_external_prs.yml
+0
-8
spec/models/ci/pipeline_spec.rb
spec/models/ci/pipeline_spec.rb
+0
-10
No files found.
app/models/ci/pipeline.rb
View file @
0a43715f
...
...
@@ -1107,7 +1107,7 @@ module Ci
merge_request
.
modified_paths
elsif
branch_updated?
push_details
.
modified_paths
elsif
external_pull_request?
&&
::
Feature
.
enabled?
(
:ci_modified_paths_of_external_prs
,
project
,
default_enabled: :yaml
)
elsif
external_pull_request?
external_pull_request
.
modified_paths
end
end
...
...
config/feature_flags/development/ci_modified_paths_of_external_prs.yml
deleted
100644 → 0
View file @
98a4386b
---
name
:
ci_modified_paths_of_external_prs
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60736
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/330605
milestone
:
'
13.12'
type
:
development
group
:
group::pipeline authoring
default_enabled
:
true
spec/models/ci/pipeline_spec.rb
View file @
0a43715f
...
...
@@ -2037,16 +2037,6 @@ RSpec.describe Ci::Pipeline, :mailer, factory_default: :keep do
it
'returns external pull request modified paths'
do
expect
(
pipeline
.
modified_paths
).
to
match
(
external_pull_request
.
modified_paths
)
end
context
'when the FF ci_modified_paths_of_external_prs is disabled'
do
before
do
stub_feature_flags
(
ci_modified_paths_of_external_prs:
false
)
end
it
'returns nil'
do
expect
(
pipeline
.
modified_paths
).
to
be_nil
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment