Commit 0a6437f4 authored by Justin Ho's avatar Justin Ho Committed by Arturo Herrero

Add HipChat to the list of disabled services

Update feature specs accordingly
parent 7e016820
......@@ -1370,9 +1370,9 @@ class Project < ApplicationRecord
end
def disabled_services
return %w(datadog) unless Feature.enabled?(:datadog_ci_integration, self)
return %w(datadog hipchat) unless Feature.enabled?(:datadog_ci_integration, self)
[]
%w(hipchat)
end
def find_or_initialize_service(name)
......
---
title: Remove HipChat integration from frontend and docs
merge_request: 57556
author:
type: deprecated
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'User activates HipChat', :js do
include_context 'project service activation'
context 'with standard settings' do
before do
stub_request(:post, /.*api.hipchat.com.*/)
end
it 'activates service' do
visit_project_integration('HipChat')
fill_in('Room', with: 'gitlab')
fill_in('Token', with: 'verySecret')
click_test_then_save_integration(expect_test_to_fail: false)
expect(page).to have_content('HipChat settings saved and active.')
end
end
context 'with custom settings' do
before do
stub_request(:post, /.*chat.example.com.*/)
end
it 'activates service' do
visit_project_integration('HipChat')
fill_in('Room', with: 'gitlab_custom')
fill_in('Token', with: 'secretCustom')
fill_in('Server', with: 'https://chat.example.com')
click_test_then_save_integration(expect_test_to_fail: false)
expect(page).to have_content('HipChat settings saved and active.')
end
end
end
......@@ -10,7 +10,7 @@ RSpec.describe 'User views services' do
expect(page).to have_content('Integrations')
expect(page).to have_content('Campfire')
expect(page).to have_content('HipChat')
expect(page).to have_content('Jira')
expect(page).to have_content('Assembla')
expect(page).to have_content('Pushover')
expect(page).to have_content('Atlassian Bamboo')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment