Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0c71fe19
Commit
0c71fe19
authored
Nov 12, 2018
by
samdbeckham
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Restyles the dismissed state for vulnerabilities
parent
d786cf32
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
25 additions
and
9 deletions
+25
-9
ee/app/assets/javascripts/security_dashboard/components/security_dashboard_table_row.vue
...ity_dashboard/components/security_dashboard_table_row.vue
+19
-9
ee/app/assets/javascripts/security_dashboard/components/vulnerability_issue_link.vue
...ecurity_dashboard/components/vulnerability_issue_link.vue
+1
-0
ee/changelogs/unreleased/8145-consider-using-something-other-than-a-strike-for-dismissed-vulnerabilities.yml
...ing-other-than-a-strike-for-dismissed-vulnerabilities.yml
+5
-0
No files found.
ee/app/assets/javascripts/security_dashboard/components/security_dashboard_table_row.vue
View file @
0c71fe19
...
...
@@ -57,7 +57,10 @@ export default {
</
script
>
<
template
>
<div
class=
"gl-responsive-table-row vulnerabilities-row"
>
<div
class=
"gl-responsive-table-row vulnerabilities-row"
:class=
"
{ dismissed: isDismissed }"
>
<div
class=
"table-section section-10"
>
<div
class=
"table-mobile-header"
...
...
@@ -87,12 +90,15 @@ export default {
<gl-button
class=
"btn js-vulnerability-info"
variant=
"blank"
:class=
"
{ strikethrough: isDismissed }"
@
click=
"openModal(
{ vulnerability })"
>
{{
vulnerability
.
name
}}
</gl-button>
<span
v-if=
"isDismissed"
class=
"prepend-left-8 vertical-align-middle"
>
DISMISSED
</span>
<vulnerability-issue-link
v-if=
"hasIssue"
class=
"prepend-left-
10
"
class=
"prepend-left-
8
"
:issue=
"vulnerability.issue_feedback"
:project-name=
"vulnerability.project.name"
/>
...
...
@@ -114,7 +120,7 @@ export default {
{{
s__
(
'
Reports|Confidence
'
)
}}
</div>
<div
class=
"table-mobile-content text-capitalize"
>
<span
:class=
"
{ strikethrough: isDismissed }">
{{
confidence
}}
</span>
{{
confidence
}}
</div>
</div>
...
...
@@ -125,7 +131,7 @@ export default {
>
{{
s__
(
'
Reports|Actions
'
)
}}
</div>
<div
class=
"table-mobile-content
vulnerabilities-
action-buttons"
>
<div
class=
"table-mobile-content action-buttons"
>
<vulnerability-action-buttons
:vulnerability=
"vulnerability"
:can-create-issue=
"canCreateIssue"
...
...
@@ -137,7 +143,7 @@ export default {
</div>
</
template
>
<
style
>
<
style
scoped
>
@media
(
min-width
:
768px
)
{
.vulnerabilities-row
{
padding
:
0.6em
0.4em
;
...
...
@@ -151,14 +157,14 @@ export default {
margin-top
:
-1px
;
}
.vulnerabilities-row
.
vulnerabilities-
action-buttons
{
.vulnerabilities-row
.action-buttons
{
opacity
:
0
;
padding-right
:
1em
;
text-align
:
right
;
}
.vulnerabilities-row
:hover
.
vulnerabilities-
action-buttons
,
.vulnerabilities-row
:focus
.
vulnerabilities-
action-buttons
{
.vulnerabilities-row
:hover
.action-buttons
,
.vulnerabilities-row
:focus
.action-buttons
{
opacity
:
1
;
}
}
...
...
@@ -171,4 +177,8 @@ export default {
color
:
#707070
;
font-size
:
0.8em
;
}
.dismissed
.table-mobile-content
:not
(
.action-buttons
)
{
opacity
:
0.5
;
}
</
style
>
ee/app/assets/javascripts/security_dashboard/components/vulnerability_issue_link.vue
View file @
0c71fe19
...
...
@@ -38,6 +38,7 @@ export default {
/>
<a
:href=
"issue.issue_url"
class=
"vertical-align-middle"
>
{{
linkText
}}
</a>
</div>
</
template
>
ee/changelogs/unreleased/8145-consider-using-something-other-than-a-strike-for-dismissed-vulnerabilities.yml
0 → 100644
View file @
0c71fe19
---
title
:
Restyles the dismissed vulnerabilities
merge_request
:
8401
author
:
type
:
other
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment