Merge branch 'mw-remove-fa-instances-from-js-specs' into 'master'

Remove fa- instances from js specs

See merge request gitlab-org/gitlab!49114

ee/spec/frontend/filtered_search/filtered_search_manager_spec.js

@@ -33,7 +33,7 @@ describe('Filtered Search Manager (EE)', () => {
             ${FilteredSearchSpecHelper.createInputHTML()}
           </ul>
           <button class="clear-search" type="button">
-            <i class="fa fa-times"></i>
+            <svg class="s16 clear-search-icon" data-testid="close-icon"><use xlink:href="icons.svg#close" /></svg>
           </button>
         </form>
       </div>

spec/frontend/alerts_service_settings/components/alerts_service_form_spec.js

@@ -42,8 +42,8 @@ describe('AlertsServiceForm', () => {
     mockAxios = new MockAdapter(axios);
     setFixtures(`
     <div>
-      <span class="js-service-active-status fa fa-circle" data-value="true"></span>
-      <span class="js-service-active-status fa fa-power-off" data-value="false"></span>
+      <span class="js-service-active-status" data-value="true"><svg class="s16 cgreen" data-testid="check-icon"><use xlink:href="icons.svg#check" /></svg></span>
+      <span class="js-service-active-status" data-value="false"><svg class="s16 clgray" data-testid="power-icon"><use xlink:href="icons.svg#power" /></svg></span>
     </div>`);
   });
 

spec/frontend/branches/ajax_loading_spinner_spec.js

@@ -9,7 +9,7 @@ describe('Ajax Loading Spinner', () => {
     <a class="js-ajax-loading-spinner"
        data-remote
        href="http://goesnowhere.nothing/whereami">
-      <i class="fa fa-trash-o"></i>
+       Remove me
     </a></div>`;
     AjaxLoadingSpinner.init();
     ajaxLoadingSpinnerElement = document.querySelector('.js-ajax-loading-spinner');

spec/frontend/filtered_search/filtered_search_manager_spec.js

@@ -69,7 +69,7 @@ describe('Filtered Search Manager', () => {
             ${FilteredSearchSpecHelper.createInputHTML(placeholder)}
           </ul>
           <button class="clear-search" type="button">
-            <i class="fa fa-times"></i>
+            <svg class="s16 clear-search-icon" data-testid="close-icon"><use xlink:href="icons.svg#close" /></svg>
           </button>
         </form>
       </div>

spec/frontend/lib/utils/common_utils_spec.js

@@ -526,8 +526,8 @@ describe('common_utils', () => {
     });
 
     it('should set svg className when passed', () => {
-      expect(commonUtils.spriteIcon('test', 'fa fa-test')).toEqual(
-        '<svg class="fa fa-test"><use xlink:href="icons.svg#test" /></svg>',
+      expect(commonUtils.spriteIcon('test', 'first-icon-class second-icon-class')).toEqual(
+        '<svg class="first-icon-class second-icon-class"><use xlink:href="icons.svg#test" /></svg>',
       );
     });
   });