Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
109cc6b3
Commit
109cc6b3
authored
Mar 13, 2020
by
Thong Kuah
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'zeitwerk-saml-patch' into 'master'
Fix omniauth SAML patch See merge request gitlab-org/gitlab!26633
parents
8fb16ff9
8bda2c78
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
4 deletions
+3
-4
config/initializers_before_autoloader/100_patch_omniauth_saml.rb
...initializers_before_autoloader/100_patch_omniauth_saml.rb
+2
-3
spec/initializers/100_patch_omniauth_saml_spec.rb
spec/initializers/100_patch_omniauth_saml_spec.rb
+1
-1
No files found.
lib/omni_auth/strategies/
saml.rb
→
config/initializers_before_autoloader/100_patch_omniauth_
saml.rb
View file @
109cc6b3
# frozen_string_literal: true
# frozen_string_literal: true
require
'omniauth/strategies/saml'
module
OmniAuth
module
OmniAuth
module
Strategies
module
Strategies
class
SAML
class
SAML
extend
::
Gitlab
::
Utils
::
Override
# NOTE: This method duplicates code from omniauth-saml
# NOTE: This method duplicates code from omniauth-saml
# so that we can access authn_request to store it
# so that we can access authn_request to store it
# See: https://github.com/omniauth/omniauth-saml/issues/172
# See: https://github.com/omniauth/omniauth-saml/issues/172
override
:request_phase
def
request_phase
def
request_phase
authn_request
=
OneLogin
::
RubySaml
::
Authrequest
.
new
authn_request
=
OneLogin
::
RubySaml
::
Authrequest
.
new
...
...
spec/
lib/omni_auth/strategies/
saml_spec.rb
→
spec/
initializers/100_patch_omniauth_
saml_spec.rb
View file @
109cc6b3
...
@@ -2,7 +2,7 @@
...
@@ -2,7 +2,7 @@
require
'spec_helper'
require
'spec_helper'
describe
OmniAuth
::
Strategies
::
SAML
,
type: :strategy
do
describe
'OmniAuth::Strategies::SAML'
,
type: :strategy
do
let
(
:idp_sso_target_url
)
{
'https://login.example.com/idp'
}
let
(
:idp_sso_target_url
)
{
'https://login.example.com/idp'
}
let
(
:strategy
)
{
[
OmniAuth
::
Strategies
::
SAML
,
{
idp_sso_target_url:
idp_sso_target_url
}]
}
let
(
:strategy
)
{
[
OmniAuth
::
Strategies
::
SAML
,
{
idp_sso_target_url:
idp_sso_target_url
}]
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment