Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
11913a76
Commit
11913a76
authored
Feb 16, 2016
by
James Lopez
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
updated system note service and spec based on feedback
parent
99a50447
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
5 deletions
+3
-5
app/services/system_note_service.rb
app/services/system_note_service.rb
+3
-1
spec/services/system_note_service_spec.rb
spec/services/system_note_service_spec.rb
+0
-4
No files found.
app/services/system_note_service.rb
View file @
11913a76
...
@@ -274,7 +274,9 @@ class SystemNoteService
...
@@ -274,7 +274,9 @@ class SystemNoteService
# Check if a cross reference to a noteable from a mentioner already exists
# Check if a cross reference to a noteable from a mentioner already exists
#
#
# This method is used to prevent multiple notes being created for a mention
# This method is used to prevent multiple notes being created for a mention
# when a issue is updated, for example.
# when a issue is updated, for example. The method also calls notes_for_mentioner
# to check if the mentioner is a commit, and return matches only on commit hash
# instead of project + commit, to avoid repeated mentions from forks.
#
#
# noteable - Noteable object being referenced
# noteable - Noteable object being referenced
# mentioner - Mentionable object
# mentioner - Mentionable object
...
...
spec/services/system_note_service_spec.rb
View file @
11913a76
...
@@ -431,10 +431,6 @@ describe SystemNoteService, services: true do
...
@@ -431,10 +431,6 @@ describe SystemNoteService, services: true do
let
(
:commit2
)
{
forked_project
.
commit
}
let
(
:commit2
)
{
forked_project
.
commit
}
before
do
before
do
allow
(
commit0
).
to
receive
(
:to_reference
)
{
noteable
.
project
.
to_reference
+
commit0
.
class
.
reference_prefix
+
commit0
.
id
}
described_class
.
cross_reference
(
noteable
,
commit0
,
author2
)
described_class
.
cross_reference
(
noteable
,
commit0
,
author2
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment