Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
12184d16
Commit
12184d16
authored
Feb 13, 2021
by
Lee Tickett
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove default service desk issue title prefix
parent
91550884
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
8 deletions
+7
-8
changelogs/unreleased/275169-remove-service-desk-issue-prefix.yml
...gs/unreleased/275169-remove-service-desk-issue-prefix.yml
+5
-0
lib/gitlab/email/handler/service_desk_handler.rb
lib/gitlab/email/handler/service_desk_handler.rb
+1
-7
spec/lib/gitlab/email/handler/service_desk_handler_spec.rb
spec/lib/gitlab/email/handler/service_desk_handler_spec.rb
+1
-1
No files found.
changelogs/unreleased/275169-remove-service-desk-issue-prefix.yml
0 → 100644
View file @
12184d16
---
title
:
Remove service desk issue prefix
merge_request
:
54140
author
:
Lee Tickett @leetickett
type
:
changed
lib/gitlab/email/handler/service_desk_handler.rb
View file @
12184d16
...
...
@@ -75,7 +75,7 @@ module Gitlab
@issue
=
Issues
::
CreateService
.
new
(
project
,
User
.
support_bot
,
title:
issue_title
,
title:
mail
.
subject
,
description:
message_including_template
,
confidential:
true
,
external_author:
from_address
...
...
@@ -133,12 +133,6 @@ module Gitlab
(
mail
.
reply_to
||
[]).
first
||
mail
.
from
.
first
||
mail
.
sender
end
def
issue_title
from
=
"(from
#{
from_address
}
)"
if
from_address
"Service Desk
#{
from
}
:
#{
mail
.
subject
}
"
end
def
can_handle_legacy_format?
project_path
&&
project_path
.
include?
(
'/'
)
&&
!
mail_key
.
include?
(
'+'
)
end
...
...
spec/lib/gitlab/email/handler/service_desk_handler_spec.rb
View file @
12184d16
...
...
@@ -36,7 +36,7 @@ RSpec.describe Gitlab::Email::Handler::ServiceDeskHandler do
expect
(
new_issue
.
author
).
to
eql
(
User
.
support_bot
)
expect
(
new_issue
.
confidential?
).
to
be
true
expect
(
new_issue
.
all_references
.
all
).
to
be_empty
expect
(
new_issue
.
title
).
to
eq
(
"
Service Desk (from jake@adventuretime.ooo):
The message subject! @all"
)
expect
(
new_issue
.
title
).
to
eq
(
"The message subject! @all"
)
expect
(
new_issue
.
description
).
to
eq
(
expected_description
.
strip
)
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment