New job to check LastKeywordArgument deprecations

.gitlab/ci/rails.gitlab-ci.yml

@@ -376,6 +376,24 @@ db:backup_and_restore:
   rules:
     - changes: ["lib/backup/**/*"]
 
+rspec:deprecations:
+  extends:
+    - .default-retry
+    - .default-before_script
+    - .static-analysis-cache
+    - .rails:rules:deprecations
+  stage: post-test
+  allow_failure: true
+  variables:
+    SETUP_DB: "false"
+  script:
+    - bundle exec rubocop --only Lint/LastKeywordArgument --parallel
+  artifacts:
+    expire_in: 31d
+    when: always
+    paths:
+      - deprecations/
+
 rspec:coverage:
   extends:
     - .coverage-base

.gitlab/ci/rules.gitlab-ci.yml

@@ -825,6 +825,15 @@
     - <<: *if-merge-request
       changes: *code-backstage-patterns
 
+.rails:rules:deprecations:
+  rules:
+    - <<: *if-not-ee
+      when: never
+    - <<: *if-merge-request
+      changes: *code-backstage-patterns
+    - <<: *if-master-schedule-nightly
+    - <<: *if-merge-request-title-run-all-rspec
+
 .rails:rules:rspec-coverage:
   rules:
     - <<: *if-not-ee

doc/development/pipelines.md

@@ -671,7 +671,7 @@ and included in `rules` definitions via [YAML anchors](../ci/yaml/README.md#anch
 | `if-master-refs`                                             | Matches if the current branch is `master`. | |
 | `if-master-push`                                             | Matches if the current branch is `master` and pipeline source is `push`. | |
 | `if-master-schedule-2-hourly`                                | Matches if the current branch is `master` and pipeline runs on a 2-hourly schedule. | |
-| `if-master-schedule-2-nightly`                               | Matches if the current branch is `master` and pipeline runs on a nightly schedule. | |
+| `if-master-schedule-nightly`                                 | Matches if the current branch is `master` and pipeline runs on a nightly schedule. | |
 | `if-auto-deploy-branches`                                    | Matches if the current branch is an auto-deploy one. | |
 | `if-master-or-tag`                                           | Matches if the pipeline is for the `master` branch or for a tag. | |
 | `if-merge-request`                                           | Matches if the pipeline is for a merge request. | |