Check whether PagerDuty setting is active

Check whether PagerDuty setting is active when
creating incident issue

app/services/concerns/incident_management/settings.rb

 # frozen_string_literal: true
 module IncidentManagement
   module Settings
+    include Gitlab::Utils::StrongMemoize
+
     def incident_management_setting
       strong_memoize(:incident_management_setting) do
         project.incident_management_setting ||

app/services/incident_management/pager_duty/create_incident_issue_service.rb

@@ -3,6 +3,8 @@
 module IncidentManagement
   module PagerDuty
     class CreateIncidentIssueService < BaseService
+      include IncidentManagement::Settings
+
       def initialize(project, incident_payload)
         super(project, User.alert_bot, incident_payload)
       end
@@ -38,7 +40,8 @@ module IncidentManagement
       end
 
       def webhook_available?
-        Feature.enabled?(:pagerduty_webhook, project)
+        Feature.enabled?(:pagerduty_webhook, project) &&
+          incident_management_setting.pagerduty_active?
       end
 
       def forbidden

spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe IncidentManagement::PagerDuty::CreateIncidentIssueService do
-  let_it_be(:project) { create(:project) }
+  let_it_be(:project, reload: true) { create(:project) }
   let_it_be(:user) { User.alert_bot }
   let(:webhook_payload) { Gitlab::Json.parse(fixture_file('pager_duty/webhook_incident_trigger.json')) }
   let(:parsed_payload) { ::PagerDuty::WebhookPayloadParser.call(webhook_payload) }
@@ -17,50 +17,71 @@ RSpec.describe IncidentManagement::PagerDuty::CreateIncidentIssueService do
         stub_feature_flags(pagerduty_webhook: project)
       end
 
-      context 'when issue can be created' do
-        it 'creates a new issue' do
-          expect { execute }.to change(Issue, :count).by(1)
+      context 'when PagerDuty webhook setting is active' do
+        let_it_be(:incident_management_setting) { create(:project_incident_management_setting, project: project, pagerduty_active: true) }
+
+        context 'when issue can be created' do
+          it 'creates a new issue' do
+            expect { execute }.to change(Issue, :count).by(1)
+          end
+
+          it 'responds with success' do
+            response = execute
+
+            expect(response).to be_success
+            expect(response.payload[:issue]).to be_kind_of(Issue)
+          end
+
+          it 'the issue author is Alert bot' do
+            expect(execute.payload[:issue].author).to eq(User.alert_bot)
+          end
+
+          it 'issue has a correct title' do
+            expect(execute.payload[:issue].title).to eq(incident_payload['title'])
+          end
+
+          it 'issue has a correct description' do
+            markdown_line_break = '  '
+
+            expect(execute.payload[:issue].description).to eq(
+              <<~MARKDOWN.chomp
+                **Incident:** [My new incident](https://webdemo.pagerduty.com/incidents/PRORDTY)#{markdown_line_break}
+                **Incident number:** 33#{markdown_line_break}
+                **Urgency:** high#{markdown_line_break}
+                **Status:** triggered#{markdown_line_break}
+                **Incident key:** #{markdown_line_break}
+                **Created at:** 26 September 2017, 3:14PM (UTC)#{markdown_line_break}
+                **Assignees:** [Laura Haley](https://webdemo.pagerduty.com/users/P553OPV)#{markdown_line_break}
+                **Impacted services:** [Production XDB Cluster](https://webdemo.pagerduty.com/services/PN49J75)
+              MARKDOWN
+            )
+          end
         end
 
-        it 'responds with success' do
-          response = execute
+        context 'when the payload does not contain a title' do
+          let(:incident_payload) { {} }
 
-          expect(response).to be_success
-          expect(response.payload[:issue]).to be_kind_of(Issue)
-        end
+          it 'does not create a GitLab issue' do
+            expect { execute }.not_to change(Issue, :count)
+          end
 
-        it 'the issue author is Alert bot' do
-          expect(execute.payload[:issue].author).to eq(User.alert_bot)
+          it 'responds with error' do
+            expect(execute).to be_error
+            expect(execute.message).to eq("Title can't be blank")
+          end
         end
+      end
 
-        it 'issue has a correct title' do
-          expect(execute.payload[:issue].title).to eq(incident_payload['title'])
-        end
+      context 'when PagerDuty webhook setting is not active' do
+        let_it_be(:incident_management_setting) { create(:project_incident_management_setting, project: project, pagerduty_active: false) }
 
-        it 'issue has a correct description' do
-          markdown_line_break = '  '
-
-          expect(execute.payload[:issue].description).to eq(
-            <<~MARKDOWN.chomp
-              **Incident:** [My new incident](https://webdemo.pagerduty.com/incidents/PRORDTY)#{markdown_line_break}
-              **Incident number:** 33#{markdown_line_break}
-              **Urgency:** high#{markdown_line_break}
-              **Status:** triggered#{markdown_line_break}
-              **Incident key:** #{markdown_line_break}
-              **Created at:** 26 September 2017, 3:14PM (UTC)#{markdown_line_break}
-              **Assignees:** [Laura Haley](https://webdemo.pagerduty.com/users/P553OPV)#{markdown_line_break}
-              **Impacted services:** [Production XDB Cluster](https://webdemo.pagerduty.com/services/PN49J75)
-            MARKDOWN
-          )
+        it 'does not create a GitLab issue' do
+          expect { execute }.not_to change(Issue, :count)
         end
-      end
-
-      context 'when issue cannot be created' do
-        let(:incident_payload) { {} }
 
-        it 'responds with error' do
+        it 'responds with forbidden' do
           expect(execute).to be_error
-          expect(execute.message).to eq("Title can't be blank")
+          expect(execute.http_status).to eq(:forbidden)
         end
       end
     end

spec/workers/incident_management/pager_duty/process_incident_worker_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe IncidentManagement::PagerDuty::ProcessIncidentWorker do
   let_it_be(:project) { create(:project) }
+  let_it_be(:incident_management_setting) { create(:project_incident_management_setting, project: project, pagerduty_active: true) }
 
   describe '#perform' do
     subject(:perform) { described_class.new.perform(project.id, incident_payload) }